125985 2013-12-19 00:29:58 -0800 Test that text-decoration-skip: ink is the same as regular underlines if no descenders 2013-12-19 15:21:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield commit-queue dino jonlee simon.fraser thorton oldest_to_newest 961307 0 mmaxfield 2013-12-19 00:29:58 -0800 Test that text-decoration-skip: ink is the same as regular underlines if no descenders 961308 1 219630 mmaxfield 2013-12-19 00:31:14 -0800 Created attachment 219630 Patch 961551 2 219630 simon.fraser 2013-12-19 14:54:35 -0800 Comment on attachment 219630 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219630&action=review > LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-no-descenders-expected.html:1 > +<!DOCTYPE HTML> Minor preference for <!DOCTYPE html> > LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-no-descenders-expected.html:8 > +<div style="display: inline-block; -webkit-transform: scale(5); -webkit-transform-origin: left top; -webkit-text-decoration-line: underline">NO DESCENDERS</div> Please use text-decoration: underline > LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-no-descenders.html:8 > +<div style="display: inline-block; -webkit-text-decoration-skip: ink; -webkit-transform: scale(5); -webkit-transform-origin: left top; -webkit-text-decoration-line: underline">NO DESCENDERS</div> Ditto. 961553 3 219686 mmaxfield 2013-12-19 14:56:20 -0800 Created attachment 219686 Patch 961574 4 219686 commit-queue 2013-12-19 15:21:14 -0800 Comment on attachment 219686 Patch Clearing flags on attachment: 219686 Committed r160865: <http://trac.webkit.org/changeset/160865> 961575 5 commit-queue 2013-12-19 15:21:16 -0800 All reviewed patches have been landed. Closing bug. 219630 2013-12-19 00:31:14 -0800 2013-12-19 14:56:18 -0800 Patch bug-125985-20131219003113.patch text/plain 2976 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwODIwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmMxNzU3OTQxN2QzYTBiZjRiZTZk MDcyZGYzZWEzZjMzYjYzOTBiMS4uN2I1NjE1NmZjNWE5MDg5MDQ2Y2FmNmU5ZmI5ZjllOGZiNjI4 MTIxZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTEyLTE5ICBNeWxlcyBDLiBNYXhmaWVs ZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgVGVzdCB0aGF0IHRleHQtZGVjb3Jh dGlvbi1za2lwOiBpbmsgaXMgdGhlIHNhbWUgYXMgcmVndWxhciB1bmRlcmxpbmVzIGlmIG5vIGRl c2NlbmRlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNTk4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IElmIHRoZXJlIGFyZSBubyBkZXNjZW5kZXJzIGluIHRoZSB1bmRlcmxpbmVkIHRleHQsIHVzaW5n IHRoZSB0ZXh0LWRlY29yYXRpb24tc2tpcDogaW5rCisgICAgICAgIENTUyBwcm9wZXJ0eSBzaG91 bGQgYmVoYXZlIGFzIGlmIGl0IHdhc24ndCBzcGVjaWZpZWQgKGFuZCB0aGUgdW5kZXJsaW5lIGlz IGEgbm9ybWFsIG9uZSkKKworICAgICAgICAqIGZhc3QvY3NzMy10ZXh0L2NzczMtdGV4dC1kZWNv cmF0aW9uL3RleHQtZGVjb3JhdGlvbi1za2lwL3RleHQtZGVjb3JhdGlvbi1za2lwLWluay1uby1k ZXNjZW5kZXJzLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzMy10ZXh0 L2NzczMtdGV4dC1kZWNvcmF0aW9uL3RleHQtZGVjb3JhdGlvbi1za2lwL3RleHQtZGVjb3JhdGlv bi1za2lwLWluay1uby1kZXNjZW5kZXJzLmh0bWw6IEFkZGVkLgorCiAyMDEzLTEyLTE4ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIENyYXNoIGluIFdlYkNvcmU6 OkxvZ2ljYWxTZWxlY3Rpb25PZmZzZXRDYWNoZXM6OkxvZ2ljYWxTZWxlY3Rpb25PZmZzZXRDYWNo ZXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzMy10ZXh0L2NzczMtdGV4dC1kZWNv cmF0aW9uL3RleHQtZGVjb3JhdGlvbi1za2lwL3RleHQtZGVjb3JhdGlvbi1za2lwLWluay1uby1k ZXNjZW5kZXJzLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2NzczMtdGV4dC9jc3Mz LXRleHQtZGVjb3JhdGlvbi90ZXh0LWRlY29yYXRpb24tc2tpcC90ZXh0LWRlY29yYXRpb24tc2tp cC1pbmstbm8tZGVzY2VuZGVycy1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmEzNTQ4NzQwZDIz NDFjZjViNWZkNGZiZmMyNGIxMWI1YmMzYTE2ZGEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2NzczMtdGV4dC9jc3MzLXRleHQtZGVjb3JhdGlvbi90ZXh0LWRlY29yYXRpb24t c2tpcC90ZXh0LWRlY29yYXRpb24tc2tpcC1pbmstbm8tZGVzY2VuZGVycy1leHBlY3RlZC5odG1s CkBAIC0wLDAgKzEsMTAgQEAKKzwhRE9DVFlQRSBIVE1MPgorPGh0bWw+Cis8aGVhZD4KKzwvaGVh ZD4KKzxib2R5PgorQmVjYXVzZSB0aGUgZm9sbG93aW5nIHRleHQgZG9lcyBub3QgaGF2ZSBhbnkg ZGVzY2VuZGVycywgcmVuZGVyaW5nIGl0IHdpdGggdGV4dC1kZWNvcmF0aW9uLXNraXA6IGluayBz aG91bGQgbG9vayB0aGUgc2FtZSBhcyByZW5kZXJpbmcgaXQgd2l0aCBqdXN0IGEgcmVndWxhciB1 bmRlcmxpbmUuCis8ZGl2PjwvZGl2PgorPGRpdiBzdHlsZT0iZGlzcGxheTogaW5saW5lLWJsb2Nr OyAtd2Via2l0LXRyYW5zZm9ybTogc2NhbGUoNSk7IC13ZWJraXQtdHJhbnNmb3JtLW9yaWdpbjog bGVmdCB0b3A7IC13ZWJraXQtdGV4dC1kZWNvcmF0aW9uLWxpbmU6IHVuZGVybGluZSI+Tk8gREVT Q0VOREVSUzwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9jc3MzLXRleHQvY3NzMy10ZXh0LWRlY29yYXRpb24vdGV4dC1kZWNvcmF0aW9uLXNraXAv dGV4dC1kZWNvcmF0aW9uLXNraXAtaW5rLW5vLWRlc2NlbmRlcnMuaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvY3NzMy10ZXh0L2NzczMtdGV4dC1kZWNvcmF0aW9uL3RleHQtZGVjb3JhdGlvbi1za2lw L3RleHQtZGVjb3JhdGlvbi1za2lwLWluay1uby1kZXNjZW5kZXJzLmh0bWwKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u OGUyZDM5YzEyNTVjYzVlYTZlZmE4M2M2NThjNTAwZWNhMGE1ZTFkZQotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzMy10ZXh0L2NzczMtdGV4dC1kZWNvcmF0aW9uL3RleHQt ZGVjb3JhdGlvbi1za2lwL3RleHQtZGVjb3JhdGlvbi1za2lwLWluay1uby1kZXNjZW5kZXJzLmh0 bWwKQEAgLTAsMCArMSwxMCBAQAorPCFET0NUWVBFIEhUTUw+Cis8aHRtbD4KKzxoZWFkPgorPC9o ZWFkPgorPGJvZHk+CitCZWNhdXNlIHRoZSBmb2xsb3dpbmcgdGV4dCBkb2VzIG5vdCBoYXZlIGFu eSBkZXNjZW5kZXJzLCByZW5kZXJpbmcgaXQgd2l0aCB0ZXh0LWRlY29yYXRpb24tc2tpcDogaW5r IHNob3VsZCBsb29rIHRoZSBzYW1lIGFzIHJlbmRlcmluZyBpdCB3aXRoIGp1c3QgYSByZWd1bGFy IHVuZGVybGluZS4KKzxkaXY+PC9kaXY+Cis8ZGl2IHN0eWxlPSJkaXNwbGF5OiBpbmxpbmUtYmxv Y2s7IC13ZWJraXQtdGV4dC1kZWNvcmF0aW9uLXNraXA6IGluazsgLXdlYmtpdC10cmFuc2Zvcm06 IHNjYWxlKDUpOyAtd2Via2l0LXRyYW5zZm9ybS1vcmlnaW46IGxlZnQgdG9wOyAtd2Via2l0LXRl eHQtZGVjb3JhdGlvbi1saW5lOiB1bmRlcmxpbmUiPk5PIERFU0NFTkRFUlM8L2Rpdj4KKzwvYm9k eT4KKzwvaHRtbD4K 219686 2013-12-19 14:56:20 -0800 2013-12-19 15:21:14 -0800 Patch bug-125985-20131219145620.patch text/plain 2939 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwNDkyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmNjYjJkOGFmNDZlNTRmNWE5Yzg3 NDU4OTMzODZlMmEzYzViYTY1Ny4uNDIyNWRkZTM5MzE4MDNjYjUwMWVmM2VkOTRhNTM4NDE5MmY1 OWUxOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTEyLTE5ICBNeWxlcyBDLiBNYXhmaWVs ZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgVGVzdCB0aGF0IHRleHQtZGVjb3Jh dGlvbi1za2lwOiBpbmsgaXMgdGhlIHNhbWUgYXMgcmVndWxhciB1bmRlcmxpbmVzIGlmIG5vIGRl c2NlbmRlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNTk4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IElmIHRoZXJlIGFyZSBubyBkZXNjZW5kZXJzIGluIHRoZSB1bmRlcmxpbmVkIHRleHQsIHVzaW5n IHRoZSB0ZXh0LWRlY29yYXRpb24tc2tpcDogaW5rCisgICAgICAgIENTUyBwcm9wZXJ0eSBzaG91 bGQgYmVoYXZlIGFzIGlmIGl0IHdhc24ndCBzcGVjaWZpZWQgKGFuZCB0aGUgdW5kZXJsaW5lIGlz IGEgbm9ybWFsIG9uZSkKKworICAgICAgICAqIGZhc3QvY3NzMy10ZXh0L2NzczMtdGV4dC1kZWNv cmF0aW9uL3RleHQtZGVjb3JhdGlvbi1za2lwL3RleHQtZGVjb3JhdGlvbi1za2lwLWluay1uby1k ZXNjZW5kZXJzLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzMy10ZXh0 L2NzczMtdGV4dC1kZWNvcmF0aW9uL3RleHQtZGVjb3JhdGlvbi1za2lwL3RleHQtZGVjb3JhdGlv bi1za2lwLWluay1uby1kZXNjZW5kZXJzLmh0bWw6IEFkZGVkLgorCiAyMDEzLTEyLTEyICBBbGV4 ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgYWxnb3JpdGht Lm5hbWUgcmV0dXJuIHJlZ2lzdGVyZWQgbmFtZSwgbm90IG5vcm1hbGl6ZWQgb25lCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NzczMtdGV4dC9jc3MzLXRleHQtZGVjb3JhdGlvbi90ZXh0 LWRlY29yYXRpb24tc2tpcC90ZXh0LWRlY29yYXRpb24tc2tpcC1pbmstbm8tZGVzY2VuZGVycy1l eHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MzLXRleHQvY3NzMy10ZXh0LWRlY29y YXRpb24vdGV4dC1kZWNvcmF0aW9uLXNraXAvdGV4dC1kZWNvcmF0aW9uLXNraXAtaW5rLW5vLWRl c2NlbmRlcnMtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45YTA4OTU4Y2Y2ZmIxMzgwZWM1MGU5 YjA1NjAzNDVhYjY4NDRlNTYzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9j c3MzLXRleHQvY3NzMy10ZXh0LWRlY29yYXRpb24vdGV4dC1kZWNvcmF0aW9uLXNraXAvdGV4dC1k ZWNvcmF0aW9uLXNraXAtaW5rLW5vLWRlc2NlbmRlcnMtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsx LDEwIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8L2hlYWQ+Cis8Ym9keT4K K0JlY2F1c2UgdGhlIGZvbGxvd2luZyB0ZXh0IGRvZXMgbm90IGhhdmUgYW55IGRlc2NlbmRlcnMs IHJlbmRlcmluZyBpdCB3aXRoIHRleHQtZGVjb3JhdGlvbi1za2lwOiBpbmsgc2hvdWxkIGxvb2sg dGhlIHNhbWUgYXMgcmVuZGVyaW5nIGl0IHdpdGgganVzdCBhIHJlZ3VsYXIgdW5kZXJsaW5lLgor PGRpdj48L2Rpdj4KKzxkaXYgc3R5bGU9ImRpc3BsYXk6IGlubGluZS1ibG9jazsgLXdlYmtpdC10 cmFuc2Zvcm06IHNjYWxlKDUpOyAtd2Via2l0LXRyYW5zZm9ybS1vcmlnaW46IGxlZnQgdG9wOyB0 ZXh0LWRlY29yYXRpb246IHVuZGVybGluZSI+Tk8gREVTQ0VOREVSUzwvZGl2PgorPC9ib2R5Pgor PC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MzLXRleHQvY3NzMy10ZXh0 LWRlY29yYXRpb24vdGV4dC1kZWNvcmF0aW9uLXNraXAvdGV4dC1kZWNvcmF0aW9uLXNraXAtaW5r LW5vLWRlc2NlbmRlcnMuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzMy10ZXh0L2NzczMtdGV4 dC1kZWNvcmF0aW9uL3RleHQtZGVjb3JhdGlvbi1za2lwL3RleHQtZGVjb3JhdGlvbi1za2lwLWlu ay1uby1kZXNjZW5kZXJzLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDhkZDcwMTM4YTQwMjcwYjMxZjE5NDk1 OTgxMTNlYzNiNzE4ZjdiOQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3Nz My10ZXh0L2NzczMtdGV4dC1kZWNvcmF0aW9uL3RleHQtZGVjb3JhdGlvbi1za2lwL3RleHQtZGVj b3JhdGlvbi1za2lwLWluay1uby1kZXNjZW5kZXJzLmh0bWwKQEAgLTAsMCArMSwxMCBAQAorPCFE T0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPC9oZWFkPgorPGJvZHk+CitCZWNhdXNlIHRo ZSBmb2xsb3dpbmcgdGV4dCBkb2VzIG5vdCBoYXZlIGFueSBkZXNjZW5kZXJzLCByZW5kZXJpbmcg aXQgd2l0aCB0ZXh0LWRlY29yYXRpb24tc2tpcDogaW5rIHNob3VsZCBsb29rIHRoZSBzYW1lIGFz IHJlbmRlcmluZyBpdCB3aXRoIGp1c3QgYSByZWd1bGFyIHVuZGVybGluZS4KKzxkaXY+PC9kaXY+ Cis8ZGl2IHN0eWxlPSJkaXNwbGF5OiBpbmxpbmUtYmxvY2s7IC13ZWJraXQtdGV4dC1kZWNvcmF0 aW9uLXNraXA6IGluazsgLXdlYmtpdC10cmFuc2Zvcm06IHNjYWxlKDUpOyAtd2Via2l0LXRyYW5z Zm9ybS1vcmlnaW46IGxlZnQgdG9wOyB0ZXh0LWRlY29yYXRpb246IHVuZGVybGluZSI+Tk8gREVT Q0VOREVSUzwvZGl2PgorPC9ib2R5PgorPC9odG1sPgo=