125976 2013-12-18 20:11:05 -0800 DoublyLinkedLists can't be concatenated 2014-01-06 09:37:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 121074 1 mhahnenberg mhahnenberg benjamin cmarcelo commit-queue oldest_to_newest 961251 0 mhahnenberg 2013-12-18 20:11:05 -0800 It would be useful to be able to do so. 961260 1 219611 mhahnenberg 2013-12-18 20:57:52 -0800 Created attachment 219611 Patch 961270 2 219611 ggaren 2013-12-18 21:45:40 -0800 Comment on attachment 219611 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219611&action=review > Source/WTF/wtf/DoublyLinkedList.h:85 > + void concat(DoublyLinkedList<T>&); Maybe call this append? concat is less clear about where the elements go (head or tail). 964649 3 mhahnenberg 2014-01-06 09:37:34 -0800 Committed r161349: <http://trac.webkit.org/changeset/161349> 219611 2013-12-18 20:57:52 -0800 2013-12-18 21:45:39 -0800 Patch bug-125976-20131218205736.patch text/plain 1782 mhahnenberg SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNjA4MjMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEyLTE4ICBNYXJrIEhhaG5lbmJlcmcgIDxt aGFobmVuYmVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgRG91Ymx5TGlua2VkTGlzdHMgY2FuJ3Qg YmUgY29uY2F0ZW5hdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjU5NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHd0Zi9Eb3VibHlMaW5rZWRMaXN0Lmg6CisgICAgICAgIChXVEY6OkRvdWJseUxp bmtlZExpc3Q8VD46OmNvbmNhdCk6IFRoZSBmaXJzdCBsaXN0IGFkb3B0cyBhbGwgb2YgdGhlIG5v ZGVzIGZyb20gdGhlIHNlY29uZCBsaXN0LgorICAgICAgICBUaGUgc2Vjb25kIGxpc3QgYmVjb21l cyBlbXB0eS4KKwogMjAxMy0xMi0xOCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3 ZWJraXQub3JnPgogCiAgICAgICAgIFtXaW5DYWlyb10gUHJlcGFyYXRpb24gZm9yIEdTdHJlYW1l ciBvbiBXaW5kb3dzLgpJbmRleDogU291cmNlL1dURi93dGYvRG91Ymx5TGlua2VkTGlzdC5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0RvdWJseUxpbmtlZExpc3QuaAkocmV2aXNpb24g MTYwODIyKQorKysgU291cmNlL1dURi93dGYvRG91Ymx5TGlua2VkTGlzdC5oCSh3b3JraW5nIGNv cHkpCkBAIC04Miw2ICs4Miw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHB1c2goVCopOwogICAgIHZv aWQgYXBwZW5kKFQqKTsKICAgICB2b2lkIHJlbW92ZShUKik7CisgICAgdm9pZCBjb25jYXQoRG91 Ymx5TGlua2VkTGlzdDxUPiYpOwogCiBwcml2YXRlOgogICAgIFQqIG1faGVhZDsKQEAgLTE4Niw2 ICsxODcsMzEgQEAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFQqIERvdWJseUxpbgogICAg IHJldHVybiBub2RlOwogfQogCit0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgdm9pZCBEb3Vi bHlMaW5rZWRMaXN0PFQ+Ojpjb25jYXQoRG91Ymx5TGlua2VkTGlzdDxUPiYgb3RoZXIpCit7Cisg ICAgaWYgKCFvdGhlci5oZWFkKCkpCisgICAgICAgIHJldHVybjsKKworICAgIGlmICghaGVhZCgp KSB7CisgICAgICAgIG1faGVhZCA9IG90aGVyLmhlYWQoKTsKKyAgICAgICAgbV90YWlsID0gb3Ro ZXIudGFpbCgpOworICAgICAgICBvdGhlci5jbGVhcigpOworICAgICAgICByZXR1cm47CisgICAg fQorCisgICAgQVNTRVJUKHRhaWwoKSk7CisgICAgQVNTRVJUKG90aGVyLmhlYWQoKSk7CisgICAg VCogb3RoZXJIZWFkID0gb3RoZXIuaGVhZCgpOworICAgIFQqIG90aGVyVGFpbCA9IG90aGVyLnRh aWwoKTsKKyAgICBvdGhlci5jbGVhcigpOworCisgICAgQVNTRVJUKCFtX3RhaWwtPm5leHQoKSk7 CisgICAgbV90YWlsLT5zZXROZXh0KG90aGVySGVhZCk7CisgICAgQVNTRVJUKCFvdGhlckhlYWQt PnByZXYoKSk7CisgICAgb3RoZXJIZWFkLT5zZXRQcmV2KG1fdGFpbCk7CisgICAgbV90YWlsID0g b3RoZXJUYWlsOworfQorCiB9IC8vIG5hbWVzcGFjZSBXVEYKIAogdXNpbmcgV1RGOjpEb3VibHlM aW5rZWRMaXN0Tm9kZTsK