125974 2013-12-18 19:58:22 -0800 CStack: Rename functions in JSStack to fit WebKit Coding Style 2013-12-18 22:09:57 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 961246 0 mark.lam 2013-12-18 19:58:22 -0800 This patch is purely cosmetic. There are no semantic changes. 961247 1 219606 mark.lam 2013-12-18 20:00:38 -0800 Created attachment 219606 the patch. 961273 2 mark.lam 2013-12-18 22:09:57 -0800 Landed in r160824 on the jsCStack branch: <http://trac.webkit.org/r160824>. 219606 2013-12-18 20:00:38 -0800 2013-12-18 20:04:48 -0800 the patch. bug-125974.patch text/plain 7708 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwODIxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBA CisyMDEzLTEyLTE4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD U3RhY2s6IFJlbmFtZSBmdW5jdGlvbnMgaW4gSlNTdGFjayB0byBmaXQgV2ViS2l0IENvZGluZyBT dHlsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NTk3NC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIGlzIGEgcHVyZWx5IGNvc21ldGljIGNoYW5nZS4gVGhlcmUgYXJlIG5vIHNlbWFudGljIGNo YW5nZXMuCisKKyAgICAgICAgKiBpbnRlcnByZXRlci9KU1N0YWNrLmNwcDoKKyAgICAgICAgKEpT Qzo6SlNTdGFjazo6SlNTdGFjayk6CisgICAgICAgIChKU0M6OkpTU3RhY2s6OmdhdGhlckNvbnNl cnZhdGl2ZVJvb3RzKToKKyAgICAgICAgKEpTQzo6SlNTdGFjazo6c2FuaXRpemVTdGFjayk6Cisg ICAgICAgICogaW50ZXJwcmV0ZXIvSlNTdGFjay5oOgorICAgICAgICAoSlNDOjpKU1N0YWNrOjpi YXNlT2ZTdGFjayk6CisgICAgICAgICogaW50ZXJwcmV0ZXIvSlNTdGFja0lubGluZXMuaDoKKyAg ICAgICAgKEpTQzo6SlNTdGFjazo6dG9wT2ZGcmFtZUZvcik6CisgICAgICAgIChKU0M6OkpTU3Rh Y2s6OnRvcE9mU3RhY2spOgorICAgICAgICAoSlNDOjpKU1N0YWNrOjpzdGFydE9mRnJhbWVGb3Ip OgorICAgICAgICAoSlNDOjpKU1N0YWNrOjplbnRyeUNoZWNrKToKKyAgICAgICAgKEpTQzo6SlNT dGFjazo6cHVzaEZyYW1lKToKKyAgICAgICAgKEpTQzo6SlNTdGFjazo6cG9wRnJhbWUpOgorICAg ICAgICAoSlNDOjpKU1N0YWNrOjpzaHJpbmspOgorICAgICAgICAoSlNDOjpKU1N0YWNrOjppbnN0 YWxsRmVuY2UpOgorICAgICAgICAoSlNDOjpKU1N0YWNrOjp2YWxpZGF0ZUZlbmNlKToKKyAgICAg ICAgKEpTQzo6SlNTdGFjazo6aW5zdGFsbFRyYXBzQWZ0ZXJGcmFtZSk6CisKIDIwMTMtMTItMTgg IE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIENTdGFjazogRml4IGJh c2VsaW5lIHRvIERGRyBKSVQgT1NSLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVy cHJldGVyL0pTU3RhY2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnRlcnByZXRlci9KU1N0YWNrLmNwcAkocmV2aXNpb24gMTYwODIwKQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2ludGVycHJldGVyL0pTU3RhY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Myw3 ICs1Myw3IEBAIEpTU3RhY2s6OkpTU3RhY2soVk0mIHZtLCBzaXplX3QgY2FwYWNpdHkKICAgICB1 cGRhdGVTdGFja0xpbWl0KGhpZ2hBZGRyZXNzKCkpOwogICAgIG1fY29tbWl0RW5kID0gaGlnaEFk ZHJlc3MoKTsKICAgICAKLSAgICBtX2xhc3RTdGFja1RvcCA9IGdldEJhc2VPZlN0YWNrKCk7Cisg ICAgbV9sYXN0U3RhY2tUb3AgPSBiYXNlT2ZTdGFjaygpOwogCiAgICAgZGlzYWJsZUVycm9yU3Rh Y2tSZXNlcnZlKCk7CiAKQEAgLTk2LDcgKzk2LDcgQEAgYm9vbCBKU1N0YWNrOjpncm93U2xvd0Nh c2UoUmVnaXN0ZXIqIG5ldwogdm9pZCBKU1N0YWNrOjpnYXRoZXJDb25zZXJ2YXRpdmVSb290cyhD b25zZXJ2YXRpdmVSb290cyYgY29uc2VydmF0aXZlUm9vdHMpCiB7CiAjaWYgRU5BQkxFKExMSU5U X0NMT09QKQotICAgIGNvbnNlcnZhdGl2ZVJvb3RzLmFkZChnZXRCYXNlT2ZTdGFjaygpLCBnZXRU b3BPZlN0YWNrKCkpOworICAgIGNvbnNlcnZhdGl2ZVJvb3RzLmFkZChiYXNlT2ZTdGFjaygpLCB0 b3BPZlN0YWNrKCkpOwogI2Vsc2UKICAgICBVTlVTRURfUEFSQU0oY29uc2VydmF0aXZlUm9vdHMp OwogI2VuZGlmCkBAIC0xMDUsNyArMTA1LDcgQEAgdm9pZCBKU1N0YWNrOjpnYXRoZXJDb25zZXJ2 YXRpdmVSb290cyhDbwogdm9pZCBKU1N0YWNrOjpnYXRoZXJDb25zZXJ2YXRpdmVSb290cyhDb25z ZXJ2YXRpdmVSb290cyYgY29uc2VydmF0aXZlUm9vdHMsIEpJVFN0dWJSb3V0aW5lU2V0JiBqaXRT dHViUm91dGluZXMsIENvZGVCbG9ja1NldCYgY29kZUJsb2NrcykKIHsKICNpZiBFTkFCTEUoTExJ TlRfQ0xPT1ApCi0gICAgY29uc2VydmF0aXZlUm9vdHMuYWRkKGdldEJhc2VPZlN0YWNrKCksIGdl dFRvcE9mU3RhY2soKSwgaml0U3R1YlJvdXRpbmVzLCBjb2RlQmxvY2tzKTsKKyAgICBjb25zZXJ2 YXRpdmVSb290cy5hZGQoYmFzZU9mU3RhY2soKSwgdG9wT2ZTdGFjaygpLCBqaXRTdHViUm91dGlu ZXMsIGNvZGVCbG9ja3MpOwogI2Vsc2UKICAgICBVTlVTRURfUEFSQU0oY29uc2VydmF0aXZlUm9v dHMpOwogICAgIFVOVVNFRF9QQVJBTShqaXRTdHViUm91dGluZXMpOwpAQCAtMTE2LDE1ICsxMTYs MTUgQEAgdm9pZCBKU1N0YWNrOjpnYXRoZXJDb25zZXJ2YXRpdmVSb290cyhDbwogdm9pZCBKU1N0 YWNrOjpzYW5pdGl6ZVN0YWNrKCkKIHsKICNpZiBFTkFCTEUoTExJTlRfQ0xPT1ApCi0gICAgQVNT RVJUKGdldFRvcE9mU3RhY2soKSA8PSBnZXRCYXNlT2ZTdGFjaygpKTsKKyAgICBBU1NFUlQodG9w T2ZTdGFjaygpIDw9IGJhc2VPZlN0YWNrKCkpOwogICAgIAotICAgIGlmIChtX2xhc3RTdGFja1Rv cCA8IGdldFRvcE9mU3RhY2soKSkgeworICAgIGlmIChtX2xhc3RTdGFja1RvcCA8IHRvcE9mU3Rh Y2soKSkgewogICAgICAgICBjaGFyKiBiZWdpbiA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KG1f bGFzdFN0YWNrVG9wKTsKLSAgICAgICAgY2hhciogZW5kID0gcmVpbnRlcnByZXRfY2FzdDxjaGFy Kj4oZ2V0VG9wT2ZTdGFjaygpKTsKKyAgICAgICAgY2hhciogZW5kID0gcmVpbnRlcnByZXRfY2Fz dDxjaGFyKj4odG9wT2ZTdGFjaygpKTsKICAgICAgICAgbWVtc2V0KGJlZ2luLCAwLCBlbmQgLSBi ZWdpbik7CiAgICAgfQogICAgIAotICAgIG1fbGFzdFN0YWNrVG9wID0gZ2V0VG9wT2ZTdGFjaygp OworICAgIG1fbGFzdFN0YWNrVG9wID0gdG9wT2ZTdGFjaygpOwogI2VuZGlmCiB9CiAKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9KU1N0YWNrLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0pTU3RhY2suaAkocmV2aXNpb24g MTYwODIwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0pTU3RhY2suaAko d29ya2luZyBjb3B5KQpAQCAtODUsNyArODUsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAg dm9pZCBnYXRoZXJDb25zZXJ2YXRpdmVSb290cyhDb25zZXJ2YXRpdmVSb290cyYsIEpJVFN0dWJS b3V0aW5lU2V0JiwgQ29kZUJsb2NrU2V0Jik7CiAgICAgICAgIHZvaWQgc2FuaXRpemVTdGFjaygp OwogCi0gICAgICAgIFJlZ2lzdGVyKiBnZXRCYXNlT2ZTdGFjaygpIGNvbnN0CisgICAgICAgIFJl Z2lzdGVyKiBiYXNlT2ZTdGFjaygpIGNvbnN0CiAgICAgICAgIHsKICAgICAgICAgICAgIHJldHVy biBoaWdoQWRkcmVzcygpIC0gMTsKICAgICAgICAgfQpAQCAtOTcsOSArOTcsOSBAQCBuYW1lc3Bh Y2UgSlNDIHsKICAgICAgICAgc3RhdGljIHNpemVfdCBjb21taXR0ZWRCeXRlQ291bnQoKTsKICAg ICAgICAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZVRocmVhZGluZygpOwogCi0gICAgICAgIFJlZ2lz dGVyKiBnZXRUb3BPZkZyYW1lKENhbGxGcmFtZSopOwotICAgICAgICBSZWdpc3RlciogZ2V0U3Rh cnRPZkZyYW1lKENhbGxGcmFtZSopOwotICAgICAgICBSZWdpc3RlciogZ2V0VG9wT2ZTdGFjaygp OworICAgICAgICBSZWdpc3RlciogdG9wT2ZGcmFtZUZvcihDYWxsRnJhbWUqKTsKKyAgICAgICAg UmVnaXN0ZXIqIHN0YXJ0T2ZGcmFtZUZvcihDYWxsRnJhbWUqKTsKKyAgICAgICAgUmVnaXN0ZXIq IHRvcE9mU3RhY2soKTsKIAogICAgICAgICBib29sIGVudHJ5Q2hlY2soY2xhc3MgQ29kZUJsb2Nr KiwgaW50KTsKIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0pTU3Rh Y2tJbmxpbmVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJl dGVyL0pTU3RhY2tJbmxpbmVzLmgJKHJldmlzaW9uIDE2MDgyMCkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9pbnRlcnByZXRlci9KU1N0YWNrSW5saW5lcy5oCSh3b3JraW5nIGNvcHkpCkBAIC0z MywyNyArMzMsMjcgQEAKIAogbmFtZXNwYWNlIEpTQyB7CiAKLWlubGluZSBSZWdpc3RlciogSlNT dGFjazo6Z2V0VG9wT2ZGcmFtZShDYWxsRnJhbWUqIGZyYW1lKQoraW5saW5lIFJlZ2lzdGVyKiBK U1N0YWNrOjp0b3BPZkZyYW1lRm9yKENhbGxGcmFtZSogZnJhbWUpCiB7CiAgICAgaWYgKFVOTElL RUxZKCFmcmFtZSkpCi0gICAgICAgIHJldHVybiBnZXRCYXNlT2ZTdGFjaygpOworICAgICAgICBy ZXR1cm4gYmFzZU9mU3RhY2soKTsKICAgICByZXR1cm4gZnJhbWUtPnRvcE9mRnJhbWUoKSAtIDE7 CiB9CiAKLWlubGluZSBSZWdpc3RlciogSlNTdGFjazo6Z2V0VG9wT2ZTdGFjaygpCitpbmxpbmUg UmVnaXN0ZXIqIEpTU3RhY2s6OnRvcE9mU3RhY2soKQogewotICAgIHJldHVybiBnZXRUb3BPZkZy YW1lKG1fdG9wQ2FsbEZyYW1lKTsKKyAgICByZXR1cm4gdG9wT2ZGcmFtZUZvcihtX3RvcENhbGxG cmFtZSk7CiB9CiAKLWlubGluZSBSZWdpc3RlciogSlNTdGFjazo6Z2V0U3RhcnRPZkZyYW1lKENh bGxGcmFtZSogZnJhbWUpCitpbmxpbmUgUmVnaXN0ZXIqIEpTU3RhY2s6OnN0YXJ0T2ZGcmFtZUZv cihDYWxsRnJhbWUqIGZyYW1lKQogewogICAgIENhbGxGcmFtZSogY2FsbGVyRnJhbWUgPSBmcmFt ZS0+Y2FsbGVyRnJhbWVTa2lwcGluZ1ZNRW50cnlTZW50aW5lbCgpOwotICAgIHJldHVybiBnZXRU b3BPZkZyYW1lKGNhbGxlckZyYW1lKTsKKyAgICByZXR1cm4gdG9wT2ZGcmFtZUZvcihjYWxsZXJG cmFtZSk7CiB9CiAKIGlubGluZSBib29sIEpTU3RhY2s6OmVudHJ5Q2hlY2soY2xhc3MgQ29kZUJs b2NrKiBjb2RlQmxvY2ssIGludCBhcmdzQ291bnQpCiB7Ci0gICAgUmVnaXN0ZXIqIG9sZEVuZCA9 IGdldFRvcE9mU3RhY2soKTsKKyAgICBSZWdpc3Rlciogb2xkRW5kID0gdG9wT2ZTdGFjaygpOwog CiAgICAgLy8gRW5zdXJlIHRoYXQgd2UgaGF2ZSBlbm91Z2ggc3BhY2UgZm9yIHRoZSBwYXJhbWV0 ZXJzOgogICAgIHNpemVfdCBwYWRkZWRBcmdzQ291bnQgPSBhcmdzQ291bnQ7CkBAIC04Myw3ICs4 Myw3IEBAIGlubGluZSBib29sIEpTU3RhY2s6OmVudHJ5Q2hlY2soY2xhc3MgQ28KIGlubGluZSBD YWxsRnJhbWUqIEpTU3RhY2s6OnB1c2hGcmFtZShjbGFzcyBDb2RlQmxvY2sqIGNvZGVCbG9jaywg SlNTY29wZSogc2NvcGUsIGludCBhcmdzQ291bnQsIEpTT2JqZWN0KiBjYWxsZWUpCiB7CiAgICAg QVNTRVJUKCEhc2NvcGUpOwotICAgIFJlZ2lzdGVyKiBvbGRFbmQgPSBnZXRUb3BPZlN0YWNrKCk7 CisgICAgUmVnaXN0ZXIqIG9sZEVuZCA9IHRvcE9mU3RhY2soKTsKIAogICAgIC8vIEVuc3VyZSB0 aGF0IHdlIGhhdmUgZW5vdWdoIHNwYWNlIGZvciB0aGUgcGFyYW1ldGVyczoKICAgICBzaXplX3Qg cGFkZGVkQXJnc0NvdW50ID0gYXJnc0NvdW50OwpAQCAtMTU5LDcgKzE1OSw3IEBAIGlubGluZSB2 b2lkIEpTU3RhY2s6OnBvcEZyYW1lKENhbGxGcmFtZSoKICAgICAvLyB0aGlzIGNhc2UsIHdlJ3Jl IHNocmlua2luZyBhbGwgdGhlIHdheSB0byB0aGUgYmVnaW5uaW5nIHNpbmNlIHRoZXJlCiAgICAg Ly8gYXJlIG5vIG1vcmUgZnJhbWVzIG9uIHRoZSBzdGFjay4KICAgICBpZiAoIWNhbGxlckZyYW1l KQotICAgICAgICBzaHJpbmsoZ2V0QmFzZU9mU3RhY2soKSk7CisgICAgICAgIHNocmluayhiYXNl T2ZTdGFjaygpKTsKIAogICAgIGluc3RhbGxUcmFwc0FmdGVyRnJhbWUoY2FsbGVyRnJhbWUpOwog fQpAQCAtMTY5LDcgKzE2OSw3IEBAIGlubGluZSB2b2lkIEpTU3RhY2s6OnNocmluayhSZWdpc3Rl ciogbmUKICAgICBpZiAobmV3RW5kID49IG1fZW5kKQogICAgICAgICByZXR1cm47CiAgICAgdXBk YXRlU3RhY2tMaW1pdChuZXdFbmQpOwotICAgIGlmIChtX2VuZCA9PSBnZXRCYXNlT2ZTdGFjaygp ICYmIChtX2NvbW1pdEVuZCAtIGdldEJhc2VPZlN0YWNrKCkpID49IG1heEV4Y2Vzc0NhcGFjaXR5 KQorICAgIGlmIChtX2VuZCA9PSBiYXNlT2ZTdGFjaygpICYmIChtX2NvbW1pdEVuZCAtIGJhc2VP ZlN0YWNrKCkpID49IG1heEV4Y2Vzc0NhcGFjaXR5KQogICAgICAgICByZWxlYXNlRXhjZXNzQ2Fw YWNpdHkoKTsKIH0KIApAQCAtMjI3LDcgKzIyNyw3IEBAIGlubGluZSB2b2lkIEpTU3RhY2s6Omlu c3RhbGxGZW5jZShDYWxsRnIKIHsKICAgICBVTlVTRURfUEFSQU0oZnVuY3Rpb24pOwogICAgIFVO VVNFRF9QQVJBTShsaW5lTm8pOwotICAgIFJlZ2lzdGVyKiBzdGFydE9mRnJhbWUgPSBnZXRTdGFy dE9mRnJhbWUoZnJhbWUpOworICAgIFJlZ2lzdGVyKiBzdGFydE9mRnJhbWUgPSBzdGFydE9mRnJh bWVGb3IoZnJhbWUpOwogCiAgICAgLy8gVGhlIGxhc3QgYXJnSW5kZXggaXMgYXQ6CiAgICAgc2l6 ZV90IG1heEluZGV4ID0gZnJhbWUtPmFyZ0luZGV4Rm9yUmVnaXN0ZXIoc3RhcnRPZkZyYW1lKSAr IDE7CkBAIC0yNDMsNyArMjQzLDcgQEAgaW5saW5lIHZvaWQgSlNTdGFjazo6dmFsaWRhdGVGZW5j ZShDYWxsRgogICAgIFVOVVNFRF9QQVJBTShmdW5jdGlvbik7CiAgICAgVU5VU0VEX1BBUkFNKGxp bmVObyk7CiAgICAgQVNTRVJUKCEhZnJhbWUtPnNjb3BlKCkpOwotICAgIFJlZ2lzdGVyKiBzdGFy dE9mRnJhbWUgPSBnZXRTdGFydE9mRnJhbWUoZnJhbWUpOworICAgIFJlZ2lzdGVyKiBzdGFydE9m RnJhbWUgPSBzdGFydE9mRnJhbWVGb3IoZnJhbWUpOwogICAgIHNpemVfdCBtYXhJbmRleCA9IGZy YW1lLT5hcmdJbmRleEZvclJlZ2lzdGVyKHN0YXJ0T2ZGcmFtZSkgKyAxOwogICAgIHNpemVfdCBz dGFydEluZGV4ID0gbWF4SW5kZXggLSBGZW5jZVNpemU7CiAgICAgZm9yIChzaXplX3QgaSA9IHN0 YXJ0SW5kZXg7IGkgPCBtYXhJbmRleDsgKytpKSB7CkBAIC0yNzMsNyArMjczLDcgQEAgaW5saW5l IHZvaWQgSlNTdGFjazo6dmFsaWRhdGVGZW5jZShDYWxsRgogCiBpbmxpbmUgdm9pZCBKU1N0YWNr OjppbnN0YWxsVHJhcHNBZnRlckZyYW1lKENhbGxGcmFtZSogZnJhbWUpCiB7Ci0gICAgUmVnaXN0 ZXIqIHRvcE9mRnJhbWUgPSBnZXRUb3BPZkZyYW1lKGZyYW1lKTsKKyAgICBSZWdpc3RlciogdG9w T2ZGcmFtZSA9IHRvcE9mRnJhbWVGb3IoZnJhbWUpOwogICAgIGNvbnN0IGludCBzaXplT2ZUcmFw ID0gNjQ7CiAgICAgaW50MzJfdCogc3RhcnRPZlRyYXAgPSByZWludGVycHJldF9jYXN0PGludDMy X3QqPih0b3BPZkZyYW1lKTsKICAgICBpbnQzMl90KiBlbmRPZlRyYXAgPSBzdGFydE9mVHJhcCAt IHNpemVPZlRyYXA7Cg==