125955 2013-12-18 15:14:48 -0800 PDFPlugin: Never make a NSEventType = 0 2013-12-18 15:22:51 -0800 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca mitz oldest_to_newest 961136 0 thorton 2013-12-18 15:14:48 -0800 It's a nonsensical value for NSEventType. We should inform callers of eventTypeFromWebEvent that the conversion failed in a out-of-band manner. <rdar://problem/15691339> 961138 1 219577 thorton 2013-12-18 15:19:01 -0800 Created attachment 219577 patch 961141 2 thorton 2013-12-18 15:22:51 -0800 http://trac.webkit.org/changeset/160801 219577 2013-12-18 15:19:01 -0800 2013-12-18 15:20:55 -0800 patch pdfnseventtype.diff text/plain 4539 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiOGZkMDA0Li40YTJlMDI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMTItMTggIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUERGUGx1Z2luOiBOZXZlciBtYWtlIGEgTlNFdmVudFR5cGUgPSAwCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU5NTUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1 Z2lucy9QREYvUERGUGx1Z2luLm1tOgorICAgICAgICAoV2ViS2l0OjpnZXRFdmVudFR5cGVGcm9t V2ViRXZlbnQpOgorICAgICAgICBNYWtlIGdldEV2ZW50VHlwZUZyb21XZWJFdmVudCByZXR1cm4g aXRzIE5TRXZlbnRUeXBlIGFzIGFuIG91dCBhcmcsIGFuZAorICAgICAgICBtYWtlIHRoZSByZXR1 cm4gdmFsdWUgcmVwcmVzZW50IHdoZXRoZXIgb3Igbm90IHdlIHNldCBpdC4KKworICAgICAgICAo V2ViS2l0OjpQREZQbHVnaW46Om5zRXZlbnRGb3JXZWJNb3VzZUV2ZW50KToKKyAgICAgICAgKFdl YktpdDo6UERGUGx1Z2luOjpoYW5kbGVLZXlib2FyZEV2ZW50KToKKyAgICAgICAgTWFrZSB1c2Ug b2YgZ2V0RXZlbnRUeXBlRnJvbVdlYkV2ZW50LgorCiAyMDEzLTEyLTE4ICBBbmRlcnMgQ2FybHNz b24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgV0tSZW1vdGVPYmplY3RSZWdpc3Ry eSBzaG91bGQgaW52b2tlIGludm9jYXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2luLm1tCmluZGV4IDg5ZWU4OWYuLmM3MjRlZGUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2lu Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2lu Lm1tCkBAIC0xMjQ5LDQ5ICsxMjQ5LDUzIEBAIHN0YXRpYyBOU1VJbnRlZ2VyIG1vZGlmaWVyRmxh Z3NGcm9tV2ViRXZlbnQoY29uc3QgV2ViRXZlbnQmIGV2ZW50KQogICAgICAgICB8IChldmVudC5t ZXRhS2V5KCkgPyBOU0NvbW1hbmRLZXlNYXNrIDogMCk7CiB9CiAgICAgCi1zdGF0aWMgTlNFdmVu dFR5cGUgZXZlbnRUeXBlRnJvbVdlYkV2ZW50KGNvbnN0IFdlYkV2ZW50JiBldmVudCkKK3N0YXRp YyBib29sIGdldEV2ZW50VHlwZUZyb21XZWJFdmVudChjb25zdCBXZWJFdmVudCYgZXZlbnQsIE5T RXZlbnRUeXBlJiBldmVudFR5cGUpCiB7CiAgICAgc3dpdGNoIChldmVudC50eXBlKCkpIHsKICAg ICBjYXNlIFdlYkV2ZW50OjpLZXlEb3duOgotICAgICAgICByZXR1cm4gTlNLZXlEb3duOworICAg ICAgICBldmVudFR5cGUgPSBOU0tleURvd247CisgICAgICAgIHJldHVybiB0cnVlOwogICAgIGNh c2UgV2ViRXZlbnQ6OktleVVwOgotICAgICAgICByZXR1cm4gTlNLZXlVcDsKLQorICAgICAgICBl dmVudFR5cGUgPSBOU0tleVVwOworICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICBjYXNlIFdlYkV2 ZW50OjpNb3VzZURvd246CiAgICAgICAgIHN3aXRjaCAoc3RhdGljX2Nhc3Q8Y29uc3QgV2ViTW91 c2VFdmVudCY+KGV2ZW50KS5idXR0b24oKSkgewogICAgICAgICBjYXNlIFdlYk1vdXNlRXZlbnQ6 OkxlZnRCdXR0b246Ci0gICAgICAgICAgICByZXR1cm4gTlNMZWZ0TW91c2VEb3duOworICAgICAg ICAgICAgZXZlbnRUeXBlID0gTlNMZWZ0TW91c2VEb3duOworICAgICAgICAgICAgcmV0dXJuIHRy dWU7CiAgICAgICAgIGNhc2UgV2ViTW91c2VFdmVudDo6UmlnaHRCdXR0b246Ci0gICAgICAgICAg ICByZXR1cm4gTlNSaWdodE1vdXNlRG93bjsKKyAgICAgICAgICAgIGV2ZW50VHlwZSA9IE5TUmln aHRNb3VzZURvd247CisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgZGVmYXVsdDoK LSAgICAgICAgICAgIHJldHVybiAwOworICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAg ICB9Ci0gICAgICAgIGJyZWFrOwogICAgIGNhc2UgV2ViRXZlbnQ6Ok1vdXNlVXA6CiAgICAgICAg IHN3aXRjaCAoc3RhdGljX2Nhc3Q8Y29uc3QgV2ViTW91c2VFdmVudCY+KGV2ZW50KS5idXR0b24o KSkgewogICAgICAgICBjYXNlIFdlYk1vdXNlRXZlbnQ6OkxlZnRCdXR0b246Ci0gICAgICAgICAg ICByZXR1cm4gTlNMZWZ0TW91c2VVcDsKKyAgICAgICAgICAgIGV2ZW50VHlwZSA9IE5TTGVmdE1v dXNlVXA7CisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgY2FzZSBXZWJNb3VzZUV2 ZW50OjpSaWdodEJ1dHRvbjoKLSAgICAgICAgICAgIHJldHVybiBOU1JpZ2h0TW91c2VVcDsKKyAg ICAgICAgICAgIGV2ZW50VHlwZSA9IE5TUmlnaHRNb3VzZVVwOworICAgICAgICAgICAgcmV0dXJu IHRydWU7CiAgICAgICAgIGRlZmF1bHQ6Ci0gICAgICAgICAgICByZXR1cm4gMDsKKyAgICAgICAg ICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgfQotICAgICAgICBicmVhazsKICAgICBjYXNlIFdl YkV2ZW50OjpNb3VzZU1vdmU6CiAgICAgICAgIHN3aXRjaCAoc3RhdGljX2Nhc3Q8Y29uc3QgV2Vi TW91c2VFdmVudCY+KGV2ZW50KS5idXR0b24oKSkgewogICAgICAgICBjYXNlIFdlYk1vdXNlRXZl bnQ6OkxlZnRCdXR0b246Ci0gICAgICAgICAgICByZXR1cm4gTlNMZWZ0TW91c2VEcmFnZ2VkOwor ICAgICAgICAgICAgZXZlbnRUeXBlID0gTlNMZWZ0TW91c2VEcmFnZ2VkOworICAgICAgICAgICAg cmV0dXJuIHRydWU7CiAgICAgICAgIGNhc2UgV2ViTW91c2VFdmVudDo6UmlnaHRCdXR0b246Ci0g ICAgICAgICAgICByZXR1cm4gTlNSaWdodE1vdXNlRHJhZ2dlZDsKKyAgICAgICAgICAgIGV2ZW50 VHlwZSA9IE5TUmlnaHRNb3VzZURyYWdnZWQ7CisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAg ICAgICAgY2FzZSBXZWJNb3VzZUV2ZW50OjpOb0J1dHRvbjoKLSAgICAgICAgICAgIHJldHVybiBO U01vdXNlTW92ZWQ7CisgICAgICAgICAgICBldmVudFR5cGUgPSBOU01vdXNlTW92ZWQ7CisgICAg ICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICAgIHJldHVy biAwOworICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICB9Ci0gICAgICAgIGJyZWFr OwotCiAgICAgZGVmYXVsdDoKLSAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIHJldHVybiBmYWxz ZTsKICAgICB9CiB9CiAgICAgCkBAIC0xMzAxLDkgKzEzMDUsOSBAQCBOU0V2ZW50ICpQREZQbHVn aW46Om5zRXZlbnRGb3JXZWJNb3VzZUV2ZW50KGNvbnN0IFdlYk1vdXNlRXZlbnQmIGV2ZW50KQog CiAgICAgSW50UG9pbnQgcG9zaXRpb25JblBERlZpZXdDb29yZGluYXRlcyhjb252ZXJ0RnJvbVBs dWdpblRvUERGVmlldyhtX2xhc3RNb3VzZVBvc2l0aW9uSW5QbHVnaW5Db29yZGluYXRlcykpOwog Ci0gICAgTlNFdmVudFR5cGUgZXZlbnRUeXBlID0gZXZlbnRUeXBlRnJvbVdlYkV2ZW50KGV2ZW50 KTsKKyAgICBOU0V2ZW50VHlwZSBldmVudFR5cGU7CiAKLSAgICBpZiAoIWV2ZW50VHlwZSkKKyAg ICBpZiAoIWdldEV2ZW50VHlwZUZyb21XZWJFdmVudChldmVudCwgZXZlbnRUeXBlKSkKICAgICAg ICAgcmV0dXJuIDA7CiAKICAgICBOU1VJbnRlZ2VyIG1vZGlmaWVyRmxhZ3MgPSBtb2RpZmllckZs YWdzRnJvbVdlYkV2ZW50KGV2ZW50KTsKQEAgLTE0NjIsNyArMTQ2NiwxMSBAQCBib29sIFBERlBs dWdpbjo6aGFuZGxlQ29udGV4dE1lbnVFdmVudChjb25zdCBXZWJNb3VzZUV2ZW50JiBldmVudCkK IAogYm9vbCBQREZQbHVnaW46OmhhbmRsZUtleWJvYXJkRXZlbnQoY29uc3QgV2ViS2V5Ym9hcmRF dmVudCYgZXZlbnQpCiB7Ci0gICAgTlNFdmVudFR5cGUgZXZlbnRUeXBlID0gZXZlbnRUeXBlRnJv bVdlYkV2ZW50KGV2ZW50KTsKKyAgICBOU0V2ZW50VHlwZSBldmVudFR5cGU7CisKKyAgICBpZiAo IWdldEV2ZW50VHlwZUZyb21XZWJFdmVudChldmVudCwgZXZlbnRUeXBlKSkKKyAgICAgICAgcmV0 dXJuIGZhbHNlOworCiAgICAgTlNVSW50ZWdlciBtb2RpZmllckZsYWdzID0gbW9kaWZpZXJGbGFn c0Zyb21XZWJFdmVudChldmVudCk7CiAgICAgCiAgICAgTlNFdmVudCAqZmFrZUV2ZW50ID0gW05T RXZlbnQga2V5RXZlbnRXaXRoVHlwZTpldmVudFR5cGUgbG9jYXRpb246TlNaZXJvUG9pbnQgbW9k aWZpZXJGbGFnczptb2RpZmllckZsYWdzIHRpbWVzdGFtcDowIHdpbmRvd051bWJlcjowIGNvbnRl eHQ6MCBjaGFyYWN0ZXJzOmV2ZW50LnRleHQoKSBjaGFyYWN0ZXJzSWdub3JpbmdNb2RpZmllcnM6 ZXZlbnQudW5tb2RpZmllZFRleHQoKSBpc0FSZXBlYXQ6ZXZlbnQuaXNBdXRvUmVwZWF0KCkga2V5 Q29kZTpldmVudC5uYXRpdmVWaXJ0dWFsS2V5Q29kZSgpXTsK