125939 2013-12-18 12:34:30 -0800 [iOS] Frequent ASSERT(hasOneRef()) in SharedBuffer::releasePurgeableBuffer 2013-12-18 13:01:41 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca commit-queue japhet psolanki sam simon.fraser yongjun_zhang oldest_to_newest 961056 0 thorton 2013-12-18 12:34:30 -0800 http://trac.webkit.org/changeset/146082 fixed this by not making a purgeable buffer if a SharedBuffer has multiple refs, but the check was put in ResourceBuffer::createPurgeableBuffer instead of down in SharedBuffer::createPurgeableBuffer. This is fine for ToT WebKit, because ResourceBuffer::createPurgeableBuffer is the only caller of SharedBuffer::createPurgeableBuffer, but causes trouble for not-quite-yet-upstreamed iOS SharedBuffer code, which has another caller of SharedBuffer::createPurgeableBuffer. Pushing the early-return down into SharedBuffer::createPurgeableBuffer makes more sense and will fix the aforementioned assertion failures on iOS, and hopefully resolve some hard-to-track-down crashes. 961058 1 219558 thorton 2013-12-18 12:37:55 -0800 Created attachment 219558 patch 961069 2 219558 psolanki 2013-12-18 12:50:15 -0800 Comment on attachment 219558 patch Patch looks fine to me. Though you'll need an official reviewer to give you r+. 961073 3 thorton 2013-12-18 13:01:41 -0800 http://trac.webkit.org/changeset/160792 219558 2013-12-18 12:37:55 -0800 2013-12-18 12:53:03 -0800 patch hasonerefmove.diff text/plain 2571 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ODQ1ODM2Li43OWM2OWY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAg QEAKKzIwMTMtMTItMTggIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgW2lPU10gRnJlcXVlbnQgQVNTRVJUKGhhc09uZVJlZigpKSBpbiBTaGFyZWRCdWZm ZXI6OnJlbGVhc2VQdXJnZWFibGVCdWZmZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyNTkzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIHIxNDYwODIgZml4ZWQgdGhlc2UgYXNzZXJ0aW9ucyBieSBub3Qg bWFraW5nIGEgcHVyZ2VhYmxlIGJ1ZmZlciBpZiBhIFNoYXJlZEJ1ZmZlcgorICAgICAgICBoYXMg bXVsdGlwbGUgcmVmcywgYnV0IHRoZSBjaGVjayB3YXMgcHV0IGluIFJlc291cmNlQnVmZmVyOjpj cmVhdGVQdXJnZWFibGVCdWZmZXIKKyAgICAgICAgaW5zdGVhZCBvZiBkb3duIGluIFNoYXJlZEJ1 ZmZlcjo6Y3JlYXRlUHVyZ2VhYmxlQnVmZmVyLgorCisgICAgICAgIFRoaXMgaXMgZmluZSBmb3Ig bW9zdCBXZWJLaXQgcG9ydHMsIGJlY2F1c2UgUmVzb3VyY2VCdWZmZXI6OmNyZWF0ZVB1cmdlYWJs ZUJ1ZmZlcgorICAgICAgICBpcyB0aGUgb25seSBjYWxsZXIgb2YgU2hhcmVkQnVmZmVyOjpjcmVh dGVQdXJnZWFibGVCdWZmZXIsIGJ1dCBjYXVzZXMgdHJvdWJsZSBmb3IKKyAgICAgICAgbm90LXF1 aXRlLXlldC11cHN0cmVhbWVkIGlPUyBTaGFyZWRCdWZmZXIgY29kZSwgd2hpY2ggYWRkcyBhbm90 aGVyIGNhbGxlcgorICAgICAgICBvZiBTaGFyZWRCdWZmZXI6OmNyZWF0ZVB1cmdlYWJsZUJ1ZmZl ci4KKworICAgICAgICBQdXNoIHRoZSBlYXJseS1yZXR1cm4gZG93biBpbnRvIFNoYXJlZEJ1ZmZl cjo6Y3JlYXRlUHVyZ2VhYmxlQnVmZmVyIHRvIGVuc3VyZQorICAgICAgICB0aGF0IGFsbCBjYWxs ZXJzIGFyZSBwcm90ZWN0ZWQgZnJvbSBjcmVhdGluZyBhIHB1cmdlYWJsZSBidWZmZXIgaWYgdGhl IFNoYXJlZEJ1ZmZlcgorICAgICAgICBoYXMgcHJldmlvdXNseSBiZWVuIHZlbmRlZCBlbHNld2hl cmUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBoYXMgbm8gZWZmZWN0IG9uIHRoZSBjdXJyZW50 IE9wZW4gU291cmNlIHRyZWUuCisKKyAgICAgICAgKiBsb2FkZXIvUmVzb3VyY2VCdWZmZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VCdWZmZXI6OmNyZWF0ZVB1cmdlYWJsZUJ1ZmZl cik6CisgICAgICAgICogcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlNoYXJlZEJ1ZmZlcjo6Y3JlYXRlUHVyZ2VhYmxlQnVmZmVyKToKKwogMjAxMy0xMi0xOCAg T2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFNpbXBsaWZ5IGJpbmRp bmdzIGNvZGVnZW4gZm9yIGFkZGluZyBnZXRPd25Qcm9wZXJ0eVNsb3Qgb3ZlcnJpZGVzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VCdWZmZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlQnVmZmVyLmNwcAppbmRleCBkYWUxYzJkLi5iMGEzZWRm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VCdWZmZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUJ1ZmZlci5jcHAKQEAgLTExNSw4ICsx MTUsNiBAQCBib29sIFJlc291cmNlQnVmZmVyOjpoYXNQdXJnZWFibGVCdWZmZXIoKSBjb25zdAog dm9pZCBSZXNvdXJjZUJ1ZmZlcjo6Y3JlYXRlUHVyZ2VhYmxlQnVmZmVyKCkgY29uc3QKIHsKICAg ICBBU1NFUlQobV9zaGFyZWRCdWZmZXIpOwotICAgIGlmICghc2hhcmVkQnVmZmVyKCktPmhhc09u ZVJlZigpKQotICAgICAgICByZXR1cm47CiAgICAgc2hhcmVkQnVmZmVyKCktPmNyZWF0ZVB1cmdl YWJsZUJ1ZmZlcigpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9T aGFyZWRCdWZmZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmNw cAppbmRleCBmODQ4Y2U2Li5mODE1MmYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9TaGFyZWRCdWZmZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJl ZEJ1ZmZlci5jcHAKQEAgLTIzMSw2ICsyMzEsOSBAQCB2b2lkIFNoYXJlZEJ1ZmZlcjo6Y3JlYXRl UHVyZ2VhYmxlQnVmZmVyKCkgY29uc3QKICAgICAgICAgcmV0dXJuOwogI2VuZGlmCiAKKyAgICBp ZiAoIWhhc09uZVJlZigpKQorICAgICAgICByZXR1cm47CisKICAgICBjaGFyKiBkZXN0aW5hdGlv biA9IDA7CiAgICAgbV9wdXJnZWFibGVCdWZmZXIgPSBQdXJnZWFibGVCdWZmZXI6OmNyZWF0ZVVu aW5pdGlhbGl6ZWQobV9zaXplLCBkZXN0aW5hdGlvbik7CiAgICAgaWYgKCFtX3B1cmdlYWJsZUJ1 ZmZlcikK