<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>125934</bug_id>
          
          <creation_ts>2013-12-18 11:16:33 -0800</creation_ts>
          <short_desc>Simplify bindings codefen for adding getOwnPropertySlot overrides</short_desc>
          <delta_ts>2013-12-18 12:09:36 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Oliver Hunt">oliver</reporter>
          <assigned_to name="Oliver Hunt">oliver</assigned_to>
          <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>961012</commentid>
    <comment_count>0</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2013-12-18 11:16:33 -0800</bug_when>
    <thetext>Simplify bindings codefen for adding getOwnPropertySlot overrides</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>961014</commentid>
    <comment_count>1</comment_count>
      <attachid>219550</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2013-12-18 11:17:34 -0800</bug_when>
    <thetext>Created attachment 219550
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>961039</commentid>
    <comment_count>2</comment_count>
      <attachid>219550</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2013-12-18 11:51:08 -0800</bug_when>
    <thetext>Comment on attachment 219550
Patch

Cool.

Please wait for Mac EWS to become green.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>961050</commentid>
    <comment_count>3</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2013-12-18 12:09:36 -0800</bug_when>
    <thetext>Committed r160786: &lt;http://trac.webkit.org/changeset/160786&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>219550</attachid>
            <date>2013-12-18 11:17:34 -0800</date>
            <delta_ts>2013-12-18 11:51:08 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-125934-20131218111734.patch</filename>
            <type>text/plain</type>
            <size>4621</size>
            <attacher name="Oliver Hunt">oliver</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwNzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjAzYjhlYzhlYWZjOWRm
YTlkNzVhOWIwZjhkOGM5YmNhYTA5NzU2Mi4uMjcyZGZjNjM3OWFlNDJhZGJhMWIwNDQwZmM1YTdl
MmRhMzRmZTBhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTEyLTE4ICBPbGl2
ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisKKyAgICAgICAgU2ltcGxpZnkgYmluZGluZ3Mg
Y29kZWdlbiBmb3IgYWRkaW5nIGdldE93blByb3BlcnR5U2xvdCBvdmVycmlkZXMKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTkzNAorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbXBsZSByZWZhY3Rvcmlu
ZyBubyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0Nv
ZGVHZW5lcmF0b3JKUy5wbToKKyAgICAgICAgKEluc3RhbmNlT3ZlcnJpZGVzR2V0T3duUHJvcGVy
dHlTbG90KToKKyAgICAgICAgKFByb3RvdHlwZU92ZXJyaWRlc0dldE93blByb3BlcnR5U2xvdCk6
CisgICAgICAgIChHZW5lcmF0ZUhlYWRlcik6CisgICAgICAgIChHZW5lcmF0ZUltcGxlbWVudGF0
aW9uKToKKwogMjAxMy0xMi0xNyAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAg
ICAgICAgIFJlbW92ZSBKU0lubGluZUdldE93blByb3BlcnR5U2xvdCBhdHRyaWJ1dGUgYXMgaXQg
aXMgbm8gbG9uZ2VyIG5lY2Vzc2FyeQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGlu
Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z
Y3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQppbmRleCBlZTQ1MTU4OGViODJkZTJmYWNkZDNjOGJj
NTVhNjYyNmQ1OGQ1MWJiLi5kZmJiNWJkOTFhMTdiMjE0N2FhY2NjZTE2YTAzNTRkY2I5YTU1Y2Y5
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0
b3JKUy5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0
b3JKUy5wbQpAQCAtNTU0LDYgKzU1NCwzNSBAQCBzdWIgR2V0TmFtZWRHZXR0ZXJGdW5jdGlvbgog
ICAgIHJldHVybiBHZXRTcGVjaWFsQWNjZXNzb3JGdW5jdGlvbkZvclR5cGUoJGludGVyZmFjZSwg
ImdldHRlciIsICJET01TdHJpbmciLCAxKTsKIH0KIAorc3ViIEluc3RhbmNlT3ZlcnJpZGVzR2V0
T3duUHJvcGVydHlTbG90Cit7CisgICAgbXkgJGludGVyZmFjZSA9IHNoaWZ0OworICAgIG15ICRu
dW1BdHRyaWJ1dGVzID0gQHskaW50ZXJmYWNlLT5hdHRyaWJ1dGVzfTsKKworICAgIG15ICRuYW1l
ZEdldHRlckZ1bmN0aW9uID0gR2V0TmFtZWRHZXR0ZXJGdW5jdGlvbigkaW50ZXJmYWNlKTsKKyAg
ICBteSAkaW5kZXhlZEdldHRlckZ1bmN0aW9uID0gR2V0SW5kZXhlZEdldHRlckZ1bmN0aW9uKCRp
bnRlcmZhY2UpOworICAgIG15ICRoYXNOdW1lcmljSW5kZXhlZEdldHRlciA9ICRpbmRleGVkR2V0
dGVyRnVuY3Rpb24gPyAkY29kZUdlbmVyYXRvci0+SXNOdW1lcmljVHlwZSgkaW5kZXhlZEdldHRl
ckZ1bmN0aW9uLT5zaWduYXR1cmUtPnR5cGUpIDogMDsKKworICAgIG15ICRoYXNJbXB1cmVOYW1l
ZEdldHRlciA9ICRuYW1lZEdldHRlckZ1bmN0aW9uCisgICAgICAgIHx8ICRpbnRlcmZhY2UtPmV4
dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21OYW1lZEdldHRlciJ9CisgICAgICAgIHx8ICRpbnRl
cmZhY2UtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21HZXRPd25Qcm9wZXJ0eVNsb3QifTsK
KworICAgIG15ICRoYXNDb21wbGV4R2V0dGVyID0gJGluZGV4ZWRHZXR0ZXJGdW5jdGlvbgorICAg
ICAgICB8fCAkaW50ZXJmYWNlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiSlNDdXN0b21HZXRPd25Q
cm9wZXJ0eVNsb3RBbmREZXNjcmlwdG9yIn0KKyAgICAgICAgfHwgJGhhc0ltcHVyZU5hbWVkR2V0
dGVyOworCisgICAgcmV0dXJuICRudW1BdHRyaWJ1dGVzID4gMCB8fCAhJGludGVyZmFjZS0+ZXh0
ZW5kZWRBdHRyaWJ1dGVzLT57Ik5vSW50ZXJmYWNlT2JqZWN0In0gfHwgJGhhc0NvbXBsZXhHZXR0
ZXI7CisKK30KKworc3ViIFByb3RvdHlwZU92ZXJyaWRlc0dldE93blByb3BlcnR5U2xvdAorewor
ICAgIG15ICRpbnRlcmZhY2UgPSBzaGlmdDsKKyAgICBteSAkbnVtQ29uc3RhbnRzID0gQHskaW50
ZXJmYWNlLT5jb25zdGFudHN9OworICAgIG15ICRudW1GdW5jdGlvbnMgPSBAeyRpbnRlcmZhY2Ut
PmZ1bmN0aW9uc307CisgICAgcmV0dXJuICRudW1GdW5jdGlvbnMgPiAwIHx8ICRudW1Db25zdGFu
dHMgPiAwOworfQorCiBzdWIgR2VuZXJhdGVIZWFkZXIKIHsKICAgICBteSAkb2JqZWN0ID0gc2hp
ZnQ7CkBAIC02ODUsNyArNzE0LDcgQEAgc3ViIEdlbmVyYXRlSGVhZGVyCiAgICAgICAgIHx8ICRp
bnRlcmZhY2UtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJKU0N1c3RvbUdldE93blByb3BlcnR5U2xv
dEFuZERlc2NyaXB0b3IifQogICAgICAgICB8fCAkaGFzSW1wdXJlTmFtZWRHZXR0ZXI7CiAgICAg
Ci0gICAgbXkgJGhhc0dldHRlciA9ICRudW1BdHRyaWJ1dGVzID4gMCB8fCAhJGludGVyZmFjZS0+
ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57Ik5vSW50ZXJmYWNlT2JqZWN0In0gfHwgJGhhc0NvbXBsZXhH
ZXR0ZXI7CisgICAgbXkgJGhhc0dldHRlciA9IEluc3RhbmNlT3ZlcnJpZGVzR2V0T3duUHJvcGVy
dHlTbG90KCRpbnRlcmZhY2UpOwogCiAgICAgaWYgKCRoYXNJbXB1cmVOYW1lZEdldHRlcikgewog
ICAgICAgICAkc3RydWN0dXJlRmxhZ3N7IkpTQzo6SGFzSW1wdXJlR2V0T3duUHJvcGVydHlTbG90
In0gPSAxOwpAQCAtOTcyLDcgKzEwMDEsNyBAQCBzdWIgR2VuZXJhdGVIZWFkZXIKICAgICBwdXNo
KEBoZWFkZXJDb250ZW50LCAiICAgIH1cblxuIik7CiAKICAgICBwdXNoKEBoZWFkZXJDb250ZW50
LCAiICAgIERFQ0xBUkVfSU5GTztcbiIpOwotICAgIGlmICgkbnVtRnVuY3Rpb25zID4gMCB8fCAk
bnVtQ29uc3RhbnRzID4gMCkgeworICAgIGlmIChQcm90b3R5cGVPdmVycmlkZXNHZXRPd25Qcm9w
ZXJ0eVNsb3QoJGludGVyZmFjZSkpIHsKICAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiAg
ICBzdGF0aWMgYm9vbCBnZXRPd25Qcm9wZXJ0eVNsb3QoSlNDOjpKU09iamVjdCosIEpTQzo6RXhl
Y1N0YXRlKiwgSlNDOjpQcm9wZXJ0eU5hbWUsIEpTQzo6UHJvcGVydHlTbG90Jik7XG4iKTsKICAg
ICAgICAgJHN0cnVjdHVyZUZsYWdzeyJKU0M6Ok92ZXJyaWRlc0dldE93blByb3BlcnR5U2xvdCJ9
ID0gMTsKICAgICB9CkBAIC0xNjUyLDcgKzE2ODEsNyBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRh
dGlvbgogICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIn1cblxuIik7CiAgICAgfQogCi0gICAg
aWYgKCRudW1Db25zdGFudHMgPiAwIHx8ICRudW1GdW5jdGlvbnMgPiAwKSB7CisgICAgaWYgKFBy
b3RvdHlwZU92ZXJyaWRlc0dldE93blByb3BlcnR5U2xvdCgkaW50ZXJmYWNlKSkgewogICAgICAg
ICBwdXNoKEBpbXBsQ29udGVudCwgImJvb2wgJHtjbGFzc05hbWV9UHJvdG90eXBlOjpnZXRPd25Q
cm9wZXJ0eVNsb3QoSlNPYmplY3QqIG9iamVjdCwgRXhlY1N0YXRlKiBleGVjLCBQcm9wZXJ0eU5h
bWUgcHJvcGVydHlOYW1lLCBQcm9wZXJ0eVNsb3QmIHNsb3QpXG4iKTsKICAgICAgICAgcHVzaChA
aW1wbENvbnRlbnQsICJ7XG4iKTsKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgJHtj
bGFzc05hbWV9UHJvdG90eXBlKiB0aGlzT2JqZWN0ID0ganNDYXN0PCR7Y2xhc3NOYW1lfVByb3Rv
dHlwZSo+KG9iamVjdCk7XG4iKTsKQEAgLTE3NzMsMTMgKzE4MDIsNyBAQCBzdWIgR2VuZXJhdGVJ
bXBsZW1lbnRhdGlvbgogICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIn1cblxuIik7CiAgICAg
fQogCi0gICAgbXkgJGhhc0dldHRlciA9ICRudW1BdHRyaWJ1dGVzID4gMAotICAgICAgICAgICAg
ICAgICB8fCAhJGludGVyZmFjZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57Ik5vSW50ZXJmYWNlT2Jq
ZWN0In0KLSAgICAgICAgICAgICAgICAgfHwgJGluZGV4ZWRHZXR0ZXJGdW5jdGlvbgotICAgICAg
ICAgICAgICAgICB8fCAkaW50ZXJmYWNlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiSlNDdXN0b21H
ZXRPd25Qcm9wZXJ0eVNsb3RBbmREZXNjcmlwdG9yIn0KLSAgICAgICAgICAgICAgICAgfHwgJGlu
dGVyZmFjZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkN1c3RvbUdldE93blByb3BlcnR5U2xvdCJ9
Ci0gICAgICAgICAgICAgICAgIHx8ICRuYW1lZEdldHRlckZ1bmN0aW9uCi0gICAgICAgICAgICAg
ICAgIHx8ICRpbnRlcmZhY2UtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21OYW1lZEdldHRl
ciJ9OworICAgIG15ICRoYXNHZXR0ZXIgPSBJbnN0YW5jZU92ZXJyaWRlc0dldE93blByb3BlcnR5
U2xvdCgkaW50ZXJmYWNlKTsKIAogICAgICMgQXR0cmlidXRlcwogICAgIGlmICgkaGFzR2V0dGVy
KSB7Cg==
</data>
<flag name="review"
          id="243199"
          type_id="1"
          status="+"
          setter="ap"
    />
          </attachment>
      

    </bug>

</bugzilla>