125931 2013-12-18 10:52:23 -0800 CStack Branch: getHostCallReturnValue shouldn't pop the callFrame 2013-12-18 11:51:11 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 961003 0 msaboff 2013-12-18 10:52:23 -0800 Given that getHostCallReturnValue() is called after the return of a slow path function and that return will pop the callee frame, there is no need to pop the callee frame in getHostCallReturnValue. 961007 1 219549 msaboff 2013-12-18 10:56:31 -0800 Created attachment 219549 Patch 961036 2 219549 ggaren 2013-12-18 11:46:40 -0800 Comment on attachment 219549 Patch r=me 961040 3 msaboff 2013-12-18 11:51:11 -0800 Committed r160784: <http://trac.webkit.org/changeset/160784> 219549 2013-12-18 10:56:31 -0800 2013-12-18 11:46:40 -0800 Patch 125931.patch text/plain 3822 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwNzc4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEzLTEyLTE4ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENTdGFjayBCcmFuY2g6IGdldEhvc3RDYWxsUmV0dXJuVmFsdWUgc2hvdWxkbid0IHBvcCB0 aGUgY2FsbEZyYW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjU5MzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBTaW5jZSBnZXRIb3N0Q2FsbFJldHVyblZhbHVlKCkgaXMgY2FsbGVkIGFmdGVyIGEgY2Fs bCB0byBhIHNsb3cgcGF0aAorICAgICAgICBmdW5jdGlvbiBhbmQgdGhlIHJldHVybiBmcm9tIHRo ZSBzbG93IHBhdGNoIHBvcHMgdGhlIGNhbGwgZnJhbWUgdGhlcmUgaXMKKyAgICAgICAgbm8gbmVl ZCBmb3IgZ2V0SG9zdENhbGxSZXR1cm5WYWx1ZSgpIHRvIHBvcCB0aGUgZnJhbWUuCisgICAgICAg IFJlbW92ZWQgdGhlIHBvcHBpbmcgb2YgdGhlIGNhbGwgZnJhbWUgZ2V0SG9zdENhbGxSZXR1cm5W YWx1ZSgpIGZvciBhbGwgQ1BVIHBsYXRmb3Jtcy4KKworICAgICAgICAqIGppdC9KSVRPcGVyYXRp b25zLmNwcDoKKwogMjAxMy0xMi0xNyAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNv bT4KIAogICAgICAgICBDU3RhY2sgQnJhbmNoOiBGaXggdmFyYXJncyBjYWxscyB0byB3b3JrIG9u IEMgc3RhY2sKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25z LmNwcAkocmV2aXNpb24gMTYwNzc3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRP cGVyYXRpb25zLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTczMCw3ICsxNzMwLDYgQEAgYXNtICgK ICIuZ2xvYmwgIiBTWU1CT0xfU1RSSU5HKGdldEhvc3RDYWxsUmV0dXJuVmFsdWUpICJcbiIKIEhJ REVfU1lNQk9MKGdldEhvc3RDYWxsUmV0dXJuVmFsdWUpICJcbiIKIFNZTUJPTF9TVFJJTkcoZ2V0 SG9zdENhbGxSZXR1cm5WYWx1ZSkgIjoiICJcbiIKLSAgICAibW92IDAoJXJicCksICVyYnBcbiIg Ly8gQ2FsbGVyRnJhbWVBbmRQQzo6Y2FsbGVyRnJhbWUKICAgICAibW92ICVyYnAsICVyZGlcbiIK ICAgICAiam1wICIgTE9DQUxfUkVGRVJFTkNFKGdldEhvc3RDYWxsUmV0dXJuVmFsdWVXaXRoRXhl Y1N0YXRlKSAiXG4iCiApOwpAQCAtMTc0MSw3ICsxNzQwLDYgQEAgYXNtICgKICIuZ2xvYmwgIiBT WU1CT0xfU1RSSU5HKGdldEhvc3RDYWxsUmV0dXJuVmFsdWUpICJcbiIKIEhJREVfU1lNQk9MKGdl dEhvc3RDYWxsUmV0dXJuVmFsdWUpICJcbiIKIFNZTUJPTF9TVFJJTkcoZ2V0SG9zdENhbGxSZXR1 cm5WYWx1ZSkgIjoiICJcbiIKLSAgICAibW92IDAoJWVicCksICVlYnBcbiIgLy8gQ2FsbGVyRnJh bWVBbmRQQzo6Y2FsbGVyRnJhbWUKICAgICAibW92ICVlYnAsIDQoJWVzcClcbiIKICAgICAiam1w ICIgTE9DQUxfUkVGRVJFTkNFKGdldEhvc3RDYWxsUmV0dXJuVmFsdWVXaXRoRXhlY1N0YXRlKSAi XG4iCiApOwpAQCAtMTc1NSw3ICsxNzUzLDYgQEAgSElERV9TWU1CT0woZ2V0SG9zdENhbGxSZXR1 cm5WYWx1ZSkgIlxuIgogIi50aHVtYiIgIlxuIgogIi50aHVtYl9mdW5jICIgVEhVTUJfRlVOQ19Q QVJBTShnZXRIb3N0Q2FsbFJldHVyblZhbHVlKSAiXG4iCiBTWU1CT0xfU1RSSU5HKGdldEhvc3RD YWxsUmV0dXJuVmFsdWUpICI6IiAiXG4iCi0gICAgImxkciByNywgW3I3LCAjMF0iICJcbiIgLy8g Q2FsbGVyRnJhbWVBbmRQQzo6Y2FsbGVyRnJhbWUKICAgICAibW92IHIwLCByNyIgIlxuIgogICAg ICJiICIgTE9DQUxfUkVGRVJFTkNFKGdldEhvc3RDYWxsUmV0dXJuVmFsdWVXaXRoRXhlY1N0YXRl KSAiXG4iCiApOwpAQCAtMTc2Nyw3ICsxNzY0LDYgQEAgYXNtICgKIEhJREVfU1lNQk9MKGdldEhv c3RDYWxsUmV0dXJuVmFsdWUpICJcbiIKIElOTElORV9BUk1fRlVOQ1RJT04oZ2V0SG9zdENhbGxS ZXR1cm5WYWx1ZSkKIFNZTUJPTF9TVFJJTkcoZ2V0SG9zdENhbGxSZXR1cm5WYWx1ZSkgIjoiICJc biIKLSAgICAibGRyIHIxMSwgW3IxMSwgIzBdIiAiXG4iIC8vIENhbGxlckZyYW1lQW5kUEM6OmNh bGxlckZyYW1lCiAgICAgIm1vdiByMCwgcjExIiAiXG4iCiAgICAgImIgIiBMT0NBTF9SRUZFUkVO Q0UoZ2V0SG9zdENhbGxSZXR1cm5WYWx1ZVdpdGhFeGVjU3RhdGUpICJcbiIKICk7CkBAIC0xNzc5 LDcgKzE3NzUsNiBAQCBhc20gKAogIi5nbG9ibCAiIFNZTUJPTF9TVFJJTkcoZ2V0SG9zdENhbGxS ZXR1cm5WYWx1ZSkgIlxuIgogSElERV9TWU1CT0woZ2V0SG9zdENhbGxSZXR1cm5WYWx1ZSkgIlxu IgogU1lNQk9MX1NUUklORyhnZXRIb3N0Q2FsbFJldHVyblZhbHVlKSAiOiIgIlxuIgotICAgICJs ZHVyIHgyOSwgW3gyOSwgIzBdIiAiXG4iCiAgICAgICJtb3YgeDAsIHgyOSIgIlxuIgogICAgICAi YiAiIExPQ0FMX1JFRkVSRU5DRShnZXRIb3N0Q2FsbFJldHVyblZhbHVlV2l0aEV4ZWNTdGF0ZSkg IlxuIgogKTsKQEAgLTE3OTEsNyArMTc4Niw2IEBAIGFzbSAoCiBISURFX1NZTUJPTChnZXRIb3N0 Q2FsbFJldHVyblZhbHVlKSAiXG4iCiBTWU1CT0xfU1RSSU5HKGdldEhvc3RDYWxsUmV0dXJuVmFs dWUpICI6IiAiXG4iCiAgICAgTE9BRF9GVU5DVElPTl9UT19UOShnZXRIb3N0Q2FsbFJldHVyblZh bHVlV2l0aEV4ZWNTdGF0ZSkKLSAgICAibHcgJGZwLCAwKCRmcCkiICJcbiIgLy8gQ2FsbGVyRnJh bWVBbmRQQzo6Y2FsbGVyRnJhbWUKICAgICAibW92ZSAkYTAsICRmcCIgIlxuIgogICAgICJiICIg TE9DQUxfUkVGRVJFTkNFKGdldEhvc3RDYWxsUmV0dXJuVmFsdWVXaXRoRXhlY1N0YXRlKSAiXG4i CiApOwpAQCAtMTgwMiw3ICsxNzk2LDYgQEAgYXNtICgKICIuZ2xvYmwgIiBTWU1CT0xfU1RSSU5H KGdldEhvc3RDYWxsUmV0dXJuVmFsdWUpICJcbiIKIEhJREVfU1lNQk9MKGdldEhvc3RDYWxsUmV0 dXJuVmFsdWUpICJcbiIKIFNZTUJPTF9TVFJJTkcoZ2V0SG9zdENhbGxSZXR1cm5WYWx1ZSkgIjoi ICJcbiIKLSAgICAibW92LmwgQHIxNCwgcjE0IiAiXG4iIC8vIENhbGxlckZyYW1lQW5kUEM6OmNh bGxlckZyYW1lCiAgICAgIm1vdiByMTQsIHI0IiAiXG4iCiAgICAgIm1vdi5sIDJmLCAiIFNINF9T Q1JBVENIX1JFR0lTVEVSICJcbiIKICAgICAiYnJhZiAiIFNINF9TQ1JBVENIX1JFR0lTVEVSICJc biIKQEAgLTE4MTUsNyArMTgwOCw2IEBAIFNZTUJPTF9TVFJJTkcoZ2V0SG9zdENhbGxSZXR1cm5W YWx1ZSkgIjoKIGV4dGVybiAiQyIgewogICAgIF9fZGVjbHNwZWMobmFrZWQpIEVuY29kZWRKU1Zh bHVlIEhPU1RfQ0FMTF9SRVRVUk5fVkFMVUVfT1BUSU9OIGdldEhvc3RDYWxsUmV0dXJuVmFsdWUo KQogICAgIHsKLSAgICAgICAgX19hc20gbW92IGVicCwgW2VicCArIDBdOyAvLyBDYWxsZXJGcmFt ZUFuZFBDOjpjYWxsZXJGcmFtZQogICAgICAgICBfX2FzbSBtb3YgW2VzcCArIDRdLCBlYnA7CiAg ICAgICAgIF9fYXNtIGptcCBnZXRIb3N0Q2FsbFJldHVyblZhbHVlV2l0aEV4ZWNTdGF0ZQogICAg IH0K