125924 2013-12-18 05:34:34 -0800 Null-pointer dereference in WebCore::RootInlineBox::prevRootBox 2013-12-18 09:22:10 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 116980 1 rhodovan.u-szeged webkit-unassigned commit-queue esprehn+autocc glenn gyuyoung.kim kling koivisto macpherson menard oldest_to_newest 960910 0 rhodovan.u-szeged 2013-12-18 05:34:34 -0800 The failing test: <html> <head> <style> html{ orphans:-988; widows:435; -webkit-columns:1in auto ; width: 0; } </style> </head> <body contenteditable="true"> This test requires DumpRenderTree to see the log of what resources are loaded. It verifies that noscript-image1.png is not loaded because it is in a noscript block and noscript-image2.png is loaded because it is not in a noscript block. </html> The backtrace: Program received signal SIGSEGV, Segmentation fault. [Switching to LWP 27824] 0x00007ffff324f3c4 in WebCore::RootInlineBox::prevRootBox (this=0x0) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RootInlineBox.h:242 242 return toRootInlineBox(m_prevLineBox); (gdb) bt #0 0x00007ffff324f3c4 in WebCore::RootInlineBox::prevRootBox (this=0x0) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RootInlineBox.h:242 #1 0x00007ffff38ddb74 in WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange (this=0x75e020, layoutState=..., resolver=..., cleanLineStart=..., cleanLineBidiStatus=..., consecutiveHyphenatedLines=0) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RenderBlockLineLayout.cpp:1512 #2 0x00007ffff38db5ee in WebCore::RenderBlockFlow::layoutRunsAndFloats (this=0x75e020, layoutState=..., hasInlineChild=true) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RenderBlockLineLayout.cpp:1104 #3 0x00007ffff38dedb0 in WebCore::RenderBlockFlow::layoutLineBoxes (this=0x75e020, relayoutChildren=false, repaintLogicalTop=..., repaintLogicalBottom=...) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RenderBlockLineLayout.cpp:1696 #4 0x00007ffff38c24b4 in WebCore::RenderBlockFlow::layoutInlineChildren (this=0x75e020, relayoutChildren=false, repaintLogicalTop=..., repaintLogicalBottom=...) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RenderBlockFlow.cpp:531 #5 0x00007ffff38c17e5 in WebCore::RenderBlockFlow::layoutBlock (this=0x75e020, relayoutChildren=false, pageLogicalHeight=<incomplete type>) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RenderBlockFlow.cpp:356 #6 0x00007ffff389138f in WebCore::RenderBlock::layout (this=0x75e020) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RenderBlock.cpp:1323 #7 0x00007ffff38c2896 in WebCore::RenderBlockFlow::layoutBlockChild (this=0x8172a0, child=..., marginInfo=..., previousFloatLogicalBottom=..., maxFloatLogicalBottom=...) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RenderBlockFlow.cpp:592 #8 0x00007ffff38c23b2 in WebCore::RenderBlockFlow::layoutBlockChildren (this=0x8172a0, relayoutChildren=false, maxFloatLogicalBottom=...) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RenderBlockFlow.cpp:511 #9 0x00007ffff38c1809 in WebCore::RenderBlockFlow::layoutBlock (this=0x8172a0, relayoutChildren=false, pageLogicalHeight=<incomplete type>) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RenderBlockFlow.cpp:358 #10 0x00007ffff389138f in WebCore::RenderBlock::layout (this=0x8172a0) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RenderBlock.cpp:1323 #11 0x00007ffff38c2896 in WebCore::RenderBlockFlow::layoutBlockChild (this=0x66ea10, child=..., marginInfo=..., previousFloatLogicalBottom=..., maxFloatLogicalBottom=...) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RenderBlockFlow.cpp:592 #12 0x00007ffff38c23b2 in WebCore::RenderBlockFlow::layoutBlockChildren (this=0x66ea10, relayoutChildren=true, maxFloatLogicalBottom=...) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RenderBlockFlow.cpp:511 #13 0x00007ffff38c1809 in WebCore::RenderBlockFlow::layoutBlock (this=0x66ea10, relayoutChildren=true, pageLogicalHeight=<incomplete type>) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RenderBlockFlow.cpp:358 #14 0x00007ffff389138f in WebCore::RenderBlock::layout (this=0x66ea10) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RenderBlock.cpp:1323 #15 0x00007ffff3a5fa43 in WebCore::RenderView::layoutContent (this=0x66ea10, state=...) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RenderView.cpp:153 #16 0x00007ffff3a606a8 in WebCore::RenderView::layout (this=0x66ea10) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/rendering/RenderView.cpp:339 #17 0x00007ffff35face9 in WebCore::FrameView::layout (this=0x816d60, allowSubtree=true) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/page/FrameView.cpp:1261 #18 0x00007ffff30be058 in WebCore::Document::implicitClose (this=0x75a690) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/dom/Document.cpp:2390 #19 0x00007ffff34f70fb in WebCore::FrameLoader::checkCallImplicitClose (this=0x8254f8) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/loader/FrameLoader.cpp:849 #20 0x00007ffff34f6e8f in WebCore::FrameLoader::checkCompleted (this=0x8254f8) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/loader/FrameLoader.cpp:792 #21 0x00007ffff34f6bea in WebCore::FrameLoader::finishedParsing (this=0x8254f8) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/loader/FrameLoader.cpp:725 #22 0x00007ffff30c5241 in WebCore::Document::finishedParsing (this=0x75a690) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/dom/Document.cpp:4357 #23 0x00007ffff337944d in WebCore::HTMLConstructionSite::finishedParsing (this=0x66e908) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/html/parser/HTMLConstructionSite.cpp:347 #24 0x00007ffff33b06ef in WebCore::HTMLTreeBuilder::finished (this=0x66e8f0) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:2901 #25 0x00007ffff338038c in WebCore::HTMLDocumentParser::end (this=0x816430) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/html/parser/HTMLDocumentParser.cpp:749 #26 0x00007ffff3380477 in WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd (this=0x816430) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/html/parser/HTMLDocumentParser.cpp:760 #27 0x00007ffff337f0bf in WebCore::HTMLDocumentParser::prepareToStopParsing (this=0x816430) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/html/parser/HTMLDocumentParser.cpp:203 #28 0x00007ffff33804bc in WebCore::HTMLDocumentParser::attemptToEnd (this=0x816430) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/html/parser/HTMLDocumentParser.cpp:772 #29 0x00007ffff3380575 in WebCore::HTMLDocumentParser::finish (this=0x816430) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/html/parser/HTMLDocumentParser.cpp:821 #30 0x00007ffff34e9d74 in WebCore::DocumentWriter::end (this=0x838120) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/loader/DocumentWriter.cpp:245 ---Type <return> to continue, or q <return> to quit--- #31 0x00007ffff34d7ffe in WebCore::DocumentLoader::finishedLoading (this=0x838080, finishTime=0) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/loader/DocumentLoader.cpp:408 #32 0x00007ffff34d7d6c in WebCore::DocumentLoader::notifyFinished (this=0x838080, resource=0x8a90f0) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/loader/DocumentLoader.cpp:345 #33 0x00007ffff3568a34 in WebCore::CachedResource::checkNotify (this=0x8a90f0) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/loader/cache/CachedResource.cpp:369 #34 0x00007ffff3568b0e in WebCore::CachedResource::finishLoading (this=0x8a90f0) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/loader/cache/CachedResource.cpp:385 #35 0x00007ffff35656aa in WebCore::CachedRawResource::finishLoading (this=0x8a90f0, data=0x81acc0) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/loader/cache/CachedRawResource.cpp:94 #36 0x00007ffff352a5db in WebCore::SubresourceLoader::didFinishLoading (this=0x81ce30, finishTime=0) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/loader/SubresourceLoader.cpp:279 #37 0x00007ffff3526939 in WebCore::ResourceLoader::didFinishLoading (this=0x81ce30, finishTime=0) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/loader/ResourceLoader.cpp:487 #38 0x00007ffff41c0b5a in WebCore::readCallback (asyncResult=0x81a1e0, data=0x839df0) at /home/reni/Data/REPOS/webkitnix/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:1328 #39 0x00007fffeff93bb9 in async_ready_callback_wrapper (source_object=0x81e5e0, res=0x81a1e0, user_data=0x839df0) at ginputstream.c:530 #40 0x00007fffeffb5cbb in g_task_return_now (task=0x81a1e0) at gtask.c:1105 #41 complete_in_idle_cb (task=<optimized out>) at gtask.c:1114 #42 0x00007ffff02d9473 in g_main_dispatch (context=0x611920) at gmain.c:3054 #43 g_main_context_dispatch (context=0x611920) at gmain.c:3630 #44 0x00007ffff02d97b8 in g_main_context_iterate (dispatch=1, block=<optimized out>, context=0x611920, self=<optimized out>) at gmain.c:3701 #45 g_main_context_iterate (context=0x611920, block=<optimized out>, dispatch=1, self=<optimized out>) at gmain.c:3638 #46 0x00007ffff02d9bfa in g_main_loop_run (loop=0x611a80) at gmain.c:3895 #47 0x00007ffff49fe332 in WTF::RunLoop::run () at /home/reni/Data/REPOS/webkitnix/Source/WTF/wtf/nix/RunLoopNix.cpp:60 #48 0x00007ffff4956b9c in WebKit::WebProcessMainNix (argc=2, argv=0x7fffffffde68) at /home/reni/Data/REPOS/webkitnix/Source/WebKit2/WebProcess/nix/WebProcessMainNix.cpp:84 #49 0x00000000004007b4 in main (argc=2, argv=0x7fffffffde68) at /home/reni/Data/REPOS/webkitnix/Source/WebKit2/nix/MainNix.cpp:30 960913 1 219529 dbatyai.u-szeged 2013-12-18 05:50:05 -0800 Created attachment 219529 Proposed patch 960918 2 219529 kling 2013-12-18 06:27:29 -0800 Comment on attachment 219529 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=219529&action=review Code change looks fine, but we need to remove the "nobreak" comment. > LayoutTests/ChangeLog:3 > + Null-pointer dereference in WebCore::RootInlineBox::prevRootBox This is a bad bug/patch title and we should avoid them. It describes the symptom and not the cause. I would call it something like "CSS: Null-pointer dereference with negative 'orphans' value." > Source/WebCore/css/CSSParser.cpp:2225 > /* nobreak */ This idiosyncratic comment is no longer valid since you're removing the fall-through. 960922 3 219532 dbatyai.u-szeged 2013-12-18 06:55:07 -0800 Created attachment 219532 Proposed patch Corrected according to review 960932 4 219532 commit-queue 2013-12-18 07:48:39 -0800 Comment on attachment 219532 Proposed patch Clearing flags on attachment: 219532 Committed r160766: <http://trac.webkit.org/changeset/160766> 219529 2013-12-18 05:50:05 -0800 2013-12-18 06:27:29 -0800 Proposed patch proposedpatch.patch text/plain 4049 dbatyai.u-szeged ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwZDI1OTQxLi43N2U1Y2EyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMTIt MTggIETDoW5pZWwgQsOhdHlhaSAgPGRiYXR5YWkudS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNv bT4KKworICAgICAgICBOdWxsLXBvaW50ZXIgZGVyZWZlcmVuY2UgaW4gV2ViQ29yZTo6Um9vdElu bGluZUJveDo6cHJldlJvb3RCb3gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyNTkyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRlc3Qgd2l0aCBuZWdhdGl2ZSBvcnBoYW5zIHZhbHVlLgorCisgICAgICAg ICogZmFzdC9jc3MvbmVnYXRpdmUtb3JwaGFucy1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvY3NzL25lZ2F0aXZlLW9ycGhhbnMtY3Jhc2guaHRtbDogQWRkZWQuCisK IDIwMTMtMTItMTcgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAg W01TRV0gUGVyaW9kaWNhbGx5IG1vbml0b3Igc291cmNlIGJ1ZmZlcnMuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2Nzcy9uZWdhdGl2ZS1vcnBoYW5zLWNyYXNoLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2Zhc3QvY3NzL25lZ2F0aXZlLW9ycGhhbnMtY3Jhc2gtZXhwZWN0ZWQudHh0 Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjdlZjIyZTkKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9uZWdhdGl2ZS1vcnBoYW5zLWNyYXNoLWV4cGVj dGVkLnR4dApAQCAtMCwwICsxIEBACitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy9uZWdhdGl2ZS1vcnBoYW5zLWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9u ZWdhdGl2ZS1vcnBoYW5zLWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMC4uNzhjMjQzZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL25l Z2F0aXZlLW9ycGhhbnMtY3Jhc2guaHRtbApAQCAtMCwwICsxLDI3IEBACis8aHRtbD4KKzxoZWFk PgorPHN0eWxlPgoraHRtbCB7CisgICAgb3JwaGFuczotOTg4OworICAgIHdpZG93czogNDM1Owor ICAgIC13ZWJraXQtY29sdW1uczoxaW4gYXV0byA7CisgICAgd2lkdGg6IDA7Cit9Cis8L3N0eWxl PgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBB c1RleHQoKTsKKworZnVuY3Rpb24gb25Mb2FkKCkKK3sKKyAgICBkb2N1bWVudC5ib2R5Lm9mZnNl dExlZnQ7CisgICAgZG9jdW1lbnQuYm9keS5pbm5lckhUTUwgPSAnUEFTUyc7Cit9Cis8L3Njcmlw dD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0ib25Mb2FkKCkiPgorPCEtLSBUaGlzIHRlc3QgaXMg Zm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU5MjQuIE5lZWQg c29tZSBsb25nIHRleHQgZm9yIHJlcHJvZHVjaW5nIGNyYXNoLi0tPgorPCEtLSBDb3BpZWQgdGhl IGZvbGxvd2luZyBmcm9tIFczQyBzcGVjLi0tPgorVGhlICdvcnBoYW5zJyBwcm9wZXJ0eSBzcGVj aWZpZXMgdGhlIG1pbmltdW0gbnVtYmVyIG9mIGxpbmVzIGluIGEgYmxvY2sgY29udGFpbmVyIHRo YXQgbXVzdCBiZSBsZWZ0IGF0IHRoZSBib3R0b20gb2YgYSBwYWdlLiBUaGUgJ3dpZG93cycgcHJv cGVydHkgc3BlY2lmaWVzIHRoZSBtaW5pbXVtIG51bWJlciBvZiBsaW5lcyBpbiBhIGJsb2NrIGNv bnRhaW5lciB0aGF0IG11c3QgYmUgbGVmdCBhdCB0aGUgdG9wIG9mIGEgcGFnZS4gRXhhbXBsZXMg b2YgaG93IHRoZXkgYXJlIHVzZWQgdG8gY29udHJvbCBwYWdlIGJyZWFrcyBhcmUgZ2l2ZW4gYmVs b3cuCis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IGNiMjAyMDEuLjY4ZGM3YzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAx My0xMi0xOCAgRMOhbmllbCBCw6F0eWFpICA8ZGJhdHlhaS51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1 bmcuY29tPgorCisgICAgICAgIE51bGwtcG9pbnRlciBkZXJlZmVyZW5jZSBpbiBXZWJDb3JlOjpS b290SW5saW5lQm94OjpwcmV2Um9vdEJveAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI1OTI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgb3JwaGFucyBhbmQgd2lkb3dzIHNob3VsZCBiZSBwb3NpdGl2ZSBp bnRlZ2VyLgorCisgICAgICAgIHNwZWMgbGluazoKKyAgICAgICAgaHR0cDovL3d3dy53My5vcmcv VFIvQ1NTMi9wYWdlLmh0bWwjcHJvcGRlZi1vcnBoYW5zCisKKyAgICAgICAgQmFja3BvcnRlZCBm cm9tIEJsaW5rOiBodHRwczovL2NvZGVyZXZpZXcuY2hyb21pdW0ub3JnLzEwODY2MzAwOQorCisg ICAgICAgIFRlc3Q6IGZhc3QvY3NzL25lZ2F0aXZlLW9ycGhhbnMtY3Jhc2guaHRtbAorCisgICAg ICAgICogY3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBh cnNlVmFsdWUpOgorCiAyMDEzLTEyLTE3ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29t PgogCiAgICAgICAgIFtNU0VdIFBlcmlvZGljYWxseSBtb25pdG9yIHNvdXJjZSBidWZmZXJzLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTUGFyc2VyLmNwcAppbmRleCAzZTY1MjExLi44MTUwODIyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTUGFyc2VyLmNwcApAQCAtMjIxNywxNyArMjIxNywxOCBAQCBib29sIENTU1BhcnNlcjo6 cGFyc2VWYWx1ZShDU1NQcm9wZXJ0eUlEIHByb3BJZCwgYm9vbCBpbXBvcnRhbnQpCiAgICAgICAg IGJyZWFrOwogCiAgICAgY2FzZSBDU1NQcm9wZXJ0eVpJbmRleDogICAgICAgICAgICAgIC8vIGF1 dG8gfCA8aW50ZWdlcj4gfCBpbmhlcml0Ci0gICAgICAgIGlmIChpZCA9PSBDU1NWYWx1ZUF1dG8p IHsKKyAgICAgICAgaWYgKGlkID09IENTU1ZhbHVlQXV0bykKICAgICAgICAgICAgIHZhbGlkUHJp bWl0aXZlID0gdHJ1ZTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9CisgICAgICAgIGVs c2UKKyAgICAgICAgICAgIHZhbGlkUHJpbWl0aXZlID0gKCFpZCAmJiB2YWxpZFVuaXQodmFsdWUs IEZJbnRlZ2VyLCBDU1NRdWlya3NNb2RlKSk7CisgICAgICAgIGJyZWFrOwogICAgICAgICAvKiBu b2JyZWFrICovCiAgICAgY2FzZSBDU1NQcm9wZXJ0eU9ycGhhbnM6IC8vIDxpbnRlZ2VyPiB8IGlu aGVyaXQgfCBhdXRvIChXZSd2ZSBhZGRlZCBzdXBwb3J0IGZvciBhdXRvIGZvciBiYWNrd2FyZHMg Y29tcGF0aWJpbGl0eSkKICAgICBjYXNlIENTU1Byb3BlcnR5V2lkb3dzOiAvLyA8aW50ZWdlcj4g fCBpbmhlcml0IHwgYXV0byAoRGl0dG8pCiAgICAgICAgIGlmIChpZCA9PSBDU1NWYWx1ZUF1dG8p CiAgICAgICAgICAgICB2YWxpZFByaW1pdGl2ZSA9IHRydWU7CiAgICAgICAgIGVsc2UKLSAgICAg ICAgICAgIHZhbGlkUHJpbWl0aXZlID0gKCFpZCAmJiB2YWxpZFVuaXQodmFsdWUsIEZJbnRlZ2Vy LCBDU1NRdWlya3NNb2RlKSk7CisgICAgICAgICAgICB2YWxpZFByaW1pdGl2ZSA9ICghaWQgJiYg dmFsaWRVbml0KHZhbHVlLCBGUG9zaXRpdmVJbnRlZ2VyLCBDU1NRdWlya3NNb2RlKSk7CiAgICAg ICAgIGJyZWFrOwogCiAgICAgY2FzZSBDU1NQcm9wZXJ0eUxpbmVIZWlnaHQ6Ci0tIAoxLjcuOS41 Cgo= 219532 2013-12-18 06:55:07 -0800 2013-12-18 07:48:39 -0800 Proposed patch proposedpatch.patch text/plain 4032 dbatyai.u-szeged ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwZDI1OTQxLi43N2U1Y2EyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMTIt MTggIETDoW5pZWwgQsOhdHlhaSAgPGRiYXR5YWkudS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNv bT4KKworICAgICAgICBDU1M6IE51bGwtcG9pbnRlciBkZXJlZmVyZW5jZSB3aXRoIG5lZ2F0aXZl ICdvcnBoYW5zJyB2YWx1ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyNTkyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRlc3Qgd2l0aCBuZWdhdGl2ZSBvcnBoYW5zIHZhbHVlLgorCisgICAgICAgICog ZmFzdC9jc3MvbmVnYXRpdmUtb3JwaGFucy1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg ICAgICAqIGZhc3QvY3NzL25lZ2F0aXZlLW9ycGhhbnMtY3Jhc2guaHRtbDogQWRkZWQuCisKIDIw MTMtMTItMTcgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW01T RV0gUGVyaW9kaWNhbGx5IG1vbml0b3Igc291cmNlIGJ1ZmZlcnMuCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2Nzcy9uZWdhdGl2ZS1vcnBoYW5zLWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL2Zhc3QvY3NzL25lZ2F0aXZlLW9ycGhhbnMtY3Jhc2gtZXhwZWN0ZWQudHh0Cm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjdlZjIyZTkKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9uZWdhdGl2ZS1vcnBoYW5zLWNyYXNoLWV4cGVjdGVk LnR4dApAQCAtMCwwICsxIEBACitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nz cy9uZWdhdGl2ZS1vcnBoYW5zLWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9uZWdh dGl2ZS1vcnBoYW5zLWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MC4uNzhjMjQzZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL25lZ2F0 aXZlLW9ycGhhbnMtY3Jhc2guaHRtbApAQCAtMCwwICsxLDI3IEBACis8aHRtbD4KKzxoZWFkPgor PHN0eWxlPgoraHRtbCB7CisgICAgb3JwaGFuczotOTg4OworICAgIHdpZG93czogNDM1OworICAg IC13ZWJraXQtY29sdW1uczoxaW4gYXV0byA7CisgICAgd2lkdGg6IDA7Cit9Cis8L3N0eWxlPgor PHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1Rl eHQoKTsKKworZnVuY3Rpb24gb25Mb2FkKCkKK3sKKyAgICBkb2N1bWVudC5ib2R5Lm9mZnNldExl ZnQ7CisgICAgZG9jdW1lbnQuYm9keS5pbm5lckhUTUwgPSAnUEFTUyc7Cit9Cis8L3NjcmlwdD4K KzwvaGVhZD4KKzxib2R5IG9ubG9hZD0ib25Mb2FkKCkiPgorPCEtLSBUaGlzIHRlc3QgaXMgZm9y IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU5MjQuIE5lZWQgc29t ZSBsb25nIHRleHQgZm9yIHJlcHJvZHVjaW5nIGNyYXNoLi0tPgorPCEtLSBDb3BpZWQgdGhlIGZv bGxvd2luZyBmcm9tIFczQyBzcGVjLi0tPgorVGhlICdvcnBoYW5zJyBwcm9wZXJ0eSBzcGVjaWZp ZXMgdGhlIG1pbmltdW0gbnVtYmVyIG9mIGxpbmVzIGluIGEgYmxvY2sgY29udGFpbmVyIHRoYXQg bXVzdCBiZSBsZWZ0IGF0IHRoZSBib3R0b20gb2YgYSBwYWdlLiBUaGUgJ3dpZG93cycgcHJvcGVy dHkgc3BlY2lmaWVzIHRoZSBtaW5pbXVtIG51bWJlciBvZiBsaW5lcyBpbiBhIGJsb2NrIGNvbnRh aW5lciB0aGF0IG11c3QgYmUgbGVmdCBhdCB0aGUgdG9wIG9mIGEgcGFnZS4gRXhhbXBsZXMgb2Yg aG93IHRoZXkgYXJlIHVzZWQgdG8gY29udHJvbCBwYWdlIGJyZWFrcyBhcmUgZ2l2ZW4gYmVsb3cu Cis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmlu ZGV4IGNiMjAyMDEuLjY4ZGM3YzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMy0x Mi0xOCAgRMOhbmllbCBCw6F0eWFpICA8ZGJhdHlhaS51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcu Y29tPgorCisgICAgICAgIENTUzogTnVsbC1wb2ludGVyIGRlcmVmZXJlbmNlIHdpdGggbmVnYXRp dmUgJ29ycGhhbnMnIHZhbHVlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTI1OTI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgb3JwaGFucyBhbmQgd2lkb3dzIHNob3VsZCBiZSBwb3NpdGl2ZSBpbnRlZ2Vy LgorCisgICAgICAgIHNwZWMgbGluazoKKyAgICAgICAgaHR0cDovL3d3dy53My5vcmcvVFIvQ1NT Mi9wYWdlLmh0bWwjcHJvcGRlZi1vcnBoYW5zCisKKyAgICAgICAgQmFja3BvcnRlZCBmcm9tIEJs aW5rOiBodHRwczovL2NvZGVyZXZpZXcuY2hyb21pdW0ub3JnLzEwODY2MzAwOQorCisgICAgICAg IFRlc3Q6IGZhc3QvY3NzL25lZ2F0aXZlLW9ycGhhbnMtY3Jhc2guaHRtbAorCisgICAgICAgICog Y3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlVmFs dWUpOgorCiAyMDEzLTEyLTE3ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAg ICAgICAgIFtNU0VdIFBlcmlvZGljYWxseSBtb25pdG9yIHNvdXJjZSBidWZmZXJzLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTUGFyc2VyLmNwcAppbmRleCAzZTY1MjExLi4xMmQ0NGQwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT UGFyc2VyLmNwcApAQCAtMjIxNywxNyArMjIxNywxOCBAQCBib29sIENTU1BhcnNlcjo6cGFyc2VW YWx1ZShDU1NQcm9wZXJ0eUlEIHByb3BJZCwgYm9vbCBpbXBvcnRhbnQpCiAgICAgICAgIGJyZWFr OwogCiAgICAgY2FzZSBDU1NQcm9wZXJ0eVpJbmRleDogICAgICAgICAgICAgIC8vIGF1dG8gfCA8 aW50ZWdlcj4gfCBpbmhlcml0Ci0gICAgICAgIGlmIChpZCA9PSBDU1NWYWx1ZUF1dG8pIHsKKyAg ICAgICAgaWYgKGlkID09IENTU1ZhbHVlQXV0bykKICAgICAgICAgICAgIHZhbGlkUHJpbWl0aXZl ID0gdHJ1ZTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9Ci0gICAgICAgIC8qIG5vYnJl YWsgKi8KKyAgICAgICAgZWxzZQorICAgICAgICAgICAgdmFsaWRQcmltaXRpdmUgPSAoIWlkICYm IHZhbGlkVW5pdCh2YWx1ZSwgRkludGVnZXIsIENTU1F1aXJrc01vZGUpKTsKKyAgICAgICAgYnJl YWs7CisKICAgICBjYXNlIENTU1Byb3BlcnR5T3JwaGFuczogLy8gPGludGVnZXI+IHwgaW5oZXJp dCB8IGF1dG8gKFdlJ3ZlIGFkZGVkIHN1cHBvcnQgZm9yIGF1dG8gZm9yIGJhY2t3YXJkcyBjb21w YXRpYmlsaXR5KQogICAgIGNhc2UgQ1NTUHJvcGVydHlXaWRvd3M6IC8vIDxpbnRlZ2VyPiB8IGlu aGVyaXQgfCBhdXRvIChEaXR0bykKICAgICAgICAgaWYgKGlkID09IENTU1ZhbHVlQXV0bykKICAg ICAgICAgICAgIHZhbGlkUHJpbWl0aXZlID0gdHJ1ZTsKICAgICAgICAgZWxzZQotICAgICAgICAg ICAgdmFsaWRQcmltaXRpdmUgPSAoIWlkICYmIHZhbGlkVW5pdCh2YWx1ZSwgRkludGVnZXIsIENT U1F1aXJrc01vZGUpKTsKKyAgICAgICAgICAgIHZhbGlkUHJpbWl0aXZlID0gKCFpZCAmJiB2YWxp ZFVuaXQodmFsdWUsIEZQb3NpdGl2ZUludGVnZXIsIENTU1F1aXJrc01vZGUpKTsKICAgICAgICAg YnJlYWs7CiAKICAgICBjYXNlIENTU1Byb3BlcnR5TGluZUhlaWdodDoK