125920 2013-12-18 04:15:33 -0800 [MIPS] Use shorter j <address> jump in MacroAssembler::replaceWithJump. 2022-07-11 14:44:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified NEW DoNotImportToRadar P2 Normal --- 108664 1 kilvadyb webkit-unassigned benjamin bfulgham cmarcelo commit-queue fpizlo fu gergely ggaren jbriance mhahnenberg msaboff palfia ssseintr1 oldest_to_newest 960895 0 kilvadyb 2013-12-18 04:15:33 -0800 Using a simpler direct "jump to address" instead of "jump register" instructions in MacroAssembler::replaceWithJump we could generate smaller code and we don't need additional nops in branchTrue() and branchFalse(). For this we need to ensure that the generated JIT code is within a 256MB-aligned region. This problem is discussed in https://bugs.webkit.org/show_bug.cgi?id=103146 960898 1 219523 kilvadyb 2013-12-18 04:46:34 -0800 Created attachment 219523 proposed patch. With using direct jump instruction the code is simpler, the generated code is smaller and the speed improvements are: SunSpider : 5294.0ms -> 5098.7ms v8-v6: 18846.3ms -> 17286.7ms 1111968 2 ssseintr1 2015-07-24 05:14:46 -0700 + } else if (isWithin256MB(reinterpret_cast<int8_t*>(result) + bytes, bytes)) { + // 2nd half is good, release 1st half. + if (munmap(result, bytes)) + CRASH(); + } else I think the code is wrong here. As we are only returning 2nd half of our result, result should be changed as result + bytes. (i.e, result = reinterpret_cast<int8_t*>(result) + bytes, bytes);) Please comment me, if I'm wrong. 1111969 3 jbriance 2015-07-24 05:25:16 -0700 (In reply to comment #2) > I think the code is wrong here. > As we are only returning 2nd half of our result, result should be changed as > result + bytes. (i.e, result = reinterpret_cast<int8_t*>(result) + bytes, > bytes);) > You're right, in this case result should be updated :) 1112419 4 ssseintr1 2015-07-27 08:38:36 -0700 (In reply to comment #3) > (In reply to comment #2) > > I think the code is wrong here. > > As we are only returning 2nd half of our result, result should be changed as > > result + bytes. (i.e, result = reinterpret_cast<int8_t*>(result) + bytes, > > bytes);) > > > > You're right, in this case result should be updated :) I would like to know, how this problem was not observed by any1 else? Because it is very common get an address at the end of 256MB range, isn't it? 1112420 5 jbriance 2015-07-27 08:58:37 -0700 > I would like to know, how this problem was not observed by any1 else? Mainly because this change has not been committed in WebKit yet ;) > Because it is very common get an address at the end of 256MB range, isn't it? This case is quite unlikely: the chances that the first mmap doesn't fit between two 256Mb boundardies are low, then the chances that the 2nd mmap doesn't fit are also low. Finally, 50% chance that you'll need the 2nd mmaped area. But of course it's not impossible, so this would need to be fixed. 1112431 6 219523 fpizlo 2015-07-27 10:03:59 -0700 Comment on attachment 219523 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=219523&action=review We should remove MIPS from svn. You should maintain it downstream. This port doesn't have the kind of regular maintenance that we would expect from an in-tree port. > Source/WTF/wtf/OSAllocatorPosix.cpp:75 > + if (executable && UNLIKELY(!isWithin256MB(result, bytes))) { I don't see how this can happen if you're using a fixed pool. 1158791 7 219523 jbriance 2016-01-26 05:33:49 -0800 Comment on attachment 219523 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=219523&action=review >> Source/WTF/wtf/OSAllocatorPosix.cpp:75 >> + if (executable && UNLIKELY(!isWithin256MB(result, bytes))) { > > I don't see how this can happen if you're using a fixed pool. It can happen because of the fixed pool allocation itself: this fixed pool must fit in a 256Mb page. 219523 2013-12-18 04:46:34 -0800 2015-07-27 10:03:59 -0700 proposed patch. region.diff text/plain 9766 kilvadyb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDQzMmRiYWQuLmQ0ODA4YjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTEyLTE4ICBCYWxhenMgS2lsdmFk eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgW01JUFNdIFVzZSBzaG9ydGVy IGogPGFkZHJlc3M+IGp1bXAgaW4gTWFjcm9Bc3NlbWJsZXI6OnJlcGxhY2VXaXRoSnVtcC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTkyMAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBkaXJlY3Qg Imp1bXAgdG8gYWRkcmVzcyIgaW5zdGVhZCBvZiAianVtcCByZWdpc3RlciIgaW4KKyAgICAgICAg TWFjcm9Bc3NlbWJsZXJNSVBTOjpyZXBsYWNlV2l0aEp1bXAuCisKKyAgICAgICAgKiBhc3NlbWJs ZXIvTUlQU0Fzc2VtYmxlci5oOgorICAgICAgICAoSlNDOjpNSVBTQXNzZW1ibGVyOjptYXhKdW1w UmVwbGFjZW1lbnRTaXplKToKKyAgICAgICAgKEpTQzo6TUlQU0Fzc2VtYmxlcjo6cmV2ZXJ0SnVt cFRvTW92ZSk6CisgICAgICAgIChKU0M6Ok1JUFNBc3NlbWJsZXI6OmNhbkp1bXBXaXRoSik6Cisg ICAgICAgIChKU0M6Ok1JUFNBc3NlbWJsZXI6OnJlcGxhY2VXaXRoSnVtcCk6CisgICAgICAgICog YXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2Vt Ymxlck1JUFM6OmJyYW5jaEVxdWFsKToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJNSVBT OjpicmFuY2hOb3RFcXVhbCk6CisgICAgICAgICogaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaDoK KwogMjAxMy0xMi0xNyAgSnVsaWVuIEJyaWFuY2VhdSAgPGpicmlhbmNlQGNpc2NvLmNvbT4KIAog ICAgICAgICBGaXggYXJtdjcgYW5kIHNoNCBidWlsZHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01JUFNBc3NlbWJsZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9hc3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5oCmluZGV4IGI3NWI0ZDAuLmI1ZDJmMWQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5o CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5oCkBA IC03MjgsMzUgKzcyOCw2IEBAIHB1YmxpYzoKICAgICAvLyB3cml0YWJsZSByZWdpb24gb2YgbWVt b3J5OyB0byBtb2RpZnkgdGhlIGNvZGUgaW4gYW4gZXhlY3V0ZS1vbmx5IGV4ZWN1YWJsZQogICAg IC8vIHBvb2wgdGhlICdyZXBhdGNoJyBhbmQgJ3JlbGluaycgbWV0aG9kcyBzaG91bGQgYmUgdXNl ZC4KIAotICAgIHN0YXRpYyBzaXplX3QgbGlua0RpcmVjdEp1bXAodm9pZCogY29kZSwgdm9pZCog dG8pCi0gICAgewotICAgICAgICBNSVBTV29yZCogaW5zbiA9IHJlaW50ZXJwcmV0X2Nhc3Q8TUlQ U1dvcmQqPihyZWludGVycHJldF9jYXN0PGludHB0cl90Pihjb2RlKSk7Ci0gICAgICAgIHNpemVf dCBvcHMgPSAwOwotICAgICAgICBpbnQzMl90IHNsb3RBZGRyID0gcmVpbnRlcnByZXRfY2FzdDxp bnQ+KGluc24pICsgNDsKLSAgICAgICAgaW50MzJfdCB0b0FkZHIgPSByZWludGVycHJldF9jYXN0 PGludD4odG8pOwotCi0gICAgICAgIGlmICgoc2xvdEFkZHIgJiAweGYwMDAwMDAwKSAhPSAodG9B ZGRyICYgMHhmMDAwMDAwMCkpIHsKLSAgICAgICAgICAgIC8vIGx1aQotICAgICAgICAgICAgKmlu c24gPSAweDNjMDAwMDAwIHwgKE1JUFNSZWdpc3RlcnM6OnQ5IDw8IE9QX1NIX1JUKSB8ICgodG9B ZGRyID4+IDE2KSAmIDB4ZmZmZik7Ci0gICAgICAgICAgICArK2luc247Ci0gICAgICAgICAgICAv LyBvcmkKLSAgICAgICAgICAgICppbnNuID0gMHgzNDAwMDAwMCB8IChNSVBTUmVnaXN0ZXJzOjp0 OSA8PCBPUF9TSF9SVCkgfCAoTUlQU1JlZ2lzdGVyczo6dDkgPDwgT1BfU0hfUlMpIHwgKHRvQWRk ciAmIDB4ZmZmZik7Ci0gICAgICAgICAgICArK2luc247Ci0gICAgICAgICAgICAvLyBqcgotICAg ICAgICAgICAgKmluc24gPSAweDAwMDAwMDA4IHwgKE1JUFNSZWdpc3RlcnM6OnQ5IDw8IE9QX1NI X1JTKTsKLSAgICAgICAgICAgICsraW5zbjsKLSAgICAgICAgICAgIG9wcyA9IDQgKiBzaXplb2Yo TUlQU1dvcmQpOwotICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgLy8gagotICAgICAgICAg ICAgKmluc24gPSAweDA4MDAwMDAwIHwgKCh0b0FkZHIgJiAweDBmZmZmZmZmKSA+PiAyKTsKLSAg ICAgICAgICAgICsraW5zbjsKLSAgICAgICAgICAgIG9wcyA9IDIgKiBzaXplb2YoTUlQU1dvcmQp OwotICAgICAgICB9Ci0gICAgICAgIC8vIG5vcAotICAgICAgICAqaW5zbiA9IDB4MDAwMDAwMDA7 Ci0gICAgICAgIHJldHVybiBvcHM7Ci0gICAgfQotCiAgICAgdm9pZCBsaW5rSnVtcChBc3NlbWJs ZXJMYWJlbCBmcm9tLCBBc3NlbWJsZXJMYWJlbCB0bykKICAgICB7CiAgICAgICAgIEFTU0VSVCh0 by5pc1NldCgpKTsKQEAgLTg5NiwzNCArODY3LDQyIEBAIHB1YmxpYzoKIAogICAgIHN0YXRpYyBw dHJkaWZmX3QgbWF4SnVtcFJlcGxhY2VtZW50U2l6ZSgpCiAgICAgewotICAgICAgICByZXR1cm4g c2l6ZW9mKE1JUFNXb3JkKSAqIDQ7CisgICAgICAgIHJldHVybiBzaXplb2YoTUlQU1dvcmQpICog MjsKICAgICB9CiAKICAgICBzdGF0aWMgdm9pZCByZXZlcnRKdW1wVG9Nb3ZlKHZvaWQqIGluc3Ry dWN0aW9uU3RhcnQsIFJlZ2lzdGVySUQgcnQsIGludCBpbW0pCiAgICAgewogICAgICAgICBNSVBT V29yZCogaW5zbiA9IHN0YXRpY19jYXN0PE1JUFNXb3JkKj4oaW5zdHJ1Y3Rpb25TdGFydCk7Ci0g ICAgICAgIHNpemVfdCBjb2RlU2l6ZSA9IDIgKiBzaXplb2YoTUlQU1dvcmQpOwogCiAgICAgICAg IC8vIGx1aQogICAgICAgICAqaW5zbiA9IDB4M2MwMDAwMDAgfCAocnQgPDwgT1BfU0hfUlQpIHwg KChpbW0gPj4gMTYpICYgMHhmZmZmKTsKICAgICAgICAgKytpbnNuOwogICAgICAgICAvLyBvcmkK ICAgICAgICAgKmluc24gPSAweDM0MDAwMDAwIHwgKHJ0IDw8IE9QX1NIX1JTKSB8IChydCA8PCBP UF9TSF9SVCkgfCAoaW1tICYgMHhmZmZmKTsKLSAgICAgICAgKytpbnNuOwotICAgICAgICAvLyBp ZiBqciAkdDkKLSAgICAgICAgaWYgKCppbnNuID09IDB4MDMyMDAwMDgpIHsKLSAgICAgICAgICAg ICppbnNuID0gMHgwMDAwMDAwMDsKLSAgICAgICAgICAgIGNvZGVTaXplICs9IHNpemVvZihNSVBT V29yZCk7Ci0gICAgICAgIH0KLSAgICAgICAgY2FjaGVGbHVzaChpbnNuLCBjb2RlU2l6ZSk7Cisg ICAgICAgIGNhY2hlRmx1c2goaW5zbiwgMiAqIHNpemVvZihNSVBTV29yZCkpOworICAgIH0KKwor ICAgIHN0YXRpYyBib29sIGNhbkp1bXBXaXRoSih2b2lkKiBpbnN0cnVjdGlvblN0YXJ0LCB2b2lk KiB0bykKKyAgICB7CisgICAgICAgIGludHB0cl90IHNsb3RBZGRyID0gcmVpbnRlcnByZXRfY2Fz dDxpbnRwdHJfdD4oaW5zdHJ1Y3Rpb25TdGFydCkgKyA0OworICAgICAgICBpbnRwdHJfdCB0b0Fk ZHIgPSByZWludGVycHJldF9jYXN0PGludHB0cl90Pih0byk7CisgICAgICAgIHJldHVybiAoc2xv dEFkZHIgJiAweGYwMDAwMDAwKSA9PSAodG9BZGRyICYgMHhmMDAwMDAwMCk7CiAgICAgfQogCiAg ICAgc3RhdGljIHZvaWQgcmVwbGFjZVdpdGhKdW1wKHZvaWQqIGluc3RydWN0aW9uU3RhcnQsIHZv aWQqIHRvKQogICAgIHsKICAgICAgICAgQVNTRVJUKCEoYml0d2lzZV9jYXN0PHVpbnRwdHJfdD4o aW5zdHJ1Y3Rpb25TdGFydCkgJiAzKSk7CiAgICAgICAgIEFTU0VSVCghKGJpdHdpc2VfY2FzdDx1 aW50cHRyX3Q+KHRvKSAmIDMpKTsKLSAgICAgICAgc2l6ZV90IG9wcyA9IGxpbmtEaXJlY3RKdW1w KGluc3RydWN0aW9uU3RhcnQsIHRvKTsKLSAgICAgICAgY2FjaGVGbHVzaChpbnN0cnVjdGlvblN0 YXJ0LCBvcHMpOworICAgICAgICBBU1NFUlQoY2FuSnVtcFdpdGhKKGluc3RydWN0aW9uU3RhcnQs IHRvKSk7CisgICAgICAgIE1JUFNXb3JkKiBpbnNuID0gcmVpbnRlcnByZXRfY2FzdDxNSVBTV29y ZCo+KGluc3RydWN0aW9uU3RhcnQpOworICAgICAgICBpbnQzMl90IHRvQWRkciA9IHJlaW50ZXJw cmV0X2Nhc3Q8aW50MzJfdD4odG8pOworCisgICAgICAgIC8vIGogPHRvPgorICAgICAgICAqaW5z biA9IDB4MDgwMDAwMDAgfCAoKHRvQWRkciAmIDB4MGZmZmZmZmYpID4+IDIpOworICAgICAgICAr K2luc247CisgICAgICAgIC8vIG5vcAorICAgICAgICAqaW5zbiA9IDB4MDAwMDAwMDA7CisgICAg ICAgIGNhY2hlRmx1c2goaW5zdHJ1Y3Rpb25TdGFydCwgMiAqIHNpemVvZihNSVBTV29yZCkpOwog ICAgIH0KIAogICAgIHN0YXRpYyB2b2lkIHJlcGxhY2VXaXRoTG9hZCh2b2lkKiBpbnN0cnVjdGlv blN0YXJ0KQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlck1JUFMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9B c3NlbWJsZXJNSVBTLmgKaW5kZXggYTQ1MjllZi4uNDBmYWQwNCAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCkBAIC0yNTU5 LDggKzI1NTksNiBAQCBwdWJsaWM6CiAKICAgICBKdW1wIGJyYW5jaEVxdWFsKFJlZ2lzdGVySUQg cnMsIFJlZ2lzdGVySUQgcnQpCiAgICAgewotICAgICAgICBtX2Fzc2VtYmxlci5ub3AoKTsKLSAg ICAgICAgbV9hc3NlbWJsZXIubm9wKCk7CiAgICAgICAgIG1fYXNzZW1ibGVyLmFwcGVuZEp1bXAo KTsKICAgICAgICAgbV9hc3NlbWJsZXIuYmVxKHJzLCBydCwgMCk7CiAgICAgICAgIG1fYXNzZW1i bGVyLm5vcCgpOwpAQCAtMjU3MCw4ICsyNTY4LDYgQEAgcHVibGljOgogCiAgICAgSnVtcCBicmFu Y2hOb3RFcXVhbChSZWdpc3RlcklEIHJzLCBSZWdpc3RlcklEIHJ0KQogICAgIHsKLSAgICAgICAg bV9hc3NlbWJsZXIubm9wKCk7Ci0gICAgICAgIG1fYXNzZW1ibGVyLm5vcCgpOwogICAgICAgICBt X2Fzc2VtYmxlci5hcHBlbmRKdW1wKCk7CiAgICAgICAgIG1fYXNzZW1ibGVyLmJuZShycywgcnQs IDApOwogICAgICAgICBtX2Fzc2VtYmxlci5ub3AoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmgKaW5kZXggMWYzYWQwMy4uYWM4OTFmZCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmgK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmgKQEAg LTEwMiw3ICsxMDIsNyBAQCBjbGFzcyBEZW1hbmRFeGVjdXRhYmxlQWxsb2NhdG9yOwogI2VuZGlm CiAKICNpZiBFTkFCTEUoRVhFQ1VUQUJMRV9BTExPQ0FUT1JfRklYRUQpCi0jaWYgQ1BVKEFSTSkg fHwgQ1BVKEFSTTY0KQorI2lmIENQVShBUk0pIHx8IENQVShBUk02NCkgfHwgQ1BVKE1JUFMpCiBz dGF0aWMgY29uc3Qgc2l6ZV90IGZpeGVkRXhlY3V0YWJsZU1lbW9yeVBvb2xTaXplID0gMTYgKiAx MDI0ICogMTAyNDsKICNlbGlmIENQVShYODZfNjQpCiBzdGF0aWMgY29uc3Qgc2l6ZV90IGZpeGVk RXhlY3V0YWJsZU1lbW9yeVBvb2xTaXplID0gMTAyNCAqIDEwMjQgKiAxMDI0OwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCAzYTU0 MzUxLi5mYzUwNDZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTEyLTE4ICBCYWxhenMgS2ls dmFkeSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgW01JUFNdIFVzZSBzaG9y dGVyIGogPGFkZHJlc3M+IGp1bXAgaW4gTWFjcm9Bc3NlbWJsZXI6OnJlcGxhY2VXaXRoSnVtcC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTkyMAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRvIGJlIGFi bGUgdG8gdXNlIGRpcmVjdCAianVtcCB0byBhZGRyZXNzIiBpbnN0cnVjdGlvbnMgaW4gZ2VuZXJh dGVkCisgICAgICAgIGNvZGVzIG9mIE1hY3JvQXNzZW1ibGVyTUlQUzo6cmVwbGFjZVdpdGhKdW1w IHdlIGhhdmUgdG8gdXNlCisgICAgICAgIEV4ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbCBv biBNSVBTIGFuZCBmb3JjZSB0aGUgYWxsb2NhdGVkIG1lbW9yeQorICAgICAgICB0byByZXNpZGUg aW4gYSAyNTZNQi1hbGlnbmVkIHJlZ2lvbi4KKworICAgICAgICAqIHd0Zi9PU0FsbG9jYXRvclBv c2l4LmNwcDoKKyAgICAgICAgKFdURjo6aXNXaXRoaW4yNTZNQik6CisgICAgICAgIChXVEY6Ok9T QWxsb2NhdG9yOjpyZXNlcnZlVW5jb21taXR0ZWQpOgorICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5o OgorCiAyMDEzLTEyLTE2ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAg ICAgICBbaU9TXSBVcHN0cmVhbSBXZWJDb3JlL2h0bWwgY2hhbmdlcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dURi93dGYvT1NBbGxvY2F0b3JQb3NpeC5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9PU0FsbG9j YXRvclBvc2l4LmNwcAppbmRleCBhNzFmMzkxLi5mNjc2YjAzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V1RGL3d0Zi9PU0FsbG9jYXRvclBvc2l4LmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9PU0FsbG9j YXRvclBvc2l4LmNwcApAQCAtMzUsNiArMzUsMTUgQEAKIAogbmFtZXNwYWNlIFdURiB7CiAKKyNp ZiBDUFUoTUlQUykKK3N0YXRpYyBib29sIGlzV2l0aGluMjU2TUIoY29uc3Qgdm9pZCogcHRyLCBz aXplX3QgbGVuZ3RoKQoreworICAgIGNvbnN0IGludHB0cl90IHN0YXJ0ID0gcmVpbnRlcnByZXRf Y2FzdDxpbnRwdHJfdD4ocHRyKTsKKyAgICBjb25zdCBpbnRwdHJfdCBlbmQgPSBzdGFydCArIGxl bmd0aCAtIDE7CisgICAgcmV0dXJuIChzdGFydCAmIDB4ZjAwMDAwMDApID09IChlbmQgJiAweGYw MDAwMDAwKTsKK30KKyNlbmRpZiAvLyBDUFUoTUlQUykKKwogdm9pZCogT1NBbGxvY2F0b3I6OnJl c2VydmVVbmNvbW1pdHRlZChzaXplX3QgYnl0ZXMsIFVzYWdlIHVzYWdlLCBib29sIHdyaXRhYmxl LCBib29sIGV4ZWN1dGFibGUsIGJvb2wgaW5jbHVkZXNHdWFyZFBhZ2VzKQogewogI2lmIE9TKFFO WCkKQEAgLTUwLDEyICs1OSwzOSBAQCB2b2lkKiBPU0FsbG9jYXRvcjo6cmVzZXJ2ZVVuY29tbWl0 dGVkKHNpemVfdCBieXRlcywgVXNhZ2UgdXNhZ2UsIGJvb2wgd3JpdGFibGUsCiAjZWxpZiBPUyhM SU5VWCkKICAgICBVTlVTRURfUEFSQU0odXNhZ2UpOwogICAgIFVOVVNFRF9QQVJBTSh3cml0YWJs ZSk7CisjaWYgIUNQVShNSVBTKQogICAgIFVOVVNFRF9QQVJBTShleGVjdXRhYmxlKTsKKyNlbmRp ZgogICAgIFVOVVNFRF9QQVJBTShpbmNsdWRlc0d1YXJkUGFnZXMpOwogCiAgICAgdm9pZCogcmVz dWx0ID0gbW1hcCgwLCBieXRlcywgUFJPVF9OT05FLCBNQVBfTk9SRVNFUlZFIHwgTUFQX1BSSVZB VEUgfCBNQVBfQU5PTiwgLTEsIDApOwogICAgIGlmIChyZXN1bHQgPT0gTUFQX0ZBSUxFRCkKICAg ICAgICAgQ1JBU0goKTsKKyNpZiBDUFUoTUlQUykKKyAgICAvLyBPbiBNSVBTIHdlIGNhbiB1c2Ug c2hvcnRlciBqIDxhZGRyZXNzPiBqdW1wIGluc3RydWN0aW9ucyBpZiB0aGUgZXhlY3V0YWJsZQor ICAgIC8vIG1lbW9yeSByZXNpZGVzIGVudGlyZWx5IHdpdGhpbiBhIHNpbmdsZSAyNTZNQiBwYWdl IChlLmcuIDB4MzAwMC4wMDAwIHRvIDB4M2ZmZi5mZmZmKS4KKyAgICAvLyBVc3VhbGx5IHRoaXMg aXMgdHJ1ZSBmb3IgdGhlIHNtYWxsIGJ1ZmZlcnMgd2UgYWxsb2NhdGUsIGJ1dCB3ZSB0ZXN0LCBh bmQgdXBvbiBmYWlsdXJlCisgICAgLy8gd2UgcmVhbGxvY2F0ZSBhIGRvdWJsZS1zaXplIHJlZ2lv biwgY2hvb3NlIGEgdmFsaWQgcmVnaW9uLCBhbmQgdW5tYXAgdGhlIHJlbWFpbmRlci4KKyAgICBp ZiAoZXhlY3V0YWJsZSAmJiBVTkxJS0VMWSghaXNXaXRoaW4yNTZNQihyZXN1bHQsIGJ5dGVzKSkp IHsKKyAgICAgICAgLy8gTm90IGluIDI1Nk1CIHJlZ2lvbiwgdHJ5IHRvIG1hcCBkb3VibGUgc2l6 ZS4KKyAgICAgICAgaWYgKG11bm1hcChyZXN1bHQsIGJ5dGVzKSkKKyAgICAgICAgICAgIENSQVNI KCk7CisgICAgICAgIHJlc3VsdCA9IG1tYXAoMCwgMiAqIGJ5dGVzLCBQUk9UX05PTkUsIE1BUF9O T1JFU0VSVkUgfCBNQVBfUFJJVkFURSB8IE1BUF9BTk9OLCAtMSwgMCk7CisgICAgICAgIGlmIChy ZXN1bHQgPT0gTUFQX0ZBSUxFRCkKKyAgICAgICAgICAgIENSQVNIKCk7CisgICAgICAgIGlmIChp c1dpdGhpbjI1Nk1CKHJlc3VsdCwgYnl0ZXMpKSB7CisgICAgICAgICAgICAvLyAxc3QgaGFsZiBp cyBnb29kLCByZWxlYXNlIDJuZCBoYWxmLgorICAgICAgICAgICAgaWYgKG11bm1hcChyZWludGVy cHJldF9jYXN0PGludDhfdCo+KHJlc3VsdCkgKyBieXRlcywgYnl0ZXMpKQorICAgICAgICAgICAg ICAgIENSQVNIKCk7CisgICAgICAgIH0gZWxzZSBpZiAoaXNXaXRoaW4yNTZNQihyZWludGVycHJl dF9jYXN0PGludDhfdCo+KHJlc3VsdCkgKyBieXRlcywgYnl0ZXMpKSB7CisgICAgICAgICAgICAv LyAybmQgaGFsZiBpcyBnb29kLCByZWxlYXNlIDFzdCBoYWxmLgorICAgICAgICAgICAgaWYgKG11 bm1hcChyZXN1bHQsIGJ5dGVzKSkKKyAgICAgICAgICAgICAgICBDUkFTSCgpOworICAgICAgICB9 IGVsc2UKKyAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIH0KKyNlbmRpZiAv LyBDUFUoTUlQUykKKwogICAgIG1hZHZpc2UocmVzdWx0LCBieXRlcywgTUFEVl9ET05UTkVFRCk7 CiAjZWxzZQogICAgIHZvaWQqIHJlc3VsdCA9IHJlc2VydmVBbmRDb21taXQoYnl0ZXMsIHVzYWdl LCB3cml0YWJsZSwgZXhlY3V0YWJsZSwgaW5jbHVkZXNHdWFyZFBhZ2VzKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmlu ZGV4IDc3Yzc2Y2YuLmViZDJlNDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3Jt LmgKKysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaApAQCAtODcyLDcgKzg3Miw3IEBACiAv KiBQaWNrIHdoaWNoIGFsbG9jYXRvciB0byB1c2U7IHdlIG9ubHkgbmVlZCBhbiBleGVjdXRhYmxl IGFsbG9jYXRvciBpZiB0aGUgYXNzZW1ibGVyIGlzIGNvbXBpbGVkIGluLgogICAgT24geDg2LTY0 IHdlIHVzZSBhIHNpbmdsZSBmaXhlZCBtbWFwLCBvbiBvdGhlciBwbGF0Zm9ybXMgd2UgbW1hcCBv biBkZW1hbmQuICovCiAjaWYgRU5BQkxFKEFTU0VNQkxFUikKLSNpZiBDUFUoWDg2XzY0KSAmJiAh T1MoV0lORE9XUykgfHwgUExBVEZPUk0oSU9TKQorI2lmIENQVShYODZfNjQpICYmICFPUyhXSU5E T1dTKSB8fCBQTEFURk9STShJT1MpIHx8IENQVShNSVBTKQogI2RlZmluZSBFTkFCTEVfRVhFQ1VU QUJMRV9BTExPQ0FUT1JfRklYRUQgMQogI2Vsc2UKICNkZWZpbmUgRU5BQkxFX0VYRUNVVEFCTEVf QUxMT0NBVE9SX0RFTUFORCAxCg==