125916 2013-12-18 02:19:27 -0800 Move function calls outside loop in dom 2013-12-20 02:59:00 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lvidacs.u-szeged webkit-unassigned andersca cmarcelo commit-queue darin esprehn+autocc kangil.han lvidacs.u-szeged oldest_to_newest 960872 0 lvidacs.u-szeged 2013-12-18 02:19:27 -0800 Dom Node::dumpStatistics() and Element::cloneAttributesFromElement(const Element& other) calls length() method in each iteration, while the number of elements does not change within the loop. 960894 1 219521 lvidacs.u-szeged 2013-12-18 04:11:40 -0800 Created attachment 219521 Patch 961806 2 219521 commit-queue 2013-12-20 02:58:58 -0800 Comment on attachment 219521 Patch Clearing flags on attachment: 219521 Committed r160901: <http://trac.webkit.org/changeset/160901> 961807 3 commit-queue 2013-12-20 02:59:00 -0800 All reviewed patches have been landed. Closing bug. 219521 2013-12-18 04:11:40 -0800 2013-12-20 02:58:58 -0800 Patch bug-125916-20131218131138.patch text/plain 2473 lvidacs.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwNzU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2IyMDIwMTE4ZDMyMTBl MWMwN2RhYjcwYTM5YzQwNGJjMDg1MTE5OC4uMjAzNzQxMDU1NWQ2OTU0MWNiMGIzMjZjMjBmMjQz OTk3MDgyMzgwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTEyLTE4ICBMYXN6 bG8gVmlkYWNzICA8bHZpZGFjcy51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgorCisgICAg ICAgIE1vdmUgZnVuY3Rpb24gY2FsbHMgb3V0c2lkZSBsb29wIGluIGRvbQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1OTE2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gbm90IGNhbGwgbGVuZ3RoKCkg aW4gZWFjaCBpdGVyYXRpb24uCisKKyAgICAgICAgKiBkb20vRWxlbWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpFbGVtZW50OjpjbG9uZUF0dHJpYnV0ZXNGcm9tRWxlbWVudCk6CisgICAgICAg ICogZG9tL05vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6ZHVtcFN0YXRpc3RpY3Mp OgorCiAyMDEzLTEyLTE3ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAg ICAgIFtNU0VdIFBlcmlvZGljYWxseSBtb25pdG9yIHNvdXJjZSBidWZmZXJzLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0Vs ZW1lbnQuY3BwCmluZGV4IDBjMzgyMDc5MTcwNWI4NmVkMGM1ZjUzMTFkMjgyM2YwYzA4ZjhmN2Uu LjVmZjc4NTVjOGViYTBkOWMyNTU0ODBhNThhNjM0NzI4Mzg0ZDVlYzkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxl bWVudC5jcHAKQEAgLTMwNTksNyArMzA1OSw4IEBAIHZvaWQgRWxlbWVudDo6Y2xvbmVBdHRyaWJ1 dGVzRnJvbUVsZW1lbnQoY29uc3QgRWxlbWVudCYgb3RoZXIpCiAgICAgZWxzZQogICAgICAgICBt X2VsZW1lbnREYXRhID0gb3RoZXIubV9lbGVtZW50RGF0YS0+bWFrZVVuaXF1ZUNvcHkoKTsKIAot ICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBtX2VsZW1lbnREYXRhLT5sZW5ndGgoKTsgKytp KSB7CisgICAgdW5zaWduZWQgbGVuZ3RoID0gbV9lbGVtZW50RGF0YS0+bGVuZ3RoKCk7CisgICAg Zm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGxlbmd0aDsgKytpKSB7CiAgICAgICAgIGNvbnN0IEF0 dHJpYnV0ZSYgYXR0cmlidXRlID0gY29uc3RfY2FzdDxjb25zdCBFbGVtZW50RGF0YSo+KG1fZWxl bWVudERhdGEuZ2V0KCkpLT5hdHRyaWJ1dGVBdChpKTsKICAgICAgICAgYXR0cmlidXRlQ2hhbmdl ZChhdHRyaWJ1dGUubmFtZSgpLCBhdHRyaWJ1dGUudmFsdWUoKSwgTW9kaWZpZWRCeUNsb25pbmcp OwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAppbmRleCA3YzkwNTY5NzE3NWQxNjkzMGMyYjBlNmRkMWFh YWJiZWEzM2UzYWMzLi40ZmFiNjFlMjY4ZjY5ZDI4Njg3NmMwYTQ4MTljZDg5ZDE5Y2YyNGVhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvZG9tL05vZGUuY3BwCkBAIC0xNTMsOSArMTUzLDEwIEBAIHZvaWQgTm9kZTo6ZHVtcFN0YXRp c3RpY3MoKQogICAgICAgICAgICAgICAgICAgICByZXN1bHQuaXRlcmF0b3ItPnZhbHVlKys7CiAK ICAgICAgICAgICAgICAgICBpZiAoRWxlbWVudERhdGEqIGVsZW1lbnREYXRhID0gZWxlbWVudC0+ ZWxlbWVudERhdGEoKSkgewotICAgICAgICAgICAgICAgICAgICBhdHRyaWJ1dGVzICs9IGVsZW1l bnREYXRhLT5sZW5ndGgoKTsKKyAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbGVuZ3RoID0g ZWxlbWVudERhdGEtPmxlbmd0aCgpOworICAgICAgICAgICAgICAgICAgICBhdHRyaWJ1dGVzICs9 IGxlbmd0aDsKICAgICAgICAgICAgICAgICAgICAgKytlbGVtZW50c1dpdGhBdHRyaWJ1dGVTdG9y YWdlOwotICAgICAgICAgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgZWxlbWVu dERhdGEtPmxlbmd0aCgpOyArK2kpIHsKKyAgICAgICAgICAgICAgICAgICAgZm9yICh1bnNpZ25l ZCBpID0gMDsgaSA8IGxlbmd0aDsgKytpKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICBBdHRy aWJ1dGUmIGF0dHIgPSBlbGVtZW50RGF0YS0+YXR0cmlidXRlQXQoaSk7CiAgICAgICAgICAgICAg ICAgICAgICAgICBpZiAoYXR0ci5hdHRyKCkpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KythdHRyaWJ1dGVzV2l0aEF0dHI7Cg==