125915 2013-12-18 02:00:37 -0800 False webkit-check-style warnings on * 2013-12-18 10:02:59 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tgergely.u-szeged webkit-unassigned commit-queue darin gbalogh.u-szeged glenn oldest_to_newest 960866 0 tgergely.u-szeged 2013-12-18 02:00:37 -0800 The webkit-check-style script reports error on multiplication when it checks the usage * in pointer declarations (e.g. in bug 120284). 960867 1 tgergely.u-szeged 2013-12-18 02:03:26 -0800 A patch for bug 125846 causes this since r160706. 960925 2 219533 gbalogh.u-szeged 2013-12-18 07:00:43 -0800 Created attachment 219533 patch I fix this error. However keep in mind there is impossible (without a full-parser) to distinguish the following to scenarios. pointer declaration: <some type> * <some variable name>; multiplication: <some variable name> * <some (other) variable name>; Of course the latest one is bad practice. So I only filter the case: delete <variable name> * <variable name>; return <variable name> * <variable name>; 960967 3 219533 commit-queue 2013-12-18 10:02:57 -0800 Comment on attachment 219533 patch Clearing flags on attachment: 219533 Committed r160772: <http://trac.webkit.org/changeset/160772> 960968 4 commit-queue 2013-12-18 10:02:59 -0800 All reviewed patches have been landed. Closing bug. 219533 2013-12-18 07:00:43 -0800 2013-12-18 10:02:57 -0800 patch f2744.fix.diff text/plain 2420 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2Yjcx ZTkxLi5mNjE1MWRiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMTItMTggIEdlcmdvIEJhbG9naCAgPGdlcnl4 eXpAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIEZhbHNlIHdlYmtpdC1jaGVjay1zdHlsZSB3 YXJuaW5ncyBvbiAqLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTI1OTE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAg KGNoZWNrX3NwYWNpbmcpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvY3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAoQ3BwU3R5bGVUZXN0LnRlc3RfcG9pbnRlcl9y ZWZlcmVuY2VfbWFya2VyX2xvY2F0aW9uKToKKwogMjAxMy0xMi0xOCAgRMOhbmllbCBCw6F0eWFp ICA8QmF0eWFpLkRhbmllbEBzdHVkLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIE1vdmUgZXhwZWN0 YXRpb24gcGFyc2luZyBvdXQgb2YgdGhlIGNvbnN0cnVjdG9yIG9mIFRlc3RFeHBlY3RhdGlvbnMK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggZmEx ODBjOC4uZDA1ODlkNCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHAucHkKQEAgLTE5MjQsOCArMTkyNCw4IEBAIGRlZiBjaGVja19zcGFjaW5nKGZpbGVfZXh0 ZW5zaW9uLCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVycm9yKToKIAogICAgIGlmIGZpbGVf ZXh0ZW5zaW9uID09ICdjcHAnOgogICAgICAgICAjIEMrKyBzaG91bGQgaGF2ZSB0aGUgJiBvciAq IGJlc2lkZSB0aGUgdHlwZSBub3QgdGhlIHZhcmlhYmxlIG5hbWUuCi0gICAgICAgIG1hdGNoZWQg PSBtYXRjaChyJ1xzKihbXHdcc10rKSg/PCFcYnJldHVybnxcYmRlbGV0ZSlccysoP1A8cG9pbnRl cl9vcGVyYXRvcj5cKnxcJilccypcdysnLCBsaW5lKQotICAgICAgICBpZiBtYXRjaGVkOgorICAg ICAgICBtYXRjaGVkID0gbWF0Y2gocidccyooP1A8cHJlX3BhcnQ+W1x3XHNdKylccysoP1A8cG9p bnRlcl9vcGVyYXRvcj5cKnxcJilccypcdysnLCBsaW5lKQorICAgICAgICBpZiBtYXRjaGVkIGFu ZCBub3QgbWF0Y2hlZC5ncm91cCgncHJlX3BhcnQnKS5zdGFydHN3aXRoKCdyZXR1cm4nKSBhbmQg bm90IG1hdGNoZWQuZ3JvdXAoJ3ByZV9wYXJ0Jykuc3RhcnRzd2l0aCgnZGVsZXRlJyk6CiAgICAg ICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ3doaXRlc3BhY2UvZGVjbGFyYXRpb24nLCAzLAog ICAgICAgICAgICAgICAgICAgJ0RlY2xhcmF0aW9uIGhhcyBzcGFjZSBiZXR3ZWVuIHR5cGUgbmFt ZSBhbmQgJXMgaW4gJXMnICUgKG1hdGNoZWQuZ3JvdXAoJ3BvaW50ZXJfb3BlcmF0b3InKSwgbWF0 Y2hlZC5ncm91cCgwKS5zdHJpcCgpKSkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQppbmRleCBlZDkxMTdmLi5kNzEyNTZi IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91 bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nw cF91bml0dGVzdC5weQpAQCAtMjA3MCw2ICsyMDcwLDcgQEAgY2xhc3MgQ3BwU3R5bGVUZXN0KENw cFN0eWxlVGVzdEJhc2UpOgogICAgICAgICAgICAgICAgICAgICAgICAgICdEZWNsYXJhdGlvbiBo YXMgc3BhY2UgYmV0d2VlbiB0eXBlIG5hbWUgYW5kICogaW4gaW50ICogYiAgW3doaXRlc3BhY2Uv ZGVjbGFyYXRpb25dIFszXScsCiAgICAgICAgICAgICAgICAgICAgICAgICAgJ2Zvby5jcHAnKQog ICAgICAgICBzZWxmLmFzc2VydF9saW50KCdyZXR1cm4gKmI7JywgJycsICdmb28uY3BwJykKKyAg ICAgICAgc2VsZi5hc3NlcnRfbGludCgncmV0dXJuIGEgKiBiOycsICcnLCAnZm9vLmNwcCcpCiAg ICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ2RlbGV0ZSAqYjsnLCAnJywgJ2Zvby5jcHAnKQogICAg ICAgICBzZWxmLmFzc2VydF9saW50KCdpbnQgKmI7JywgJycsICdmb28uYycpCiAgICAgICAgIHNl bGYuYXNzZXJ0X2xpbnQoJ2ludCogYjsnLAo=