125909 2013-12-17 20:06:57 -0800 Web Inspector: handle scroll to zoom in TimelineOverview 2014-01-20 19:02:52 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy aroben graouts joepeck timothy webkit-bug-importer oldest_to_newest 960814 0 timothy 2013-12-17 20:06:57 -0800 Support scroll up and down to zoom TimelineOverview. 960817 1 219499 timothy 2013-12-17 20:13:17 -0800 Created attachment 219499 Patch 960990 2 219546 timothy 2013-12-18 10:33:06 -0800 Created attachment 219546 Patch 960999 3 219546 joepeck 2013-12-18 10:46:45 -0800 Comment on attachment 219546 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219546&action=review r=me > Source/WebInspectorUI/UserInterface/TimelineOverview.js:169 > + var deviceDirection = event.webkitDirectionInvertedFromDevice ? -1 : 1; Does this match Instruments / OS X Maps? As long as we are consistent with something in the system =). 969415 4 timothy 2014-01-18 00:35:54 -0800 *** Bug 14378 has been marked as a duplicate of this bug. *** 969422 5 webkit-bug-importer 2014-01-18 01:03:37 -0800 <rdar://problem/15852729> 970123 6 timothy 2014-01-20 19:02:52 -0800 https://trac.webkit.org/changeset/162409 219499 2013-12-17 20:13:17 -0800 2013-12-18 10:33:03 -0800 Patch bug-125909-20131217201316.patch text/plain 3324 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3ODg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA2 OGQ1OWZlZWQwZjM5NjhjODc2ZTIzNzUzZjAxMTgxMzc3OTczZmEzLi5jZDIzYjE5NGEzYTcyZDhi ZjU4ZmFlNGJmMzViZDNhNDg2YjI4ODg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxMy0xMi0xNyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgU3VwcG9ydCBzY3JvbGwgdG8gem9vbSBpbiBUaW1lbGluZU92ZXJ2aWV3 LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU5 MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvVGltZWxpbmVPdmVydmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5U aW1lbGluZU92ZXJ2aWV3KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3 LnByb3RvdHlwZS5faGFuZGxlV2hlZWxFdmVudCk6CisKKzIwMTMtMTItMTcgIFRpbW90aHkgSGF0 Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCiAgICAgICAgIEFkZCB0aGUgc3RhcnQgb2YgdGhl IFRpbWVsaW5lT3ZlcnZpZXcgY2xhc3MuCiAKICAgICAgICAgVGltZWxpbmVPdmVydmlldyBjdXJy ZW50bHkgaGFzIGEgdGltZSBydWxlciBhbmQgdHJhY2tzIHRoZSBjdXJyZW50IHJlY29yZGluZyB0 aW1lLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVGlt ZWxpbmVPdmVydmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Rp bWVsaW5lT3ZlcnZpZXcuanMKaW5kZXggNmFhZGVlZWZmODNmNTAzNDI1YzYwYTczNDFjMTU2YmMw NTkyMTBkZC4uNjEzYTIxYTMyNmQ0YzA1N2Q1OTRlNjEwYzU3ZjQyNTQ2ZjE3YTdhOSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVGltZWxpbmVPdmVydmll dy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9UaW1lbGluZU92 ZXJ2aWV3LmpzCkBAIC0zMCw2ICszMCw4IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3 ID0gZnVuY3Rpb24oKQogICAgIHRoaXMuX2VsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50 KCJkaXYiKTsKICAgICB0aGlzLl9lbGVtZW50LmNsYXNzTmFtZSA9IFdlYkluc3BlY3Rvci5UaW1l bGluZU92ZXJ2aWV3LlN0eWxlQ2xhc3NOYW1lOwogCisgICAgdGhpcy5fZWxlbWVudC5hZGRFdmVu dExpc3RlbmVyKCJ3aGVlbCIsIHRoaXMuX2hhbmRsZVdoZWVsRXZlbnQuYmluZCh0aGlzKSk7CisK ICAgICB0aGlzLl9zY3JvbGxDb250YWluZXIgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYi KTsKICAgICB0aGlzLl9zY3JvbGxDb250YWluZXIuY2xhc3NOYW1lID0gV2ViSW5zcGVjdG9yLlRp bWVsaW5lT3ZlcnZpZXcuU2Nyb2xsQ29udGFpbmVyU3R5bGVDbGFzc05hbWU7CiAgICAgdGhpcy5f ZWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLl9zY3JvbGxDb250YWluZXIpOwpAQCAtNDYsNiArNDgs OCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVPdmVydmlldyA9IGZ1bmN0aW9uKCkKIAogV2ViSW5z cGVjdG9yLlRpbWVsaW5lT3ZlcnZpZXcuU3R5bGVDbGFzc05hbWUgPSAidGltZWxpbmUtb3ZlcnZp ZXciOwogV2ViSW5zcGVjdG9yLlRpbWVsaW5lT3ZlcnZpZXcuU2Nyb2xsQ29udGFpbmVyU3R5bGVD bGFzc05hbWUgPSAic2Nyb2xsLWNvbnRhaW5lciI7CitXZWJJbnNwZWN0b3IuVGltZWxpbmVPdmVy dmlldy5NaW5pbXVtU2Vjb25kc1BlclBpeGVsID0gMC4wMDE7CitXZWJJbnNwZWN0b3IuVGltZWxp bmVPdmVydmlldy5TZWNvbmRzUGVyU2Nyb2xsRGVsdGEgPSAwLjAwMDAwNTsKIAogV2ViSW5zcGVj dG9yLlRpbWVsaW5lT3ZlcnZpZXcucHJvdG90eXBlID0gewogICAgIGNvbnN0cnVjdG9yOiBXZWJJ bnNwZWN0b3IuVGltZWxpbmVPdmVydmlldywKQEAgLTE0OSw1ICsxNTMsMjYgQEAgV2ViSW5zcGVj dG9yLlRpbWVsaW5lT3ZlcnZpZXcucHJvdG90eXBlID0gewogICAgICAgICBpZiAodGhpcy5fc2No ZWR1bGVkTGF5b3V0VXBkYXRlSWRlbnRpZmllcikKICAgICAgICAgICAgIHJldHVybjsKICAgICAg ICAgdGhpcy5fc2NoZWR1bGVkTGF5b3V0VXBkYXRlSWRlbnRpZmllciA9IHJlcXVlc3RBbmltYXRp b25GcmFtZSh0aGlzLnVwZGF0ZUxheW91dC5iaW5kKHRoaXMpKTsKKyAgICB9LAorCisgICAgX2hh bmRsZVdoZWVsRXZlbnQ6IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsKKyAgICAgICAgaWYgKE1hdGgu YWJzKGV2ZW50LmRlbHRhWCkgPj0gTWF0aC5hYnMoZXZlbnQuZGVsdGFZKSkKKyAgICAgICAgICAg IHJldHVybjsKKworICAgICAgICAvLyBSZW1lbWJlciB0aGUgbW91c2UgcG9zaXRpb24gaW4gdGlt ZS4KKyAgICAgICAgdmFyIG1vdXNlT2Zmc2V0ID0gZXZlbnQub2Zmc2V0WDsKKyAgICAgICAgdmFy IG1vdXNlUG9zaXRpb25UaW1lID0gKHRoaXMuX3Njcm9sbENvbnRhaW5lci5zY3JvbGxMZWZ0ICsg bW91c2VPZmZzZXQpICogdGhpcy5zZWNvbmRzUGVyUGl4ZWw7CisKKyAgICAgICAgdmFyIGRpcmVj dGlvbiA9IGV2ZW50LndlYmtpdERpcmVjdGlvbkludmVydGVkRnJvbURldmljZSA/IC0xIDogMTsK KyAgICAgICAgdmFyIG5ld1NlY29uZHNQZXJQaXhlbCA9IHRoaXMuc2Vjb25kc1BlclBpeGVsICsg KGV2ZW50LmRlbHRhWSAqIFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3LlNlY29uZHNQZXJT Y3JvbGxEZWx0YSAqIGRpcmVjdGlvbik7CisKKyAgICAgICAgdGhpcy5zZWNvbmRzUGVyUGl4ZWwg PSBNYXRoLm1heChXZWJJbnNwZWN0b3IuVGltZWxpbmVPdmVydmlldy5NaW5pbXVtU2Vjb25kc1Bl clBpeGVsLCBuZXdTZWNvbmRzUGVyUGl4ZWwpOworCisgICAgICAgIC8vIENlbnRlciB0aGUgem9v bSBhcm91bmQgdGhlIG1vdXNlIGJhc2VkIG9uIHRoZSByZW1lbWJlcmVkIG1vdXNlIHBvc2l0aW9u IHRpbWUuCisgICAgICAgIHRoaXMuX3Njcm9sbENvbnRhaW5lci5zY3JvbGxMZWZ0ID0gKG1vdXNl UG9zaXRpb25UaW1lIC8gdGhpcy5zZWNvbmRzUGVyUGl4ZWwpIC0gbW91c2VPZmZzZXQ7CisKKyAg ICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKKyAgICAgICAgZXZlbnQuc3RvcFByb3BhZ2F0 aW9uKCk7CiAgICAgfQogfTsK 219546 2013-12-18 10:33:06 -0800 2013-12-18 10:46:45 -0800 Patch bug-125909-20131218103305.patch text/plain 3889 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3ODg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA2 OGQ1OWZlZWQwZjM5NjhjODc2ZTIzNzUzZjAxMTgxMzc3OTczZmEzLi5jZDIzYjE5NGEzYTcyZDhi ZjU4ZmFlNGJmMzViZDNhNDg2YjI4ODg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxMy0xMi0xNyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgU3VwcG9ydCBzY3JvbGwgdG8gem9vbSBpbiBUaW1lbGluZU92ZXJ2aWV3 LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU5 MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvVGltZWxpbmVPdmVydmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5U aW1lbGluZU92ZXJ2aWV3KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3 LnByb3RvdHlwZS5faGFuZGxlV2hlZWxFdmVudCk6CisKKzIwMTMtMTItMTcgIFRpbW90aHkgSGF0 Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCiAgICAgICAgIEFkZCB0aGUgc3RhcnQgb2YgdGhl IFRpbWVsaW5lT3ZlcnZpZXcgY2xhc3MuCiAKICAgICAgICAgVGltZWxpbmVPdmVydmlldyBjdXJy ZW50bHkgaGFzIGEgdGltZSBydWxlciBhbmQgdHJhY2tzIHRoZSBjdXJyZW50IHJlY29yZGluZyB0 aW1lLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVGlt ZWxpbmVPdmVydmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Rp bWVsaW5lT3ZlcnZpZXcuanMKaW5kZXggZTg2ZDAyOThjYjQ4ZTI3OGZhMWU4MDg4ZDA0YTkzMWQ2 ZWQ4YjQ0Mi4uMjRlYzEyNDI2YWU0YTA1Yjg2YWYyZDY4MmMzNDQzODk2NmU1YzQ0OSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVGltZWxpbmVPdmVydmll dy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9UaW1lbGluZU92 ZXJ2aWV3LmpzCkBAIC0zMCw2ICszMCw4IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3 ID0gZnVuY3Rpb24oKQogICAgIHRoaXMuX2VsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50 KCJkaXYiKTsKICAgICB0aGlzLl9lbGVtZW50LmNsYXNzTmFtZSA9IFdlYkluc3BlY3Rvci5UaW1l bGluZU92ZXJ2aWV3LlN0eWxlQ2xhc3NOYW1lOwogCisgICAgdGhpcy5fZWxlbWVudC5hZGRFdmVu dExpc3RlbmVyKCJ3aGVlbCIsIHRoaXMuX2hhbmRsZVdoZWVsRXZlbnQuYmluZCh0aGlzKSk7CisK ICAgICB0aGlzLl9zY3JvbGxDb250YWluZXIgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYi KTsKICAgICB0aGlzLl9zY3JvbGxDb250YWluZXIuY2xhc3NOYW1lID0gV2ViSW5zcGVjdG9yLlRp bWVsaW5lT3ZlcnZpZXcuU2Nyb2xsQ29udGFpbmVyU3R5bGVDbGFzc05hbWU7CiAgICAgdGhpcy5f ZWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLl9zY3JvbGxDb250YWluZXIpOwpAQCAtNDYsNiArNDgs OCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVPdmVydmlldyA9IGZ1bmN0aW9uKCkKIAogV2ViSW5z cGVjdG9yLlRpbWVsaW5lT3ZlcnZpZXcuU3R5bGVDbGFzc05hbWUgPSAidGltZWxpbmUtb3ZlcnZp ZXciOwogV2ViSW5zcGVjdG9yLlRpbWVsaW5lT3ZlcnZpZXcuU2Nyb2xsQ29udGFpbmVyU3R5bGVD bGFzc05hbWUgPSAic2Nyb2xsLWNvbnRhaW5lciI7CitXZWJJbnNwZWN0b3IuVGltZWxpbmVPdmVy dmlldy5NaW5pbXVtU2Vjb25kc1BlclBpeGVsID0gMC4wMDE7CitXZWJJbnNwZWN0b3IuVGltZWxp bmVPdmVydmlldy5TZWNvbmRzUGVyU2Nyb2xsRGVsdGEgPSAwLjAwMDAwNTsKIAogV2ViSW5zcGVj dG9yLlRpbWVsaW5lT3ZlcnZpZXcucHJvdG90eXBlID0gewogICAgIGNvbnN0cnVjdG9yOiBXZWJJ bnNwZWN0b3IuVGltZWxpbmVPdmVydmlldywKQEAgLTg0LDcgKzg4LDcgQEAgV2ViSW5zcGVjdG9y LlRpbWVsaW5lT3ZlcnZpZXcucHJvdG90eXBlID0gewogICAgICAgICBpZiAodGhpcy5fdGltZWxp bmVSdWxlci5zZWNvbmRzUGVyUGl4ZWwgPT09IHgpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAg ICAgICAgdGhpcy5fdGltZWxpbmVSdWxlci5zZWNvbmRzUGVyUGl4ZWwgPSB4OworICAgICAgICB0 aGlzLl90aW1lbGluZVJ1bGVyLnNlY29uZHNQZXJQaXhlbCA9IE1hdGgubWF4KFdlYkluc3BlY3Rv ci5UaW1lbGluZU92ZXJ2aWV3Lk1pbmltdW1TZWNvbmRzUGVyUGl4ZWwsIHgpOwogCiAgICAgICAg IHRoaXMuX25lZWRzTGF5b3V0KCk7CiAgICAgfSwKQEAgLTE0OSw1ICsxNTMsMzAgQEAgV2ViSW5z cGVjdG9yLlRpbWVsaW5lT3ZlcnZpZXcucHJvdG90eXBlID0gewogICAgICAgICBpZiAodGhpcy5f c2NoZWR1bGVkTGF5b3V0VXBkYXRlSWRlbnRpZmllcikKICAgICAgICAgICAgIHJldHVybjsKICAg ICAgICAgdGhpcy5fc2NoZWR1bGVkTGF5b3V0VXBkYXRlSWRlbnRpZmllciA9IHJlcXVlc3RBbmlt YXRpb25GcmFtZSh0aGlzLnVwZGF0ZUxheW91dC5iaW5kKHRoaXMpKTsKKyAgICB9LAorCisgICAg X2hhbmRsZVdoZWVsRXZlbnQ6IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsKKyAgICAgICAgLy8gUmVx dWlyZSB0d2ljZSB0aGUgdmVydGljYWwgZGVsdGEgdG8gb3ZlcmNvbWUgaG9yaXpvbnRhbCBzY3Jv bGxpbmcuIFRoaXMgcHJldmVudHMgbW9zdAorICAgICAgICAvLyBjYXNlcyBvZiBpbmFkdmVydGVu dCB6b29taW5nIGZvciBzbGlnaHRseSBkaWFnb25hbCBzY3JvbGxzLgorICAgICAgICBpZiAoTWF0 aC5hYnMoZXZlbnQuZGVsdGFYKSA+PSBNYXRoLmFicyhldmVudC5kZWx0YVkpICogMC41KQorICAg ICAgICAgICAgcmV0dXJuOworCisgICAgICAgIC8vIFJlbWVtYmVyIHRoZSBtb3VzZSBwb3NpdGlv biBpbiB0aW1lLgorICAgICAgICB2YXIgbW91c2VPZmZzZXQgPSBldmVudC5vZmZzZXRYOworICAg ICAgICB2YXIgc2Nyb2xsT2Zmc2V0ID0gdGhpcy5fc2Nyb2xsQ29udGFpbmVyLnNjcm9sbExlZnQ7 CisgICAgICAgIHZhciBtb3VzZVBvc2l0aW9uVGltZSA9IChzY3JvbGxPZmZzZXQgKyBtb3VzZU9m ZnNldCkgKiB0aGlzLnNlY29uZHNQZXJQaXhlbDsKKyAgICAgICAgdmFyIGRldmljZURpcmVjdGlv biA9IGV2ZW50LndlYmtpdERpcmVjdGlvbkludmVydGVkRnJvbURldmljZSA/IC0xIDogMTsKKwor ICAgICAgICB0aGlzLnNlY29uZHNQZXJQaXhlbCArPSBldmVudC5kZWx0YVkgKiBXZWJJbnNwZWN0 b3IuVGltZWxpbmVPdmVydmlldy5TZWNvbmRzUGVyU2Nyb2xsRGVsdGEgKiBkZXZpY2VEaXJlY3Rp b247CisKKyAgICAgICAgLy8gRm9yY2UgbGF5b3V0IHNvIHdlIGNhbiB1cGRhdGUgdGhlIHNjcm9s bCBwb3NpdGlvbiBzeW5jaHJvbm91c2x5LgorICAgICAgICB0aGlzLnVwZGF0ZUxheW91dCgpOwor CisgICAgICAgIC8vIENlbnRlciB0aGUgem9vbSBhcm91bmQgdGhlIG1vdXNlIGJhc2VkIG9uIHRo ZSByZW1lbWJlcmVkIG1vdXNlIHBvc2l0aW9uIHRpbWUuCisgICAgICAgIHRoaXMuX3Njcm9sbENv bnRhaW5lci5zY3JvbGxMZWZ0ID0gTWF0aC5tYXgoMCwgTWF0aC5yb3VuZCgobW91c2VQb3NpdGlv blRpbWUgLyB0aGlzLnNlY29uZHNQZXJQaXhlbCkgLSBtb3VzZU9mZnNldCkpOworCisgICAgICAg IGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CisgICAgICAgIGV2ZW50LnN0b3BQcm9wYWdhdGlvbigp OwogICAgIH0KIH07Cg==