125904 2013-12-17 18:41:39 -0800 Do not create cue subtree just to delete it 2013-12-18 10:29:43 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson commit-queue esprehn+autocc gyuyoung.kim jer.noble oldest_to_newest 960787 0 eric.carlson 2013-12-17 18:41:39 -0800 TextTrackCue creates its display lazily, so it might be NULL when removeDisplayTree or setActive(false) is called. Don't bother creating the display tree if we only want to delete it. 960972 1 219543 eric.carlson 2013-12-18 10:10:51 -0800 Created attachment 219543 Proposed patch 960975 2 219543 jer.noble 2013-12-18 10:12:08 -0800 Comment on attachment 219543 Proposed patch r=me. 960987 3 219543 commit-queue 2013-12-18 10:29:41 -0800 Comment on attachment 219543 Proposed patch Clearing flags on attachment: 219543 Committed r160777: <http://trac.webkit.org/changeset/160777> 960988 4 commit-queue 2013-12-18 10:29:43 -0800 All reviewed patches have been landed. Closing bug. 219543 2013-12-18 10:10:51 -0800 2013-12-18 10:29:41 -0800 Proposed patch patch_2.txt text/plain 1520 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MDc0MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTEyLTE3ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIERvIG5vdCBjcmVhdGUg Y3VlIHN1YnRyZWUganVzdCB0byBkZWxldGUgaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTkwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgY292ZXJlZCBieSBleGlzdGluZyB0 ZXN0cy4KKworICAgICAgICAqIGh0bWwvdHJhY2svVGV4dFRyYWNrQ3VlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlRleHRUcmFja0N1ZTo6c2V0SXNBY3RpdmUpOiBSZXR1cm4gZWFybHkgaWYgZGlz cGxheSB0cmVlIGlzIE5VTEwuCisgICAgICAgIChXZWJDb3JlOjpUZXh0VHJhY2tDdWU6OnJlbW92 ZURpc3BsYXlUcmVlKTogRGl0dG8uCisKIDIwMTMtMTItMTcgIFNpbW9uIEZyYXNlciAgPHNpbW9u LmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lICJjYW5SdWJiZXJCYW5kcyIgdG8g ImNhblJ1YmJlckJhbmQiCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1RleHRUcmFj a0N1ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9UZXh0VHJh Y2tDdWUuY3BwCShyZXZpc2lvbiAxNjA2NDApCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNr L1RleHRUcmFja0N1ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU3MSw2ICs1NzEsOSBAQCB2b2lk IFRleHRUcmFja0N1ZTo6c2V0SXNBY3RpdmUoYm9vbCBhY3RpCiAgICAgbV9pc0FjdGl2ZSA9IGFj dGl2ZTsKIAogICAgIGlmICghYWN0aXZlKSB7CisgICAgICAgIGlmICghaGFzRGlzcGxheVRyZWUo KSkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICAvLyBSZW1vdmUgdGhlIGRpc3BsYXkg dHJlZSBhcyBzb29uIGFzIHRoZSBjdWUgYmVjb21lcyBpbmFjdGl2ZS4KICAgICAgICAgZGlzcGxh eVRyZWVJbnRlcm5hbCgpLT5yZW1vdmUoQVNTRVJUX05PX0VYQ0VQVElPTik7CiAgICAgfQpAQCAt ODQ2LDYgKzg0OSw4IEBAIFRleHRUcmFja0N1ZUJveCogVGV4dFRyYWNrQ3VlOjpnZXREaXNwbGEK IAogdm9pZCBUZXh0VHJhY2tDdWU6OnJlbW92ZURpc3BsYXlUcmVlKCkKIHsKKyAgICBpZiAoIWhh c0Rpc3BsYXlUcmVlKCkpCisgICAgICAgIHJldHVybjsKICAgICBkaXNwbGF5VHJlZUludGVybmFs KCktPnJlbW92ZShBU1NFUlRfTk9fRVhDRVBUSU9OKTsKIH0KIAo=