125902 2013-12-17 18:31:40 -0800 Web Inspector: Some basic InjectedScriptHost cleanup 2013-12-17 22:20:57 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy oldest_to_newest 960782 0 joepeck 2013-12-17 18:31:40 -0800 Nobody accesses ScriptDebugServer through InjectedScriptManager. Remove the accessor and the reason for holding onto DebuggerAgent. 960793 1 219490 joepeck 2013-12-17 18:51:45 -0800 Created attachment 219490 [PATCH] Proposed Fix 960845 2 219490 commit-queue 2013-12-17 22:20:55 -0800 Comment on attachment 219490 [PATCH] Proposed Fix Clearing flags on attachment: 219490 Committed r160752: <http://trac.webkit.org/changeset/160752> 960846 3 commit-queue 2013-12-17 22:20:57 -0800 All reviewed patches have been landed. Closing bug. 219490 2013-12-17 18:51:45 -0800 2013-12-17 22:20:55 -0800 [PATCH] Proposed Fix cleanup2.patch text/plain 5146 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMDQ0YjczLi44NjBmZTg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQg QEAKIDIwMTMtMTItMTcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBTb21lIGJhc2ljIEluamVjdGVkU2NyaXB0SG9zdCBjbGVh bnVwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU5 MDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1v dmUgSW5qZWN0ZWRTY3JpcHRIb3N0OjpzY3JpcHREZWJ1Z1NlcnZlci4gTm9ib2R5IGFjY2Vzc2Vz CisgICAgICAgIHRoZSBTY3JpcHREZWJ1Z1NlcnZlciB0aHJvdWdoIHRoZSBpbmplY3RlZCBzY3Jp cHQgaG9zdC4gVGhpcworICAgICAgICBhbHNvIGxldHMgdXMgcmVtb3ZlIHRoZSByZWZlcmVuY2Ug dG8gdGhlIERlYnVnZ2VyQWdlbnQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5qZWN0ZWRTY3Jp cHRIb3N0LmNwcDoKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRIb3N0Lmg6Cisg ICAgICAgIChXZWJDb3JlOjpJbmplY3RlZFNjcmlwdEhvc3Q6OmluaXQpOgorICAgICAgICAqIGlu c3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3Bl Y3RvckNvbnRyb2xsZXI6Okluc3BlY3RvckNvbnRyb2xsZXIpOgorICAgICAgICAqIGluc3BlY3Rv ci9Xb3JrZXJJbnNwZWN0b3JDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Oldvcmtl ckluc3BlY3RvckNvbnRyb2xsZXI6Oldvcmtlckluc3BlY3RvckNvbnRyb2xsZXIpOgorCisyMDEz LTEyLTE3ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAg V2ViIEluc3BlY3RvcjogU29tZSBiYXNpYyBEZWJ1Z2dlckFnZW50IGNsZWFudXAKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTkwMQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRIb3N0LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdEhvc3QuY3BwCmluZGV4IGFkYzQy NDUuLjA3Yzc2ZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3Rl ZFNjcmlwdEhvc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNj cmlwdEhvc3QuY3BwCkBAIC00NSw3ICs0NSw2IEBACiAjaW5jbHVkZSAiSW5zcGVjdG9yRE9NQWdl bnQuaCIKICNpbmNsdWRlICJJbnNwZWN0b3JET01TdG9yYWdlQWdlbnQuaCIKICNpbmNsdWRlICJJ bnNwZWN0b3JEYXRhYmFzZUFnZW50LmgiCi0jaW5jbHVkZSAiSW5zcGVjdG9yRGVidWdnZXJBZ2Vu dC5oIgogI2luY2x1ZGUgIkluc3BlY3RvcldlYkZyb250ZW5kRGlzcGF0Y2hlcnMuaCIKICNpbmNs dWRlICJQYXN0ZWJvYXJkLmgiCiAjaW5jbHVkZSAiU3RvcmFnZS5oIgpAQCAtMTYyLDEzICsxNjEs NiBAQCBTdHJpbmcgSW5qZWN0ZWRTY3JpcHRIb3N0OjpzdG9yYWdlSWRJbXBsKFN0b3JhZ2UqIHN0 b3JhZ2UpCiAgICAgcmV0dXJuIFN0cmluZygpOwogfQogCi0jaWYgRU5BQkxFKEpBVkFTQ1JJUFRf REVCVUdHRVIpCi1TY3JpcHREZWJ1Z1NlcnZlciYgSW5qZWN0ZWRTY3JpcHRIb3N0OjpzY3JpcHRE ZWJ1Z1NlcnZlcigpCi17Ci0gICAgcmV0dXJuIG1fZGVidWdnZXJBZ2VudC0+c2NyaXB0RGVidWdT ZXJ2ZXIoKTsKLX0KLSNlbmRpZgotCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAv LyBFTkFCTEUoSU5TUEVDVE9SKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luamVjdGVkU2NyaXB0SG9zdC5oIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luamVjdGVk U2NyaXB0SG9zdC5oCmluZGV4IDhjNDRkNzcuLjExOWE0NTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdEhvc3QuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRIb3N0LmgKQEAgLTU0LDkgKzU0LDcgQEAgY2xhc3Mg SW5zcGVjdG9yQ29uc29sZUFnZW50OwogY2xhc3MgSW5zcGVjdG9yRE9NQWdlbnQ7CiBjbGFzcyBJ bnNwZWN0b3JET01TdG9yYWdlQWdlbnQ7CiBjbGFzcyBJbnNwZWN0b3JEYXRhYmFzZUFnZW50Owot Y2xhc3MgSW5zcGVjdG9yRGVidWdnZXJBZ2VudDsKIGNsYXNzIE5vZGU7Ci1jbGFzcyBTY3JpcHRE ZWJ1Z1NlcnZlcjsKIGNsYXNzIFN0b3JhZ2U7CiAKIHN0cnVjdCBFdmVudExpc3RlbmVySW5mbzsK QEAgLTczLDkgKzcxLDYgQEAgcHVibGljOgogI2VuZGlmCiAgICAgICAgICAgICAsIEluc3BlY3Rv ckRPTVN0b3JhZ2VBZ2VudCogZG9tU3RvcmFnZUFnZW50CiAgICAgICAgICAgICAsIEluc3BlY3Rv ckRPTUFnZW50KiBkb21BZ2VudAotI2lmIEVOQUJMRShKQVZBU0NSSVBUX0RFQlVHR0VSKQotICAg ICAgICAgICAgLCBJbnNwZWN0b3JEZWJ1Z2dlckFnZW50KiBkZWJ1Z2dlckFnZW50Ci0jZW5kaWYK ICAgICAgICAgKQogICAgIHsKICAgICAgICAgbV9pbnNwZWN0b3JBZ2VudCA9IGluc3BlY3RvckFn ZW50OwpAQCAtODUsOSArODAsNiBAQCBwdWJsaWM6CiAjZW5kaWYKICAgICAgICAgbV9kb21TdG9y YWdlQWdlbnQgPSBkb21TdG9yYWdlQWdlbnQ7CiAgICAgICAgIG1fZG9tQWdlbnQgPSBkb21BZ2Vu dDsKLSNpZiBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikKLSAgICAgICAgbV9kZWJ1Z2dlckFn ZW50ID0gZGVidWdnZXJBZ2VudDsKLSNlbmRpZgogICAgIH0KIAogICAgIHN0YXRpYyBOb2RlKiBz Y3JpcHRWYWx1ZUFzTm9kZShEZXByZWNhdGVkOjpTY3JpcHRWYWx1ZSk7CkBAIC0xMTUsMTAgKzEw Nyw2IEBAIHB1YmxpYzoKICNlbmRpZgogICAgIFN0cmluZyBzdG9yYWdlSWRJbXBsKFN0b3JhZ2Uq KTsKIAotI2lmIEVOQUJMRShKQVZBU0NSSVBUX0RFQlVHR0VSKQotICAgIFNjcmlwdERlYnVnU2Vy dmVyJiBzY3JpcHREZWJ1Z1NlcnZlcigpOwotI2VuZGlmCi0KIHByaXZhdGU6CiAgICAgSW5qZWN0 ZWRTY3JpcHRIb3N0KCk7CiAKQEAgLTEyOSw5ICsxMTcsNiBAQCBwcml2YXRlOgogI2VuZGlmCiAg ICAgSW5zcGVjdG9yRE9NU3RvcmFnZUFnZW50KiBtX2RvbVN0b3JhZ2VBZ2VudDsKICAgICBJbnNw ZWN0b3JET01BZ2VudCogbV9kb21BZ2VudDsKLSNpZiBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dF UikKLSAgICBJbnNwZWN0b3JEZWJ1Z2dlckFnZW50KiBtX2RlYnVnZ2VyQWdlbnQ7Ci0jZW5kaWYK ICAgICBWZWN0b3I8T3duUHRyPEluc3BlY3RhYmxlT2JqZWN0Pj4gbV9pbnNwZWN0ZWRPYmplY3Rz OwogICAgIE93blB0cjxJbnNwZWN0YWJsZU9iamVjdD4gbV9kZWZhdWx0SW5zcGVjdGFibGVPYmpl Y3Q7CiB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNv bnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xs ZXIuY3BwCmluZGV4IGQwYjU1YzguLjRlYWIyY2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKQEAgLTE3Miw3ICsxNzIsNiBAQCBJbnNw ZWN0b3JDb250cm9sbGVyOjpJbnNwZWN0b3JDb250cm9sbGVyKFBhZ2UqIHBhZ2UsIEluc3BlY3Rv ckNsaWVudCogaW5zcGVjdG9yQwogI2VuZGlmCiAgICAgICAgICwgZG9tU3RvcmFnZUFnZW50CiAg ICAgICAgICwgbV9kb21BZ2VudAotICAgICAgICAsIG1fZGVidWdnZXJBZ2VudAogICAgICk7CiAK ICNpZiBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9Xb3JrZXJJbnNwZWN0b3JDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9Xb3JrZXJJbnNwZWN0b3JDb250cm9sbGVyLmNwcAppbmRleCA1NWE0MjQ1 Li5kZmZmM2Y4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvV29ya2VySW5z cGVjdG9yQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL1dvcmtl ckluc3BlY3RvckNvbnRyb2xsZXIuY3BwCkBAIC04OSw3ICs4OSw2IEBAIFdvcmtlckluc3BlY3Rv ckNvbnRyb2xsZXI6Oldvcmtlckluc3BlY3RvckNvbnRyb2xsZXIoV29ya2VyR2xvYmFsU2NvcGUq IHdvcmtlckdsCiAgICAgT3duUHRyPEluc3BlY3RvckNvbnNvbGVBZ2VudD4gY29uc29sZUFnZW50 ID0gV29ya2VyQ29uc29sZUFnZW50OjpjcmVhdGUobV9pbnN0cnVtZW50aW5nQWdlbnRzLmdldCgp LCBtX2luamVjdGVkU2NyaXB0TWFuYWdlci5nZXQoKSk7CiAjaWYgRU5BQkxFKEpBVkFTQ1JJUFRf REVCVUdHRVIpCiAgICAgT3duUHRyPEluc3BlY3RvckRlYnVnZ2VyQWdlbnQ+IGRlYnVnZ2VyQWdl bnQgPSBXb3JrZXJEZWJ1Z2dlckFnZW50OjpjcmVhdGUobV9pbnN0cnVtZW50aW5nQWdlbnRzLmdl dCgpLCB3b3JrZXJHbG9iYWxTY29wZSwgbV9pbmplY3RlZFNjcmlwdE1hbmFnZXIuZ2V0KCkpOwot ICAgIEluc3BlY3RvckRlYnVnZ2VyQWdlbnQqIGRlYnVnZ2VyQWdlbnRQdHIgPSBkZWJ1Z2dlckFn ZW50LmdldCgpOwogICAgIG1fcnVudGltZUFnZW50LT5zZXRTY3JpcHREZWJ1Z1NlcnZlcigmZGVi dWdnZXJBZ2VudC0+c2NyaXB0RGVidWdTZXJ2ZXIoKSk7CiAgICAgbV9hZ2VudHMuYXBwZW5kKGRl YnVnZ2VyQWdlbnQucmVsZWFzZSgpKTsKIApAQCAtMTA2LDkgKzEwNSw2IEBAIFdvcmtlckluc3Bl Y3RvckNvbnRyb2xsZXI6Oldvcmtlckluc3BlY3RvckNvbnRyb2xsZXIoV29ya2VyR2xvYmFsU2Nv cGUqIHdvcmtlckdsCiAjZW5kaWYKICAgICAgICAgLCAwCiAgICAgICAgICwgMAotI2lmIEVOQUJM RShKQVZBU0NSSVBUX0RFQlVHR0VSKQotICAgICAgICAsIGRlYnVnZ2VyQWdlbnRQdHIKLSNlbmRp ZgogICAgICk7CiB9CiAgCg==