125901 2013-12-17 18:28:08 -0800 Web Inspector: Some basic DebuggerAgent cleanup 2013-12-18 11:22:59 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue eflews.bot graouts gyuyoung.kim joepeck timothy oldest_to_newest 960779 0 joepeck 2013-12-17 18:28:08 -0800 Some cleanup of DebuggerAgent. • Inline a function only called in one place. • Remove unnecessary virtual. • Remove private enabled() function and just use member variable. 960780 1 219484 joepeck 2013-12-17 18:30:34 -0800 Created attachment 219484 [PATCH] Proposed Fix 960800 2 219484 eflews.bot 2013-12-17 19:15:56 -0800 Comment on attachment 219484 [PATCH] Proposed Fix Attachment 219484 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/47478062 961004 3 219484 joepeck 2013-12-18 10:54:08 -0800 Comment on attachment 219484 [PATCH] Proposed Fix efl-wk2 bot looks like it was cancelled. I'm going to cq+. 961018 4 219484 commit-queue 2013-12-18 11:22:57 -0800 Comment on attachment 219484 [PATCH] Proposed Fix Clearing flags on attachment: 219484 Committed r160780: <http://trac.webkit.org/changeset/160780> 961019 5 commit-queue 2013-12-18 11:22:59 -0800 All reviewed patches have been landed. Closing bug. 219484 2013-12-17 18:30:34 -0800 2013-12-18 11:22:57 -0800 [PATCH] Proposed Fix clean.patch text/plain 3815 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3YTlmMzEzLi5hMDQ0YjczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTMtMTItMTcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBTb21lIGJhc2ljIERlYnVnZ2VyQWdlbnQgY2xlYW51cAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1OTAxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0 b3IvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5oOgorICAgICAgICBSZW1vdmUgdmlydHVhbCBmcm9t IG5vdCByZWFsbHkgdmlydHVhbCBtZXRob2QuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVj dG9yRGVidWdnZXJBZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JEZWJ1Z2dl ckFnZW50OjplbmFibGUpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRGVidWdnZXJBZ2Vu dDo6ZGlzYWJsZSk6CisgICAgICAgIFVzZSBtZW1iZXIgdmFyaWFibGUgaW5zdGVhZCBvZiBwcml2 YXRlIGZ1bmN0aW9uLgorCisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JEZWJ1Z2dlckFnZW50 OjpzZXRQYXVzZU9uRXhjZXB0aW9ucyk6CisgICAgICAgIElubGluZSB0aGUgdGhyZWUgbGluZXMg ZnJvbSB0aGUgcHJpdmF0ZSBmdW5jdGlvbi4KKwogMjAxMy0xMi0xNyAgU2ltb24gRnJhc2VyICA8 c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgImNhblJ1YmJlckJhbmRz IiB0byAiY2FuUnViYmVyQmFuZCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcAppbmRleCBkMTcyZDNjLi5mMmUzNGY4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuY3Bw CkBAIC0xMjIsNyArMTIyLDcgQEAgdm9pZCBJbnNwZWN0b3JEZWJ1Z2dlckFnZW50OjpzdXBwb3J0 c1NlcGFyYXRlU2NyaXB0Q29tcGlsYXRpb25BbmRFeGVjdXRpb24oRXJyb3IKIAogdm9pZCBJbnNw ZWN0b3JEZWJ1Z2dlckFnZW50OjplbmFibGUoRXJyb3JTdHJpbmcqKQogewotICAgIGlmIChlbmFi bGVkKCkpCisgICAgaWYgKG1fZW5hYmxlZCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgZW5hYmxl KCk7CkBAIC0xMzIsNyArMTMyLDcgQEAgdm9pZCBJbnNwZWN0b3JEZWJ1Z2dlckFnZW50OjplbmFi bGUoRXJyb3JTdHJpbmcqKQogCiB2b2lkIEluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OmRpc2FibGUo RXJyb3JTdHJpbmcqKQogewotICAgIGlmICghZW5hYmxlZCgpKQorICAgIGlmICghbV9lbmFibGVk KQogICAgICAgICByZXR1cm47CiAKICAgICBkaXNhYmxlKCk7CkBAIC01MzksMTEgKzUzOSw3IEBA IHZvaWQgSW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6c2V0UGF1c2VPbkV4Y2VwdGlvbnMoRXJyb3JT dHJpbmcqIGVycm9yU3RyaW5nLCBjb25zCiAgICAgICAgICplcnJvclN0cmluZyA9ICJVbmtub3du IHBhdXNlIG9uIGV4Y2VwdGlvbnMgbW9kZTogIiArIHN0cmluZ1BhdXNlU3RhdGU7CiAgICAgICAg IHJldHVybjsKICAgICB9Ci0gICAgc2V0UGF1c2VPbkV4Y2VwdGlvbnNJbXBsKGVycm9yU3RyaW5n LCBwYXVzZVN0YXRlKTsKLX0KIAotdm9pZCBJbnNwZWN0b3JEZWJ1Z2dlckFnZW50OjpzZXRQYXVz ZU9uRXhjZXB0aW9uc0ltcGwoRXJyb3JTdHJpbmcqIGVycm9yU3RyaW5nLCBpbnQgcGF1c2VTdGF0 ZSkKLXsKICAgICBzY3JpcHREZWJ1Z1NlcnZlcigpLnNldFBhdXNlT25FeGNlcHRpb25zU3RhdGUo c3RhdGljX2Nhc3Q8U2NyaXB0RGVidWdTZXJ2ZXI6OlBhdXNlT25FeGNlcHRpb25zU3RhdGU+KHBh dXNlU3RhdGUpKTsKICAgICBpZiAoc2NyaXB0RGVidWdTZXJ2ZXIoKS5wYXVzZU9uRXhjZXB0aW9u c1N0YXRlKCkgIT0gcGF1c2VTdGF0ZSkKICAgICAgICAgKmVycm9yU3RyaW5nID0gIkludGVybmFs IGVycm9yLiBDb3VsZCBub3QgY2hhbmdlIHBhdXNlIG9uIGV4Y2VwdGlvbnMgc3RhdGUiOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQu aCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmgKaW5k ZXggY2JiZmQxNS4uMjdjMTI2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yRGVidWdnZXJBZ2VudC5oCkBAIC0xMjEsNyArMTIxLDcgQEAgcHVibGljOgogICAg IHZvaWQgc2NoZWR1bGVQYXVzZU9uTmV4dFN0YXRlbWVudChJbnNwZWN0b3I6Okluc3BlY3RvckRl YnVnZ2VyRnJvbnRlbmREaXNwYXRjaGVyOjpSZWFzb246OkVudW0gYnJlYWtSZWFzb24sIFBhc3NS ZWZQdHI8SW5zcGVjdG9yOjpJbnNwZWN0b3JPYmplY3Q+IGRhdGEpOwogICAgIHZvaWQgY2FuY2Vs UGF1c2VPbk5leHRTdGF0ZW1lbnQoKTsKICAgICB2b2lkIGJyZWFrUHJvZ3JhbShJbnNwZWN0b3I6 Okluc3BlY3RvckRlYnVnZ2VyRnJvbnRlbmREaXNwYXRjaGVyOjpSZWFzb246OkVudW0gYnJlYWtS ZWFzb24sIFBhc3NSZWZQdHI8SW5zcGVjdG9yOjpJbnNwZWN0b3JPYmplY3Q+IGRhdGEpOwotICAg IHZpcnR1YWwgdm9pZCBzY3JpcHRFeGVjdXRpb25CbG9ja2VkQnlDU1AoY29uc3QgU3RyaW5nJiBk aXJlY3RpdmVUZXh0KTsKKyAgICB2b2lkIHNjcmlwdEV4ZWN1dGlvbkJsb2NrZWRCeUNTUChjb25z dCBTdHJpbmcmIGRpcmVjdGl2ZVRleHQpOwogCiAgICAgY2xhc3MgTGlzdGVuZXIgewogICAgIHB1 YmxpYzoKQEAgLTE1MiwxNSArMTUyLDExIEBAIHByb3RlY3RlZDoKICAgICB2b2lkIHJlc2V0KCk7 CiAKIHByaXZhdGU6Ci0gICAgYm9vbCBlbmFibGVkKCkgY29uc3QgeyByZXR1cm4gbV9lbmFibGVk OyB9OwotCiAgICAgUGFzc1JlZlB0cjxJbnNwZWN0b3I6OlR5cGVCdWlsZGVyOjpBcnJheTxJbnNw ZWN0b3I6OlR5cGVCdWlsZGVyOjpEZWJ1Z2dlcjo6Q2FsbEZyYW1lPj4gY3VycmVudENhbGxGcmFt ZXMoKTsKIAogICAgIHZpcnR1YWwgdm9pZCBkaWRQYXJzZVNvdXJjZShKU0M6OlNvdXJjZUlELCBj b25zdCBTY3JpcHQmKSBPVkVSUklERSBGSU5BTDsKICAgICB2aXJ0dWFsIHZvaWQgZmFpbGVkVG9Q YXJzZVNvdXJjZShjb25zdCBTdHJpbmcmIHVybCwgY29uc3QgU3RyaW5nJiBkYXRhLCBpbnQgZmly c3RMaW5lLCBpbnQgZXJyb3JMaW5lLCBjb25zdCBTdHJpbmcmIGVycm9yTWVzc2FnZSkgT1ZFUlJJ REUgRklOQUw7CiAKLSAgICB2b2lkIHNldFBhdXNlT25FeGNlcHRpb25zSW1wbChFcnJvclN0cmlu ZyosIGludCk7Ci0KICAgICBQYXNzUmVmUHRyPEluc3BlY3Rvcjo6VHlwZUJ1aWxkZXI6OkRlYnVn Z2VyOjpMb2NhdGlvbj4gcmVzb2x2ZUJyZWFrcG9pbnQoY29uc3QgU3RyaW5nJiBicmVha3BvaW50 SWRlbnRpZmllciwgSlNDOjpTb3VyY2VJRCwgY29uc3QgU2NyaXB0QnJlYWtwb2ludCYpOwogICAg IHZvaWQgY2xlYXIoKTsKICAgICBib29sIGFzc2VydFBhdXNlZChFcnJvclN0cmluZyopOwo=