125867 2013-12-17 12:35:31 -0800 GRAPHICS_SURFACE needed for EGLOffScreenSurface 2013-12-17 13:15:24 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alex.christensen webkit-unassigned allan.jensen benjamin cmarcelo commit-queue dino kondapallykalyan mrobinson noam roger_fong oldest_to_newest 960633 0 alex.christensen 2013-12-17 12:35:31 -0800 WebGL doesn't work on Windows with accelerated compositing. GRAPHICS_SURFACE is not necessary except for this compile error, and I'm pretty sure I shouldn't be using it at all. I'm not sure why, and this does not make it draw to the screen, but this fixes a compile error. The notImplemented in createOffScreenSurface is not hit. Also, ENABLE_GLIB_SUPPORT was removed in https://bugs.webkit.org/show_bug.cgi?id=104266 so as long as we're touching WTF, let's clean that up. 960635 1 219442 alex.christensen 2013-12-17 12:39:00 -0800 Created attachment 219442 Patch 960647 2 219442 commit-queue 2013-12-17 13:15:22 -0800 Comment on attachment 219442 Patch Clearing flags on attachment: 219442 Committed r160725: <http://trac.webkit.org/changeset/160725> 960648 3 commit-queue 2013-12-17 13:15:24 -0800 All reviewed patches have been landed. Closing bug. 219442 2013-12-17 12:39:00 -0800 2013-12-17 13:15:21 -0800 Patch bug-125867-20131217133859.patch text/plain 3032 alex.christensen SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNjA3MjMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEyLTE3ICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ29tcGlsZSBmaXggZm9yIFdlYkdM IG9uIFdpbmRvd3Mgd2l0aG91dCBHUkFQSElDU19TVVJGQUNFLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1ODY3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvRmVhdHVyZURlZmluZXMuaDoKKyAg ICAgICAgUmVtb3ZlZCB1bnVzZWQgRU5BQkxFX0dMSUJfU1VQUE9SVCBtYWNyby4KKyAgICAgICAg KiB3dGYvUGxhdGZvcm0uaDoKKyAgICAgICAgRG9uJ3QgdXNlIEdSQVBISUNTX1NVUkZBQ0UgZm9y IFdlYkdMIG9uIFdpbmRvd3MuCisKIDIwMTMtMTItMTcgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hy aXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbV2luXSBGaXhlZCBsaW5rZXIgZXJyb3Ig d2l0aCBHU3RyZWFtZXIuCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9GZWF0dXJlRGVmaW5lcy5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmgJKHJldmlzaW9uIDE2 MDcxMikKKysrIFNvdXJjZS9XVEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmgJKHdvcmtpbmcgY29weSkK QEAgLTUwNiwxMCArNTA2LDYgQEAKICNkZWZpbmUgRU5BQkxFX0dFT0xPQ0FUSU9OIDAKICNlbmRp ZgogCi0jaWYgIWRlZmluZWQoRU5BQkxFX0dMSUJfU1VQUE9SVCkKLSNkZWZpbmUgRU5BQkxFX0dM SUJfU1VQUE9SVCAwCi0jZW5kaWYKLQogI2lmICFkZWZpbmVkKEVOQUJMRV9ISURERU5fUEFHRV9E T01fVElNRVJfVEhST1RUTElORykKICNkZWZpbmUgRU5BQkxFX0hJRERFTl9QQUdFX0RPTV9USU1F Ul9USFJPVFRMSU5HIDAKICNlbmRpZgpJbmRleDogU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiAxNjA3MTIp CisrKyBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC04OTcsNyAr ODk3LDYgQEAKICNkZWZpbmUgV1RGX1VTRV9PUEVOR0wgMQogI2RlZmluZSBXVEZfVVNFX09QRU5H TF9FU18yIDEKICNkZWZpbmUgV1RGX1VTRV9FR0wgMQotI2RlZmluZSBXVEZfVVNFX0dSQVBISUNT X1NVUkZBQ0UgMQogI2VuZGlmCiAKICNpZiBVU0UoVEVYVFVSRV9NQVBQRVIpICYmIFVTRSgzRF9H UkFQSElDUykgJiYgIWRlZmluZWQoV1RGX1VTRV9URVhUVVJFX01BUFBFUl9HTCkKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cJKHJldmlzaW9uIDE2MDcyMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEyLTE3ICBBbGV4IENocmlzdGVuc2Vu ICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ29tcGlsZSBmaXggZm9yIFdl YkdMIG9uIFdpbmRvd3Mgd2l0aG91dCBHUkFQSElDU19TVVJGQUNFLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1ODY3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9vcGVu Z2wvR0xQbGF0Zm9ybVN1cmZhY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R0xQbGF0Zm9ybVN1 cmZhY2U6OmNyZWF0ZU9mZlNjcmVlblN1cmZhY2UpOgorICAgICAgICBQcm90ZWN0IHJlZmVyZW5j ZSB0byBFR0xPZmZTY3JlZW5TdXJmYWNlIHdpdGggVVNFKEdSQVBISUNTX1NVUkZBQ0UpLgorCiAy MDEzLTEyLTE3ICBSYWR1IFN0YXZpbGEgIDxzdGF2aWxhQGFkb2JlLmNvbT4KIAogICAgICAgICBb Q1NTIFJlZ2lvbnNdIFBvc2l0aW9uZWQgZWxlbWVudHMgaW4gcmVnaW9ucyBnZXQgY2xpcHBlZCBp ZiB0aGV5IGZhbGwgb3V0c2lkZSB0aGUgcmVnaW9uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR0xQbGF0Zm9ybVN1cmZhY2UuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HTFBsYXRmb3JtU3VyZmFj ZS5jcHAJKHJldmlzaW9uIDE2MDcxMikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL29wZW5nbC9HTFBsYXRmb3JtU3VyZmFjZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ3LDcg KzQ3LDcgQEAgUGFzc093blB0cjxHTFBsYXRmb3JtU3VyZmFjZT4gR0xQbGF0Zm9ybQogICAgIE93 blB0cjxHTFBsYXRmb3JtU3VyZmFjZT4gc3VyZmFjZTsKICNpZiBVU0UoR0xYKQogICAgIHN1cmZh Y2UgPSBhZG9wdFB0cihuZXcgR0xYT2ZmU2NyZWVuU3VyZmFjZShhdHRyaWJ1dGVzKSk7Ci0jZWxp ZiBVU0UoRUdMKQorI2VsaWYgVVNFKEVHTCkgJiYgVVNFKEdSQVBISUNTX1NVUkZBQ0UpCiAgICAg c3VyZmFjZSA9IEVHTE9mZlNjcmVlblN1cmZhY2U6OmNyZWF0ZU9mZlNjcmVlblN1cmZhY2UoYXR0 cmlidXRlcyk7CiAjZWxzZQogICAgIC8vIEZJWE1FOiBOZWVkIFdHTCBpbXBsZW1lbnRhdGlvbiBm b3IgV2luZG93cwo=