125866 2013-12-17 12:22:43 -0800 Revise filter-build-webkit to deal with Windows logs 2013-12-17 13:17:30 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Unspecified RESOLVED FIXED P2 Enhancement --- 1 bfulgham bfulgham bfulgham ddkilzer lforschler mrowe oldest_to_newest 960629 0 bfulgham 2013-12-17 12:22:43 -0800 Revise the "filter-build-webkit" script to do a better job of stripping uninteresting cruft from our build logs. 960630 1 219440 bfulgham 2013-12-17 12:25:22 -0800 Created attachment 219440 Patch 960631 2 lforschler 2013-12-17 12:29:59 -0800 In addition to this patch, I believe we will need to update the buildbot master config to pass in the platform parameter for windows. 960637 3 219440 ddkilzer 2013-12-17 12:59:40 -0800 Comment on attachment 219440 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219440&action=review r=me > Tools/Scripts/filter-build-webkit:92 > +..-p|--platform Logfile type (default: mac) What are the periods for? Would be nice if you used $platform here in case the default ever changes. :) -p|--platform Logfile type (default: $platform) 960649 4 219440 bfulgham 2013-12-17 13:16:09 -0800 Comment on attachment 219440 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219440&action=review >> Tools/Scripts/filter-build-webkit:92 >> +..-p|--platform Logfile type (default: mac) > > What are the periods for? > > Would be nice if you used $platform here in case the default ever changes. :) > > -p|--platform Logfile type (default: $platform) Periods should NOT be there. I'll fix. I'll also change to $platform - great idea! 960651 5 bfulgham 2013-12-17 13:17:30 -0800 Committed r160726: <http://trac.webkit.org/changeset/160726> 219440 2013-12-17 12:25:22 -0800 2013-12-17 13:16:09 -0800 Patch bug-125866-20131217122521.patch text/plain 5896 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MDcyMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDEzLTEyLTE3ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFtXaW5dIFJldmlzZSBmaWx0ZXItYnVpbGQtd2Via2l0IHRvIGRlYWwgd2l0 aCBXaW5kb3dzIGJ1aWxkIGxvZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyNTg2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEVuaGFuY2UgdGhlIHNjcmlwdCB0byBhY2NlcHQgYSAncGxhdGZvcm0nIGFy Z3VtZW50LiBXaGVuIHBsYXRmb3JtCisgICAgICAgICd3aW4nIGlzIHByb3ZpZGVkLCB1c2UgcHJv Y2Vzc2luZyBmb3IgdGhlIFdpbmRvd3MgYnVpbGQgZmlsZSBmb3JtYXQuCisgICAgICAgIE90aGVy d2lzZSwgcHJvY2VzcyB0aGUgZmlsZXMgYXMgbm9ybWFsLgorCisgICAgICAgICogU2NyaXB0cy9m aWx0ZXItYnVpbGQtd2Via2l0OgorICAgICAgICAodXNhZ2VBbmRFeGl0KTogQWRkIGEgJ3BsYXRm b3JtJyBhcmd1bWVudAorICAgICAgICAoc2hvdWxkSWdub3JlTGluZSk6IFdoZW4gcGxhdGZvcm0g PT0gJ3dpbicgdXNlIHRoZSBuZXcgV2luZG93cworICAgICAgICBydWxlcyBmb3IgcHJvY2Vzc2lu ZyB0aGUgYnVpbGQgZmlsZS4KKwogMjAxMy0xMi0xNyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFw QGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgc3R5bGUgY2hlY2tlciBub3cgdGhhdCBFTlVN X0NMQVNTIGlzIGdvbmUKSW5kZXg6IFRvb2xzL1NjcmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2ZpbHRlci1idWlsZC13ZWJraXQJKHJldmlzaW9u IDE2MDcxOCkKKysrIFRvb2xzL1NjcmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdAkod29ya2luZyBj b3B5KQpAQCAtNzQsNiArNzQsNyBAQCBzdWIgcG9zc2libHlDb2xvcmVkKCQkKTsKIAogIyBHbG9i YWwgdmFyaWFibGVzIHVzZWQgb25seSBpbiBnbG9iYWwgc2NvcGUuCiBteSAkb3V0cHV0UGF0aCA9 ICImU1RET1VUIjsKK215ICRwbGF0Zm9ybSA9ICJtYWMiOwogbXkgJHNob3dIZWxwOwogCiAjIEds b2JhbCB2YXJpYWJsZXMgdXNlZCBpbiBnbG9iYWwgYW5kIHN1YnJvdXRpbmUgc2NvcGUuCkBAIC04 OCw2ICs4OSw3IEBAIHN1YiB1c2FnZUFuZEV4aXQoKQogVXNhZ2U6IEB7WyBiYXNlbmFtZSgkMCkg XX0gW29wdGlvbnNdIGJ1aWxkbG9nMSBbYnVpbGRsb2cyIC4uLl0KICAgICAgICBidWlsZC13ZWJr aXQgfCBAe1sgYmFzZW5hbWUoJDApIF19IFtvcHRpb25zXQogICAtaHwtLWhlbHAgICAgIFNob3cg dGhpcyBoZWxwIG1lc3NhZ2UKKy4uLXB8LS1wbGF0Zm9ybSBMb2dmaWxlIHR5cGUgKGRlZmF1bHQ6 IG1hYykKIE91dHB1dCBPcHRpb25zOgogICAtb3wtLW91dHB1dCAgIFBhdGggZm9yIG91dHB1dCAo ZGVmYXVsdDogU1RET1VUKQogICAtZnwtLWZvcm1hdCAgIE91dHB1dCBmb3JtYXQgKGRlZmF1bHQ6 ICRvdXRwdXRGb3JtYXQpCkBAIC0xMDQsNiArMTA2LDcgQEAgX19FTkRfXwogbXkgJGdldE9wdGlv bnNSZXN1bHQgPSBHZXRPcHRpb25zKAogICAgICdofGhlbHAnICAgICAgICAgICAgICAgID0+IFwk c2hvd0hlbHAsCiAgICAgJ298b3V0cHV0PXMnICAgICAgICAgICAgPT4gXCRvdXRwdXRQYXRoLAor ICAgICdwfHBsYXRmb3JtPXMnICAgICAgICAgID0+IFwkcGxhdGZvcm0sCiAgICAgJ2Z8Zm9ybWF0 PXMnICAgICAgICAgICAgPT4gXCZzZXRPdXRwdXRGb3JtYXRPcHRpb24sCiAgICAgJ2NvbG9yIScg ICAgICAgICAgICAgICAgPT4gXCR1c2VDb2xvciwKICAgICAnbHxsb2cnICAgICAgICAgICAgICAg ICA9PiBcJGxvZ1VuZmlsdGVyZWRPdXRwdXQsCkBAIC0xMzksNyArMTQyLDcgQEAgZm9yIChteSAk cHJldmlvdXNMaW5lID0gIiIsIG15ICRsaW5lID0gPAogICAgICAgICBwcmludExpbmUoJGxpbmUs IFNUWUxFX1BMQUlOKTsKICAgICB9IGVsc2lmICgkbGluZSA9fiAvXCpcKiBCVUlMRCBTVUNDRUVE RUQgXCpcKi8pIHsKICAgICAgICAgcHJpbnRMaW5lKCJCdWlsZCBTdWNjZWVkZWQiLCBTVFlMRV9T VUNDRVNTKTsKLSAgICB9IGVsc2lmICgkbGluZSA9fiAvXihQaGFzZVNjcmlwdEV4ZWN1dGlvbnxD b21waWxlQ3xEaXN0cmlidXRlZC1Db21waWxlQ3xMZHxQQlhDcHxDcFJlc291cmNlfENvcHlQTkdG aWxlfENvcHlUaWZmRmlsZXxDcEhlYWRlcnxQcm9jZXNzaW5nfFByb2Nlc3NJbmZvUGxpc3RGaWxl fFByb2Nlc3NQQ0h8UHJvY2Vzc1BDSFwrXCt8VG91Y2h8TGlidG9vbHxDb3B5U3RyaW5nc0ZpbGV8 TWlnfENyZWF0ZVVuaXZlcnNhbEJpbmFyeXxBbmFseXplfFByb2Nlc3NQcm9kdWN0UGFja2FnaW5n fENvZGVTaWdufFN5bUxpbmt8VXBkYXRpbmd8Q29tcGlsZVhJQnxTdHJpcE5JQnxDb3B5UGxpc3RG aWxlfEdlbmVyYXRlRFNZTUZpbGUpICgiW14iXSsifFxTKyk/LykgeworICAgIH0gZWxzaWYgKCRs aW5lID1+IC9eKFBoYXNlU2NyaXB0RXhlY3V0aW9ufENsQ29tcGlsZXxDb21waWxlQ3xEaXN0cmli dXRlZC1Db21waWxlQ3xMZHxQQlhDcHxDcFJlc291cmNlfENvcHlQTkdGaWxlfENvcHlUaWZmRmls ZXxDcEhlYWRlcnxQcm9jZXNzaW5nfFByb2Nlc3NJbmZvUGxpc3RGaWxlfFByb2Nlc3NQQ0h8UHJv Y2Vzc1BDSFwrXCt8VG91Y2h8TGlidG9vbHxDb3B5U3RyaW5nc0ZpbGV8TWlnfENyZWF0ZVVuaXZl cnNhbEJpbmFyeXxBbmFseXplfFByb2Nlc3NQcm9kdWN0UGFja2FnaW5nfENvZGVTaWdufFN5bUxp bmt8VXBkYXRpbmd8Q29tcGlsZVhJQnxTdHJpcE5JQnxDb3B5UGxpc3RGaWxlfEdlbmVyYXRlRFNZ TUZpbGUpICgiW14iXSsifFxTKyk/LykgewogICAgICAgICBteSAoJGNvbW1hbmQsICRwYXRoKSA9 ICgkMSwgYmFzZW5hbWUoJDIpKTsKICAgICAgICAgJHBhdGggPX4gcy8iLy9nOwogICAgICAgICBw cmludExpbmUoIiRjb21tYW5kICRwYXRoIiwgU1RZTEVfUExBSU4pOwpAQCAtMTU2LDcgKzE1OSw3 IEBAIGZvciAobXkgJHByZXZpb3VzTGluZSA9ICIiLCBteSAkbGluZSA9IDwKICAgICAgICAgcHJp bnRMaW5lKCIkY29tbWFuZCAkcGF0aCIsIFNUWUxFX1BMQUlOKTsKICAgICB9IGVsc2UgewogICAg ICAgICAjIFRoaXMgb25seSBnZXRzIGhpdCBpZiBzdGRlcnIgaXMgcmVkaXJlY3RlZCB0byBzdGRv dXQuCi0gICAgICAgIGlmICgkbGluZSA9fiAvXCpcKiBCVUlMRCBGQUlMRUQgXCpcKi8pIHsKKyAg ICAgICAgaWYgKCgkbGluZSA9fiAvXCpcKiBCVUlMRCBGQUlMRUQgXCpcKi8pIHx8ICgkbGluZSA9 fiAvXkJ1aWxkIEZBSUxFRC4vKSkgewogICAgICAgICAgICAgJGJ1aWxkRmFpbGVkID0gMTsKICAg ICAgICAgfQogICAgICAgICBwcmludExpbmUoJGxpbmUsICRidWlsZEZpbmlzaGVkID8gU1RZTEVf U1VDQ0VTUyA6IFNUWUxFX0FMRVJUKTsKQEAgLTIyMywxNCArMjI2LDM0IEBAIHN1YiBzaG91bGRJ Z25vcmVMaW5lKCQkKQogICAgIHJldHVybiAxIGlmICRsaW5lID1+IC9eSmF2YVNjcmlwdENvcmVc L3BjcmVcL2RmdGFibGVzLzsKICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXkNyZWF0aW5nIGhh c2h0YWJsZSBmb3IgLzsKICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXldyb3RlIG91dHB1dCB0 byAvOwotICAgIHJldHVybiAxIGlmICRsaW5lID1+IC9eKHRvdWNofHBlcmx8Y2F0fHJtIC1mfGJp c29ufGZsZXh8cHl0aG9ufFwvdXNyXC9iaW5cL2dcK1wrfGdwZXJmfGVjaG98c2VkfGlmIFxbIFwt ZnxXZWJDb3JlXC9nZW5lcmF0ZS1leHBvcnQtZmlsZSkgLzsKICAgICByZXR1cm4gMSBpZiAkbGlu ZSA9fiAvXlVORE9DVU1FTlRFRDogLzsKICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvbGlidG9v bC4qaGFzIG5vIHN5bWJvbHMvOwogICAgIHJldHVybiAxIGlmICRsaW5lID1+IC9eIyBMb3dlciBj YXNlIGFsbCB0aGUgdmFsdWVzLCBhcyBDU1MgdmFsdWVzIGFyZSBjYXNlLWluc2Vuc2l0aXZlJC87 CiAgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL15pZiBzb3J0IC87Ci0gICAgcmV0dXJuIDEgaWYg JGxpbmUgPX4gL14gICAgLyAmJiAkcHJldmlvdXNMaW5lICF+IC9yZWZlcmVuY2VkIGZyb206JC87 Ci0gICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL15wcmludGYgLzsKLSAgICByZXR1cm4gMSBpZiAk bGluZSA9fiAvXm9mZmxpbmVhc206IE5vdGhpbmcgY2hhbmdlZC87CisgICAgaWYgKCRwbGF0Zm9y bSBlcSAid2luIikgeworICAgICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXlxzKih0b3VjaHxw ZXJsfGNhdHxybSAtZnxiaXNvbnxkZWx8ZmxleHxweXRob258XC91c3JcL2JpblwvZ1wrXCt8Z3Bl cmZ8ZWNob3xzZWR8aWYgXFsgXC1mfFdlYkNvcmVcL2dlbmVyYXRlLWV4cG9ydC1maWxlKSAvOwor ICAgICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXlxzKihpZiBub3QgZXhpc3QgXCJ8aWYgZXJy b3JsZXZlbCAxKS87CisgICAgICAgIHJldHVybiAxIGlmICRsaW5lID1+IC8oXlxzKnxNU0IzMDcz OlxzKykoc2V0IHxSRU0gfGNtZCBcL2MpLzsKKyAgICAgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4g L15ccypbY0NdOlxcW3BQXXJvZ3JhbSBbZkZdaWxlcy4qXFwuKlxcKENMfG1pZGwpXC5leGUgLzsK KyAgICAgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL15ccypQcm9jZXNzaW5nIC4qXC4oYWNmfGh8 aWRsKVxzKiQvOworICAgICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXlxzKnByaW50ZiAvOwor ICAgICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXlxzKlwvdXNyXC9iaW5cL2Jhc2hccyovOwor ICAgICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXlxzKm9mZmxpbmVhc206IE5vdGhpbmcgY2hh bmdlZC87CisgICAgICAgIHJldHVybiAxIGlmICRsaW5lID1+IC8gXGQrIEZpbGVcKHNcKSBjb3Bp ZWQvOworICAgICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXlxzKkZpbGUgbm90IGZvdW5kIC0g XCpcLmgvOworICAgICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvbWtkaXJccytcIi87CisgICAg ICAgIHJldHVybiAxIGlmICRsaW5lID1+IC94Y29weSBcL3kgXC9kIFwiLzsKKyAgICAgICAgcmV0 dXJuIDEgaWYgJGxpbmUgPX4gL1wub2JqXCJccyokLzsKKyAgICAgICAgcmV0dXJuIDEgaWYgJGxp bmUgPX4gLzpccysoY21kIFwvY3xzZXQpXHMrLzsKKyAgICAgICAgcmV0dXJuIDEgaWYgJGxpbmUg PX4gL01TQjMwNzM6XHMrJC87CisgICAgICAgIHJldHVybiAxIGlmICRsaW5lID1+IC9NU0IzMDcz OlxzK2lmIG5vdCBleGlzdC87CisgICAgICAgIHJldHVybiAxIGlmICRsaW5lID1+IC93aGljaC5l eGUgYmFzaC87CisgICAgfSBlbHNlIHsKKyAgICAgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL14o dG91Y2h8cGVybHxjYXR8cm0gLWZ8Ymlzb258ZmxleHxweXRob258XC91c3JcL2JpblwvZ1wrXCt8 Z3BlcmZ8ZWNob3xzZWR8aWYgXFsgXC1mfFdlYkNvcmVcL2dlbmVyYXRlLWV4cG9ydC1maWxlKSAv OworICAgICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXiAgICAvICYmICRwcmV2aW91c0xpbmUg IX4gL3JlZmVyZW5jZWQgZnJvbTokLzsKKyAgICAgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL15w cmludGYgLzsKKyAgICAgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL15vZmZsaW5lYXNtOiBOb3Ro aW5nIGNoYW5nZWQvOworICAgIH0KICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXlNob3dpbmcg Zmlyc3QvOwogCiAgICAgcmV0dXJuIDA7Cg==