125853 2013-12-17 04:58:16 -0800 prepare-ChangeLog doesn't handle templates properly 2013-12-18 09:23:07 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy webkit-unassigned commit-queue dbates dbatyai.u-szeged gbalogh.u-szeged ossy zherczeg oldest_to_newest 960463 0 ossy 2013-12-17 04:58:16 -0800 A simple diff: --------------- diff --git a/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp b/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp index bbcddd2..d3863d6 100644 --- a/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp +++ b/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp @@ -41,6 +41,7 @@ namespace CoreIPC { void ArgumentCoder<ResourceRequest>::encodePlatformData(ArgumentEncoder& encoder, const ResourceRequest& resourceRequest) { + // foo encoder << static_cast<uint32_t>(resourceRequest.soupMessageFlags()); } The generated ChangeLog entry: ------------------------------- * Shared/soup/WebCoreArgumentCodersSoup.cpp: (CoreIPC::::encodePlatformData): 960864 1 219512 dbatyai.u-szeged 2013-12-18 01:55:31 -0800 Created attachment 219512 Proposed patch 960868 2 219513 dbatyai.u-szeged 2013-12-18 02:06:00 -0800 Created attachment 219513 Proposed patch 960906 3 219513 galpeter 2013-12-18 05:16:00 -0800 Comment on attachment 219513 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=219513&action=review > Tools/ChangeLog:3 > + Fixed template handling in prepare-ChangeLog This line does not match the bug entry's title. 960917 4 219530 dbatyai.u-szeged 2013-12-18 06:15:55 -0800 Created attachment 219530 Proposed patch 960934 5 219530 ossy 2013-12-18 07:53:07 -0800 Comment on attachment 219530 Proposed patch The fix looks good to me, but please add a unittest. 960937 6 219537 dbatyai.u-szeged 2013-12-18 08:27:06 -0800 Created attachment 219537 Proposed patch 960952 7 219537 commit-queue 2013-12-18 09:23:05 -0800 Comment on attachment 219537 Proposed patch Clearing flags on attachment: 219537 Committed r160769: <http://trac.webkit.org/changeset/160769> 960953 8 commit-queue 2013-12-18 09:23:07 -0800 All reviewed patches have been landed. Closing bug. 219512 2013-12-18 01:55:31 -0800 2013-12-18 02:02:01 -0800 Proposed patch proposedpatch.patch text/plain 1289 dbatyai.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNmI3 MDdiLi40NzY1ZWYzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMTItMTggIETDoW5pZWwgQsOhdHlhaSAgPGRi YXR5YWkudS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KKworICAgICAgICBGaXhlZCB0ZW1w bGF0ZSBoYW5kbGluZyBpbiBwcmVwYXJlLUNoYW5nZUxvZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1ODUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nOgor ICAgICAgICAoZ2V0X2Z1bmN0aW9uX2xpbmVfcmFuZ2VzX2Zvcl9jcHApOgorCiAyMDEzLTEyLTE2 ICBLcnp5c3p0b2YgQ3plY2ggIDxrLmN6ZWNoQHNhbXN1bmcuY29tPgogCiAgICAgICAgIEFkZCBt eXNlbGYgYXMgYSBjb21taXR0ZXIKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1D aGFuZ2VMb2cgYi9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCmluZGV4IGU2ZTc4OTcu LjEzYWEzZmYgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKKysr IGIvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwpAQCAtNzYyLDcgKzc2Miw3IEBAIHN1 YiBnZXRfZnVuY3Rpb25fbGluZV9yYW5nZXNfZm9yX2NwcCgkJCkKIAogCiAgICAgICAgICMgRmlu ZCBmdW5jdGlvbiwgaW50ZXJmYWNlIGFuZCBtZXRob2QgbmFtZXMuCi0gICAgICAgIHdoaWxlICht JigoPzpbWzp3b3JkOl1dKzo6KSpvcGVyYXRvcig/OlsgXHRdKlwoXCl8W14oKV0qKXxbWzp3b3Jk Ol06fl0rfFsoKXt9Ojs9XSl8XEAoPzppbXBsZW1lbnRhdGlvbnxpbnRlcmZhY2V8cHJvdG9jb2wp XHMrKFx3KylbXntdKiZnKSB7CisgICAgICAgIHdoaWxlIChtJigoPzpbWzp3b3JkOl1dKzo6KSpv cGVyYXRvcig/OlsgXHRdKlwoXCl8W14oKV0qKXxbWzp3b3JkOl08Pjp+XSt8PFtbOndvcmQ6XTp+ XSs+fFsoKXt9Ojs9XSl8XEAoPzppbXBsZW1lbnRhdGlvbnxpbnRlcmZhY2V8cHJvdG9jb2wpXHMr KFx3KylbXntdKiZnKSB7CiAgICAgICAgICAgICAjIFNraXAgYW4gYXJyYXkgZGVmaW5pdGlvbiBh dCB0aGUgdG9wIGxldmVsLgogICAgICAgICAgICAgIyBlLmcuIHN0YXRpYyBpbnQgYXJyW10gPSB7 IDEsIDIsIDMgfTsKICAgICAgICAgICAgIGlmICgkMSkgewo= 219513 2013-12-18 02:06:00 -0800 2013-12-18 06:15:30 -0800 Proposed patch proposedpatch.patch text/plain 1273 dbatyai.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNmI3 MDdiLi40NzY1ZWYzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMTItMTggIETDoW5pZWwgQsOhdHlhaSAgPGRi YXR5YWkudS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KKworICAgICAgICBGaXhlZCB0ZW1w bGF0ZSBoYW5kbGluZyBpbiBwcmVwYXJlLUNoYW5nZUxvZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1ODUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nOgor ICAgICAgICAoZ2V0X2Z1bmN0aW9uX2xpbmVfcmFuZ2VzX2Zvcl9jcHApOgorCiAyMDEzLTEyLTE2 ICBLcnp5c3p0b2YgQ3plY2ggIDxrLmN6ZWNoQHNhbXN1bmcuY29tPgogCiAgICAgICAgIEFkZCBt eXNlbGYgYXMgYSBjb21taXR0ZXIKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1D aGFuZ2VMb2cgYi9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCmluZGV4IGU2ZTc4OTcu LjEzYWEzZmYgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKKysr IGIvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwpAQCAtNzYyLDcgKzc2Miw3IEBAIHN1 YiBnZXRfZnVuY3Rpb25fbGluZV9yYW5nZXNfZm9yX2NwcCgkJCkKIAogCiAgICAgICAgICMgRmlu ZCBmdW5jdGlvbiwgaW50ZXJmYWNlIGFuZCBtZXRob2QgbmFtZXMuCi0gICAgICAgIHdoaWxlICht JigoPzpbWzp3b3JkOl1dKzo6KSpvcGVyYXRvcig/OlsgXHRdKlwoXCl8W14oKV0qKXxbWzp3b3Jk Ol06fl0rfFsoKXt9Ojs9XSl8XEAoPzppbXBsZW1lbnRhdGlvbnxpbnRlcmZhY2V8cHJvdG9jb2wp XHMrKFx3KylbXntdKiZnKSB7CisgICAgICAgIHdoaWxlIChtJigoPzpbWzp3b3JkOl1dKzo6KSpv cGVyYXRvcig/OlsgXHRdKlwoXCl8W14oKV0qKXxbWzp3b3JkOl08Pjp+XSt8Wygpe306Oz1dKXxc QCg/OmltcGxlbWVudGF0aW9ufGludGVyZmFjZXxwcm90b2NvbClccysoXHcrKVtee10qJmcpIHsK ICAgICAgICAgICAgICMgU2tpcCBhbiBhcnJheSBkZWZpbml0aW9uIGF0IHRoZSB0b3AgbGV2ZWwu CiAgICAgICAgICAgICAjIGUuZy4gc3RhdGljIGludCBhcnJbXSA9IHsgMSwgMiwgMyB9OwogICAg ICAgICAgICAgaWYgKCQxKSB7Cg== 219530 2013-12-18 06:15:55 -0800 2013-12-18 08:48:23 -0800 Proposed patch proposedpatch.patch text/plain 1280 dbatyai.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNmI3 MDdiLi40NzY1ZWYzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMTItMTggIETDoW5pZWwgQsOhdHlhaSAgPGRi YXR5YWkudS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KKworICAgICAgICBwcmVwYXJlLUNo YW5nZUxvZyBkb2Vzbid0IGhhbmRsZSB0ZW1wbGF0ZXMgcHJvcGVybHkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTg1MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9wcmVwYXJlLUNoYW5n ZUxvZzoKKyAgICAgICAgKGdldF9mdW5jdGlvbl9saW5lX3Jhbmdlc19mb3JfY3BwKToKKwogMjAx My0xMi0xNiAgS3J6eXN6dG9mIEN6ZWNoICA8ay5jemVjaEBzYW1zdW5nLmNvbT4KIAogICAgICAg ICBBZGQgbXlzZWxmIGFzIGEgY29tbWl0dGVyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3By ZXBhcmUtQ2hhbmdlTG9nIGIvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwppbmRleCBl NmU3ODk3Li4xM2FhM2ZmIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdl TG9nCisrKyBiL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKQEAgLTc2Miw3ICs3NjIs NyBAQCBzdWIgZ2V0X2Z1bmN0aW9uX2xpbmVfcmFuZ2VzX2Zvcl9jcHAoJCQpCiAKIAogICAgICAg ICAjIEZpbmQgZnVuY3Rpb24sIGludGVyZmFjZSBhbmQgbWV0aG9kIG5hbWVzLgotICAgICAgICB3 aGlsZSAobSYoKD86W1s6d29yZDpdXSs6Oikqb3BlcmF0b3IoPzpbIFx0XSpcKFwpfFteKCldKil8 W1s6d29yZDpdOn5dK3xbKCl7fTo7PV0pfFxAKD86aW1wbGVtZW50YXRpb258aW50ZXJmYWNlfHBy b3RvY29sKVxzKyhcdyspW157XSomZykgeworICAgICAgICB3aGlsZSAobSYoKD86W1s6d29yZDpd XSs6Oikqb3BlcmF0b3IoPzpbIFx0XSpcKFwpfFteKCldKil8W1s6d29yZDpdPD46fl0rfFsoKXt9 Ojs9XSl8XEAoPzppbXBsZW1lbnRhdGlvbnxpbnRlcmZhY2V8cHJvdG9jb2wpXHMrKFx3KylbXntd KiZnKSB7CiAgICAgICAgICAgICAjIFNraXAgYW4gYXJyYXkgZGVmaW5pdGlvbiBhdCB0aGUgdG9w IGxldmVsLgogICAgICAgICAgICAgIyBlLmcuIHN0YXRpYyBpbnQgYXJyW10gPSB7IDEsIDIsIDMg fTsKICAgICAgICAgICAgIGlmICgkMSkgewo= 219537 2013-12-18 08:27:06 -0800 2013-12-18 09:23:05 -0800 Proposed patch proposedpatch.patch text/plain 2548 dbatyai.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjOTY3 M2ZkLi5jOTg5ZDhiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMTItMTggIETDoW5pZWwgQsOhdHlhaSAgPGRi YXR5YWkudS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KKworICAgICAgICBwcmVwYXJlLUNo YW5nZUxvZyBkb2Vzbid0IGhhbmRsZSB0ZW1wbGF0ZXMgcHJvcGVybHkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTg1MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9wcmVwYXJlLUNoYW5n ZUxvZzoKKyAgICAgICAgKGdldF9mdW5jdGlvbl9saW5lX3Jhbmdlc19mb3JfY3BwKToKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHBlcmwvcHJlcGFyZS1DaGFuZ2VMb2dfdW5pdHRlc3QvcmVzb3Vy Y2VzL2NwcF91bml0dGVzdHMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cGVybC9wcmVwYXJlLUNoYW5nZUxvZ191bml0dGVzdC9yZXNvdXJjZXMvY3BwX3VuaXR0ZXN0cy5j cHA6CisgICAgICAgIChDbGFzczExMDxUZW1wbGF0ZUNsYXNzPjo6ZnVuYzM2KToKKwogMjAxMy0x Mi0xNyAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggVGlt ZVJhbmdlczo6aW50ZXJzZWN0V2l0aApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9wcmVwYXJl LUNoYW5nZUxvZyBiL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKaW5kZXggZTZlNzg5 Ny4uNDFkNmI1NiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwor KysgYi9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCkBAIC03NjIsNyArNzYyLDcgQEAg c3ViIGdldF9mdW5jdGlvbl9saW5lX3Jhbmdlc19mb3JfY3BwKCQkKQogCiAKICAgICAgICAgIyBG aW5kIGZ1bmN0aW9uLCBpbnRlcmZhY2UgYW5kIG1ldGhvZCBuYW1lcy4KLSAgICAgICAgd2hpbGUg KG0mKCg/OltbOndvcmQ6XV0rOjopKm9wZXJhdG9yKD86WyBcdF0qXChcKXxbXigpXSopfFtbOndv cmQ6XTp+XSt8Wygpe306Oz1dKXxcQCg/OmltcGxlbWVudGF0aW9ufGludGVyZmFjZXxwcm90b2Nv bClccysoXHcrKVtee10qJmcpIHsKKyAgICAgICAgd2hpbGUgKG0mKCg/OltbOndvcmQ6XV0rOjop Km9wZXJhdG9yKD86WyBcdF0qXChcKXxbXigpXSopfFtbOndvcmQ6XTw+On5dK3xbKCl7fTo7PV0p fFxAKD86aW1wbGVtZW50YXRpb258aW50ZXJmYWNlfHByb3RvY29sKVxzKyhcdyspW157XSomZykg ewogICAgICAgICAgICAgIyBTa2lwIGFuIGFycmF5IGRlZmluaXRpb24gYXQgdGhlIHRvcCBsZXZl bC4KICAgICAgICAgICAgICMgZS5nLiBzdGF0aWMgaW50IGFycltdID0geyAxLCAyLCAzIH07CiAg ICAgICAgICAgICBpZiAoJDEpIHsKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVy bC9wcmVwYXJlLUNoYW5nZUxvZ191bml0dGVzdC9yZXNvdXJjZXMvY3BwX3VuaXR0ZXN0cy1leHBl Y3RlZC50eHQgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvcHJlcGFyZS1DaGFuZ2VMb2dfdW5p dHRlc3QvcmVzb3VyY2VzL2NwcF91bml0dGVzdHMtZXhwZWN0ZWQudHh0CmluZGV4IGM1ODU2MGUu LjhmMTFmN2EgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9wcmVwYXJlLUNo YW5nZUxvZ191bml0dGVzdC9yZXNvdXJjZXMvY3BwX3VuaXR0ZXN0cy1leHBlY3RlZC50eHQKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL3ByZXBhcmUtQ2hhbmdlTG9nX3VuaXR0ZXN0L3Jl c291cmNlcy9jcHBfdW5pdHRlc3RzLWV4cGVjdGVkLnR4dApAQCAtMjE3LDUgKzIxNywxMCBAQAog ICAgICAgJzMyMCcsCiAgICAgICAnQ2xhc3MxMDg6OmZ1bmMzNScKICAgICBdLAorICAgIFsKKyAg ICAgICczOTEnLAorICAgICAgJzM5MycsCisgICAgICAnQ2xhc3MxMTA8VGVtcGxhdGVDbGFzcz46 OmZ1bmMzNicKKyAgICBdCiAgIF0KIH0KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cGVybC9wcmVwYXJlLUNoYW5nZUxvZ191bml0dGVzdC9yZXNvdXJjZXMvY3BwX3VuaXR0ZXN0cy5j cHAgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvcHJlcGFyZS1DaGFuZ2VMb2dfdW5pdHRlc3Qv cmVzb3VyY2VzL2NwcF91bml0dGVzdHMuY3BwCmluZGV4IDAxNWE2OTQuLjkzNmY4MGIgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9wcmVwYXJlLUNoYW5nZUxvZ191bml0dGVz dC9yZXNvdXJjZXMvY3BwX3VuaXR0ZXN0cy5jcHAKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw ZXJsL3ByZXBhcmUtQ2hhbmdlTG9nX3VuaXR0ZXN0L3Jlc291cmNlcy9jcHBfdW5pdHRlc3RzLmNw cApAQCAtMzg3LDMgKzM4Nyw3IEBAIGNsYXNzIENsYXNzMTA5IHsKIH07CiAKIH07CisKK3ZvaWQg Q2xhc3MxMTA8VGVtcGxhdGVDbGFzcz46OmZ1bmMzNigpCit7Cit9Cg==