125848 2013-12-17 02:40:28 -0800 Fix the SH4 and ARMv7 build after r160680 2013-12-17 05:27:39 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 125809 1 jbriance webkit-unassigned commit-queue mhahnenberg oliver ossy yannick.poirier oldest_to_newest 960441 0 jbriance 2013-12-17 02:40:28 -0800 sh4 compilation fails: [ 20%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/assembler/MacroAssembler.cpp.o In file included from /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:33:0, from /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/assembler/MacroAssembler.h:60, from /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/assembler/LinkBuffer.h:38, from /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/assembler/LinkBuffer.cpp:27: /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/assembler/SH4Assembler.h: In constructor ‘JSC::SH4Assembler::SH4Assembler()’: /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/assembler/SH4Assembler.h:348:35: error: ‘INT_MIN’ was not declared in this scope In file included from /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:33:0, from /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/assembler/MacroAssembler.h:60, from /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/assembler/MacroAssembler.cpp:27: /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/assembler/SH4Assembler.h: In constructor ‘JSC::SH4Assembler::SH4Assembler()’: /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/assembler/SH4Assembler.h:348:35: error: ‘INT_MIN’ was not declared in this scope make[3]: *** [Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/assembler/MacroAssembler.cpp.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[3]: *** [Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/assembler/LinkBuffer.cpp.o] Error 1 make[2]: *** [Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/all] Error 2 make[1]: *** [Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/rule] Error 2 make: *** [jsc] Error 2 960444 1 219405 jbriance 2013-12-17 02:42:19 -0800 Created attachment 219405 Include limits.h for INT_MIN in sh4 assembler. 960460 2 219405 ossy 2013-12-17 04:49:26 -0800 Comment on attachment 219405 Include limits.h for INT_MIN in sh4 assembler. Not only the SH4 build is affected, but ARMv7 too. Could you add this include to ARMv7Assembler.h too please? Otherwise LGTM, r=me with fixing both of these builds. 960461 3 219410 jbriance 2013-12-17 04:54:17 -0800 Created attachment 219410 Include limits.h for INT_MIN in armv7 and sh4 assembler. 960462 4 219410 ossy 2013-12-17 04:55:27 -0800 Comment on attachment 219410 Include limits.h for INT_MIN in armv7 and sh4 assembler. Thanks. 960473 5 219410 commit-queue 2013-12-17 05:27:37 -0800 Comment on attachment 219410 Include limits.h for INT_MIN in armv7 and sh4 assembler. Clearing flags on attachment: 219410 Committed r160703: <http://trac.webkit.org/changeset/160703> 960474 6 commit-queue 2013-12-17 05:27:39 -0800 All reviewed patches have been landed. Closing bug. 219405 2013-12-17 02:42:19 -0800 2013-12-17 04:54:17 -0800 Include limits.h for INT_MIN in sh4 assembler. bug-125848.patch text/plain 1047 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwNjk4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEzLTEyLTE3ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIEZpeCBzaDQgYnVpbGQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMjU4NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGFzc2VtYmxlci9TSDRBc3NlbWJsZXIuaDogSW5jbHVkZSBsaW1pdHMu aCBmb3IgSU5UX01JTi4KKwogMjAxMy0xMi0xNiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIEF2b2lkIGluZGlyZWN0IGZ1bmN0aW9uIGNhbGxzIGZvciBjdXN0b20g Z2V0dGVycwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9TSDRBc3NlbWJs ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1NINEFz c2VtYmxlci5oCShyZXZpc2lvbiAxNjA2OTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL1NINEFzc2VtYmxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMyw3IEBACiAj aW5jbHVkZSAiQXNzZW1ibGVyQnVmZmVyLmgiCiAjaW5jbHVkZSAiQXNzZW1ibGVyQnVmZmVyV2l0 aENvbnN0YW50UG9vbC5oIgogI2luY2x1ZGUgIkpJVENvbXBpbGF0aW9uRWZmb3J0LmgiCisjaW5j bHVkZSA8bGltaXRzLmg+CiAjaW5jbHVkZSA8c3RkYXJnLmg+CiAjaW5jbHVkZSA8c3RkaW50Lmg+ CiAjaW5jbHVkZSA8c3RkaW8uaD4K 219410 2013-12-17 04:54:17 -0800 2013-12-17 05:27:37 -0800 Include limits.h for INT_MIN in armv7 and sh4 assembler. bug-125848_2.patch text/plain 1582 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwNzAxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTEyLTE3ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIEZpeCBhcm12NyBhbmQgc2g0IGJ1aWxkcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTg0OAorCisgICAgICAgIFJldmlld2VkIGJ5IENz YWJhIE9zenRyb2dvbsOhYy4KKworICAgICAgICAqIGFzc2VtYmxlci9BUk12N0Fzc2VtYmxlci5o OiBJbmNsdWRlIGxpbWl0cy5oIGZvciBJTlRfTUlOLgorICAgICAgICAqIGFzc2VtYmxlci9TSDRB c3NlbWJsZXIuaDogSW5jbHVkZSBsaW1pdHMuaCBmb3IgSU5UX01JTi4KKwogMjAxMy0xMi0xNiAg T2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEF2b2lkIGluZGlyZWN0 IGZ1bmN0aW9uIGNhbGxzIGZvciBjdXN0b20gZ2V0dGVycwpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2Fzc2VtYmxlci9BUk12N0Fzc2VtYmxlci5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNdjdBc3NlbWJsZXIuaAkocmV2aXNpb24gMTYwNjk2 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk12N0Fzc2VtYmxlci5oCSh3 b3JraW5nIGNvcHkpCkBAIC0zMCw2ICszMCw3IEBACiAjaWYgRU5BQkxFKEFTU0VNQkxFUikgJiYg Q1BVKEFSTV9USFVNQjIpCiAKICNpbmNsdWRlICJBc3NlbWJsZXJCdWZmZXIuaCIKKyNpbmNsdWRl IDxsaW1pdHMuaD4KICNpbmNsdWRlIDx3dGYvQXNzZXJ0aW9ucy5oPgogI2luY2x1ZGUgPHd0Zi9W ZWN0b3IuaD4KICNpbmNsdWRlIDxzdGRpbnQuaD4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvU0g0QXNzZW1ibGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2Fzc2VtYmxlci9TSDRBc3NlbWJsZXIuaAkocmV2aXNpb24gMTYwNjk2KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9TSDRBc3NlbWJsZXIuaAkod29ya2luZyBjb3B5 KQpAQCAtMzMsNiArMzMsNyBAQAogI2luY2x1ZGUgIkFzc2VtYmxlckJ1ZmZlci5oIgogI2luY2x1 ZGUgIkFzc2VtYmxlckJ1ZmZlcldpdGhDb25zdGFudFBvb2wuaCIKICNpbmNsdWRlICJKSVRDb21w aWxhdGlvbkVmZm9ydC5oIgorI2luY2x1ZGUgPGxpbWl0cy5oPgogI2luY2x1ZGUgPHN0ZGFyZy5o PgogI2luY2x1ZGUgPHN0ZGludC5oPgogI2luY2x1ZGUgPHN0ZGlvLmg+Cg==