125847 2013-12-17 02:21:31 -0800 Should not have identifiers with underscores in them, especially not leading underscores. 2013-12-18 10:03:47 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gbalogh.u-szeged webkit-unassigned ap commit-queue darin glenn rniwa oldest_to_newest 960438 0 gbalogh.u-szeged 2013-12-17 02:21:31 -0800 example: Options::Options(double _default_long_timeout, double _default_short_timeout) Should be defaultLongTimeout and defaultShortTimeout. 960439 1 gbalogh.u-szeged 2013-12-17 02:22:32 -0800 RFC: it is true or not? 960502 2 darin 2013-12-17 07:49:41 -0800 This is all covered in the coding style document <http://www.webkit.org/coding/coding-style.html>. It doesn’t list everything that it prohibits, but it’s clear that underscores are used only in macros (it calls them “defined constants”). 960607 3 ap 2013-12-17 11:50:28 -0800 There are some exceptions where underscores are needed to match names coming from elsewhere (e.g. please don't rename CryptoAlgorithmRSAES_PKCS1_v1_5.h), but this example is clearly in violation of WebKit rules. 960936 4 219536 gbalogh.u-szeged 2013-12-18 08:17:55 -0800 Created attachment 219536 patch This is fix the existing underscore checking logic, which ignored the constructor definitions. 960969 5 219536 commit-queue 2013-12-18 10:03:44 -0800 Comment on attachment 219536 patch Clearing flags on attachment: 219536 Committed r160773: <http://trac.webkit.org/changeset/160773> 960970 6 commit-queue 2013-12-18 10:03:47 -0800 All reviewed patches have been landed. Closing bug. 219536 2013-12-18 08:17:55 -0800 2013-12-18 10:03:43 -0800 patch f2745.diff text/plain 4718 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2Yjcx ZTkxLi5kZjQyZjIwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMTItMTggIEdlcmdvIEJhbG9naCAgPGdlcnl4 eXpAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFNob3VsZCBub3QgaGF2ZSBpZGVudGlmaWVy cyB3aXRoIHVuZGVyc2NvcmVzIGluIHRoZW0sIGVzcGVjaWFsbHkgbm90IGxlYWRpbmcgdW5kZXJz Y29yZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjU4NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5OgorICAgICAgICAoY2hlY2tf aWRlbnRpZmllcl9uYW1lX2luX2RlY2xhcmF0aW9uKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weToKKyAgICAgICAgKENwcFN0eWxlVGVz dC50ZXN0X3J1bnRpbWVfc2VsZmluaXQpOgorICAgICAgICAoV2ViS2l0U3R5bGVUZXN0LnRlc3Rf bmFtZXMpOgorCiAyMDEzLTEyLTE4ICBEw6FuaWVsIELDoXR5YWkgIDxCYXR5YWkuRGFuaWVsQHN0 dWQudS1zemVnZWQuaHU+CiAKICAgICAgICAgTW92ZSBleHBlY3RhdGlvbiBwYXJzaW5nIG91dCBv ZiB0aGUgY29uc3RydWN0b3Igb2YgVGVzdEV4cGVjdGF0aW9ucwpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCBmYTE4MGM4Li5iMzgyZmM4IDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMzIxOSwx MiArMzIxOSwxNSBAQCBkZWYgY2hlY2tfaWRlbnRpZmllcl9uYW1lX2luX2RlY2xhcmF0aW9uKGZp bGVuYW1lLCBsaW5lX251bWJlciwgbGluZSwgZmlsZV9zdGF0ZQogICAgIGNoYXJhY3Rlcl9hZnRl cl9pZGVudGlmaWVyX3JlZ2V4cCA9IHInKD9QPGNoYXJhY3Rlcl9hZnRlcl9pZGVudGlmaWVyPltb OygpPSxdKSg/IT0pJwogICAgIGRlY2xhcmF0aW9uX3dpdGhvdXRfdHlwZV9yZWdleHAgPSByJ1xz KicgKyBpZGVudGlmaWVyX3JlZ2V4cCArIHInXHMqJyArIG1heWJlX2JpdGZpZWxkX3JlZ2V4cCAr IGNoYXJhY3Rlcl9hZnRlcl9pZGVudGlmaWVyX3JlZ2V4cAogICAgIGRlY2xhcmF0aW9uX3dpdGhf dHlwZV9yZWdleHAgPSByJ1xzKicgKyB0eXBlX3JlZ2V4cCArIHInXHMnICsgZGVjbGFyYXRpb25f d2l0aG91dF90eXBlX3JlZ2V4cAorICAgIGNvbnN0cnVjdG9yX3JlZ2V4cCA9IHInXHMqKFtcd19d Kjo6KSooP1A8cHJlX3BhcnQ+W1x3X10rKTo6KD9QPHBvc3RfcGFydD5bXHdfXSspWyhdJwogICAg IGlzX2Z1bmN0aW9uX2FyZ3VtZW50cyA9IEZhbHNlCiAgICAgbnVtYmVyX29mX2lkZW50aWZpZXJz ID0gMAogICAgIHdoaWxlIFRydWU6CiAgICAgICAgICMgSWYgd2UgYXJlIHNlZWluZyB0aGUgZmly c3QgaWRlbnRpZmllciBvciBhcmd1bWVudHMgb2YgYQogICAgICAgICAjIGZ1bmN0aW9uLCB0aGVy ZSBzaG91bGQgYmUgYSB0eXBlIG5hbWUgYmVmb3JlIGFuIGlkZW50aWZpZXIuCi0gICAgICAgIGlm IG5vdCBudW1iZXJfb2ZfaWRlbnRpZmllcnMgb3IgaXNfZnVuY3Rpb25fYXJndW1lbnRzOgorICAg ICAgICBjb25zdHJ1Y3Rvcl9jaGVjayA9IG1hdGNoKGNvbnN0cnVjdG9yX3JlZ2V4cCwgbGluZSkK KyAgICAgICAgaXNfY29uc3RydWN0b3IgPSBjb25zdHJ1Y3Rvcl9jaGVjayBhbmQgY29uc3RydWN0 b3JfY2hlY2suZ3JvdXAoJ3ByZV9wYXJ0JykgPT0gY29uc3RydWN0b3JfY2hlY2suZ3JvdXAoJ3Bv c3RfcGFydCcpCisgICAgICAgIGlmIG5vdCBpc19jb25zdHJ1Y3RvciBhbmQgKG5vdCBudW1iZXJf b2ZfaWRlbnRpZmllcnMgb3IgaXNfZnVuY3Rpb25fYXJndW1lbnRzKToKICAgICAgICAgICAgIGRl Y2xhcmF0aW9uX3JlZ2V4cCA9IGRlY2xhcmF0aW9uX3dpdGhfdHlwZV9yZWdleHAKICAgICAgICAg ZWxzZToKICAgICAgICAgICAgIGRlY2xhcmF0aW9uX3JlZ2V4cCA9IGRlY2xhcmF0aW9uX3dpdGhv dXRfdHlwZV9yZWdleHAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggZWQ5MTE3Zi4uZTZjMWI0NyAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3Qu cHkKQEAgLTc1MSwyNSArNzUxLDI1IEBAIGNsYXNzIENwcFN0eWxlVGVzdChDcHBTdHlsZVRlc3RC YXNlKToKICAgICBkZWYgdGVzdF9ydW50aW1lX3NlbGZpbml0KHNlbGYpOgogICAgICAgICBzZWxm LmFzc2VydF9tdWx0aV9saW5lX2xpbnQoCiAgICAgICAgICAgICAnJydcCi0gICAgICAgICAgICBG b286OkZvbyhCYXIgciwgQmVsIGwpCi0gICAgICAgICAgICAgICAgOiByXyhyXykKLSAgICAgICAg ICAgICAgICAsIGxfKGxfKSB7IH0nJycsCisgICAgICAgICAgICBGb286OkZvbyhCYXIgcmFhLCBC ZWwgbGFhKQorICAgICAgICAgICAgICAgIDogcmFhXyhyYWFfKQorICAgICAgICAgICAgICAgICwg bGFhXyhsYWFfKSB7IH0nJycsCiAgICAgICAgICAgICBbJ1lvdSBzZWVtIHRvIGJlIGluaXRpYWxp emluZyBhIG1lbWJlciB2YXJpYWJsZSB3aXRoIGl0c2VsZi4nCiAgICAgICAgICAgICAnICBbcnVu dGltZS9pbml0XSBbNF0nLAogICAgICAgICAgICAgJ1lvdSBzZWVtIHRvIGJlIGluaXRpYWxpemlu ZyBhIG1lbWJlciB2YXJpYWJsZSB3aXRoIGl0c2VsZi4nCiAgICAgICAgICAgICAnICBbcnVudGlt ZS9pbml0XSBbNF0nXSkKICAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAogICAg ICAgICAgICAgJycnXAotICAgICAgICAgICAgRm9vOjpGb28oQmFyIHIsIEJlbCBsKQotICAgICAg ICAgICAgICAgIDogcl8ocikKLSAgICAgICAgICAgICAgICAsIGxfKGwpIHsgfScnJywKKyAgICAg ICAgICAgIEZvbzo6Rm9vKEJhciByYWEsIEJlbCBsYWEpCisgICAgICAgICAgICAgICAgOiByYWFf KHJhYSkKKyAgICAgICAgICAgICAgICAsIGxhYV8obGFhKSB7IH0nJycsCiAgICAgICAgICAgICAn JykKICAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAogICAgICAgICAgICAgJycn XAotICAgICAgICAgICAgRm9vOjpGb28oQmFyIHIpCi0gICAgICAgICAgICAgICAgOiByXyhyKQot ICAgICAgICAgICAgICAgICwgbF8ocl8pCi0gICAgICAgICAgICAgICAgLCBsbF8obF8pIHsgfScn JywKKyAgICAgICAgICAgIEZvbzo6Rm9vKEJhciByYWEpCisgICAgICAgICAgICAgICAgOiByYWFf KHJhYSkKKyAgICAgICAgICAgICAgICAsIGxhYV8ocmFhXykKKyAgICAgICAgICAgICAgICAsIGxs YWFfKGxhYV8pIHsgfScnJywKICAgICAgICAgICAgICcnKQogCiAgICAgZGVmIHRlc3RfcnVudGlt ZV9ydHRpKHNlbGYpOgpAQCAtNDY3Niw2ICs0Njc2LDE0IEBAIGNsYXNzIFdlYktpdFN0eWxlVGVz dChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgICAgICAgICAgICAgICAgICAnX2xlbmd0aCcg KyBuYW1lX3VuZGVyc2NvcmVfZXJyb3JfbWVzc2FnZSkKICAgICAgICAgc2VsZi5hc3NlcnRfbGlu dCgndW5zaWduZWQgbG9uZyBsb25nIF9sZW5ndGg7JywKICAgICAgICAgICAgICAgICAgICAgICAg ICAnX2xlbmd0aCcgKyBuYW1lX3VuZGVyc2NvcmVfZXJyb3JfbWVzc2FnZSkKKyAgICAgICAgc2Vs Zi5hc3NlcnRfbGludCgnICAgIDo6Ymxhc3BhY2U6Ok9wdGlvbnM6Ok9wdGlvbnMoZG91YmxlIGRl ZmF1bHRMb25nVGltZW91dCknLAorICAgICAgICAgICAgICAgICAgICAgICAgICcnKQorICAgICAg ICBzZWxmLmFzc2VydF9saW50KCcgICAgOjpibGFzcGFjZTo6T3B0aW9uczo6T3B0aW9ucyhkb3Vi bGUgX2RlZmF1bHRfbG9uZ190aW1lb3V0KScsCisgICAgICAgICAgICAgICAgICAgICAgICAgJ19k ZWZhdWx0X2xvbmdfdGltZW91dCcgKyBuYW1lX3VuZGVyc2NvcmVfZXJyb3JfbWVzc2FnZSkKKyAg ICAgICAgc2VsZi5hc3NlcnRfbGludCgnICAgIGJsYXNwYWNlOjpPcHRpb25zOjpPcHRpb25zKGRv dWJsZSBfZGVmYXVsdF9sb25nX3RpbWVvdXQpJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAn X2RlZmF1bHRfbG9uZ190aW1lb3V0JyArIG5hbWVfdW5kZXJzY29yZV9lcnJvcl9tZXNzYWdlKQor ICAgICAgICBzZWxmLmFzc2VydF9saW50KCcgICAgT3B0aW9uczo6T3B0aW9ucyhkb3VibGUgX2Rl ZmF1bHRfbG9uZ190aW1lb3V0KScsCisgICAgICAgICAgICAgICAgICAgICAgICAgJ19kZWZhdWx0 X2xvbmdfdGltZW91dCcgKyBuYW1lX3VuZGVyc2NvcmVfZXJyb3JfbWVzc2FnZSkKIAogICAgICAg ICAjIEFsbG93IHVuZGVyc2NvcmVzIGluIE9iamVjdGl2ZSBDIGZpbGVzLgogICAgICAgICBzZWxm LmFzc2VydF9saW50KCd1bnNpZ25lZCBsb25nIGxvbmcgX2xlbmd0aDsnLAo=