125846 2013-12-17 01:51:28 -0800 Fix for C++ should have the & or * beside the type not the variable name check. 2013-12-18 02:07:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gbalogh.u-szeged webkit-unassigned commit-queue darin galpeter glenn gyuyoung.kim ossy rniwa tgergely.u-szeged oldest_to_newest 960434 0 gbalogh.u-szeged 2013-12-17 01:51:28 -0800 There is no error message when there is a space between * or & and the variable name. example: const char * currentArgument = argv[++argCounter]; 960437 1 219404 gbalogh.u-szeged 2013-12-17 02:07:58 -0800 Created attachment 219404 patch 960510 2 219404 commit-queue 2013-12-17 08:15:09 -0800 Comment on attachment 219404 patch Clearing flags on attachment: 219404 Committed r160706: <http://trac.webkit.org/changeset/160706> 960511 3 commit-queue 2013-12-17 08:15:13 -0800 All reviewed patches have been landed. Closing bug. 960536 4 darin 2013-12-17 09:19:07 -0800 This needs to be rolled out. It’s complaining on lines of code that are doing multiplication, such as the ones in bug 120284. 960869 5 tgergely.u-szeged 2013-12-18 02:07:04 -0800 (In reply to comment #4) > This needs to be rolled out. It’s complaining on lines of code that are doing multiplication, such as the ones in bug 120284. I reported bug 125915 against webkit-check-style for this issue. 219404 2013-12-17 02:07:58 -0800 2013-12-17 08:15:09 -0800 patch f2744.diff text/plain 2405 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3ZTZk ZDY1Li4xZDg4ZWJmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMTItMTcgIEdlcmdvIEJhbG9naCAgPGdlcnl4 eXpAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIEZpeCBmb3IgQysrIHNob3VsZCBoYXZlIHRo ZSAmIG9yICogYmVzaWRlIHRoZSB0eXBlIG5vdCB0aGUgdmFyaWFibGUgbmFtZSBjaGVjay4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTg0NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVja19zcGFjaW5nKToK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5w eToKKyAgICAgICAgKENwcFN0eWxlVGVzdC50ZXN0X3BvaW50ZXJfcmVmZXJlbmNlX21hcmtlcl9s b2NhdGlvbik6CisKIDIwMTMtMTItMTYgIFJvYiBCdWlzICA8cm9iLmJ1aXNAc2Ftc3VuZy5jb20+ CiAKICAgICAgICAgQWRkIG15IFNhbXN1bmcgZW1haWwgYWRkcmVzcy4KZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggYjA5ZGZhZi4uYTdkNTUyNCAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTE5 MjQsNyArMTkyNCw3IEBAIGRlZiBjaGVja19zcGFjaW5nKGZpbGVfZXh0ZW5zaW9uLCBjbGVhbl9s aW5lcywgbGluZV9udW1iZXIsIGVycm9yKToKIAogICAgIGlmIGZpbGVfZXh0ZW5zaW9uID09ICdj cHAnOgogICAgICAgICAjIEMrKyBzaG91bGQgaGF2ZSB0aGUgJiBvciAqIGJlc2lkZSB0aGUgdHlw ZSBub3QgdGhlIHZhcmlhYmxlIG5hbWUuCi0gICAgICAgIG1hdGNoZWQgPSBtYXRjaChyJ1xzKlx3 Kyg/PCFcYnJldHVybnxcYmRlbGV0ZSlccysoP1A8cG9pbnRlcl9vcGVyYXRvcj5cKnxcJilcdysn LCBsaW5lKQorICAgICAgICBtYXRjaGVkID0gbWF0Y2gocidccyooW1x3XHNdKykoPzwhXGJyZXR1 cm58XGJkZWxldGUpXHMrKD9QPHBvaW50ZXJfb3BlcmF0b3I+XCp8XCYpXHMqXHcrJywgbGluZSkK ICAgICAgICAgaWYgbWF0Y2hlZDoKICAgICAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAnd2hp dGVzcGFjZS9kZWNsYXJhdGlvbicsIDMsCiAgICAgICAgICAgICAgICAgICAnRGVjbGFyYXRpb24g aGFzIHNwYWNlIGJldHdlZW4gdHlwZSBuYW1lIGFuZCAlcyBpbiAlcycgJSAobWF0Y2hlZC5ncm91 cCgncG9pbnRlcl9vcGVyYXRvcicpLCBtYXRjaGVkLmdyb3VwKDApLnN0cmlwKCkpKQpkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3Qu cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5w eQppbmRleCBmYTRiODlkLi5lNmZlYzkwIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQpAQCAtMjA2Niw2ICsyMDY2LDkg QEAgY2xhc3MgQ3BwU3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICBzZWxmLmFz c2VydF9saW50KCdpbnQgKmI7JywKICAgICAgICAgICAgICAgICAgICAgICAgICAnRGVjbGFyYXRp b24gaGFzIHNwYWNlIGJldHdlZW4gdHlwZSBuYW1lIGFuZCAqIGluIGludCAqYiAgW3doaXRlc3Bh Y2UvZGVjbGFyYXRpb25dIFszXScsCiAgICAgICAgICAgICAgICAgICAgICAgICAgJ2Zvby5jcHAn KQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdpbnQgKiBiOycsCisgICAgICAgICAgICAgICAg ICAgICAgICAgJ0RlY2xhcmF0aW9uIGhhcyBzcGFjZSBiZXR3ZWVuIHR5cGUgbmFtZSBhbmQgKiBp biBpbnQgKiBiICBbd2hpdGVzcGFjZS9kZWNsYXJhdGlvbl0gWzNdJywKKyAgICAgICAgICAgICAg ICAgICAgICAgICAnZm9vLmNwcCcpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ3JldHVybiAq YjsnLCAnJywgJ2Zvby5jcHAnKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KCdkZWxldGUgKmI7 JywgJycsICdmb28uY3BwJykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnaW50ICpiOycsICcn LCAnZm9vLmMnKQo=