125836 2013-12-16 22:18:05 -0800 [SVG] Fix CSS transform handling when zoomed 2024-07-22 21:08:16 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=194903 BlinkMergeCandidate P2 Normal --- 1 rniwa webkit-unassigned commit-queue dino d-r fmalita fujii gyuyoung.kim krit pdr savagobr schenney sergio simon.fraser thorton zimmermann oldest_to_newest 960412 0 rniwa 2013-12-16 22:18:05 -0800 Consider merging https://chromium.googlesource.com/chromium/blink/+/12e43b6d16005ed322d97e77e2ec72b0b9d40f9a CSS takes the page zoom factor into account for all computed length values, including transform translation components. OTOH, SVG applies the zoom factor globally (at the SVG root level) - so when using CSS transforms in SVG, the translation components are scaled twice. This CL adjusts CSS transforms when used in SVG to account for the unexpected translation scale. 998701 1 228868 savagobr 2014-04-08 12:23:54 -0700 Created attachment 228868 Patch 998788 2 228868 thorton 2014-04-08 14:28:19 -0700 Comment on attachment 228868 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228868&action=review > Source/WebCore/svg/SVGGraphicsElement.cpp:80 > + float zoom = style->effectiveZoom(); does this take page scale into account? page zoom? which ones are baked into the CSS transform values? 998824 3 228868 commit-queue 2014-04-08 15:28:04 -0700 Comment on attachment 228868 Patch Clearing flags on attachment: 228868 Committed r166967: <http://trac.webkit.org/changeset/166967> 998825 4 commit-queue 2014-04-08 15:28:10 -0700 All reviewed patches have been landed. Closing bug. 228868 2014-04-08 12:23:54 -0700 2014-04-08 15:28:03 -0700 Patch bug-125836-20140408122334.patch text/plain 5230 savagobr U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2OTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjQzYzQ3MzQ3NWIyMGRi ZDU0YTllZDdkZDg1OTdlNzk1YWU3MWU2Ny4uNzQ2MDk3MTY5NDBmMjQ5ZTUwMTllOTRiNWQ4NTQw ZGU4MGYyYzJkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA0LTA4ICBBZGVu aWxzb24gQ2F2YWxjYW50aSAgPGNhdmFsY2FudGlpQGdtYWlsLmNvbT4KKworICAgICAgICBbU1ZH XSBGaXggQ1NTIHRyYW5zZm9ybSBoYW5kbGluZyB3aGVuIHpvb21lZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1ODM2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdHM6IHN2Zy96b29tL3BhZ2Uvem9v bS1jc3MtdHJhbnNmb3Jtcy1leHBlY3RlZC5zdmcKKyAgICAgICAgICAgICAgIHN2Zy96b29tL3Bh Z2Uvem9vbS1jc3MtdHJhbnNmb3Jtcy5zdmcKKworICAgICAgICBBZGp1c3RzIENTUyB0cmFuc2Zv cm1zIHdoZW4gdXNlZCBpbiBTVkcgdG8gYWNjb3VudCBmb3IgdW5leHBlY3RlZAorICAgICAgICB0 cmFuc2xhdGlvbiBzY2FsZS4gQmFja3BvcnQgZnJvbSBDaHJvbWl1bSAjMTc0OTEwLgorCisgICAg ICAgICogc3ZnL1NWR0dyYXBoaWNzRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdH cmFwaGljc0VsZW1lbnQ6OmFuaW1hdGVkTG9jYWxUcmFuc2Zvcm0pOgorCiAyMDE0LTA0LTA4ICBZ b3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKICAgICAgICAgW1NP VVBdIENvbnRyb2wgY29va2llIG1hbmFnZW1lbnQgYWNjb3JkaW5nIFJlc291cmNlUmVxdWVzdC5h bGxvd0Nvb2tpZXMoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0dyYXBoaWNz RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHR3JhcGhpY3NFbGVtZW50LmNwcApp bmRleCAwMjk2Y2JmODQ1NDRkYjYwOTk0ODZlYjRlNWNmODhkZmZhNTU0MGQzLi5kYmQ3MzdlYWJm YzZkOGYyMzkzMGZiYjkzMzY4ODJhY2EzMjE4MzU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9zdmcvU1ZHR3JhcGhpY3NFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZH R3JhcGhpY3NFbGVtZW50LmNwcApAQCAtNzUsNiArNzUsMTQgQEAgQWZmaW5lVHJhbnNmb3JtIFNW R0dyYXBoaWNzRWxlbWVudDo6YW5pbWF0ZWRMb2NhbFRyYW5zZm9ybSgpIGNvbnN0CiAKICAgICAg ICAgLy8gRmxhdHRlbiBhbnkgM0QgdHJhbnNmb3JtLgogICAgICAgICBtYXRyaXggPSB0cmFuc2Zv cm0udG9BZmZpbmVUcmFuc2Zvcm0oKTsKKyAgICAgICAgLy8gQ1NTIGJha2VzIHRoZSB6b29tIGZh Y3RvciBpbnRvIGxlbmd0aHMsIGluY2x1ZGluZyB0cmFuc2xhdGlvbiBjb21wb25lbnRzLgorICAg ICAgICAvLyBJbiBvcmRlciB0byBhbGlnbiBDU1MgJiBTVkcgdHJhbnNmb3Jtcywgd2UgbmVlZCB0 byBpbnZlcnQgdGhpcyBvcGVyYXRpb24uCisgICAgICAgIGZsb2F0IHpvb20gPSBzdHlsZS0+ZWZm ZWN0aXZlWm9vbSgpOworICAgICAgICBpZiAoem9vbSAhPSAxKSB7CisgICAgICAgICAgICBtYXRy aXguc2V0RShtYXRyaXguZSgpIC8gem9vbSk7CisgICAgICAgICAgICBtYXRyaXguc2V0RihtYXRy aXguZigpIC8gem9vbSk7CisgICAgICAgIH0KKwogICAgIH0gZWxzZQogICAgICAgICB0cmFuc2Zv cm0oKS5jb25jYXRlbmF0ZShtYXRyaXgpOwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWQwZDFhYzUxNjNmMDU5ZGQ3MGZl MTFmZmJjMjNhNmQ5N2JhNWQ3Ni4uYmE5YzI0NDA3ODM2NTdlYTVmZjY0ZjQyMTRmODczMjQzMWQw NTU0ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA0LTA4ICBBZGVuaWxzb24gQ2F2YWxj YW50aSAgPGNhdmFsY2FudGlpQGdtYWlsLmNvbT4KKworICAgICAgICBbU1ZHXSBGaXggQ1NTIHRy YW5zZm9ybSBoYW5kbGluZyB3aGVuIHpvb21lZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1ODM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRqdXN0cyBDU1MgdHJhbnNmb3JtcyB3aGVuIHVzZWQgaW4g U1ZHIHRvIGFjY291bnQgZm9yIHVuZXhwZWN0ZWQKKyAgICAgICAgdHJhbnNsYXRpb24gc2NhbGUu IEJhY2twb3J0IGZyb20gQ2hyb21pdW0gIzE3NDkxMC4KKworICAgICAgICAqIHN2Zy96b29tL3Bh Z2Uvem9vbS1jc3MtdHJhbnNmb3Jtcy1leHBlY3RlZC5zdmc6IEFkZGVkLgorICAgICAgICAqIHN2 Zy96b29tL3BhZ2Uvem9vbS1jc3MtdHJhbnNmb3Jtcy5zdmc6IEFkZGVkLgorCiAyMDE0LTA0LTA4 ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKICAgICAgICAg W1NPVVBdIENvbnRyb2wgY29va2llIG1hbmFnZW1lbnQgYWNjb3JkaW5nIFJlc291cmNlUmVxdWVz dC5hbGxvd0Nvb2tpZXMoKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3ZnL3pvb20vcGFnZS96 b29tLWNzcy10cmFuc2Zvcm1zLWV4cGVjdGVkLnN2ZyBiL0xheW91dFRlc3RzL3N2Zy96b29tL3Bh Z2Uvem9vbS1jc3MtdHJhbnNmb3Jtcy1leHBlY3RlZC5zdmcKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uY2YxZTQzYmRl Y2QyZTQ0ZmQyOWVhYmM1OGFiMjEyNTE0Yjk0YWJhZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL3N2Zy96b29tL3BhZ2Uvem9vbS1jc3MtdHJhbnNmb3Jtcy1leHBlY3RlZC5zdmcKQEAg LTAsMCArMSwyNyBAQAorPHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHht bG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIiBvbmxvYWQ9ImZvcmNlU3R5 bGVSZWNhbGMoKTtyZXBhaW50VGVzdCgpOyI+CisgIDxnIHRyYW5zZm9ybT0idHJhbnNsYXRlKDUw LCA1MCkiPgorICAgIDxyZWN0IHdpZHRoPSIxMDAiIGhlaWdodD0iMTAwIiBmaWxsPSJncmVlbiIv PgorICA8L2c+CisKKyAgPGcgdHJhbnNmb3JtPSJ0cmFuc2xhdGUoMjUwLCAzNSkgcm90YXRlKDQ1 KSI+CisgICAgPHJlY3Qgd2lkdGg9IjEwMCIgaGVpZ2h0PSIxMDAiIGZpbGw9ImdyZWVuIi8+Cisg IDwvZz4KKworICA8ZyB0cmFuc2Zvcm09InRyYW5zbGF0ZSgzMDAsIDM1KSBza2V3WCgzNSkgc2tl d1koMzUpIj4KKyAgICA8cmVjdCB3aWR0aD0iMTAwIiBoZWlnaHQ9IjEwMCIgZmlsbD0iZ3JlZW4i Lz4KKyAgPC9nPgorCisgIDxnIHRyYW5zZm9ybT0idHJhbnNsYXRlKDUwLCAyNTApIHNrZXdYKDM1 KSI+CisgICAgPHJlY3Qgd2lkdGg9IjEwMCIgaGVpZ2h0PSIxMDAiIGZpbGw9ImdyZWVuIi8+Cisg IDwvZz4KKworICA8ZyB0cmFuc2Zvcm09InRyYW5zbGF0ZSgzNTAsIDIzNSkgc2tld1koMzUpIj4K KyAgICA8cmVjdCB3aWR0aD0iMTAwIiBoZWlnaHQ9IjEwMCIgZmlsbD0iZ3JlZW4iLz4KKyAgPC9n PgorCisgIDxkZWZzPgorICAgIDxzY3JpcHQ+dmFyIHpvb21Db3VudCA9IDI7PC9zY3JpcHQ+Cisg ICAgPHNjcmlwdCB4bGluazpocmVmPSIuLi8uLi8uLi9mYXN0L3JlcGFpbnQvcmVzb3VyY2VzL3Rl eHQtYmFzZWQtcmVwYWludC5qcyIvPgorICAgIDxzY3JpcHQgeGxpbms6aHJlZj0iLi4vcmVzb3Vy Y2VzL3Rlc3RQYWdlWm9vbS5qcyIvPgorICA8L2RlZnM+Cis8L3N2Zz4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3N2Zy96b29tL3BhZ2Uvem9vbS1jc3MtdHJhbnNmb3Jtcy5zdmcgYi9MYXlvdXRU ZXN0cy9zdmcvem9vbS9wYWdlL3pvb20tY3NzLXRyYW5zZm9ybXMuc3ZnCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjRk YTBmN2ZjY2FhM2QzMTg2ZTQ0Y2Y0NGMwZTM3ZjQwNmM4MjBhOTkKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9zdmcvem9vbS9wYWdlL3pvb20tY3NzLXRyYW5zZm9ybXMuc3ZnCkBAIC0w LDAgKzEsMjcgQEAKKzxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxu czp4bGluaz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluayIgb25sb2FkPSJmb3JjZVN0eWxl UmVjYWxjKCk7cmVwYWludFRlc3QoKTsiPgorICA8ZyBzdHlsZT0iLXdlYmtpdC10cmFuc2Zvcm06 IHRyYW5zbGF0ZSg1MHB4LCA1MHB4KTsiPgorICAgIDxyZWN0IHdpZHRoPSIxMDAiIGhlaWdodD0i MTAwIiBmaWxsPSJncmVlbiIvPgorICA8L2c+CisKKyAgPGcgc3R5bGU9Ii13ZWJraXQtdHJhbnNm b3JtOiB0cmFuc2xhdGUoMjUwcHgsIDM1cHgpIHJvdGF0ZSg0NWRlZyk7Ij4KKyAgICA8cmVjdCB3 aWR0aD0iMTAwIiBoZWlnaHQ9IjEwMCIgZmlsbD0iZ3JlZW4iLz4KKyAgPC9nPgorCisgIDxnIHN0 eWxlPSItd2Via2l0LXRyYW5zZm9ybTogdHJhbnNsYXRlKDMwMHB4LCAzNXB4KSBza2V3WCgzNWRl Zykgc2tld1koMzVkZWcpOyI+CisgICAgPHJlY3Qgd2lkdGg9IjEwMCIgaGVpZ2h0PSIxMDAiIGZp bGw9ImdyZWVuIi8+CisgIDwvZz4KKworICA8ZyBzdHlsZT0iLXdlYmtpdC10cmFuc2Zvcm06IHRy YW5zbGF0ZSg1MHB4LCAyNTBweCkgc2tld1goMzVkZWcpOyI+CisgICAgPHJlY3Qgd2lkdGg9IjEw MCIgaGVpZ2h0PSIxMDAiIGZpbGw9ImdyZWVuIi8+CisgIDwvZz4KKworICA8ZyBzdHlsZT0iLXdl YmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZSgzNTBweCwgMjM1cHgpIHNrZXdZKDM1ZGVnKTsiPgor ICAgIDxyZWN0IHdpZHRoPSIxMDAiIGhlaWdodD0iMTAwIiBmaWxsPSJncmVlbiIvPgorICA8L2c+ CisKKyAgPGRlZnM+CisgICAgPHNjcmlwdD52YXIgem9vbUNvdW50ID0gMjs8L3NjcmlwdD4KKyAg ICA8c2NyaXB0IHhsaW5rOmhyZWY9Ii4uLy4uLy4uL2Zhc3QvcmVwYWludC9yZXNvdXJjZXMvdGV4 dC1iYXNlZC1yZXBhaW50LmpzIi8+CisgICAgPHNjcmlwdCB4bGluazpocmVmPSIuLi9yZXNvdXJj ZXMvdGVzdFBhZ2Vab29tLmpzIi8+CisgIDwvZGVmcz4gIAorPC9zdmc+Cg==