125825 2013-12-16 18:47:57 -0800 Clearing 'dir' attribute does not correctly set page directionality 2013-12-20 00:36:25 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 125830 BlinkMergeCandidate P2 Normal --- 1 rniwa webkit-unassigned hiremathprashants jose.lejin kling koivisto mitz mmaxfield oldest_to_newest 960355 0 rniwa 2013-12-16 18:47:57 -0800 Merge https://chromium.googlesource.com/chromium/blink/+/2d592d1c998bec9438e421e1ce1ee6caba05a884 The dir attribute by default resolves to ltr. After its set to rtl, clearing it should cause it to once again resolve to its default, ltr. This patch makes this change from the current behavior where the rtl persists the clear. 960909 1 hiremathprashants 2013-12-18 05:33:49 -0800 I will be submitting patch soon. 960911 2 219528 hiremathprashants 2013-12-18 05:47:55 -0800 Created attachment 219528 Patch proposed patch 961263 3 rniwa 2013-12-18 21:24:20 -0800 *** This bug has been marked as a duplicate of bug 125830 *** 961265 4 219528 rniwa 2013-12-18 21:24:40 -0800 Comment on attachment 219528 Patch This has been merged already. 961774 5 hiremathprashants 2013-12-20 00:36:25 -0800 https://bugs.webkit.org/show_bug.cgi?id=125830 do not solve this issue hence created new bug https://bugs.webkit.org/show_bug.cgi?id=126057 . 219528 2013-12-18 05:47:55 -0800 2013-12-18 21:24:40 -0800 Patch bug-125825-20131218191750.patch text/plain 5706 hiremathprashants SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MDc2MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTEyLTE4ICBQcmFzaGFu dCBIaXJlbWF0aCAgPGhpcmVtYXRocHJhc2hhbnRzQGdtYWlsLmNvbT4KKworICAgICAgICBDbGVh cmluZyAnZGlyJyBhdHRyaWJ1dGUgZG9lcyBub3QgY29ycmVjdGx5IHNldCBwYWdlIGRpcmVjdGlv bmFsaXR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjU4MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU ZXN0OiBmYXN0L2RvbS9BdHRyL2RpcmVjdGlvbi1hdHRyaWJ1dGUtc2V0LWFuZC1jbGVhcmVkLmh0 bWwKKyAKKyAgICAgICAgKiBodG1sL0hUTUxFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OmlzVmFsaWREaXJBdHRyaWJ1dGUpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEVsZW1lbnQ6OmNv bGxlY3RTdHlsZUZvclByZXNlbnRhdGlvbkF0dHJpYnV0ZSk6CisgICAgICAgIChXZWJDb3JlOjpI VE1MRWxlbWVudDo6ZGlyZWN0aW9uYWxpdHkpOgorICAgCiAyMDEzLTEyLTE4ICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBG aXggbWFrZSBkaXN0Y2hlY2suCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmNwcAko cmV2aXNpb24gMTYwNzYwKQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE2Miw5ICsxNjIsMTAgQEAgYm9vbCBIVE1MRWxlbWVudDo6aXNQ cmVzZW50YXRpb25BdHRyaWJ1dAogICAgIHJldHVybiBTdHlsZWRFbGVtZW50Ojppc1ByZXNlbnRh dGlvbkF0dHJpYnV0ZShuYW1lKTsKIH0KIAotc3RhdGljIGJvb2wgaXNMVFJPclJUTElnbm9yaW5n Q2FzZShjb25zdCBBdG9taWNTdHJpbmcmIGRpckF0dHJpYnV0ZVZhbHVlKQorc3RhdGljIGlubGlu ZSBib29sIGlzVmFsaWREaXJBdHRyaWJ1dGUoY29uc3QgQXRvbWljU3RyaW5nJiB2YWx1ZSkKIHsK LSAgICByZXR1cm4gZXF1YWxJZ25vcmluZ0Nhc2UoZGlyQXR0cmlidXRlVmFsdWUsICJydGwiKSB8 fCBlcXVhbElnbm9yaW5nQ2FzZShkaXJBdHRyaWJ1dGVWYWx1ZSwgImx0ciIpOworICAgIHJldHVy biBlcXVhbElnbm9yaW5nQ2FzZSh2YWx1ZSwgImF1dG8iKSB8fCBlcXVhbElnbm9yaW5nQ2FzZSh2 YWx1ZSwgImx0ciIpIAorICAgIHx8IGVxdWFsSWdub3JpbmdDYXNlKHZhbHVlLCAicnRsIik7CiB9 CiAKIHZvaWQgSFRNTEVsZW1lbnQ6OmNvbGxlY3RTdHlsZUZvclByZXNlbnRhdGlvbkF0dHJpYnV0 ZShjb25zdCBRdWFsaWZpZWROYW1lJiBuYW1lLCBjb25zdCBBdG9taWNTdHJpbmcmIHZhbHVlLCBN dXRhYmxlU3R5bGVQcm9wZXJ0aWVzJiBzdHlsZSkKQEAgLTIwNSw4ICsyMDYsOCBAQCB2b2lkIEhU TUxFbGVtZW50Ojpjb2xsZWN0U3R5bGVGb3JQcmVzZW50CiAgICAgICAgIGlmIChlcXVhbElnbm9y aW5nQ2FzZSh2YWx1ZSwgImF1dG8iKSkKICAgICAgICAgICAgIGFkZFByb3BlcnR5VG9QcmVzZW50 YXRpb25BdHRyaWJ1dGVTdHlsZShzdHlsZSwgQ1NTUHJvcGVydHlVbmljb2RlQmlkaSwgdW5pY29k ZUJpZGlBdHRyaWJ1dGVGb3JEaXJBdXRvKCp0aGlzKSk7CiAgICAgICAgIGVsc2UgewotICAgICAg ICAgICAgaWYgKGlzTFRST3JSVExJZ25vcmluZ0Nhc2UodmFsdWUpKQotICAgICAgICAgICAgICAg IGFkZFByb3BlcnR5VG9QcmVzZW50YXRpb25BdHRyaWJ1dGVTdHlsZShzdHlsZSwgQ1NTUHJvcGVy dHlEaXJlY3Rpb24sIHZhbHVlKTsKKyAgICAgICAgICAgIEF0b21pY1N0cmluZyBkaXJWYWx1ZSA9 IGlzVmFsaWREaXJBdHRyaWJ1dGUodmFsdWUpID8gdmFsdWUgOiAibHRyIjsKKyAgICAgICAgICAg IGFkZFByb3BlcnR5VG9QcmVzZW50YXRpb25BdHRyaWJ1dGVTdHlsZShzdHlsZSwgQ1NTUHJvcGVy dHlEaXJlY3Rpb24sIGRpclZhbHVlKTsKICAgICAgICAgICAgIGlmICghaGFzVGFnTmFtZShiZGlU YWcpICYmICFoYXNUYWdOYW1lKGJkb1RhZykgJiYgIWhhc1RhZ05hbWUob3V0cHV0VGFnKSkKICAg ICAgICAgICAgICAgICBhZGRQcm9wZXJ0eVRvUHJlc2VudGF0aW9uQXR0cmlidXRlU3R5bGUoc3R5 bGUsIENTU1Byb3BlcnR5VW5pY29kZUJpZGksIENTU1ZhbHVlRW1iZWQpOwogICAgICAgICB9CkBA IC04ODMsNyArODg0LDcgQEAgVGV4dERpcmVjdGlvbiBIVE1MRWxlbWVudDo6ZGlyZWN0aW9uYWxp dAogICAgICAgICAvLyBTa2lwIGVsZW1lbnRzIHdpdGggdmFsaWQgZGlyIGF0dHJpYnV0ZQogICAg ICAgICBpZiAobm9kZS0+aXNFbGVtZW50Tm9kZSgpKSB7CiAgICAgICAgICAgICBBdG9taWNTdHJp bmcgZGlyQXR0cmlidXRlVmFsdWUgPSB0b0VsZW1lbnQobm9kZSktPmZhc3RHZXRBdHRyaWJ1dGUo ZGlyQXR0cik7Ci0gICAgICAgICAgICBpZiAoaXNMVFJPclJUTElnbm9yaW5nQ2FzZShkaXJBdHRy aWJ1dGVWYWx1ZSkgfHwgZXF1YWxJZ25vcmluZ0Nhc2UoZGlyQXR0cmlidXRlVmFsdWUsICJhdXRv IikpIHsKKyAgICAgICAgICAgIGlmIChpc1ZhbGlkRGlyQXR0cmlidXRlKGRpckF0dHJpYnV0ZVZh bHVlKSkgewogICAgICAgICAgICAgICAgIG5vZGUgPSBOb2RlVHJhdmVyc2FsOjpuZXh0U2tpcHBp bmdDaGlsZHJlbihub2RlLCB0aGlzKTsKICAgICAgICAgICAgICAgICBjb250aW51ZTsKICAgICAg ICAgICAgIH0KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MDc2MCkKKysrIExheW91dFRlc3RzL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEyLTE4ICBQcmFzaGFu dCBIaXJlbWF0aCAgPGhpcmVtYXRocHJhc2hhbnRzQGdtYWlsLmNvbT4KKworICAgICAgICBDbGVh cmluZyAnZGlyJyBhdHRyaWJ1dGUgZG9lcyBub3QgY29ycmVjdGx5IHNldCBwYWdlIGRpcmVjdGlv bmFsaXR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjU4MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGZhc3QvZG9tL0F0dHIvZGlyZWN0aW9uLWF0dHJpYnV0ZS1zZXQtYW5kLWNsZWFyZWQtZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9BdHRyL2RpcmVjdGlvbi1hdHRyaWJ1 dGUtc2V0LWFuZC1jbGVhcmVkLmh0bWw6IEFkZGVkLgorCiAyMDEzLTEyLTE4ICBNaWNoYcWCIFBh a3XFgmEgdmVsIFJ1dGthICA8bS5wYWt1bGFAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCBFRkwgZ2FyZGVuaW5nCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9BdHRyL2RpcmVj dGlvbi1hdHRyaWJ1dGUtc2V0LWFuZC1jbGVhcmVkLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9BdHRyL2RpcmVjdGlvbi1hdHRyaWJ1dGUtc2V0LWFuZC1j bGVhcmVkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9t L0F0dHIvZGlyZWN0aW9uLWF0dHJpYnV0ZS1zZXQtYW5kLWNsZWFyZWQtZXhwZWN0ZWQudHh0CSh3 b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsOSBAQAorVGhpcyB0ZXN0cyB0aGF0IHNldHRpbmcgdGhl IGRpciBhdHRyaWJ1dGUgdG8gcnRsIGFuZCBjbGVhcmluZyBpdCBkZWZhdWx0cyB0byBsdHIuCisK K09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZv bGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBp cyB0cnVlCisKK1RFU1QgQ09NUExFVEUKK1BBU1Mgd2luZG93LmdldENvbXB1dGVkU3R5bGUoZG9j dW1lbnQuYm9keSkuZGlyZWN0aW9uIGlzICJsdHIiCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9BdHRyL2RpcmVjdGlvbi1hdHRyaWJ1dGUtc2V0LWFuZC1jbGVhcmVkLmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vQXR0ci9kaXJlY3Rpb24tYXR0cmlidXRlLXNldC1h bmQtY2xlYXJlZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vQXR0 ci9kaXJlY3Rpb24tYXR0cmlidXRlLXNldC1hbmQtY2xlYXJlZC5odG1sCSh3b3JraW5nIGNvcHkp CkBAIC0wLDAgKzEsMTcgQEAKKzwhZG9jdHlwZSBodG1sPgorPGh0bWw+Cis8c2NyaXB0IHNyYz0i Li4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2lmICh3 aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKK2Rlc2Ny aXB0aW9uKCdUaGlzIHRlc3RzIHRoYXQgc2V0dGluZyB0aGUgZGlyIGF0dHJpYnV0ZSB0byBydGwg YW5kIGNsZWFyaW5nIGl0IGRlZmF1bHRzIHRvIGx0ci4nKTsKK29ubG9hZCA9IGZ1bmN0aW9uKCkg eworICAgIGRvY3VtZW50LmJvZHkuZGlyID0gJ3J0bCc7CisgICAgZG9jdW1lbnQuYm9keS5vZmZz ZXRUb3A7CisgICAgZG9jdW1lbnQuYm9keS5kaXIgPSAnJzsKKyAgICBzaG91bGRCZUVxdWFsVG9T dHJpbmcoJ3dpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmJvZHkpLmRpcmVjdGlvbics ICdsdHInKTsKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIu bm90aWZ5RG9uZSgpOworfQorPC9zY3JpcHQ+Cis8Ym9keT4KSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvZG9tL0F0dHIvZGlyZWN0aW9uLWF0dHJpYnV0ZS1zZXQtYW5kLWNsZWFyZWQuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9BdHRyL2RpcmVjdGlvbi1hdHRyaWJ1dGUt c2V0LWFuZC1jbGVhcmVkLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9BdHRyL2RpcmVjdGlvbi1hdHRyaWJ1dGUtc2V0LWFuZC1jbGVhcmVkLmh0bWwJKHdvcmtpbmcg Y29weSkKClByb3BlcnR5IGNoYW5nZXMgb246IExheW91dFRlc3RzL2Zhc3QvZG9tL0F0dHIvZGly ZWN0aW9uLWF0dHJpYnV0ZS1zZXQtYW5kLWNsZWFyZWQuaHRtbApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFkZGVkOiBz dm46ZXhlY3V0YWJsZQojIyAtMCwwICsxICMjCisqClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgcHJv cGVydHkK