12582 2007-02-04 07:46:26 -0800 REGRESSION: Unclosed <title> makes the window display garbage or empty title 2007-02-07 12:27:02 -0800 1 1 1 Unclassified WebKit Page Loading 420+ Mac OS X 10.4 RESOLVED FIXED InRadar, Regression P1 Normal --- 1 ap ap ddkilzer oldest_to_newest 28613 0 ap 2007-02-04 07:46:26 -0800 Steps to reproduce: reload the attached document several times. The window title will be blank, or will display garbage intermittently. The is a regression from shipping WebKit, where the file name is used as window title. 28599 1 12916 ap 2007-02-04 07:46:57 -0800 Created attachment 12916 test case 27654 2 mjs 2007-02-04 11:51:10 -0800 <rdar://problem/4975135> 27635 3 ddkilzer 2007-02-04 12:24:02 -0800 Similar/related to Bug 3905. 25381 4 mjs 2007-02-07 00:35:29 -0800 Does this affect real-world sites? 25389 5 ap 2007-02-07 01:22:18 -0800 > Does this affect real-world sites? I am not aware of any such sites. Discovered by accident when making a test case for another bug. 24916 6 13012 ap 2007-02-07 11:50:25 -0800 Created attachment 13012 proposed fix 24917 7 13012 darin 2007-02-07 11:56:22 -0800 Comment on attachment 13012 proposed fix How does this patch help? It looks to me like if i == length then the for loop won't do anything, the while loop won't do anything, and the following if statement will return "" anyway. So this patch would have no effect. 24919 8 13012 ap 2007-02-07 12:03:29 -0800 Comment on attachment 13012 proposed fix In this case, the if statement doesn't return "": (!builderIndex && stringBuilder[builderIndex] == ' ') is false when stringBuilder[0] equals '\n', for example. 24924 9 13012 darin 2007-02-07 12:19:10 -0800 Comment on attachment 13012 proposed fix OK. I'm convinced this is correct. Let me note in passing that I'm unhappy with the structure and readability of the function. It took me a really long time studying the code to understand why it's OK to look at stringBuilder[builderIndex] when builderIndex is 0, even though that's "off the end of the array". 24926 10 ap 2007-02-07 12:27:02 -0800 Committed revision 19473. 12916 2007-02-04 07:46:57 -0800 2007-02-04 07:46:57 -0800 test case empty-title.html text/html 64 ap PGh0bWw+CiAgPGhlYWQ+CiAgICA8dGl0bGU+CiAgPC9oZWFkPgogIDxib2R5PgogIDwvYm9keT4K PC9odG1sPg== 13012 2007-02-07 11:50:25 -0800 2007-02-07 12:19:10 -0800 proposed fix 12582r1_patch.txt text/plain 1260 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxOTQ2NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDctMDItMDcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTgyCisgICAgICAgIFJF R1JFU1NJT046IFVuY2xvc2VkIDx0aXRsZT4gbWFrZXMgdGhlIHdpbmRvdyBkaXNwbGF5IGdhcmJh Z2Ugb3IgZW1wdHkgdGl0bGUKKworICAgICAgICBBdXRvbWF0aWMgdGVzdGluZyBpcyBub3QgcG9z c2libGUsIGFuZCBtYW51YWwgdGVzdGluZyBwcm9iYWJseSBkb2Vzbid0IG1ha2Ugc2Vuc2UuCisK KyAgICAgICAgKiBsb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Y2Fub25pY2FsaXplZFRpdGxlKTogQmFpbCBvdXQgZWFybHkgaWYgdGhlIHBhc3NlZCBpbiBzdHJp bmcgaXMgYWxsIHdoaXRlc3BhY2UuCisKIDIwMDctMDItMDcgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluLgpJbmRleDogV2Vi Q29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbG9h ZGVyL0RvY3VtZW50TG9hZGVyLmNwcAkocmV2aXNpb24gMTk0NjYpCisrKyBXZWJDb3JlL2xvYWRl ci9Eb2N1bWVudExvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY3LDYgKzY3LDkgQEAgc3Rh dGljIGlubGluZSBTdHJpbmcgY2Fub25pY2FsaXplZFRpdGxlKAogICAgICAgICAgICAgYnJlYWs7 CiAgICAgfQogCisgICAgaWYgKGkgPT0gbGVuZ3RoKQorICAgICAgICByZXR1cm4gIiI7CisKICAg ICAvLyBSZXBsYWNlIGNvbnRyb2wgY2hhcmFjdGVycyB3aXRoIHNwYWNlcywgYW5kIGJhY2tzbGFz aGVzIHdpdGggY3VycmVuY3kgc3ltYm9scywgYW5kIGNvbGxhcHNlIHdoaXRlc3BhY2UuCiAgICAg Ym9vbCBwcmV2aW91c0NoYXJXYXNXUyA9IGZhbHNlOwogICAgIGZvciAoOyBpIDwgbGVuZ3RoOyAr K2kpIHsK