125808 2013-12-16 15:26:59 -0800 GraphicsContext3D too awesome for VS2013 2013-12-17 10:11:22 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC Windows 8 RESOLVED FIXED P2 Normal --- 1 alex.christensen webkit-unassigned commit-queue dino kondapallykalyan roger_fong oldest_to_newest 960254 0 alex.christensen 2013-12-16 15:26:59 -0800 When compiling GraphicsContext3D.cpp in VS2013, I get error C1063. http://msdn.microsoft.com/en-us/library/aa229021(v=vs.60).aspx Can GraphicsContext3D.cpp be split up at all? I thought maybe the pack functions could be put into one source file, the unpacks into another, but that would defeat the whole purpose of having these inline functions. Is there another logical division? 960356 1 219381 alex.christensen 2013-12-16 18:52:55 -0800 Created attachment 219381 Patch 960528 2 219381 darin 2013-12-17 09:10:56 -0800 Comment on attachment 219381 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219381&action=review > Source/WebCore/platform/graphics/GraphicsContext3D.cpp:1614 > +// Visual Studio crashes with a C1063 Fatal Error if this is inlined. > +#if COMPILER(MSVC) > +#define ALWAYS_INLINE_EXCEPT_MSVC > +#else > +#define ALWAYS_INLINE_EXCEPT_MSVC ALWAYS_INLINE > +#endif I’d stick this at the top of the file, not way down here. 960562 3 alex.christensen 2013-12-17 10:11:22 -0800 http://trac.webkit.org/changeset/160713 219381 2013-12-16 18:52:55 -0800 2013-12-17 09:10:55 -0800 Patch bug-125808-20131216195254.patch text/plain 1638 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MDY4OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEyLTE2ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dpbl0gVmlz dWFsIFN0dWRpbyB3b3JrYXJvdW5kIGZvciBjb21waWxpbmcgV2ViR0wuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU4MDgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dy YXBoaWNzQ29udGV4dDNELmNwcDoKKyAgICAgICAgRG9uJ3QgaW5saW5lIG91dGVybW9zdCBmdW5j dGlvbiB0byBwcmV2ZW50IFZpc3VhbCBTdHVkaW8gY3Jhc2guCisKIDIwMTMtMTItMTYgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgRW51bUNs YXNzLmggZnJvbSBXVEYKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dy YXBoaWNzQ29udGV4dDNELmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5jcHAJKHJldmlzaW9uIDE2MDY2NCkKKysrIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTYwNiw4ICsxNjA2LDE1IEBAIEFMV0FZU19JTkxJTkUgdm9pZCBGb3Jt YXRDb252ZXJ0ZXI6OmNvbnYKICN1bmRlZiBGT1JNQVRDT05WRVJURVJfQ0FTRV9BTFBIQU9QCiB9 CiAKKy8vIFZpc3VhbCBTdHVkaW8gY3Jhc2hlcyB3aXRoIGEgQzEwNjMgRmF0YWwgRXJyb3IgaWYg dGhpcyBpcyBpbmxpbmVkLgorI2lmIENPTVBJTEVSKE1TVkMpCisjZGVmaW5lIEFMV0FZU19JTkxJ TkVfRVhDRVBUX01TVkMKKyNlbHNlCisjZGVmaW5lIEFMV0FZU19JTkxJTkVfRVhDRVBUX01TVkMg QUxXQVlTX0lOTElORQorI2VuZGlmCisKIHRlbXBsYXRlPEdyYXBoaWNzQ29udGV4dDNEOjpEYXRh Rm9ybWF0IFNyY0Zvcm1hdCwgR3JhcGhpY3NDb250ZXh0M0Q6OkRhdGFGb3JtYXQgRHN0Rm9ybWF0 LCBHcmFwaGljc0NvbnRleHQzRDo6QWxwaGFPcCBhbHBoYU9wPgotQUxXQVlTX0lOTElORSB2b2lk IEZvcm1hdENvbnZlcnRlcjo6Y29udmVydCgpCitBTFdBWVNfSU5MSU5FX0VYQ0VQVF9NU1ZDIHZv aWQgRm9ybWF0Q29udmVydGVyOjpjb252ZXJ0KCkKIHsKICAgICAvLyBNYW55IGluc3RhbnRpYXRp b25zIG9mIHRoaXMgdGVtcGxhdGUgZnVuY3Rpb24gd2lsbCBuZXZlciBiZSBlbnRlcmVkLCBzbyB3 ZSB0cnkKICAgICAvLyB0byByZXR1cm4gaW1tZWRpYXRlbHkgaW4gdGhlc2UgY2FzZXMgdG8gYXZv aWQgdGhlIGNvbXBpbGVyIHRvIGdlbmVyYXRlIHVzZWxlc3MgY29kZS4K