125789 2013-12-16 11:00:20 -0800 CStack Branch: REGRESSION(r160600) ASSERT failure in Heap::collect() 2013-12-16 13:20:53 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 960136 0 msaboff 2013-12-16 11:00:20 -0800 ASSERTION FAILED: vm()->currentThreadIsHoldingAPILock() /Volumes/Data/src/webkit.cstack/Source/JavaScriptCore/heap/Heap.cpp(755) : void JSC::Heap::collect(JSC::Heap::SweepToggle) 1 0x1006c5700 WTFCrash 2 0x10034fdf2 JSC::Heap::collect(JSC::Heap::SweepToggle) 3 0x10034e694 JSC::Heap::collectIfNecessaryOrDefer() 4 0x10012467f JSC::CopiedSpace::allocateBlock() 5 0x1001230ef JSC::CopiedSpace::init() 6 0x10034e209 JSC::Heap::Heap(JSC::VM*, JSC::HeapType) 7 0x10034df63 JSC::Heap::Heap(JSC::VM*, JSC::HeapType) 8 0x100666033 JSC::VM::VM(JSC::VM::VMType, JSC::HeapType) 9 0x100665f31 JSC::VM::VM(JSC::VM::VMType, JSC::HeapType) 10 0x100668a2e JSC::VM::create(JSC::HeapType) 11 0x100001993 jscmain(int, char**) 12 0x1000018b6 main 13 0x7fff93a6e5fd start 14 0x2 We don't have the API lock because we are still initializing the VM. We should try collecting since we haven't allocated anything. I think we need to put the shouldCollect() check back in collectIfNecessaryOrDefer(). 960143 1 219333 msaboff 2013-12-16 11:04:37 -0800 Created attachment 219333 Patch 960190 2 219333 mark.lam 2013-12-16 12:56:14 -0800 Comment on attachment 219333 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219333&action=review > Source/JavaScriptCore/ChangeLog:8 > + Restored the chouldCollect() check so we don't collect on start up. typo: chouldCollect() ==> shouldCollect(). 960194 3 219333 ggaren 2013-12-16 13:08:56 -0800 Comment on attachment 219333 Patch r=me 960198 4 msaboff 2013-12-16 13:20:53 -0800 Committed r160658: <http://trac.webkit.org/changeset/160658> 219333 2013-12-16 11:04:37 -0800 2013-12-16 13:08:56 -0800 Patch 125789.patch text/plain 1309 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwNjQ5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEzLTEyLTE2ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENTdGFjayBCcmFuY2g6IFJFR1JFU1NJT04ocjE2MDYwMCkgQVNTRVJUIGZhaWx1cmUgaW4g SGVhcDo6Y29sbGVjdCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjU3ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBSZXN0b3JlZCB0aGUgY2hvdWxkQ29sbGVjdCgpIGNoZWNrIHNvIHdlIGRvbid0IGNv bGxlY3Qgb24gc3RhcnQgdXAuCisgICAgICAgIEVsaW1pbmF0ZWQgdGhlIE9wdGlvbnM6OmRpc2Fi bGVHQygpIGNoZWNrIHNpbmNlIGl0IGlzIHBhcnQgb2YgdGhlIAorICAgICAgICBpc0RlZmVycmVk KCkgY2hlY2suCisgICAgICAgIAorCisgICAgICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAg KEpTQzo6SGVhcDo6Y29sbGVjdElmTmVjZXNzYXJ5T3JEZWZlcik6CisKIDIwMTMtMTItMTQgIEZp bGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBGVEwgc2hvdWxkICpyZWFs bHkqIGtub3cgd2hlbiB0aGluZ3MgYXJlIGZsdXNoZWQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9oZWFwL0hlYXAuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9o ZWFwL0hlYXAuY3BwCShyZXZpc2lvbiAxNjA2NDEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9IZWFwLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODc3LDEwICs4NzcsMTAgQEAgYm9vbCBI ZWFwOjpjb2xsZWN0SWZOZWNlc3NhcnlPckRlZmVyKCkKIHsKICAgICBpZiAoaXNEZWZlcnJlZCgp KQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgCi0gICAgaWYgKE9wdGlvbnM6OmRpc2FibGVH QygpKQorCisgICAgaWYgKCFzaG91bGRDb2xsZWN0KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsK LSAgICAKKwogICAgIGNvbGxlY3QoRG9Ob3RTd2VlcCk7CiAgICAgcmV0dXJuIHRydWU7CiB9Cg==