125785 2013-12-16 10:17:18 -0800 Additional refinement in MathMLSelectElement toggle implementation 2013-12-18 09:58:58 -0800 1 1 1 Unclassified WebKit MathML 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 120059 1 darin darin commit-queue dbarton fred.wang mrobinson oldest_to_newest 960112 0 darin 2013-12-16 10:17:18 -0800 Additional refinement in MathMLSelectElement toggle implementation 960114 1 219326 darin 2013-12-16 10:19:26 -0800 Created attachment 219326 Patch 960116 2 219326 darin 2013-12-16 10:21:55 -0800 Comment on attachment 219326 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219326&action=review > Source/WebCore/mathml/MathMLSelectElement.cpp:161 > // We update the attribute value of the selection attribute. > // This will also call MathMLSelectElement::attributeChanged to update the selected child. I should probably cut down this comment, too. It spends too many words restating exactly what the code below says, and should limit itself to the non-obvious part. 960871 3 219326 kling 2013-12-18 02:18:12 -0800 Comment on attachment 219326 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219326&action=review r=me >> Source/WebCore/mathml/MathMLSelectElement.cpp:161 >> // This will also call MathMLSelectElement::attributeChanged to update the selected child. > > I should probably cut down this comment, too. It spends too many words restating exactly what the code below says, and should limit itself to the non-obvious part. Your choice. Leaving cq? set. 960957 4 219326 darin 2013-12-18 09:32:08 -0800 Comment on attachment 219326 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219326&action=review >>> Source/WebCore/mathml/MathMLSelectElement.cpp:161 >>> // This will also call MathMLSelectElement::attributeChanged to update the selected child. >> >> I should probably cut down this comment, too. It spends too many words restating exactly what the code below says, and should limit itself to the non-obvious part. > > Your choice. Leaving cq? set. I’ll come back and do that later. 960965 5 219326 commit-queue 2013-12-18 09:58:56 -0800 Comment on attachment 219326 Patch Clearing flags on attachment: 219326 Committed r160771: <http://trac.webkit.org/changeset/160771> 960966 6 commit-queue 2013-12-18 09:58:58 -0800 All reviewed patches have been landed. Closing bug. 219326 2013-12-16 10:19:26 -0800 2013-12-18 09:58:56 -0800 Patch bug-125785-20131216101928.patch text/plain 5168 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwNjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmI2NjA5N2ZjODFhOTY0 ODU4OTA4YmYxYzFiZTdkNzY0ZTQ1MzNiZC4uYjhmZjBlNTMxNjI0YmE5NGE1MmZjZGZmN2IxMTll OTcwNWJjMWJiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTEyLTE2ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBBZGRpdGlvbmFsIHJlZmluZW1l bnQgaW4gTWF0aE1MU2VsZWN0RWxlbWVudCB0b2dnbGUgaW1wbGVtZW50YXRpb24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTc4NQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbWF0aG1sL01hdGhNTFNl bGVjdEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWF0aE1MU2VsZWN0RWxlbWVudDo6 ZGVmYXVsdEV2ZW50SGFuZGxlcik6IENhbGwgc2V0RGVmYXVsdEhhbmRsZWQKKyAgICAgICAgc28g dGhpcyB3aWxsIGJlIGhhbmRsZWQgYnkgb25seSBvbmUgZWxlbWVudC4KKyAgICAgICAgKFdlYkNv cmU6Ok1hdGhNTFNlbGVjdEVsZW1lbnQ6OndpbGxSZXNwb25kVG9Nb3VzZUNsaWNrRXZlbnRzKTog UmV0dXJuIHRydWUKKyAgICAgICAgb25seSB3aGVuIGFjdGlvbiBpcyBzZXQgdG8gdG9nZ2xlLCBz aW5jZSBvdGhlciBzZWxlY3QgZWxlbWVudHMgd2lsbCBub3QKKyAgICAgICAgcmVzcG9uZCB0byBt b3VzZSBjbGljayBldmVudHMuCisgICAgICAgIChXZWJDb3JlOjpNYXRoTUxTZWxlY3RFbGVtZW50 Ojp0b2dnbGUpOiBTaW1wbGlmaWVkIGNvZGUgYSBiaXQgYW5kIGdhdmUKKyAgICAgICAgbG9jYWwg YSBjbGVhcmVyIHZhcmlhYmxlIG5hbWUuCisKIDIwMTMtMTItMTUgIERhcmluIEFkbGVyICA8ZGFy aW5AYXBwbGUuY29tPgogCiAgICAgICAgIENhdGNoIGNhbGxlcnMgd2hvIGZvcmdldCB0byB1c2Ug aW5pdGlhbGl6ZVN0eWxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9tYXRobWwvTWF0aE1M U2VsZWN0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9tYXRobWwvTWF0aE1MU2VsZWN0RWxl bWVudC5jcHAKaW5kZXggMGIyMTViZjQwMmE4M2ZlZTgzNTdiMDhmNDk4NmJiMzEwOWY0NjQyNS4u ZmFhYmRmY2I3MmJmMzhhNDc4Mjg5YTc1NGNkOWI4ZTY2NTFiNGQ1NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvbWF0aG1sL01hdGhNTFNlbGVjdEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL21hdGhtbC9NYXRoTUxTZWxlY3RFbGVtZW50LmNwcApAQCAtMTM1LDYgKzEzNSw3IEBA IHZvaWQgTWF0aE1MU2VsZWN0RWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCogZXZl bnQpCiAgICAgaWYgKGV2ZW50LT50eXBlKCkgPT0gZXZlbnROYW1lcygpLmNsaWNrRXZlbnQpIHsK ICAgICAgICAgaWYgKGZhc3RHZXRBdHRyaWJ1dGUoTWF0aE1MTmFtZXM6OmFjdGlvbnR5cGVBdHRy KSA9PSAidG9nZ2xlIikgewogICAgICAgICAgICAgdG9nZ2xlKCk7CisgICAgICAgICAgICBldmVu dC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQog ICAgIH0KQEAgLTE0NCwyMyArMTQ1LDIxIEBAIHZvaWQgTWF0aE1MU2VsZWN0RWxlbWVudDo6ZGVm YXVsdEV2ZW50SGFuZGxlcihFdmVudCogZXZlbnQpCiAKIGJvb2wgTWF0aE1MU2VsZWN0RWxlbWVu dDo6d2lsbFJlc3BvbmRUb01vdXNlQ2xpY2tFdmVudHMoKQogewotICAgIHJldHVybiB0cnVlOwor ICAgIHJldHVybiBmYXN0R2V0QXR0cmlidXRlKE1hdGhNTE5hbWVzOjphY3Rpb250eXBlQXR0cikg PT0gInRvZ2dsZSI7CiB9CiAKIHZvaWQgTWF0aE1MU2VsZWN0RWxlbWVudDo6dG9nZ2xlKCkKIHsK LSAgICAvLyBXZSBkZXRlcm1pbmUgdGhlIHN1Y2Nlc3NvciBvZiB0aGUgc2VsZWN0ZWQgY2hpbGQu Ci0gICAgLy8gSWYgd2UgcmVhY2ggdGhlIGVuZCBvZiB0aGUgY2hpbGQgbGlzdCwgd2UgZ28gYmFj ayB0byB0aGUgZmlyc3QgY2hpbGQuCi0gICAgRWxlbWVudCogY2hpbGQgPSBudWxscHRyOwotICAg IGludCBzZWxlY3Rpb24gPSBnZXRTZWxlY3RlZENoaWxkQW5kSW5kZXgoY2hpbGQpOwotICAgIGlm ICghY2hpbGQgfHwgIWNoaWxkLT5uZXh0RWxlbWVudFNpYmxpbmcoKSkKLSAgICAgICAgc2VsZWN0 aW9uID0gMTsKLSAgICBlbHNlCi0gICAgICAgIHNlbGVjdGlvbisrOworICAgIC8vIFNlbGVjdCB0 aGUgc3VjY2Vzc29yIG9mIHRoZSBjdXJyZW50bHkgc2VsZWN0ZWQgY2hpbGQKKyAgICAvLyBvciB0 aGUgZmlyc3QgY2hpbGQgaWYgdGhlIGN1cnJlbnRseSBzZWxlY3RlZCBjaGlsZCBpcyB0aGUgbGFz dC4KKyAgICBFbGVtZW50KiBzZWxlY3RlZENoaWxkOworICAgIGludCBuZXdTZWxlY3RlZENoaWxk SW5kZXggPSBnZXRTZWxlY3RlZENoaWxkQW5kSW5kZXgoc2VsZWN0ZWRDaGlsZCkgKyAxOworICAg IGlmICghc2VsZWN0ZWRDaGlsZCB8fCAhc2VsZWN0ZWRDaGlsZC0+bmV4dEVsZW1lbnRTaWJsaW5n KCkpCisgICAgICAgIG5ld1NlbGVjdGVkQ2hpbGRJbmRleCA9IDE7CiAKICAgICAvLyBXZSB1cGRh dGUgdGhlIGF0dHJpYnV0ZSB2YWx1ZSBvZiB0aGUgc2VsZWN0aW9uIGF0dHJpYnV0ZS4KICAgICAv LyBUaGlzIHdpbGwgYWxzbyBjYWxsIE1hdGhNTFNlbGVjdEVsZW1lbnQ6OmF0dHJpYnV0ZUNoYW5n ZWQgdG8gdXBkYXRlIHRoZSBzZWxlY3RlZCBjaGlsZC4KLSAgICBzZXRBdHRyaWJ1dGUoTWF0aE1M TmFtZXM6OnNlbGVjdGlvbkF0dHIsIEF0b21pY1N0cmluZzo6bnVtYmVyKHNlbGVjdGlvbikpOwor ICAgIHNldEF0dHJpYnV0ZShNYXRoTUxOYW1lczo6c2VsZWN0aW9uQXR0ciwgQXRvbWljU3RyaW5n OjpudW1iZXIobmV3U2VsZWN0ZWRDaGlsZEluZGV4KSk7CiB9CiAKIH0KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhOWJmZTFk MWQzZmZkZDY1YTBjNzk1ZTliNTIwYzkyZmNhMGQ0M2UwLi44NGE2YjFkNDVjMDJlZTQxYTEyNDNi NGNmMGYwZjA3NjU1ZjIzZDdmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMTItMTYgIERh cmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIEFkZGl0aW9uYWwgcmVmaW5l bWVudCBpbiBNYXRoTUxTZWxlY3RFbGVtZW50IHRvZ2dsZSBpbXBsZW1lbnRhdGlvbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1Nzg1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBtYXRobWwvcHJlc2Vu dGF0aW9uL21hY3Rpb24tdG9nZ2xlLWV4cGVjdGVkLmh0bWw6IFVwZGF0ZWQgaW5jb3JyZWN0IGV4 cGVjdGVkCisgICAgICAgIHJlc3VsdCwgd2hpY2ggZXhwZWN0ZWQgYW4gYWxyZWFkeS1oYW5kbGVk IGV2ZW50IHRvIGJlIHJlLWhhbmRsZWQgYnkgYSBwYXJlbnQKKyAgICAgICAgZWxlbWVudCBkdXJp bmcgdGhlIGJ1YmJsaW5nIHByb2Nlc3MuCisgICAgICAgICogbWF0aG1sL3ByZXNlbnRhdGlvbi9t YWN0aW9uLXRvZ2dsZS5odG1sOiBEaXR0by4KKwogMjAxMy0xMi0xNiAgTWFyaW8gU2FuY2hleiBQ cmFkYSAgPG1hcmlvLnByYWRhQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtBVEtdIEV4cG9zZSBh Y2Nlc3NpYmlsaXR5IG9iamVjdHMgd2l0aCBBVEtfUk9MRV9DSEVDS19NRU5VX0lURU0KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL21hdGhtbC9wcmVzZW50YXRpb24vbWFjdGlvbi10b2dnbGUtZXhw ZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL21hdGhtbC9wcmVzZW50YXRpb24vbWFjdGlvbi10b2dn bGUtZXhwZWN0ZWQuaHRtbAppbmRleCA0NzFjZjJlZDc1YTIwNzMwMmMyZWM4ZTEwZmMzNWUyN2My ZGNkNWFhLi42OTkwMWQxNjM4NjdmMDliNDRjMDk3ODJhYzAwNGVhNWJlOGFmZWVkIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9tYXRobWwvcHJlc2VudGF0aW9uL21hY3Rpb24tdG9nZ2xlLWV4cGVj dGVkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWF0aG1sL3ByZXNlbnRhdGlvbi9tYWN0aW9uLXRv Z2dsZS1leHBlY3RlZC5odG1sCkBAIC05Niw3ICs5Niw3IEBACiAgICAgPCEtLSBOZXN0ZWQgPG1h Y3Rpb24+IGVsZW1lbnRzIDsgYnViYmxlID0gdHJ1ZSAtLT4KICAgICA8bWF0aD4KICAgICAgIDxt cm93PgotICAgICAgICA8bW4+NDwvbW4+CisgICAgICAgIDxtbj4yPC9tbj4KICAgICAgIDwvbXJv dz4KICAgICA8L21hdGg+CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21hdGhtbC9wcmVzZW50 YXRpb24vbWFjdGlvbi10b2dnbGUuaHRtbCBiL0xheW91dFRlc3RzL21hdGhtbC9wcmVzZW50YXRp b24vbWFjdGlvbi10b2dnbGUuaHRtbAppbmRleCAxODM5ZTc3MTBlNzVkM2NiMGI1NzgyNTI0NWFk ODIzZDE4YmRjYmE3Li5lOGYyZWMzMWI0MTQzMTg3MzJiZWQ2MjhjZmY4NjFmYTRiNGRiZDFiIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9tYXRobWwvcHJlc2VudGF0aW9uL21hY3Rpb24tdG9nZ2xl Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWF0aG1sL3ByZXNlbnRhdGlvbi9tYWN0aW9uLXRvZ2ds ZS5odG1sCkBAIC0zMyw3ICszMyw4IEBACiAgICAgICAgIGNsaWNrKCdtNCcsIGZhbHNlKTsKIAog ICAgICAgICAvLyBOZXN0ZWQgbWFjdGlvbiBlbGVtZW50cywgYnViYmxlID0gdHJ1ZSA7IChbKFsx XSAyIDMpXSA0IDUpCi0gICAgICAgIC8vIEFmdGVyIG9uZSBjbGljayBvbiB0aGUgaW5uZXIgbWFj dGlvbjogKCgxIFsyXSAzKSBbNF0gNSkKKyAgICAgICAgLy8gQWZ0ZXIgb25lIGNsaWNrIG9uIHRo ZSBpbm5lciBtYWN0aW9uOiAoWygxIFsyXSAzKV0gNCA1KQorICAgICAgICAvLyBCdWJibGluZyBz ZW5kcyB0aGUgZXZlbnQgdG8gb3V0ZXIgbWFjdGlvbiBoYW5kbGVycywgYnV0IGRlZmF1bHQgaGFu ZGxpbmcgaXMgZG9uZSBvbmx5IG9uY2UuCiAgICAgICAgIGNsaWNrKCdtNScsIHRydWUpOwogCiAg ICAgICAgIC8vIFByZXZlbnQgZGVmYXVsdCA7IChbMV0gMiAzKQo=