125784 2013-12-16 09:26:21 -0800 [iOS] Upstream WebCore/svg changes 2013-12-16 15:24:33 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbates dbates aestes commit-queue ddkilzer d-r fmalita gyuyoung.kim pdr schenney thorton zimmermann oldest_to_newest 960083 0 dbates 2013-12-16 09:26:21 -0800 Upstream the iOS related changes to WebCore/svg. 960084 1 219323 dbates 2013-12-16 09:28:53 -0800 Created attachment 219323 Patch 960092 2 219323 darin 2013-12-16 09:44:48 -0800 Comment on attachment 219323 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219323&action=review > Source/WebCore/svg/SVGAElement.cpp:239 > +#if PLATFORM(IOS) > +bool SVGAElement::willRespondToMouseClickEvents() I see no reason for this to be iOS-specific. Seems like we want it on all platforms. > Source/WebCore/svg/SVGAElement.cpp:241 > + return !href().isEmpty() || SVGGraphicsElement::willRespondToMouseClickEvents(); Should check isLink() rather than !href().isEmpty(). > Source/WebCore/svg/SVGElement.cpp:494 > +#if ENABLE(TOUCH_EVENTS) && PLATFORM(IOS) Not sure I understand why the PLATFORM(IOS) is here. 960251 3 dbates 2013-12-16 15:21:32 -0800 (In reply to comment #2) > (From update of attachment 219323 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219323&action=review > > > Source/WebCore/svg/SVGAElement.cpp:239 > > +#if PLATFORM(IOS) > > +bool SVGAElement::willRespondToMouseClickEvents() > > I see no reason for this to be iOS-specific. Seems like we want it on all platforms. Will compile for all platforms. > > > Source/WebCore/svg/SVGAElement.cpp:241 > > + return !href().isEmpty() || SVGGraphicsElement::willRespondToMouseClickEvents(); > > Should check isLink() rather than !href().isEmpty(). Will substitute isLink() for !href().isEmpty(). > > > Source/WebCore/svg/SVGElement.cpp:494 > > +#if ENABLE(TOUCH_EVENTS) && PLATFORM(IOS) > > Not sure I understand why the PLATFORM(IOS) is here. Will remove conjunct PLATFORM(IOS). 960252 4 dbates 2013-12-16 15:24:33 -0800 Committed r160668: <http://trac.webkit.org/changeset/160668> 219323 2013-12-16 09:28:53 -0800 2013-12-16 09:44:48 -0800 Patch bug-125784-20131216092853.patch text/plain 3933 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwNjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzZjZmI4NzFlYmU5YjQy MTY4MjA5Zjk5Y2E1ZTI2MGJlNzIxYmE4Zi4uMzI0YjQ1YzBiNzEzMjc1NWQ3MzRiNjkwZDMxOTMy NzdjMTI3ZWRjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTEyLTE2ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBVcHN0cmVhbSBX ZWJDb3JlL3N2ZyBjaGFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjU3ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHN2Zy9TVkdBRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdB RWxlbWVudDo6d2lsbFJlc3BvbmRUb01vdXNlQ2xpY2tFdmVudHMpOiBBZGRlZDsgaU9TLXNwZWNp ZmljLgorICAgICAgICAqIHN2Zy9TVkdBRWxlbWVudC5oOgorICAgICAgICAqIHN2Zy9TVkdFbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR0VsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKTog QWRkZWQgYXR0cmlidXRlIGxpc3RlbmVycyBmb3IgdG91Y2h7Y2FuY2VsLCBlbmQsIG1vdmUsIHN0 YXJ0fSwKKyAgICAgICAgYW5kIGdlc3R1cmV7Y2hhbmdlLCBlbmQsIHN0YXJ0fS4KKwogMjAxMy0x Mi0xNSAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10g VXBzdHJlYW0gV2ViQ29yZS9oaXN0b3J5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcv U1ZHQUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0FFbGVtZW50LmNwcAppbmRl eCBjYmQzZmI3Y2VkNzliMDFiMTVkYTkwYmYzMWQxZGFiNzJjZGM3NjAxLi5kZDc2MTVjMDVmOTNm ZDE4MTRiZWFiZjUwYTQ2NjQ2YTc5MjQ4MGZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9z dmcvU1ZHQUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdBRWxlbWVudC5j cHAKQEAgLTIzNCw2ICsyMzQsMTMgQEAgYm9vbCBTVkdBRWxlbWVudDo6Y2hpbGRTaG91bGRDcmVh dGVSZW5kZXJlcihjb25zdCBOb2RlJiBjaGlsZCkgY29uc3QKIAogICAgIHJldHVybiBTVkdFbGVt ZW50OjpjaGlsZFNob3VsZENyZWF0ZVJlbmRlcmVyKGNoaWxkKTsKIH0KKyAgICAKKyNpZiBQTEFU Rk9STShJT1MpCitib29sIFNWR0FFbGVtZW50Ojp3aWxsUmVzcG9uZFRvTW91c2VDbGlja0V2ZW50 cygpCit7IAorICAgIHJldHVybiAhaHJlZigpLmlzRW1wdHkoKSB8fCBTVkdHcmFwaGljc0VsZW1l bnQ6OndpbGxSZXNwb25kVG9Nb3VzZUNsaWNrRXZlbnRzKCk7IAorfQorI2VuZGlmCiAKIH0gLy8g bmFtZXNwYWNlIFdlYkNvcmUKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0FF bGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHQUVsZW1lbnQuaAppbmRleCA5NzEwOWNi YzhhYmZiNTY1N2Y3YWRkN2QwY2ZkOGQxNjQ4OTdmZTcxLi41YzliNDAxMWFhMDM3MGZjMjViMjY4 YTNiNTRiZTQyZTlhMTU1Yjc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHQUVs ZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHQUVsZW1lbnQuaApAQCAtNTksNiAr NTksMTAgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJvb2wgaXNGb2N1c2FibGUoKSBjb25zdCBP VkVSUklERTsKICAgICB2aXJ0dWFsIGJvb2wgaXNVUkxBdHRyaWJ1dGUoY29uc3QgQXR0cmlidXRl JikgY29uc3Q7CiAKKyNpZiBQTEFURk9STShJT1MpCisgICAgdmlydHVhbCBib29sIHdpbGxSZXNw b25kVG9Nb3VzZUNsaWNrRXZlbnRzKCkgT1ZFUlJJREU7CisjZW5kaWYKKwogICAgIEJFR0lOX0RF Q0xBUkVfQU5JTUFURURfUFJPUEVSVElFUyhTVkdBRWxlbWVudCkKICAgICAgICAgLy8gVGhpcyBk ZWNsYXJhdGlvbiB1c2VkIHRvIGRlZmluZSBhIG5vbi12aXJ0dWFsICJTdHJpbmcmIHRhcmdldCgp IGNvbnN0IiBtZXRob2QsIHRoYXQgY2xhc2hlcyB3aXRoICJ2aXJ0dWFsIFN0cmluZyBFbGVtZW50 Ojp0YXJnZXQoKSBjb25zdCIuCiAgICAgICAgIC8vIFRoYXQncyB3aHkgaXQgaGFzIGJlZW4gcmVu YW1lZCB0byAic3ZnVGFyZ2V0IiwgdGhlIENvZGVHZW5lcmF0b3JzIHRha2UgY2FyZSBvZiBjYWxs aW5nIHN2Z1RhcmdldEFuaW1hdGVkKCkgaW5zdGVhZCBvZiB0YXJnZXRBbmltYXRlZCgpLCBzZWUg Q29kZUdlbmVyYXRvci5wbS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVt ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50LmNwcAppbmRleCA4MDk1YjFh OTdmMDNkNjYzZjVlZWM0NzA4MTQ4OTU3YjZiY2Y3YjBkLi43MWFkY2MxMzdmODM3YmJlYmIwN2I3 YzQxMWZlOTRjYmFlNzk0NThmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRWxl bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnQuY3BwCkBAIC00OTEs NiArNDkxLDI0IEBAIHZvaWQgU1ZHRWxlbWVudDo6cGFyc2VBdHRyaWJ1dGUoY29uc3QgUXVhbGlm aWVkTmFtZSYgbmFtZSwgY29uc3QgQXRvbWljU3RyaW5nJiB2CiAgICAgICAgIHNldEF0dHJpYnV0 ZUV2ZW50TGlzdGVuZXIoZXZlbnROYW1lcygpLkRPTUFjdGl2YXRlRXZlbnQsIG5hbWUsIHZhbHVl KTsKICAgICBlbHNlIGlmIChuYW1lID09IEhUTUxOYW1lczo6Y2xhc3NBdHRyKQogICAgICAgICBz ZXRDbGFzc05hbWVCYXNlVmFsdWUodmFsdWUpOworI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpICYm IFBMQVRGT1JNKElPUykKKyAgICBlbHNlIGlmIChuYW1lID09IG9udG91Y2hzdGFydEF0dHIpCisg ICAgICAgIHNldEF0dHJpYnV0ZUV2ZW50TGlzdGVuZXIoZXZlbnROYW1lcygpLnRvdWNoc3RhcnRF dmVudCwgbmFtZSwgdmFsdWUpOworICAgIGVsc2UgaWYgKG5hbWUgPT0gb250b3VjaG1vdmVBdHRy KQorICAgICAgICBzZXRBdHRyaWJ1dGVFdmVudExpc3RlbmVyKGV2ZW50TmFtZXMoKS50b3VjaG1v dmVFdmVudCwgbmFtZSwgdmFsdWUpOworICAgIGVsc2UgaWYgKG5hbWUgPT0gb250b3VjaGVuZEF0 dHIpCisgICAgICAgIHNldEF0dHJpYnV0ZUV2ZW50TGlzdGVuZXIoZXZlbnROYW1lcygpLnRvdWNo ZW5kRXZlbnQsIG5hbWUsIHZhbHVlKTsKKyAgICBlbHNlIGlmIChuYW1lID09IG9udG91Y2hjYW5j ZWxBdHRyKQorICAgICAgICBzZXRBdHRyaWJ1dGVFdmVudExpc3RlbmVyKGV2ZW50TmFtZXMoKS50 b3VjaGNhbmNlbEV2ZW50LCBuYW1lLCB2YWx1ZSk7CisjZW5kaWYKKyNpZiBFTkFCTEUoSU9TX0dF U1RVUkVfRVZFTlRTKQorICAgIGVsc2UgaWYgKG5hbWUgPT0gb25nZXN0dXJlc3RhcnRBdHRyKQor ICAgICAgICBzZXRBdHRyaWJ1dGVFdmVudExpc3RlbmVyKGV2ZW50TmFtZXMoKS5nZXN0dXJlc3Rh cnRFdmVudCwgbmFtZSwgdmFsdWUpOworICAgIGVsc2UgaWYgKG5hbWUgPT0gb25nZXN0dXJlY2hh bmdlQXR0cikKKyAgICAgICAgc2V0QXR0cmlidXRlRXZlbnRMaXN0ZW5lcihldmVudE5hbWVzKCku Z2VzdHVyZWNoYW5nZUV2ZW50LCBuYW1lLCB2YWx1ZSk7CisgICAgZWxzZSBpZiAobmFtZSA9PSBv bmdlc3R1cmVlbmRBdHRyKQorICAgICAgICBzZXRBdHRyaWJ1dGVFdmVudExpc3RlbmVyKGV2ZW50 TmFtZXMoKS5nZXN0dXJlZW5kRXZlbnQsIG5hbWUsIHZhbHVlKTsKKyNlbmRpZgogICAgIGVsc2Ug aWYgKFNWR0xhbmdTcGFjZTo6cGFyc2VBdHRyaWJ1dGUobmFtZSwgdmFsdWUpKSB7CiAgICAgfSBl bHNlCiAgICAgICAgIFN0eWxlZEVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKG5hbWUsIHZhbHVlKTsK