<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>125775</bug_id>
          
          <creation_ts>2013-12-16 05:27:55 -0800</creation_ts>
          <short_desc>[GTK] Implement sizes attribute for link tag</short_desc>
          <delta_ts>2014-12-11 02:31:03 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>37674</dependson>
    
    <dependson>138411</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="William Jon McCann">william.jon.mccann</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugzilla</cc>
    
    <cc>cgarcia</cc>
    
    <cc>csaavedra</cc>
    
    <cc>darin</cc>
    
    <cc>gustavo</cc>
    
    <cc>pnormand</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>960033</commentid>
    <comment_count>0</comment_count>
    <who name="William Jon McCann">william.jon.mccann</who>
    <bug_when>2013-12-16 05:27:55 -0800</bug_when>
    <thetext>Bug #37674 implemented sizes attribute support for the link tag, but only for javascript:
+#if defined(LANGUAGE_JAVASCRIPT) &amp;&amp; LANGUAGE_JAVASCRIPT
+        attribute [Custom] DOMSettableTokenList sizes;
+#endif

This is really useful because it is pretty common these days to have something like this:
  &lt;link rel=&quot;apple-touch-icon-precomposed&quot; href=&quot;images/icons/54.png&quot;&gt;
  &lt;link rel=&quot;apple-touch-icon-precomposed&quot; sizes=&quot;72x72&quot;
href=&quot;images/icons/72.png&quot;&gt;
  &lt;link rel=&quot;apple-touch-icon-precomposed&quot; sizes=&quot;114x114&quot;
href=&quot;images/icons/114.png&quot;&gt;
  &lt;link rel=&quot;apple-touch-icon-precomposed&quot; sizes=&quot;144x144&quot;
href=&quot;images/icons/144.png&quot;&gt;

So, it would be really useful to have this available from C as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1046421</commentid>
    <comment_count>1</comment_count>
      <attachid>241014</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-11-05 02:01:24 -0800</bug_when>
    <thetext>Created attachment 241014
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1046423</commentid>
    <comment_count>2</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-11-05 02:02:58 -0800</bug_when>
    <thetext>This depends on bug #138411, that added the support for custom unstable API.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1048137</commentid>
    <comment_count>3</comment_count>
      <attachid>241421</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-11-12 04:41:10 -0800</bug_when>
    <thetext>Created attachment 241421
Rebased patch

It should apply now</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1053368</commentid>
    <comment_count>4</comment_count>
      <attachid>241421</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-12-08 06:57:54 -0800</bug_when>
    <thetext>Comment on attachment 241421
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241421&amp;action=review

&gt; Source/WebCore/bindings/js/JSHTMLLinkElementCustom.cpp:-43
&gt; -JSValue JSHTMLLinkElement::sizes(ExecState* exec) const
&gt; -{
&gt; -    return toJS(exec, globalObject(), impl().sizes());
&gt; -}
&gt; -

Why are you removing the custom getter?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1053369</commentid>
    <comment_count>5</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-12-08 07:00:07 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; Comment on attachment 241421 [details]
&gt; Rebased patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=241421&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/bindings/js/JSHTMLLinkElementCustom.cpp:-43
&gt; &gt; -JSValue JSHTMLLinkElement::sizes(ExecState* exec) const
&gt; &gt; -{
&gt; &gt; -    return toJS(exec, globalObject(), impl().sizes());
&gt; &gt; -}
&gt; &gt; -
&gt; 
&gt; Why are you removing the custom getter?

Because it&apos;s not needed. See https://bugs.webkit.org/show_bug.cgi?id=37674#c30</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1053370</commentid>
    <comment_count>6</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-12-08 07:01:08 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; (In reply to comment #4)
&gt; &gt; Comment on attachment 241421 [details]
&gt; &gt; Rebased patch
&gt; &gt; 
&gt; &gt; View in context:
&gt; &gt; https://bugs.webkit.org/attachment.cgi?id=241421&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; Source/WebCore/bindings/js/JSHTMLLinkElementCustom.cpp:-43
&gt; &gt; &gt; -JSValue JSHTMLLinkElement::sizes(ExecState* exec) const
&gt; &gt; &gt; -{
&gt; &gt; &gt; -    return toJS(exec, globalObject(), impl().sizes());
&gt; &gt; &gt; -}
&gt; &gt; &gt; -
&gt; &gt; 
&gt; &gt; Why are you removing the custom getter?
&gt; 
&gt; Because it&apos;s not needed. See
&gt; https://bugs.webkit.org/show_bug.cgi?id=37674#c30

Note that I also changed the idl, so that the getter is auto-generated, so it&apos;s not that I&apos;ve removed it, but that now it&apos;s auto-generated.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1053373</commentid>
    <comment_count>7</comment_count>
      <attachid>241421</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-12-08 07:10:01 -0800</bug_when>
    <thetext>Comment on attachment 241421
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241421&amp;action=review

&gt;&gt;&gt;&gt; Source/WebCore/bindings/js/JSHTMLLinkElementCustom.cpp:-43
&gt;&gt;&gt;&gt; -
&gt;&gt;&gt; 
&gt;&gt;&gt; Why are you removing the custom getter?
&gt;&gt; 
&gt;&gt; Because it&apos;s not needed. See https://bugs.webkit.org/show_bug.cgi?id=37674#c30
&gt; 
&gt; Note that I also changed the idl, so that the getter is auto-generated, so it&apos;s not that I&apos;ve removed it, but that now it&apos;s auto-generated.

Thanks for the information. Do you mind leaving a short note about this in the ChangeLog?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1053375</commentid>
    <comment_count>8</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-12-08 07:19:16 -0800</bug_when>
    <thetext>(In reply to comment #7)
&gt; Comment on attachment 241421 [details]
&gt; Rebased patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=241421&amp;action=review
&gt; 
&gt; &gt;&gt;&gt;&gt; Source/WebCore/bindings/js/JSHTMLLinkElementCustom.cpp:-43
&gt; &gt;&gt;&gt;&gt; -
&gt; &gt;&gt;&gt; 
&gt; &gt;&gt;&gt; Why are you removing the custom getter?
&gt; &gt;&gt; 
&gt; &gt;&gt; Because it&apos;s not needed. See https://bugs.webkit.org/show_bug.cgi?id=37674#c30
&gt; &gt; 
&gt; &gt; Note that I also changed the idl, so that the getter is auto-generated, so it&apos;s not that I&apos;ve removed it, but that now it&apos;s auto-generated.
&gt; 
&gt; Thanks for the information. Do you mind leaving a short note about this in
&gt; the ChangeLog?

Sure, thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1054446</commentid>
    <comment_count>9</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-12-11 02:31:03 -0800</bug_when>
    <thetext>Committed r177143: &lt;http://trac.webkit.org/changeset/177143&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>241014</attachid>
            <date>2014-11-05 02:01:24 -0800</date>
            <delta_ts>2014-11-12 04:41:10 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>wkdom-html-link-sizes.diff</filename>
            <type>text/plain</type>
            <size>5304</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA5N2U5YjI4Li42ZjgzNDkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMg
QEAKIDIwMTQtMTEtMDUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t
PgogCisgICAgICAgIFtHVEtdIEltcGxlbWVudCBzaXplcyBhdHRyaWJ1dGUgZm9yIGxpbmsgdGFn
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU3NzUK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRp
bmdzL2dvYmplY3QvV2ViS2l0RE9NQ3VzdG9tLmNwcDoKKyAgICAgICAgKHdlYmtpdF9kb21faHRt
bF9saW5rX2VsZW1lbnRfc2V0X3NpemVzKTogQWRkIGN1c3RvbSBzZXR0ZXIgaW1wbGVtZW50YXRp
b24uCisgICAgICAgICogYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0b21VbnN0YWJsZS5o
OgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTSFRNTExpbmtFbGVtZW50Q3VzdG9tLmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OkpTSFRNTExpbmtFbGVtZW50OjpzaXplcyk6IFJlbW92ZSBjdXN0b20g
Z2V0dGVyIGltcGxlbWVudGF0aW9uLgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdl
bmVyYXRvckdPYmplY3QucG06CisgICAgICAgIChIYXNVbnN0YWJsZUN1c3RvbUFQSSk6IE1hcmsg
V2ViS2l0RE9NSFRNTExpbmtFbGVtZW50IGFzIGhhdmluZyBjdXN0b20gdW5zdGFibGUgQVBJLgor
ICAgICAgICAqIGh0bWwvSFRNTExpbmtFbGVtZW50LmlkbDogTWFyayBzaXplcyBhdHRyaWJ1dGUg
YXMgQ3VzdG9tU2V0dGVyCisgICAgICAgIGluc3RlYWQgb2YgQ3VzdG9tLCBzaW5jZSB0aGUgZ2V0
dGVyIGNhbiBiZSBhdXRvZ2VuZXJhdGVkLCBhbmQgbWFrZQorICAgICAgICBpdCBhdmFpbGFibGUg
dG8gdGhlIEdPYmplY3QgRE9NIGJpbmRpbmdzIHRvby4KKworMjAxNC0xMS0wNSAgQ2FybG9zIEdh
cmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gRXhwb3Nl
IHVzZXIgc2NyaXB0IG1lc3NhZ2VzIHRvIEdPYmplY3QgRE9NIGJpbmRpbmdzCiAgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg0MTEKIApkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0b20uY3BwIGIv
U291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0b20uY3BwCmluZGV4
IGM3NzE5MGQuLjQ5NTVkZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dv
YmplY3QvV2ViS2l0RE9NQ3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9n
b2JqZWN0L1dlYktpdERPTUN1c3RvbS5jcHAKQEAgLTIwLDkgKzIwLDExIEBACiAjaW5jbHVkZSAi
V2ViS2l0RE9NQ3VzdG9tLmgiCiAKICNpbmNsdWRlICJKU01haW5UaHJlYWRFeGVjU3RhdGUuaCIK
KyNpbmNsdWRlICJXZWJLaXRET01ET01TZXR0YWJsZVRva2VuTGlzdFByaXZhdGUuaCIKICNpbmNs
dWRlICJXZWJLaXRET01ET01XaW5kb3dQcml2YXRlLmgiCiAjaW5jbHVkZSAiV2ViS2l0RE9NSFRN
TElucHV0RWxlbWVudC5oIgogI2luY2x1ZGUgIldlYktpdERPTUhUTUxJbnB1dEVsZW1lbnRQcml2
YXRlLmgiCisjaW5jbHVkZSAiV2ViS2l0RE9NSFRNTExpbmtFbGVtZW50UHJpdmF0ZS5oIgogI2lu
Y2x1ZGUgIldlYktpdERPTUhUTUxUZXh0QXJlYUVsZW1lbnQuaCIKICNpbmNsdWRlICJXZWJLaXRE
T01IVE1MVGV4dEFyZWFFbGVtZW50UHJpdmF0ZS5oIgogI2luY2x1ZGUgIldlYktpdERPTVByaXZh
dGUuaCIKQEAgLTY0LDMgKzY2LDEwIEBAIFdlYktpdERPTVVzZXJNZXNzYWdlSGFuZGxlciogd2Vi
a2l0X2RvbV91c2VyX21lc3NhZ2VfaGFuZGxlcnNfbmFtZXNwYWNlX2dldF9oYW5kCiAgICAgcmV0
dXJuIGtpdChjb3JlKGhhbmRsZXJzTmFtZXNwYWNlKS0+aGFuZGxlcihTdHJpbmc6OmZyb21VVEY4
KG5hbWUpLCBXZWJDb3JlOjptYWluVGhyZWFkTm9ybWFsV29ybGQoKSkpOwogfQogCit2b2lkIHdl
YmtpdF9kb21faHRtbF9saW5rX2VsZW1lbnRfc2V0X3NpemVzKFdlYktpdERPTUhUTUxMaW5rRWxl
bWVudCogbGlua0VsZW1lbnQsIGNvbnN0IGdjaGFyKiB2YWx1ZSkKK3sKKyAgICBnX3JldHVybl9p
Zl9mYWlsKFdFQktJVF9ET01fSVNfSFRNTF9MSU5LX0VMRU1FTlQobGlua0VsZW1lbnQpKTsKKyAg
ICBnX3JldHVybl9pZl9mYWlsKHZhbHVlKTsKKworICAgIGNvcmUobGlua0VsZW1lbnQpLT5zZXRT
aXplcyhTdHJpbmc6OmZyb21VVEY4KHZhbHVlKSk7Cit9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi
Q29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3RvbVVuc3RhYmxlLmggYi9Tb3VyY2Uv
V2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3RvbVVuc3RhYmxlLmgKaW5kZXgg
NzlkMGY1Ni4uY2UxNjk1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29i
amVjdC9XZWJLaXRET01DdXN0b21VbnN0YWJsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp
bmdzL2dvYmplY3QvV2ViS2l0RE9NQ3VzdG9tVW5zdGFibGUuaApAQCAtNTAsNiArNTAsMTcgQEAg
d2Via2l0X2RvbV9kb21fd2luZG93X2dldF93ZWJraXRfbmFtZXNwYWNlKFdlYktpdERPTURPTVdp
bmRvdyogc2VsZik7CiBXRUJLSVRfQVBJIFdlYktpdERPTVVzZXJNZXNzYWdlSGFuZGxlciAqCiB3
ZWJraXRfZG9tX3VzZXJfbWVzc2FnZV9oYW5kbGVyc19uYW1lc3BhY2VfZ2V0X2hhbmRsZXIoV2Vi
S2l0RE9NVXNlck1lc3NhZ2VIYW5kbGVyc05hbWVzcGFjZSogc2VsZiwgY29uc3QgZ2NoYXIqIG5h
bWUpOwogCisvKioKKyAqIHdlYmtpdF9kb21faHRtbF9saW5rX2VsZW1lbnRfc2V0X3NpemVzOgor
ICogQHNlbGY6IEEgI1dlYktpdERPTUhUTUxMaW5rRWxlbWVudAorICogQHZhbHVlOiBhICNnY2hh
cgorICoKKyAqIFN0YWJpbGl0eTogVW5zdGFibGUKKyAqIFNpbmNlOiAyLjgKKyAqLworV0VCS0lU
X0FQSSB2b2lkCit3ZWJraXRfZG9tX2h0bWxfbGlua19lbGVtZW50X3NldF9zaXplcyhXZWJLaXRE
T01IVE1MTGlua0VsZW1lbnQqIHNlbGYsIGNvbnN0IGdjaGFyKiB2YWx1ZSk7CisKIEdfRU5EX0RF
Q0xTCiAKICNlbmRpZiAvKiBXRUJLSVRfRE9NX1VTRV9VTlNUQUJMRV9BUEkgKi8KZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSFRNTExpbmtFbGVtZW50Q3VzdG9tLmNw
cCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSFRNTExpbmtFbGVtZW50Q3VzdG9tLmNw
cAppbmRleCBkM2E0YjU0Li4wNDY3YTgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k
aW5ncy9qcy9KU0hUTUxMaW5rRWxlbWVudEN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv
YmluZGluZ3MvanMvSlNIVE1MTGlua0VsZW1lbnRDdXN0b20uY3BwCkBAIC0zNiwxMSArMzYsNiBA
QCB1c2luZyBuYW1lc3BhY2UgSlNDOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLUpTVmFsdWUg
SlNIVE1MTGlua0VsZW1lbnQ6OnNpemVzKEV4ZWNTdGF0ZSogZXhlYykgY29uc3QKLXsKLSAgICBy
ZXR1cm4gdG9KUyhleGVjLCBnbG9iYWxPYmplY3QoKSwgaW1wbCgpLnNpemVzKCkpOwotfQotCiB2
b2lkIEpTSFRNTExpbmtFbGVtZW50OjpzZXRTaXplcyhFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUg
dmFsdWUpCiB7CiAgICAgaW1wbCgpLnNldFNpemVzKHZhbHVlVG9TdHJpbmdXaXRoTnVsbENoZWNr
KGV4ZWMsIHZhbHVlKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp
cHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny
aXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQppbmRleCBkNTcwYTkwLi41MGRiMGIzIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2Jq
ZWN0LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv
ckdPYmplY3QucG0KQEAgLTE1ODMsNyArMTU4Myw3IEBAIHN1YiBHZW5lcmF0ZSB7CiBzdWIgSGFz
VW5zdGFibGVDdXN0b21BUEkgewogICAgIG15ICRkb21DbGFzc05hbWUgPSBzaGlmdDsKIAotICAg
IHJldHVybiBzY2FsYXIoZ3JlcCB7JF8gZXEgJGRvbUNsYXNzTmFtZX0gcXcoV2ViS2l0RE9NRE9N
V2luZG93IFdlYktpdERPTVVzZXJNZXNzYWdlSGFuZGxlcnNOYW1lc3BhY2UpKTsKKyAgICByZXR1
cm4gc2NhbGFyKGdyZXAgeyRfIGVxICRkb21DbGFzc05hbWV9IHF3KFdlYktpdERPTURPTVdpbmRv
dyBXZWJLaXRET01Vc2VyTWVzc2FnZUhhbmRsZXJzTmFtZXNwYWNlIFdlYktpdERPTUhUTUxMaW5r
RWxlbWVudCkpOwogfQogCiBzdWIgV3JpdGVEYXRhIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL2h0bWwvSFRNTExpbmtFbGVtZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTExp
bmtFbGVtZW50LmlkbAppbmRleCA5NWE2NDFjLi4zM2U3NmNjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt
bC9IVE1MTGlua0VsZW1lbnQuaWRsCkBAIC0yNyw4ICsyNyw4IEBAIGludGVyZmFjZSBIVE1MTGlu
a0VsZW1lbnQgOiBIVE1MRWxlbWVudCB7CiAgICAgW1JlZmxlY3RdIGF0dHJpYnV0ZSBET01TdHJp
bmcgbWVkaWE7CiAgICAgW1JlZmxlY3RdIGF0dHJpYnV0ZSBET01TdHJpbmcgcmVsOwogICAgIFtS
ZWZsZWN0XSBhdHRyaWJ1dGUgRE9NU3RyaW5nIHJldjsKLSNpZiBkZWZpbmVkKExBTkdVQUdFX0pB
VkFTQ1JJUFQpICYmIExBTkdVQUdFX0pBVkFTQ1JJUFQKLSAgICBbQ3VzdG9tXSBhdHRyaWJ1dGUg
RE9NU2V0dGFibGVUb2tlbkxpc3Qgc2l6ZXM7CisjaWYgKGRlZmluZWQoTEFOR1VBR0VfSkFWQVND
UklQVCkgJiYgTEFOR1VBR0VfSkFWQVNDUklQVCkgfHwgKGRlZmluZWQoTEFOR1VBR0VfR09CSkVD
VCkgfHwgTEFOR1VBR0VfR09CSkVDVCkKKyAgICBbQ3VzdG9tU2V0dGVyXSBhdHRyaWJ1dGUgRE9N
U2V0dGFibGVUb2tlbkxpc3Qgc2l6ZXM7CiAjZW5kaWYKICAgICBbUmVmbGVjdF0gYXR0cmlidXRl
IERPTVN0cmluZyB0YXJnZXQ7CiAgICAgW1JlZmxlY3RdIGF0dHJpYnV0ZSBET01TdHJpbmcgdHlw
ZTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>241421</attachid>
            <date>2014-11-12 04:41:10 -0800</date>
            <delta_ts>2014-12-08 07:10:01 -0800</delta_ts>
            <desc>Rebased patch</desc>
            <filename>wkdom-link-sizes.diff</filename>
            <type>text/plain</type>
            <size>5304</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA2YjE0OTBlLi43NTM4ZDRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMg
QEAKIDIwMTQtMTEtMTIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t
PgogCisgICAgICAgIFtHVEtdIEltcGxlbWVudCBzaXplcyBhdHRyaWJ1dGUgZm9yIGxpbmsgdGFn
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU3NzUK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRp
bmdzL2dvYmplY3QvV2ViS2l0RE9NQ3VzdG9tLmNwcDoKKyAgICAgICAgKHdlYmtpdF9kb21faHRt
bF9saW5rX2VsZW1lbnRfc2V0X3NpemVzKTogQWRkIGN1c3RvbSBzZXR0ZXIgaW1wbGVtZW50YXRp
b24uCisgICAgICAgICogYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0b21VbnN0YWJsZS5o
OgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTSFRNTExpbmtFbGVtZW50Q3VzdG9tLmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OkpTSFRNTExpbmtFbGVtZW50OjpzaXplcyk6IFJlbW92ZSBjdXN0b20g
Z2V0dGVyIGltcGxlbWVudGF0aW9uLgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdl
bmVyYXRvckdPYmplY3QucG06CisgICAgICAgIChIYXNVbnN0YWJsZUN1c3RvbUFQSSk6IE1hcmsg
V2ViS2l0RE9NSFRNTExpbmtFbGVtZW50IGFzIGhhdmluZyBjdXN0b20gdW5zdGFibGUgQVBJLgor
ICAgICAgICAqIGh0bWwvSFRNTExpbmtFbGVtZW50LmlkbDogTWFyayBzaXplcyBhdHRyaWJ1dGUg
YXMgQ3VzdG9tU2V0dGVyCisgICAgICAgIGluc3RlYWQgb2YgQ3VzdG9tLCBzaW5jZSB0aGUgZ2V0
dGVyIGNhbiBiZSBhdXRvZ2VuZXJhdGVkLCBhbmQgbWFrZQorICAgICAgICBpdCBhdmFpbGFibGUg
dG8gdGhlIEdPYmplY3QgRE9NIGJpbmRpbmdzIHRvby4KKworMjAxNC0xMS0xMiAgQ2FybG9zIEdh
cmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gRXhwb3Nl
IHVzZXIgc2NyaXB0IG1lc3NhZ2VzIHRvIEdPYmplY3QgRE9NIGJpbmRpbmdzCiAgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzg0MTEKIApkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0b20uY3BwIGIv
U291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0b20uY3BwCmluZGV4
IGM3NzE5MGQuLjQ5NTVkZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dv
YmplY3QvV2ViS2l0RE9NQ3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9n
b2JqZWN0L1dlYktpdERPTUN1c3RvbS5jcHAKQEAgLTIwLDkgKzIwLDExIEBACiAjaW5jbHVkZSAi
V2ViS2l0RE9NQ3VzdG9tLmgiCiAKICNpbmNsdWRlICJKU01haW5UaHJlYWRFeGVjU3RhdGUuaCIK
KyNpbmNsdWRlICJXZWJLaXRET01ET01TZXR0YWJsZVRva2VuTGlzdFByaXZhdGUuaCIKICNpbmNs
dWRlICJXZWJLaXRET01ET01XaW5kb3dQcml2YXRlLmgiCiAjaW5jbHVkZSAiV2ViS2l0RE9NSFRN
TElucHV0RWxlbWVudC5oIgogI2luY2x1ZGUgIldlYktpdERPTUhUTUxJbnB1dEVsZW1lbnRQcml2
YXRlLmgiCisjaW5jbHVkZSAiV2ViS2l0RE9NSFRNTExpbmtFbGVtZW50UHJpdmF0ZS5oIgogI2lu
Y2x1ZGUgIldlYktpdERPTUhUTUxUZXh0QXJlYUVsZW1lbnQuaCIKICNpbmNsdWRlICJXZWJLaXRE
T01IVE1MVGV4dEFyZWFFbGVtZW50UHJpdmF0ZS5oIgogI2luY2x1ZGUgIldlYktpdERPTVByaXZh
dGUuaCIKQEAgLTY0LDMgKzY2LDEwIEBAIFdlYktpdERPTVVzZXJNZXNzYWdlSGFuZGxlciogd2Vi
a2l0X2RvbV91c2VyX21lc3NhZ2VfaGFuZGxlcnNfbmFtZXNwYWNlX2dldF9oYW5kCiAgICAgcmV0
dXJuIGtpdChjb3JlKGhhbmRsZXJzTmFtZXNwYWNlKS0+aGFuZGxlcihTdHJpbmc6OmZyb21VVEY4
KG5hbWUpLCBXZWJDb3JlOjptYWluVGhyZWFkTm9ybWFsV29ybGQoKSkpOwogfQogCit2b2lkIHdl
YmtpdF9kb21faHRtbF9saW5rX2VsZW1lbnRfc2V0X3NpemVzKFdlYktpdERPTUhUTUxMaW5rRWxl
bWVudCogbGlua0VsZW1lbnQsIGNvbnN0IGdjaGFyKiB2YWx1ZSkKK3sKKyAgICBnX3JldHVybl9p
Zl9mYWlsKFdFQktJVF9ET01fSVNfSFRNTF9MSU5LX0VMRU1FTlQobGlua0VsZW1lbnQpKTsKKyAg
ICBnX3JldHVybl9pZl9mYWlsKHZhbHVlKTsKKworICAgIGNvcmUobGlua0VsZW1lbnQpLT5zZXRT
aXplcyhTdHJpbmc6OmZyb21VVEY4KHZhbHVlKSk7Cit9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi
Q29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3RvbVVuc3RhYmxlLmggYi9Tb3VyY2Uv
V2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3RvbVVuc3RhYmxlLmgKaW5kZXgg
NzlkMGY1Ni4uY2UxNjk1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29i
amVjdC9XZWJLaXRET01DdXN0b21VbnN0YWJsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp
bmdzL2dvYmplY3QvV2ViS2l0RE9NQ3VzdG9tVW5zdGFibGUuaApAQCAtNTAsNiArNTAsMTcgQEAg
d2Via2l0X2RvbV9kb21fd2luZG93X2dldF93ZWJraXRfbmFtZXNwYWNlKFdlYktpdERPTURPTVdp
bmRvdyogc2VsZik7CiBXRUJLSVRfQVBJIFdlYktpdERPTVVzZXJNZXNzYWdlSGFuZGxlciAqCiB3
ZWJraXRfZG9tX3VzZXJfbWVzc2FnZV9oYW5kbGVyc19uYW1lc3BhY2VfZ2V0X2hhbmRsZXIoV2Vi
S2l0RE9NVXNlck1lc3NhZ2VIYW5kbGVyc05hbWVzcGFjZSogc2VsZiwgY29uc3QgZ2NoYXIqIG5h
bWUpOwogCisvKioKKyAqIHdlYmtpdF9kb21faHRtbF9saW5rX2VsZW1lbnRfc2V0X3NpemVzOgor
ICogQHNlbGY6IEEgI1dlYktpdERPTUhUTUxMaW5rRWxlbWVudAorICogQHZhbHVlOiBhICNnY2hh
cgorICoKKyAqIFN0YWJpbGl0eTogVW5zdGFibGUKKyAqIFNpbmNlOiAyLjgKKyAqLworV0VCS0lU
X0FQSSB2b2lkCit3ZWJraXRfZG9tX2h0bWxfbGlua19lbGVtZW50X3NldF9zaXplcyhXZWJLaXRE
T01IVE1MTGlua0VsZW1lbnQqIHNlbGYsIGNvbnN0IGdjaGFyKiB2YWx1ZSk7CisKIEdfRU5EX0RF
Q0xTCiAKICNlbmRpZiAvKiBXRUJLSVRfRE9NX1VTRV9VTlNUQUJMRV9BUEkgKi8KZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSFRNTExpbmtFbGVtZW50Q3VzdG9tLmNw
cCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSFRNTExpbmtFbGVtZW50Q3VzdG9tLmNw
cAppbmRleCBkM2E0YjU0Li4wNDY3YTgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k
aW5ncy9qcy9KU0hUTUxMaW5rRWxlbWVudEN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv
YmluZGluZ3MvanMvSlNIVE1MTGlua0VsZW1lbnRDdXN0b20uY3BwCkBAIC0zNiwxMSArMzYsNiBA
QCB1c2luZyBuYW1lc3BhY2UgSlNDOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLUpTVmFsdWUg
SlNIVE1MTGlua0VsZW1lbnQ6OnNpemVzKEV4ZWNTdGF0ZSogZXhlYykgY29uc3QKLXsKLSAgICBy
ZXR1cm4gdG9KUyhleGVjLCBnbG9iYWxPYmplY3QoKSwgaW1wbCgpLnNpemVzKCkpOwotfQotCiB2
b2lkIEpTSFRNTExpbmtFbGVtZW50OjpzZXRTaXplcyhFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUg
dmFsdWUpCiB7CiAgICAgaW1wbCgpLnNldFNpemVzKHZhbHVlVG9TdHJpbmdXaXRoTnVsbENoZWNr
KGV4ZWMsIHZhbHVlKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp
cHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny
aXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQppbmRleCBkNTcwYTkwLi41MGRiMGIzIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2Jq
ZWN0LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv
ckdPYmplY3QucG0KQEAgLTE1ODMsNyArMTU4Myw3IEBAIHN1YiBHZW5lcmF0ZSB7CiBzdWIgSGFz
VW5zdGFibGVDdXN0b21BUEkgewogICAgIG15ICRkb21DbGFzc05hbWUgPSBzaGlmdDsKIAotICAg
IHJldHVybiBzY2FsYXIoZ3JlcCB7JF8gZXEgJGRvbUNsYXNzTmFtZX0gcXcoV2ViS2l0RE9NRE9N
V2luZG93IFdlYktpdERPTVVzZXJNZXNzYWdlSGFuZGxlcnNOYW1lc3BhY2UpKTsKKyAgICByZXR1
cm4gc2NhbGFyKGdyZXAgeyRfIGVxICRkb21DbGFzc05hbWV9IHF3KFdlYktpdERPTURPTVdpbmRv
dyBXZWJLaXRET01Vc2VyTWVzc2FnZUhhbmRsZXJzTmFtZXNwYWNlIFdlYktpdERPTUhUTUxMaW5r
RWxlbWVudCkpOwogfQogCiBzdWIgV3JpdGVEYXRhIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL2h0bWwvSFRNTExpbmtFbGVtZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTExp
bmtFbGVtZW50LmlkbAppbmRleCA5NWE2NDFjLi4zM2U3NmNjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt
bC9IVE1MTGlua0VsZW1lbnQuaWRsCkBAIC0yNyw4ICsyNyw4IEBAIGludGVyZmFjZSBIVE1MTGlu
a0VsZW1lbnQgOiBIVE1MRWxlbWVudCB7CiAgICAgW1JlZmxlY3RdIGF0dHJpYnV0ZSBET01TdHJp
bmcgbWVkaWE7CiAgICAgW1JlZmxlY3RdIGF0dHJpYnV0ZSBET01TdHJpbmcgcmVsOwogICAgIFtS
ZWZsZWN0XSBhdHRyaWJ1dGUgRE9NU3RyaW5nIHJldjsKLSNpZiBkZWZpbmVkKExBTkdVQUdFX0pB
VkFTQ1JJUFQpICYmIExBTkdVQUdFX0pBVkFTQ1JJUFQKLSAgICBbQ3VzdG9tXSBhdHRyaWJ1dGUg
RE9NU2V0dGFibGVUb2tlbkxpc3Qgc2l6ZXM7CisjaWYgKGRlZmluZWQoTEFOR1VBR0VfSkFWQVND
UklQVCkgJiYgTEFOR1VBR0VfSkFWQVNDUklQVCkgfHwgKGRlZmluZWQoTEFOR1VBR0VfR09CSkVD
VCkgfHwgTEFOR1VBR0VfR09CSkVDVCkKKyAgICBbQ3VzdG9tU2V0dGVyXSBhdHRyaWJ1dGUgRE9N
U2V0dGFibGVUb2tlbkxpc3Qgc2l6ZXM7CiAjZW5kaWYKICAgICBbUmVmbGVjdF0gYXR0cmlidXRl
IERPTVN0cmluZyB0YXJnZXQ7CiAgICAgW1JlZmxlY3RdIGF0dHJpYnV0ZSBET01TdHJpbmcgdHlw
ZTsK
</data>
<flag name="review"
          id="266288"
          type_id="1"
          status="+"
          setter="mrobinson"
    />
          </attachment>
      

    </bug>

</bugzilla>