125766 2013-12-15 23:43:31 -0800 [GTK] [CMake] Add support for building GtkLauncher 2013-12-18 16:07:12 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 116377 115966 1 mrobinson mrobinson commit-queue gyuyoung.kim rakuco oldest_to_newest 960010 0 mrobinson 2013-12-15 23:43:31 -0800 This is required to do smoke testing for the WebKit1 build. 960015 1 219300 mrobinson 2013-12-16 00:24:49 -0800 Created attachment 219300 Patch 961083 2 219300 gustavo 2013-12-18 13:39:58 -0800 Comment on attachment 219300 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219300&action=review > Tools/GtkLauncher/CMakeLists.txt:1 > +add_definitions(-DWEBKIT_EXEC_PATH="${CMAKE_RUNTIME_OUTPUT_DIRECTORY}") I guess this is OK since we won't install GtkLauncher, right? > Tools/GtkLauncher/main.c:28 > +#if defined(HAVE_CONFIG_H) && HAVE_CONFIG_H I take it this is also the case with autotools, right? I think so, but… =) 961154 3 219300 mrobinson 2013-12-18 16:05:32 -0800 Comment on attachment 219300 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219300&action=review >> Tools/GtkLauncher/CMakeLists.txt:1 >> +add_definitions(-DWEBKIT_EXEC_PATH="${CMAKE_RUNTIME_OUTPUT_DIRECTORY}") > > I guess this is OK since we won't install GtkLauncher, right? Yep. This is duplicated from the autotools build. TBH, I cannot see where it is used, but I guess we could try removing it from both places in a new patch. >> Tools/GtkLauncher/main.c:28 >> +#if defined(HAVE_CONFIG_H) && HAVE_CONFIG_H > > I take it this is also the case with autotools, right? I think so, but… =) Hrm...I believe it is. This is cribbed from WTF version. Looks like the build bot did not complain. :) 961155 4 219300 mrobinson 2013-12-18 16:07:04 -0800 Comment on attachment 219300 Patch Clearing flags on attachment: 219300 Committed r160805: <http://trac.webkit.org/changeset/160805> 961156 5 mrobinson 2013-12-18 16:07:12 -0800 All reviewed patches have been landed. Closing bug. 219300 2013-12-16 00:24:49 -0800 2013-12-18 16:07:04 -0800 Patch bug-125766-20131216092448.patch text/plain 2764 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwNDEyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODIyMThkNmU5ZGQ0YzFiYjE5NzNjNTAwNmRjNzg0ZDNl ODVlNWE0YS4uMDY4ZDI3MzI1Y2Q2ZTA0MzY5MDA3MjJiYjgzMzUzYjg3MjU4YWU1OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEzLTEyLTE2ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBbQ01ha2VdIEFkZCBzdXBwb3J0IGZvciBidWlsZGluZyBHdGtMYXVu Y2hlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1 NzY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBD TWFrZUxpc3RzLnR4dDogQWRkIHRoZSBHdGtMYXVuY2hlciBzdWJkaXJlY3RvcnkgZm9yIHRoZSBH VEsgcG9ydC4KKyAgICAgICAgKiBHdGtMYXVuY2hlci9DTWFrZUxpc3RzLnR4dDogQWRkZWQuCisg ICAgICAgICogR3RrTGF1bmNoZXIvbWFpbi5jOiBTdXBwb3J0IGluY2x1ZGluZyB0aGUgQ01ha2Ug Y29uZmlnIGZpbGUuCisKIDIwMTMtMTItMTIgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFtDTWFrZV0gQnVpbGQgdGhlIHBsdWdpbiBwcm9j ZXNzIGFnYWluc3QgR1RLKyAyCmRpZmYgLS1naXQgYS9Ub29scy9DTWFrZUxpc3RzLnR4dCBiL1Rv b2xzL0NNYWtlTGlzdHMudHh0CmluZGV4IDk3NzZmOTZlNzg0MzJiNGE1YTMzMWQ3YzQ3OTRjMjU3 NjZiNWMxNjQuLjNkZDUzMjQ3MjViMWFlZWE3MDA3MWFiMGE0YWFhZjBmY2UzNGZkMDggMTAwNjQ0 Ci0tLSBhL1Rvb2xzL0NNYWtlTGlzdHMudHh0CisrKyBiL1Rvb2xzL0NNYWtlTGlzdHMudHh0CkBA IC0xOSw2ICsxOSw5IEBAIGVsc2VpZiAoIiR7UE9SVH0iIFNUUkVRVUFMICJHVEsiKQogICAgIGlm IChFTkFCTEVfV0VCS0lUMikKICAgICAgICAgYWRkX3N1YmRpcmVjdG9yeShNaW5pQnJvd3Nlci9n dGspCiAgICAgZW5kaWYgKCkKKyAgICBpZiAoRU5BQkxFX1dFQktJVCkKKyAgICAgICAgYWRkX3N1 YmRpcmVjdG9yeShHdGtMYXVuY2hlcikKKyAgICBlbmRpZiAoKQogZWxzZWlmICgiJHtQT1JUfSIg U1RSRVFVQUwgIldpbkNFIikKICAgICBhZGRfc3ViZGlyZWN0b3J5KFdpbkNFTGF1bmNoZXIpCiBl bmRpZiAoKQpkaWZmIC0tZ2l0IGEvVG9vbHMvR3RrTGF1bmNoZXIvQ01ha2VMaXN0cy50eHQgYi9U b29scy9HdGtMYXVuY2hlci9DTWFrZUxpc3RzLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41ZThjODBhZDcwNjE0 YTMyMjRjOGFjODdlZWNkZGY1YTI5NzY5NDk2Ci0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvR3Rr TGF1bmNoZXIvQ01ha2VMaXN0cy50eHQKQEAgLTAsMCArMSwyOCBAQAorYWRkX2RlZmluaXRpb25z KC1EV0VCS0lUX0VYRUNfUEFUSD0iJHtDTUFLRV9SVU5USU1FX09VVFBVVF9ESVJFQ1RPUll9IikK KworaW5jbHVkZV9kaXJlY3RvcmllcygKKyAgICAke0NNQUtFX0JJTkFSWV9ESVJ9CisgICAgJHtD TUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UKKyAgICAke0NNQUtFX1NPVVJDRV9ESVJ9L1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9Gb3J3YXJkaW5nSGVhZGVycworICAgICR7Q01BS0VfU09VUkNFX0RJUn0v U291cmNlL1dlYktpdC9ndGsKKyAgICAke0RFUklWRURfU09VUkNFU19ESVJ9CisgICAgJHtERVJJ VkVEX1NPVVJDRVNfRElSfS93ZWJraXQKKyAgICAke0dMSUJfSU5DTFVERV9ESVJTfQorICAgICR7 R1RLM19JTkNMVURFX0RJUlN9CisgICAgJHtMSUJTT1VQX0lOQ0xVREVfRElSU30KKykKKworYWRk X2V4ZWN1dGFibGUoR3RrTGF1bmNoZXIKKyAgICBMYXVuY2hlckluc3BlY3RvcldpbmRvdy5jCisg ICAgTGF1bmNoZXJJbnNwZWN0b3JXaW5kb3cuaAorICAgIG1haW4uYworKQorCit0YXJnZXRfbGlu a19saWJyYXJpZXMoR3RrTGF1bmNoZXIKKyAgICAke0phdmFTY3JpcHRDb3JlX0xJQlJBUllfTkFN RX0KKyAgICBXZWJLaXQKKyAgICAke0dMSUJfTElCUkFSSUVTfQorICAgICR7R1RLM19MSUJSQVJJ RVN9CisgICAgJHtMSUJTT1VQX0xJQlJBUklFU30KKykKKwpkaWZmIC0tZ2l0IGEvVG9vbHMvR3Rr TGF1bmNoZXIvbWFpbi5jIGIvVG9vbHMvR3RrTGF1bmNoZXIvbWFpbi5jCmluZGV4IDdlOWQyY2Rl MDdiNTg4ZTljOWZmMGRhOWE2N2RhZWNmYjlmNjI4YTEuLjUwN2I3M2NkY2JkMGVjOTFiNDE2NDYw NDhhNTVjODY4ZWM0NmM0YzIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0d0a0xhdW5jaGVyL21haW4uYwor KysgYi9Ub29scy9HdGtMYXVuY2hlci9tYWluLmMKQEAgLTI1LDcgKzI1LDE0IEBACiAgKiBPRiBU SElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0gg REFNQUdFLgogICovCiAKKyNpZiBkZWZpbmVkKEhBVkVfQ09ORklHX0gpICYmIEhBVkVfQ09ORklH X0gKKyNpZmRlZiBCVUlMRElOR19XSVRIX0NNQUtFCisjaW5jbHVkZSAiY21ha2Vjb25maWcuaCIK KyNlbHNlCiAjaW5jbHVkZSAiYXV0b3Rvb2xzY29uZmlnLmgiCisjZW5kaWYKKyNlbmRpZgorCiAj aW5jbHVkZSAiTGF1bmNoZXJJbnNwZWN0b3JXaW5kb3cuaCIKICNpbmNsdWRlIDxlcnJuby5oPgog I2luY2x1ZGUgPGdkay9nZGtrZXlzeW1zLmg+Cg==