125735 2013-12-14 02:59:27 -0800 RenderElement::rendererForRootBackground() should return a reference. 2013-12-14 04:36:34 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 959814 0 kling 2013-12-14 02:59:27 -0800 RenderElement::rendererForRootBackground() should return a reference. 959815 1 219246 kling 2013-12-14 03:00:43 -0800 Created attachment 219246 Patch 959824 2 219246 commit-queue 2013-12-14 04:36:32 -0800 Comment on attachment 219246 Patch Clearing flags on attachment: 219246 Committed r160595: <http://trac.webkit.org/changeset/160595> 959825 3 commit-queue 2013-12-14 04:36:34 -0800 All reviewed patches have been landed. Closing bug. 219246 2013-12-14 03:00:43 -0800 2013-12-14 04:36:32 -0800 Patch bug-125735.diff text/plain 5642 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5ODRkMzhiLi42MDJmNjQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTMtMTItMTQgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFJlbmRlckVsZW1lbnQ6OnJlbmRlcmVyRm9yUm9vdEJhY2tncm91bmQoKSBzaG91bGQgcmV0 dXJuIGEgcmVmZXJlbmNlLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTI1NzM1Pgor CisgICAgICAgIFRoaXMgZnVuY3Rpb24gYWx3YXlzIGZpbmRzIGEgcmVuZGVyZXIgdG8gcmV0dXJu LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAyMDEzLTEyLTEzICBB bmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIGEgY291cGxl IG9mIGlubGluZXMgZnJvbSBSZW5kZXJPYmplY3QgdG8gUmVuZGVyRWxlbWVudC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKaW5kZXggY2Y2ZWMzZS4uODk0NGQ3MyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKQEAgLTExMjQsMTIgKzExMjQsMTIgQEAg dm9pZCBSZW5kZXJCb3g6OnBhaW50Um9vdEJveEZpbGxMYXllcnMoY29uc3QgUGFpbnRJbmZvJiBw YWludEluZm8pCiAgICAgaWYgKHBhaW50SW5mby5za2lwUm9vdEJhY2tncm91bmQoKSkKICAgICAg ICAgcmV0dXJuOwogCi0gICAgYXV0byByb290QmFja2dyb3VuZFJlbmRlcmVyID0gcmVuZGVyZXJG b3JSb290QmFja2dyb3VuZCgpOworICAgIGF1dG8mIHJvb3RCYWNrZ3JvdW5kUmVuZGVyZXIgPSBy ZW5kZXJlckZvclJvb3RCYWNrZ3JvdW5kKCk7CiAgICAgCi0gICAgY29uc3QgRmlsbExheWVyKiBi Z0xheWVyID0gcm9vdEJhY2tncm91bmRSZW5kZXJlci0+c3R5bGUoKS5iYWNrZ3JvdW5kTGF5ZXJz KCk7Ci0gICAgQ29sb3IgYmdDb2xvciA9IHJvb3RCYWNrZ3JvdW5kUmVuZGVyZXItPnN0eWxlKCku dmlzaXRlZERlcGVuZGVudENvbG9yKENTU1Byb3BlcnR5QmFja2dyb3VuZENvbG9yKTsKKyAgICBj b25zdCBGaWxsTGF5ZXIqIGJnTGF5ZXIgPSByb290QmFja2dyb3VuZFJlbmRlcmVyLnN0eWxlKCku YmFja2dyb3VuZExheWVycygpOworICAgIENvbG9yIGJnQ29sb3IgPSByb290QmFja2dyb3VuZFJl bmRlcmVyLnN0eWxlKCkudmlzaXRlZERlcGVuZGVudENvbG9yKENTU1Byb3BlcnR5QmFja2dyb3Vu ZENvbG9yKTsKIAotICAgIHBhaW50RmlsbExheWVycyhwYWludEluZm8sIGJnQ29sb3IsIGJnTGF5 ZXIsIHZpZXcoKS5iYWNrZ3JvdW5kUmVjdCh0aGlzKSwgQmFja2dyb3VuZEJsZWVkTm9uZSwgQ29t cG9zaXRlU291cmNlT3Zlciwgcm9vdEJhY2tncm91bmRSZW5kZXJlcik7CisgICAgcGFpbnRGaWxs TGF5ZXJzKHBhaW50SW5mbywgYmdDb2xvciwgYmdMYXllciwgdmlldygpLmJhY2tncm91bmRSZWN0 KHRoaXMpLCBCYWNrZ3JvdW5kQmxlZWROb25lLCBDb21wb3NpdGVTb3VyY2VPdmVyLCAmcm9vdEJh Y2tncm91bmRSZW5kZXJlcik7CiB9CiAKIEJhY2tncm91bmRCbGVlZEF2b2lkYW5jZSBSZW5kZXJC b3g6OmRldGVybWluZUJhY2tncm91bmRCbGVlZEF2b2lkYW5jZShHcmFwaGljc0NvbnRleHQqIGNv bnRleHQpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAK aW5kZXggZTdiYzU2Zi4uNjA4OGQ5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJFbGVtZW50LmNwcApAQCAtMTA3NSw3ICsxMDc1LDcgQEAgdm9pZCBSZW5kZXJFbGVtZW50Ojpz ZXROZWVkc1NpbXBsaWZpZWROb3JtYWxGbG93TGF5b3V0KCkKICAgICAgICAgc2V0TGF5ZXJOZWVk c0Z1bGxSZXBhaW50KCk7CiB9CiAKLVJlbmRlckVsZW1lbnQqIFJlbmRlckVsZW1lbnQ6OnJlbmRl cmVyRm9yUm9vdEJhY2tncm91bmQoKQorUmVuZGVyRWxlbWVudCYgUmVuZGVyRWxlbWVudDo6cmVu ZGVyZXJGb3JSb290QmFja2dyb3VuZCgpCiB7CiAgICAgQVNTRVJUKGlzUm9vdCgpKTsKICAgICBp ZiAoIWhhc0JhY2tncm91bmQoKSAmJiBlbGVtZW50KCkgJiYgZWxlbWVudCgpLT5oYXNUYWdOYW1l KEhUTUxOYW1lczo6aHRtbFRhZykpIHsKQEAgLTEwODYsMTEgKzEwODYsMTEgQEAgUmVuZGVyRWxl bWVudCogUmVuZGVyRWxlbWVudDo6cmVuZGVyZXJGb3JSb290QmFja2dyb3VuZCgpCiAgICAgICAg IGlmIChhdXRvIGJvZHkgPSBkb2N1bWVudCgpLmJvZHkoKSkgewogICAgICAgICAgICAgaWYgKGJv ZHktPmhhc0xvY2FsTmFtZShIVE1MTmFtZXM6OmJvZHlUYWcpKSB7CiAgICAgICAgICAgICAgICAg aWYgKGF1dG8gcmVuZGVyZXIgPSBib2R5LT5yZW5kZXJlcigpKQotICAgICAgICAgICAgICAgICAg ICByZXR1cm4gcmVuZGVyZXI7CisgICAgICAgICAgICAgICAgICAgIHJldHVybiAqcmVuZGVyZXI7 CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9Ci0gICAgcmV0dXJuIHRoaXM7CisgICAg cmV0dXJuICp0aGlzOwogfQogCiBSZW5kZXJFbGVtZW50KiBSZW5kZXJFbGVtZW50Ojpob3ZlckFu Y2VzdG9yKCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5oCmlu ZGV4IDUxY2YwNGEuLmYzZjE2ZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVs ZW1lbnQuaApAQCAtOTksNyArOTksNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBsYXlvdXRJZk5lZWRl ZCgpIHsgaWYgKG5lZWRzTGF5b3V0KCkpIGxheW91dCgpOyB9CiAKICAgICAvLyBSZXR1cm4gdGhl IHJlbmRlcmVyIHdob3NlIGJhY2tncm91bmQgc3R5bGUgaXMgdXNlZCB0byBwYWludCB0aGUgcm9v dCBiYWNrZ3JvdW5kLiBTaG91bGQgb25seSBiZSBjYWxsZWQgb24gdGhlIHJlbmRlcmVyIGZvciB3 aGljaCBpc1Jvb3QoKSBpcyB0cnVlLgotICAgIFJlbmRlckVsZW1lbnQqIHJlbmRlcmVyRm9yUm9v dEJhY2tncm91bmQoKTsKKyAgICBSZW5kZXJFbGVtZW50JiByZW5kZXJlckZvclJvb3RCYWNrZ3Jv dW5kKCk7CiAKICAgICAvLyBVc2VkIG9ubHkgYnkgRWxlbWVudDo6cHNldWRvU3R5bGVDYWNoZUlz SW52YWxpZCB0byBnZXQgYSBmaXJzdCBsaW5lIHN0eWxlIGJhc2VkIG9mZiBvZiBhCiAgICAgLy8g Z2l2ZW4gbmV3IHN0eWxlLCB3aXRob3V0IGFjY2Vzc2luZyB0aGUgY2FjaGUuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCmluZGV4IDczYzZkNWYu LjEyOTVhMDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ckJhY2tpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJh Y2tpbmcuY3BwCkBAIC0xNTQ5LDExICsxNTQ5LDggQEAgc3RhdGljIGJvb2wgaGFzUGVyc3BlY3Rp dmVPclByZXNlcnZlczNEKGNvbnN0IFJlbmRlclN0eWxlKiBzdHlsZSkKIAogQ29sb3IgUmVuZGVy TGF5ZXJCYWNraW5nOjpyZW5kZXJlckJhY2tncm91bmRDb2xvcigpIGNvbnN0CiB7Ci0gICAgUmVu ZGVyRWxlbWVudCogYmFja2dyb3VuZFJlbmRlcmVyID0gJnJlbmRlcmVyKCk7Ci0gICAgaWYgKGJh Y2tncm91bmRSZW5kZXJlci0+aXNSb290KCkpCi0gICAgICAgIGJhY2tncm91bmRSZW5kZXJlciA9 IGJhY2tncm91bmRSZW5kZXJlci0+cmVuZGVyZXJGb3JSb290QmFja2dyb3VuZCgpOwotCi0gICAg cmV0dXJuIGJhY2tncm91bmRSZW5kZXJlci0+c3R5bGUoKS52aXNpdGVkRGVwZW5kZW50Q29sb3Io Q1NTUHJvcGVydHlCYWNrZ3JvdW5kQ29sb3IpOworICAgIGNvbnN0IGF1dG8mIGJhY2tncm91bmRS ZW5kZXJlciA9IHJlbmRlcmVyKCkuaXNSb290KCkgPyByZW5kZXJlcigpLnJlbmRlcmVyRm9yUm9v dEJhY2tncm91bmQoKSA6IHJlbmRlcmVyKCk7CisgICAgcmV0dXJuIGJhY2tncm91bmRSZW5kZXJl ci5zdHlsZSgpLnZpc2l0ZWREZXBlbmRlbnRDb2xvcihDU1NQcm9wZXJ0eUJhY2tncm91bmRDb2xv cik7CiB9CiAKIHZvaWQgUmVuZGVyTGF5ZXJCYWNraW5nOjp1cGRhdGVEaXJlY3RseUNvbXBvc2l0 ZWRCYWNrZ3JvdW5kQ29sb3IoYm9vbCBpc1NpbXBsZUNvbnRhaW5lciwgYm9vbCYgZGlkVXBkYXRl Q29udGVudHNSZWN0KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCmluZGV4 IDdlNTZmYzIuLmZkZjczNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5j cHAKQEAgLTQ4Nyw4ICs0ODcsNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgcmVuZGVyZXJPYnNjdXJl c0JhY2tncm91bmQoUmVuZGVyRWxlbWVudCogcm9vdE9iamVjdCkKICAgICBpZiAoaXNDb21wb3Np dGVkKHJvb3RPYmplY3QpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBjb25zdCBSZW5k ZXJFbGVtZW50KiByb290UmVuZGVyZXIgPSByb290T2JqZWN0LT5yZW5kZXJlckZvclJvb3RCYWNr Z3JvdW5kKCk7Ci0gICAgaWYgKHJvb3RSZW5kZXJlci0+c3R5bGUoKS5iYWNrZ3JvdW5kQ2xpcCgp ID09IFRleHRGaWxsQm94KQorICAgIGlmIChyb290T2JqZWN0LT5yZW5kZXJlckZvclJvb3RCYWNr Z3JvdW5kKCkuc3R5bGUoKS5iYWNrZ3JvdW5kQ2xpcCgpID09IFRleHRGaWxsQm94KQogICAgICAg ICByZXR1cm4gZmFsc2U7CiAKICAgICByZXR1cm4gdHJ1ZTsKQEAgLTEwMDYsOCArMTAwNSw3IEBA IGJvb2wgUmVuZGVyVmlldzo6cm9vdEJhY2tncm91bmRJc0VudGlyZWx5Rml4ZWQoKSBjb25zdAog ICAgIGlmICghcm9vdE9iamVjdCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgUmVuZGVy RWxlbWVudCogcm9vdFJlbmRlcmVyID0gcm9vdE9iamVjdC0+cmVuZGVyZXJGb3JSb290QmFja2dy b3VuZCgpOwotICAgIHJldHVybiByb290UmVuZGVyZXItPmhhc0VudGlyZWx5Rml4ZWRCYWNrZ3Jv dW5kKCk7CisgICAgcmV0dXJuIHJvb3RPYmplY3QtPnJlbmRlcmVyRm9yUm9vdEJhY2tncm91bmQo KS5oYXNFbnRpcmVseUZpeGVkQmFja2dyb3VuZCgpOwogfQogCiBMYXlvdXRSZWN0IFJlbmRlclZp ZXc6OmJhY2tncm91bmRSZWN0KFJlbmRlckJveCogYmFja2dyb3VuZFJlbmRlcmVyKSBjb25zdAo=