125734 2013-12-13 23:32:17 -0800 Move a couple of inlines from RenderObject to RenderElement. 2013-12-14 04:37:26 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue kling koivisto oldest_to_newest 959801 0 kling 2013-12-13 23:32:17 -0800 Patch inc. 959802 1 219243 kling 2013-12-13 23:32:41 -0800 Created attachment 219243 Patch 959817 2 219243 koivisto 2013-12-14 03:52:18 -0800 Comment on attachment 219243 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219243&action=review > Source/WebCore/ChangeLog:7 > + and move them over to RenderElement where style() is branchless. Maybe it should be called styleSlow() 959827 3 219243 commit-queue 2013-12-14 04:37:24 -0800 Comment on attachment 219243 Patch Clearing flags on attachment: 219243 Committed r160596: <http://trac.webkit.org/changeset/160596> 959828 4 commit-queue 2013-12-14 04:37:26 -0800 All reviewed patches have been landed. Closing bug. 219243 2013-12-13 23:32:41 -0800 2013-12-14 04:37:24 -0800 Patch bug-125734.diff text/plain 4930 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ODM0ZTcwLi45ODRkMzhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUg QEAKIDIwMTMtMTItMTMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIE1vdmUgYSBjb3VwbGUgb2YgaW5saW5lcyBmcm9tIFJlbmRlck9iamVjdCB0byBSZW5kZXJF bGVtZW50LgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTI1NzM0PgorCisgICAgICAg IFRha2UgbW9zdCBvZiB0aGUgaW5saW5lIGZ1bmN0aW9ucyBvbiBSZW5kZXJPYmplY3QgdGhhdCBj YWxsIHN0eWxlKCkKKyAgICAgICAgYW5kIG1vdmUgdGhlbSBvdmVyIHRvIFJlbmRlckVsZW1lbnQg d2hlcmUgc3R5bGUoKSBpcyBicmFuY2hsZXNzLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisyMDEzLTEyLTEzICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNv bT4KKwogICAgICAgICBNb3ZlIFJlbmRlck9iamVjdDo6cmVwYWludEFmdGVyTGF5b3V0SWZOZWVk ZWQoKSB0byBSZW5kZXJFbGVtZW50LgogICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTI1 NzEyPgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0RlbGV0ZUJ1dHRvbkNv bnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9EZWxldGVCdXR0b25Db250cm9s bGVyLmNwcAppbmRleCBkM2MwOGM0Li4wOTQ4OGU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9lZGl0aW5nL0RlbGV0ZUJ1dHRvbkNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2VkaXRpbmcvRGVsZXRlQnV0dG9uQ29udHJvbGxlci5jcHAKQEAgLTEyNSw3ICsxMjUsNyBAQCBz dGF0aWMgYm9vbCBpc0RlbGV0YWJsZUVsZW1lbnQoY29uc3QgTm9kZSogbm9kZSkKICAgICAgICAg aWYgKCFwYXJlbnROb2RlKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgICAgIFJl bmRlck9iamVjdCogcGFyZW50UmVuZGVyZXIgPSBwYXJlbnROb2RlLT5yZW5kZXJlcigpOworICAg ICAgICBhdXRvIHBhcmVudFJlbmRlcmVyID0gcGFyZW50Tm9kZS0+cmVuZGVyZXIoKTsKICAgICAg ICAgaWYgKCFwYXJlbnRSZW5kZXJlcikKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuaCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50LmgKaW5kZXggZTI5OTJhZC4uNTFjZjA0 YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5oCkBAIC0xMTQsNiAr MTE0LDI5IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgYm9yZGVySW1hZ2VJc0xvYWRlZEFuZENhbkJl UmVuZGVyZWQoKSBjb25zdDsKIAorICAgIC8vIFJldHVybnMgdHJ1ZSBpZiB0aGlzIHJlbmRlcmVy IHJlcXVpcmVzIGEgbmV3IHN0YWNraW5nIGNvbnRleHQuCisgICAgYm9vbCBjcmVhdGVzR3JvdXAo KSBjb25zdCB7IHJldHVybiBpc1RyYW5zcGFyZW50KCkgfHwgaGFzTWFzaygpIHx8IGhhc0ZpbHRl cigpIHx8IGhhc0JsZW5kTW9kZSgpOyB9CisKKyAgICBib29sIGlzVHJhbnNwYXJlbnQoKSBjb25z dCB7IHJldHVybiBzdHlsZSgpLm9wYWNpdHkoKSA8IDEuMGY7IH0KKyAgICBmbG9hdCBvcGFjaXR5 KCkgY29uc3QgeyByZXR1cm4gc3R5bGUoKS5vcGFjaXR5KCk7IH0KKworICAgIGJvb2wgaGFzQmFj a2dyb3VuZCgpIGNvbnN0IHsgcmV0dXJuIHN0eWxlKCkuaGFzQmFja2dyb3VuZCgpOyB9CisgICAg Ym9vbCBoYXNNYXNrKCkgY29uc3QgeyByZXR1cm4gc3R5bGUoKS5oYXNNYXNrKCk7IH0KKyAgICBi b29sIGhhc0NsaXBQYXRoKCkgY29uc3QgeyByZXR1cm4gc3R5bGUoKS5jbGlwUGF0aCgpOyB9Cisg ICAgYm9vbCBoYXNIaWRkZW5CYWNrZmFjZSgpIGNvbnN0IHsgcmV0dXJuIHN0eWxlKCkuYmFja2Zh Y2VWaXNpYmlsaXR5KCkgPT0gQmFja2ZhY2VWaXNpYmlsaXR5SGlkZGVuOyB9CisKKyNpZiBFTkFC TEUoQ1NTX0ZJTFRFUlMpCisgICAgYm9vbCBoYXNGaWx0ZXIoKSBjb25zdCB7IHJldHVybiBzdHls ZSgpLmhhc0ZpbHRlcigpOyB9CisjZWxzZQorICAgIGJvb2wgaGFzRmlsdGVyKCkgY29uc3QgeyBy ZXR1cm4gZmFsc2U7IH0KKyNlbmRpZgorCisjaWYgRU5BQkxFKENTU19DT01QT1NJVElORykKKyAg ICBib29sIGhhc0JsZW5kTW9kZSgpIGNvbnN0IHsgcmV0dXJuIHN0eWxlKCkuaGFzQmxlbmRNb2Rl KCk7IH0KKyNlbHNlCisgICAgYm9vbCBoYXNCbGVuZE1vZGUoKSBjb25zdCB7IHJldHVybiBmYWxz ZTsgfQorI2VuZGlmCisKIHByb3RlY3RlZDoKICAgICBlbnVtIEJhc2VUeXBlRmxhZ3MgewogICAg ICAgICBSZW5kZXJMYXllck1vZGVsT2JqZWN0RmxhZyA9IDEgPDwgMCwKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJPYmplY3QuaAppbmRleCAyYjY5M2U1Li4yMTI5ODgyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCkBAIC01NDEsNyArNTQxLDYgQEAgcHVibGlj OgogICAgIH07CiAgICAgYm9vbCBoYXNCb3hEZWNvcmF0aW9ucygpIGNvbnN0IHsgcmV0dXJuIG1f Yml0ZmllbGRzLmJveERlY29yYXRpb25TdGF0ZSgpICE9IE5vQm94RGVjb3JhdGlvbnM7IH0KICAg ICBib29sIGJhY2tncm91bmRJc0tub3duVG9CZU9ic2N1cmVkKCk7Ci0gICAgYm9vbCBoYXNCYWNr Z3JvdW5kKCkgY29uc3QgeyByZXR1cm4gc3R5bGUoKS5oYXNCYWNrZ3JvdW5kKCk7IH0KICAgICBi b29sIGhhc0VudGlyZWx5Rml4ZWRCYWNrZ3JvdW5kKCkgY29uc3Q7CiAKICAgICBib29sIG5lZWRz TGF5b3V0KCkgY29uc3QKQEAgLTU3MSwyMSArNTcwLDYgQEAgcHVibGljOgogICAgIGJvb2wgaGFz Q2xpcE9yT3ZlcmZsb3dDbGlwKCkgY29uc3QgeyByZXR1cm4gaGFzQ2xpcCgpIHx8IGhhc092ZXJm bG93Q2xpcCgpOyB9CiAKICAgICBib29sIGhhc1RyYW5zZm9ybSgpIGNvbnN0IHsgcmV0dXJuIG1f Yml0ZmllbGRzLmhhc1RyYW5zZm9ybSgpOyB9Ci0gICAgYm9vbCBoYXNNYXNrKCkgY29uc3QgeyBy ZXR1cm4gc3R5bGUoKS5oYXNNYXNrKCk7IH0KLSAgICBib29sIGhhc0NsaXBQYXRoKCkgY29uc3Qg eyByZXR1cm4gc3R5bGUoKS5jbGlwUGF0aCgpOyB9Ci0gICAgYm9vbCBoYXNIaWRkZW5CYWNrZmFj ZSgpIGNvbnN0IHsgcmV0dXJuIHN0eWxlKCkuYmFja2ZhY2VWaXNpYmlsaXR5KCkgPT0gQmFja2Zh Y2VWaXNpYmlsaXR5SGlkZGVuOyB9Ci0KLSNpZiBFTkFCTEUoQ1NTX0ZJTFRFUlMpCi0gICAgYm9v bCBoYXNGaWx0ZXIoKSBjb25zdCB7IHJldHVybiBzdHlsZSgpLmhhc0ZpbHRlcigpOyB9Ci0jZWxz ZQotICAgIGJvb2wgaGFzRmlsdGVyKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KLSNlbmRpZgot Ci0jaWYgRU5BQkxFKENTU19DT01QT1NJVElORykKLSAgICBib29sIGhhc0JsZW5kTW9kZSgpIGNv bnN0IHsgcmV0dXJuIHN0eWxlKCkuaGFzQmxlbmRNb2RlKCk7IH0KLSNlbHNlCi0gICAgYm9vbCBo YXNCbGVuZE1vZGUoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQotI2VuZGlmCiAKICAgICBpbmxp bmUgYm9vbCBwcmVzZXJ2ZXNOZXdsaW5lKCkgY29uc3Q7CiAKQEAgLTgwNSw5ICs3ODksNiBAQCBw dWJsaWM6CiAKICAgICBib29sIGlzRmxvYXRpbmdPck91dE9mRmxvd1Bvc2l0aW9uZWQoKSBjb25z dCB7IHJldHVybiAoaXNGbG9hdGluZygpIHx8IGlzT3V0T2ZGbG93UG9zaXRpb25lZCgpKTsgfQog Ci0gICAgYm9vbCBpc1RyYW5zcGFyZW50KCkgY29uc3QgeyByZXR1cm4gc3R5bGUoKS5vcGFjaXR5 KCkgPCAxLjBmOyB9Ci0gICAgZmxvYXQgb3BhY2l0eSgpIGNvbnN0IHsgcmV0dXJuIHN0eWxlKCku b3BhY2l0eSgpOyB9Ci0KICAgICBib29sIGhhc1JlZmxlY3Rpb24oKSBjb25zdCB7IHJldHVybiBt X2JpdGZpZWxkcy5oYXNSZWZsZWN0aW9uKCk7IH0KIAogICAgIC8vIEFwcGxpZWQgYXMgYSAic2xv cCIgdG8gZGlydHkgcmVjdCBjaGVja3MgZHVyaW5nIHRoZSBvdXRsaW5lIHBhaW50aW5nIHBoYXNl J3MgZGlydHktcmVjdCBjaGVja3MuCkBAIC05MDQsOSArODg1LDYgQEAgcHVibGljOgogICAgIGJv b2wgc2hvdWxkVXNlVHJhbnNmb3JtRnJvbUNvbnRhaW5lcihjb25zdCBSZW5kZXJPYmplY3QqIGNv bnRhaW5lcikgY29uc3Q7CiAgICAgdm9pZCBnZXRUcmFuc2Zvcm1Gcm9tQ29udGFpbmVyKGNvbnN0 IFJlbmRlck9iamVjdCogY29udGFpbmVyLCBjb25zdCBMYXlvdXRTaXplJiBvZmZzZXRJbkNvbnRh aW5lciwgVHJhbnNmb3JtYXRpb25NYXRyaXgmKSBjb25zdDsKICAgICAKLSAgICAvLyByZXR1cm4g dHJ1ZSBpZiB0aGlzIG9iamVjdCByZXF1aXJlcyBhIG5ldyBzdGFja2luZyBjb250ZXh0Ci0gICAg Ym9vbCBjcmVhdGVzR3JvdXAoKSBjb25zdCB7IHJldHVybiBpc1RyYW5zcGFyZW50KCkgfHwgaGFz TWFzaygpIHx8IGhhc0ZpbHRlcigpIHx8IGhhc0JsZW5kTW9kZSgpOyB9IAotICAgIAogICAgIHZp cnR1YWwgdm9pZCBhZGRGb2N1c1JpbmdSZWN0cyhWZWN0b3I8SW50UmVjdD4mLCBjb25zdCBMYXlv dXRQb2ludCYgLyogYWRkaXRpb25hbE9mZnNldCAqLywgY29uc3QgUmVuZGVyTGF5ZXJNb2RlbE9i amVjdCogLyogcGFpbnRDb250YWluZXIgKi8gPSAwKSB7IH07CiAKICAgICBMYXlvdXRSZWN0IGFi c29sdXRlT3V0bGluZUJvdW5kcygpIGNvbnN0Cg==