125721 2013-12-13 19:04:14 -0800 [Cocoa] Expose some layout milestones 2013-12-15 10:24:56 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz commit-queue sam simon.fraser oldest_to_newest 959734 0 mitz 2013-12-13 19:04:14 -0800 [Cocoa] Expose some layout milestones 959735 1 219220 mitz 2013-12-13 19:09:28 -0800 Created attachment 219220 Add -browsingContextController:renderingProgressDidChange: 959736 2 commit-queue 2013-12-13 19:11:05 -0800 Attachment 219220 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h:39: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 959864 3 mitz 2013-12-14 15:21:49 -0800 Committed <http://trac.webkit.org/r160602>. 959935 4 simon.fraser 2013-12-15 10:09:40 -0800 This broke the 32-bit build: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20%2832-bit%20Build%29?numbuilds=100 959936 5 mitz 2013-12-15 10:13:34 -0800 (In reply to comment #4) > This broke the 32-bit build: > http://build.webkit.org/builders/Apple%20MountainLion%20Release%20%2832-bit%20Build%29?numbuilds=100 Attempted fix in <http://trac.webkit.org/r160619>. 959937 6 mitz 2013-12-15 10:20:39 -0800 More fixes coming up 959938 7 mitz 2013-12-15 10:24:56 -0800 TestWebKitAPI fix in <http://trac.webkit.org/r160620>. 219220 2013-12-13 19:09:28 -0800 2013-12-13 19:29:02 -0800 Add -browsingContextController:renderingProgressDidChange: bug-125721-20131213190950.patch text/plain 5879 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MDU4MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEzLTEyLTEzICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBFeHBvc2Ugc29tZSBs YXlvdXQgbWlsZXN0b25lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTI1NzIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxl ci5oOgorICAgICAgICAoV0tSZW5kZXJpbmdQcm9ncmVzc0V2ZW50cyk6IERlY2xhcmVkIG5ldyBl bnVtLgorICAgICAgICAoQGludGVyZmFjZSBXS0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIpOiBE ZWNsYXJlZCBuZXcgb2JzZXJ2ZWRSZW5kZXJpbmdQcm9ncmVzc0V2ZW50cworICAgICAgICBwcm9w ZXJ0eS4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLQnJvd3NpbmdDb250ZXh0Q29u dHJvbGxlci5tbToKKyAgICAgICAgKGxheW91dE1pbGVzdG9uZXMpOiBBZGRlZCBoZWxwZXIgdG8g dHJhbnNsYXRlIHJlbmRlcmluZyBwcm9ncmVzcyBldmVudHMgaW50byBsYXlvdXQKKyAgICAgICAg bWlsZXN0b25lcy4KKyAgICAgICAgKC1bV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVyIHNldE9i c2VydmVkUmVuZGVyaW5nUHJvZ3Jlc3NFdmVudHM6XSk6IEFkZGVkIHRoaXMgc2V0dGVyLgorICAg ICAgICBTZXRzIHRoZSBpdmFyIGFuZCBjYWxscyBXZWJQYWdlUHJveHk6Omxpc3RlbkZvckxheW91 dE1pbGVzdG9uZXMuCisgICAgICAgIChyZW5kZXJpbmdQcm9ncmVzc0V2ZW50cyk6IEFkZGVkIGhl bHBlciB0byB0cmFuc2xhdGUgbGF5b3V0IG1pbGVzdG9uZXMgaW50byByZW5kZXJpbmcKKyAgICAg ICAgcHJvZ3Jlc3MgZXZlbnRzLgorICAgICAgICAoZGlkTGF5b3V0KTogSW1wbGVtZW50ZWQgdGhp cyBXS1BhZ2VMb2FkZXJDbGllbnQgY2FsbGJhY2sgYnkgY2FsbGluZyB0aGUgbG9hZCBkZWxlZ2F0 ZS4KKyAgICAgICAgKHNldFVwUGFnZUxvYWRlckNsaWVudCk6IFNldCB0aGUgYWJvdmUgY2FsbGJh Y2sgaW4gdGhlIGNsaWVudCBzdHJ1Y3R1cmUuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS0Jyb3dzaW5nQ29udGV4dExvYWREZWxlZ2F0ZS5oOiBEZWNsYXJlZCBuZXcgZGVsZWdhdGUg bWV0aG9kLgorCiAyMDEzLTEyLTEzICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgW1dLMl0gU3RhcnQgcmVtb3ZpbmcgY2FsbHMgdG8gU3RyaW5nOjpjaGFyYWN0ZXJzKCkK SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tCcm93c2luZ0NvbnRl eHRDb250cm9sbGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIuaAkocmV2aXNpb24gMTYwNTQ2KQor KysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS0Jyb3dzaW5nQ29udGV4dENv bnRyb2xsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMzYsNiArMzYsMTEgQEAKIEBwcm90b2NvbCBX S0Jyb3dzaW5nQ29udGV4dExvYWREZWxlZ2F0ZTsKIEBwcm90b2NvbCBXS0Jyb3dzaW5nQ29udGV4 dFBvbGljeURlbGVnYXRlOwogCit0eXBlZGVmIE5TX09QVElPTlMoTlNVSW50ZWdlciwgV0tSZW5k ZXJpbmdQcm9ncmVzc0V2ZW50cykgeworICAgIFdLUmVuZGVyaW5nUHJvZ3Jlc3NFdmVudEZpcnN0 TGF5b3V0ID0gMSA8PCAwLAorICAgIFdLUmVuZGVyaW5nUHJvZ3Jlc3NFdmVudEZpcnN0UGFpbnRX aXRoU2lnbmlmaWNhbnRBcmVhID0gMSA8PCAyLAorfTsKKwogV0tfQVBJX0NMQVNTCiBAaW50ZXJm YWNlIFdLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxlciA6IE5TT2JqZWN0CiAKQEAgLTEyMSw2ICsx MjYsOCBAQCBXS19BUElfQ0xBU1MKIAogQHByb3BlcnR5KHJlYWRvbmx5KSBkb3VibGUgZXN0aW1h dGVkUHJvZ3Jlc3M7CiAKK0Bwcm9wZXJ0eSBXS1JlbmRlcmluZ1Byb2dyZXNzRXZlbnRzIG9ic2Vy dmVkUmVuZGVyaW5nUHJvZ3Jlc3NFdmVudHM7CisKICNwcmFnbWEgbWFyayBBY3RpdmUgRG9jdW1l bnQgSW50cm9zcGVjdGlvbgogCiAvKiBUaXRsZSBvZiB0aGUgZG9jdW1lbnQgYXNzb2NpYXRlZCB3 aXRoIHRoZSBhY3RpdmUgbG9hZC4gKi8KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvQ29jb2EvV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVyLm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tCcm93c2luZ0NvbnRleHRDb250cm9s bGVyLm1tCShyZXZpc2lvbiAxNjA1NDYpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxlci5tbQkod29ya2luZyBjb3B5KQpAQCAt MzMzLDYgKzMzMywyNSBAQCAtIChkb3VibGUpZXN0aW1hdGVkUHJvZ3Jlc3MKICAgICByZXR1cm4g X3BhZ2UtPmVzdGltYXRlZFByb2dyZXNzKCk7CiB9CiAKK3N0YXRpYyBpbmxpbmUgTGF5b3V0TWls ZXN0b25lcyBsYXlvdXRNaWxlc3RvbmVzKFdLUmVuZGVyaW5nUHJvZ3Jlc3NFdmVudHMgZXZlbnRz KQoreworICAgIExheW91dE1pbGVzdG9uZXMgbWlsZXN0b25lcyA9IDA7CisKKyAgICBpZiAoZXZl bnRzICYgV0tSZW5kZXJpbmdQcm9ncmVzc0V2ZW50Rmlyc3RMYXlvdXQpCisgICAgICAgIG1pbGVz dG9uZXMgfD0gRGlkRmlyc3RMYXlvdXQ7CisKKyAgICBpZiAoZXZlbnRzICYgV0tSZW5kZXJpbmdQ cm9ncmVzc0V2ZW50Rmlyc3RQYWludFdpdGhTaWduaWZpY2FudEFyZWEpCisgICAgICAgIG1pbGVz dG9uZXMgfD0gRGlkSGl0UmVsZXZhbnRSZXBhaW50ZWRPYmplY3RzQXJlYVRocmVzaG9sZDsKKwor ICAgIHJldHVybiBtaWxlc3RvbmVzOworfQorCistICh2b2lkKXNldE9ic2VydmVkUmVuZGVyaW5n UHJvZ3Jlc3NFdmVudHM6KFdLUmVuZGVyaW5nUHJvZ3Jlc3NFdmVudHMpZXZlbnRzCit7CisgICAg X29ic2VydmVkUmVuZGVyaW5nUHJvZ3Jlc3NFdmVudHMgPSBldmVudHM7CisgICAgX3BhZ2UtPmxp c3RlbkZvckxheW91dE1pbGVzdG9uZXMobGF5b3V0TWlsZXN0b25lcyhldmVudHMpKTsKK30KKwog I3ByYWdtYSBtYXJrIEFjdGl2ZSBEb2N1bWVudCBJbnRyb3NwZWN0aW9uCiAKIC0gKE5TU3RyaW5n ICopdGl0bGUKQEAgLTUyMSw2ICs1NDAsMjggQEAgc3RhdGljIHZvaWQgcHJvY2Vzc0RpZENyYXNo KFdLUGFnZVJlZiBwYQogICAgICAgICBbKGlkIDxXS0Jyb3dzaW5nQ29udGV4dExvYWREZWxlZ2F0 ZVByaXZhdGU+KWxvYWREZWxlZ2F0ZSBicm93c2luZ0NvbnRleHRDb250cm9sbGVyV2ViUHJvY2Vz c0RpZENyYXNoOmJyb3dzaW5nQ29udGV4dF07CiB9CiAKK3N0YXRpYyBpbmxpbmUgV0tSZW5kZXJp bmdQcm9ncmVzc0V2ZW50cyByZW5kZXJpbmdQcm9ncmVzc0V2ZW50cyhXS0xheW91dE1pbGVzdG9u ZXMgbWlsZXN0b25lcykKK3sKKyAgICBXS1JlbmRlcmluZ1Byb2dyZXNzRXZlbnRzIGV2ZW50cyA9 IDA7CisKKyAgICBpZiAobWlsZXN0b25lcyAmIGtXS0RpZEZpcnN0TGF5b3V0KQorICAgICAgICBl dmVudHMgfD0gV0tSZW5kZXJpbmdQcm9ncmVzc0V2ZW50Rmlyc3RMYXlvdXQ7CisKKyAgICBpZiAo bWlsZXN0b25lcyAmIGtXS0RpZEhpdFJlbGV2YW50UmVwYWludGVkT2JqZWN0c0FyZWFUaHJlc2hv bGQpCisgICAgICAgIGV2ZW50cyB8PSBXS1JlbmRlcmluZ1Byb2dyZXNzRXZlbnRGaXJzdFBhaW50 V2l0aFNpZ25pZmljYW50QXJlYTsKKworICAgIHJldHVybiBldmVudHM7Cit9CisKK3N0YXRpYyB2 b2lkIGRpZExheW91dChXS1BhZ2VSZWYgcGFnZSwgV0tMYXlvdXRNaWxlc3RvbmVzIG1pbGVzdG9u ZXMsIFdLVHlwZVJlZiB1c2VyRGF0YSwgY29uc3Qgdm9pZCogY2xpZW50SW5mbykKK3sKKyAgICBX S0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIgKmJyb3dzaW5nQ29udGV4dCA9IChXS0Jyb3dzaW5n Q29udGV4dENvbnRyb2xsZXIgKiljbGllbnRJbmZvOworICAgIGF1dG8gbG9hZERlbGVnYXRlID0g YnJvd3NpbmdDb250ZXh0LT5fbG9hZERlbGVnYXRlLmdldCgpOworCisgICAgaWYgKFtsb2FkRGVs ZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcihicm93c2luZ0NvbnRleHRDb250cm9s bGVyOnJlbmRlcmluZ1Byb2dyZXNzRGlkQ2hhbmdlOildKQorICAgICAgICBbbG9hZERlbGVnYXRl IGJyb3dzaW5nQ29udGV4dENvbnRyb2xsZXI6YnJvd3NpbmdDb250ZXh0IHJlbmRlcmluZ1Byb2dy ZXNzRGlkQ2hhbmdlOnJlbmRlcmluZ1Byb2dyZXNzRXZlbnRzKG1pbGVzdG9uZXMpXTsKK30KKwog c3RhdGljIHZvaWQgc2V0VXBQYWdlTG9hZGVyQ2xpZW50KFdLQnJvd3NpbmdDb250ZXh0Q29udHJv bGxlciAqYnJvd3NpbmdDb250ZXh0LCBXZWJQYWdlUHJveHkmIHBhZ2UpCiB7CiAgICAgV0tQYWdl TG9hZGVyQ2xpZW50VjMgbG9hZGVyQ2xpZW50OwpAQCAtNTQ1LDYgKzU4Niw4IEBAIHN0YXRpYyB2 b2lkIHNldFVwUGFnZUxvYWRlckNsaWVudChXS0Jyb3cKIAogICAgIGxvYWRlckNsaWVudC5wcm9j ZXNzRGlkQ3Jhc2ggPSBwcm9jZXNzRGlkQ3Jhc2g7CiAKKyAgICBsb2FkZXJDbGllbnQuZGlkTGF5 b3V0ID0gZGlkTGF5b3V0OworCiAgICAgcGFnZS5pbml0aWFsaXplTG9hZGVyQ2xpZW50KCZsb2Fk ZXJDbGllbnQuYmFzZSk7CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Q29jb2EvV0tCcm93c2luZ0NvbnRleHRMb2FkRGVsZWdhdGUuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLQnJvd3NpbmdDb250ZXh0TG9hZERlbGVn YXRlLmgJKHJldmlzaW9uIDE2MDU0NikKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Q29jb2EvV0tCcm93c2luZ0NvbnRleHRMb2FkRGVsZWdhdGUuaAkod29ya2luZyBjb3B5KQpAQCAt MjUsNyArMjUsOCBAQAogCiAjaW1wb3J0IDxGb3VuZGF0aW9uL0ZvdW5kYXRpb24uaD4KIAotQGNs YXNzIFdLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxlcjsKKyNpbXBvcnQgPFdlYktpdDIvV0tCcm93 c2luZ0NvbnRleHRDb250cm9sbGVyLmg+CisKIEBjbGFzcyBXS0JhY2tGb3J3YXJkTGlzdEl0ZW07 CiAKIEBwcm90b2NvbCBXS0Jyb3dzaW5nQ29udGV4dExvYWREZWxlZ2F0ZSA8TlNPYmplY3Q+CkBA IC01NSw0ICs1Niw2IEBACiAKIC0gKHZvaWQpYnJvd3NpbmdDb250ZXh0Q29udHJvbGxlckRpZENo YW5nZUJhY2tGb3J3YXJkTGlzdDooV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVyICopc2VuZGVy IGFkZGVkSXRlbTooV0tCYWNrRm9yd2FyZExpc3RJdGVtICopYWRkZWRJdGVtIHJlbW92ZWRJdGVt czooTlNBcnJheSAqKXJlbW92ZWRJdGVtczsKIAorLSAodm9pZClicm93c2luZ0NvbnRleHRDb250 cm9sbGVyOihXS0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIgKilzZW5kZXIgcmVuZGVyaW5nUHJv Z3Jlc3NEaWRDaGFuZ2U6KFdLUmVuZGVyaW5nUHJvZ3Jlc3NFdmVudHMpcHJvZ3Jlc3NFdmVudDsK KwogQGVuZAo=