125716 2013-12-13 15:59:47 -0800 [Mac] Cache partitioning asserts when associated NSURLRequest is nil 2013-12-16 15:28:09 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified OS X 10.9 RESOLVED FIXED InRadar P2 Normal --- 1 jeffrey+webkit jeffrey+webkit ap darin oldest_to_newest 959706 0 jeffrey+webkit 2013-12-13 15:59:47 -0800 In some cases, a ResourceRequest may attempt to update the cache partition when the associated NSURLRequest is nil. This will trigger an assertion. <rdar://problem/15375976> 959707 1 219207 jeffrey+webkit 2013-12-13 16:03:26 -0800 Created attachment 219207 Patch 960231 2 jeffrey+webkit 2013-12-16 14:38:51 -0800 Committed r160663: <http://trac.webkit.org/changeset/160663> 960253 3 219207 ap 2013-12-16 15:26:09 -0800 Comment on attachment 219207 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219207&action=review > Source/WebCore/platform/network/mac/ResourceRequestMac.mm:114 > + m_cachePartition = cachePartition; Does m_cachePartition need to be reset to null when m_nsRequest is null? 960255 4 jeffrey+webkit 2013-12-16 15:28:09 -0800 (In reply to comment #3) > (From update of attachment 219207 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219207&action=review > > > Source/WebCore/platform/network/mac/ResourceRequestMac.mm:114 > > + m_cachePartition = cachePartition; > > Does m_cachePartition need to be reset to null when m_nsRequest is null? Since it doesn't reset m_cachePartition to null when the partition it gets out of the request is null either, I don't think this is necessary, but that might itself be a bug. 219207 2013-12-13 16:03:26 -0800 2013-12-16 15:26:09 -0800 Patch bug-125716-20131213160325.patch text/plain 1647 jeffrey+webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwNDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGIyNGFkMDJmOWI1YzQ5 YjAzYTFmNzQxMjUzZjY2ZGMyNjlhNGE1OC4uYTBkYTk0Mjk4ODIyMmNmNmU5MTgxNDE1YmE4Yzdi MmZhZWFlYmUwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEyLTEzICBKZWZm cmV5IFBmYXUgIDxqcGZhdUBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gQ2FjaGUgcGFydGl0 aW9uaW5nIGFzc2VydHMgd2hlbiBhc3NvY2lhdGVkIE5TVVJMUmVxdWVzdCBpcyBuaWwKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTcxNgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0 d29yay9tYWMvUmVzb3VyY2VSZXF1ZXN0TWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3Vy Y2VSZXF1ZXN0Ojpkb1VwZGF0ZVJlc291cmNlUmVxdWVzdCk6CisKIDIwMTMtMTItMTAgIEJldGgg RGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIEhvcml6b250YWwgcnViYmVyLWJh bmRpbmcgd2l0aG91dCBhIGhvcml6b250YWwgc2Nyb2xsYmFyIGlzIGRpc3RyYWN0aW5nCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZVJlcXVl c3RNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZVJl cXVlc3RNYWMubW0KaW5kZXggMmEwZDRhODIxYmNhZTAwNTIzMzNkYjhkNmYyNDQ2M2Y2M2ZmY2Fk MS4uODY5MTQwNTBmYmZkYjhhNmE1ZmU3YmJjOWEzODBmODgyOGZjNDEyMiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VSZXF1ZXN0TWFjLm1t CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlUmVxdWVz dE1hYy5tbQpAQCAtMTA4LDkgKzEwOCwxMSBAQCB2b2lkIFJlc291cmNlUmVxdWVzdDo6ZG9VcGRh dGVSZXNvdXJjZVJlcXVlc3QoKQogICAgIH0KIAogI2lmIEVOQUJMRShDQUNIRV9QQVJUSVRJT05J TkcpCi0gICAgTlNTdHJpbmcqIGNhY2hlUGFydGl0aW9uID0gW05TVVJMUHJvdG9jb2wgcHJvcGVy dHlGb3JLZXk6KE5TU3RyaW5nICopd2tDYWNoZVBhcnRpdGlvbktleSgpIGluUmVxdWVzdDptX25z UmVxdWVzdC5nZXQoKV07Ci0gICAgaWYgKGNhY2hlUGFydGl0aW9uKQotICAgICAgICBtX2NhY2hl UGFydGl0aW9uID0gY2FjaGVQYXJ0aXRpb247CisgICAgaWYgKG1fbnNSZXF1ZXN0KSB7CisgICAg ICAgIE5TU3RyaW5nKiBjYWNoZVBhcnRpdGlvbiA9IFtOU1VSTFByb3RvY29sIHByb3BlcnR5Rm9y S2V5OihOU1N0cmluZyAqKXdrQ2FjaGVQYXJ0aXRpb25LZXkoKSBpblJlcXVlc3Q6bV9uc1JlcXVl c3QuZ2V0KCldOworICAgICAgICBpZiAoY2FjaGVQYXJ0aXRpb24pCisgICAgICAgICAgICBtX2Nh Y2hlUGFydGl0aW9uID0gY2FjaGVQYXJ0aXRpb247CisgICAgfQogI2VuZGlmCiB9CiAK