125713 2013-12-13 15:01:40 -0800 LLInt should not conditionally branch to to labels outside of its function 2013-12-13 15:54:32 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue fpizlo oldest_to_newest 959687 0 mhahnenberg 2013-12-13 15:01:40 -0800 Right now we generate the following: bne _llint_throw_from_slow_path_trampoline which clang/llvm do not like. The fix is to use an unconditional jmp to the label combined with a conditional branch around the jmp. 959688 1 mhahnenberg 2013-12-13 15:01:51 -0800 <rdar://problem/15660682> 959691 2 219203 mhahnenberg 2013-12-13 15:04:47 -0800 Created attachment 219203 Patch 959694 3 219203 ggaren 2013-12-13 15:19:52 -0800 Comment on attachment 219203 Patch r=me 959703 4 219203 commit-queue 2013-12-13 15:54:30 -0800 Comment on attachment 219203 Patch Clearing flags on attachment: 219203 Committed r160571: <http://trac.webkit.org/changeset/160571> 959704 5 commit-queue 2013-12-13 15:54:32 -0800 All reviewed patches have been landed. Closing bug. 219203 2013-12-13 15:04:47 -0800 2013-12-13 15:54:30 -0800 Patch bug-125713-20131213150443.patch text/plain 2066 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwNTY3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTEyLTEzICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgTExJbnQgc2hvdWxkIG5vdCBjb25kaXRpb25hbGx5IGJyYW5jaCB0byB0byBsYWJl bHMgb3V0c2lkZSBvZiBpdHMgZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyNTcxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENvbmRpdGlvbmFsIGJyYW5jaGVzIGFyZSBpbnN1ZmZpY2llbnQg Zm9yIGp1bXBpbmcgdG8gb3V0LW9mLWZ1bmN0aW9uIGxhYmVscy4KKyAgICAgICAgVGhlIGZpeCBp cyB0byB1c2UgYW4gdW5jb25kaXRpb25hbCBqbXAgdG8gdGhlIGxhYmVsIGNvbWJpbmVkIHdpdGgg YSBjb25kaXRpb25hbCBicmFuY2ggYXJvdW5kIHRoZSBqbXAuCisKKyAgICAgICAgKiBsbGludC9M b3dMZXZlbEludGVycHJldGVyMzJfNjQuYXNtOgorICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50 ZXJwcmV0ZXI2NC5hc206CisKIDIwMTMtMTItMTMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJv QGFwcGxlLmNvbT4KIAogICAgICAgICBDbGVhbnVwIENvZGVHZW5lcmF0b3JJbnNwZWN0b3JTdHJp bmdzIGEgYml0CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRl cnByZXRlcjMyXzY0LmFzbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxp bnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQkocmV2aXNpb24gMTYwNTY2KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20JKHdv cmtpbmcgY29weSkKQEAgLTU1NSw3ICs1NTUsOSBAQCBtYWNybyBicmFuY2hJZkV4Y2VwdGlvbihs YWJlbCkKICAgICBsb2FkcCBTY29wZUNoYWluW2Nmcl0sIHQzCiAgICAgYW5kcCBNYXJrZWRCbG9j a01hc2ssIHQzCiAgICAgbG9hZHAgTWFya2VkQmxvY2s6Om1fd2Vha1NldCArIFdlYWtTZXQ6Om1f dm1bdDNdLCB0MwotICAgIGJpbmVxIFZNOjptX2V4Y2VwdGlvbiArIFRhZ09mZnNldFt0M10sIEVt cHR5VmFsdWVUYWcsIGxhYmVsCisgICAgYmllcSBWTTo6bV9leGNlcHRpb24gKyBUYWdPZmZzZXRb dDNdLCBFbXB0eVZhbHVlVGFnLCAubm9FeGNlcHRpb24KKyAgICBqbXAgbGFiZWwKKy5ub0V4Y2Vw dGlvbjoKIGVuZAogCiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZl bEludGVycHJldGVyNjQuYXNtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9s bGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCShyZXZpc2lvbiAxNjA1NjYpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbQkod29ya2lu ZyBjb3B5KQpAQCAtMzkzLDcgKzM5Myw5IEBAIG1hY3JvIGJyYW5jaElmRXhjZXB0aW9uKGxhYmVs KQogICAgIGxvYWRwIFNjb3BlQ2hhaW5bY2ZyXSwgdDMKICAgICBhbmRwIE1hcmtlZEJsb2NrTWFz aywgdDMKICAgICBsb2FkcCBNYXJrZWRCbG9jazo6bV93ZWFrU2V0ICsgV2Vha1NldDo6bV92bVt0 M10sIHQzCi0gICAgYnRxbnogVk06Om1fZXhjZXB0aW9uW3QzXSwgbGFiZWwKKyAgICBidHF6IFZN OjptX2V4Y2VwdGlvblt0M10sIC5ub0V4Y2VwdGlvbgorICAgIGptcCBsYWJlbAorLm5vRXhjZXB0 aW9uOgogZW5kCiAKIAo=