125708 2013-12-13 13:18:50 -0800 Web Inspector: support negative numbers in secondsToString and bytesToString 2014-01-10 15:50:10 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 959651 0 timothy 2013-12-13 13:18:50 -0800 Right now all negative numbers go though the smallest unit path. 959652 1 219190 timothy 2013-12-13 13:21:50 -0800 Created attachment 219190 Patch 959656 2 219190 commit-queue 2013-12-13 13:30:50 -0800 Comment on attachment 219190 Patch Rejecting attachment 219190 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 219190, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ffs from patch file(s). patching file Source/WebInspectorUI/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebInspectorUI/UserInterface/Utilities.js Hunk #1 succeeded at 775 (offset -124 lines). Hunk #2 FAILED at 808. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Utilities.js.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/48648226 966618 3 220895 timothy 2014-01-10 15:16:46 -0800 Created attachment 220895 Patch for landing 966619 4 webkit-bug-importer 2014-01-10 15:18:18 -0800 <rdar://problem/15796622> 966657 5 220895 commit-queue 2014-01-10 15:50:08 -0800 Comment on attachment 220895 Patch for landing Clearing flags on attachment: 220895 Committed r161689: <http://trac.webkit.org/changeset/161689> 966658 6 commit-queue 2014-01-10 15:50:10 -0800 All reviewed patches have been landed. Closing bug. 219190 2013-12-13 13:21:50 -0800 2014-01-10 15:16:46 -0800 Patch bug-125708-20131213132149.patch text/plain 3080 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3ODg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 MGE1ODI4MTllNzc0YWFiZjNmMDk0Y2MxZDhkMGEzMWIyMGFhOTM5Li44YzRiOGM0MDI1YWQ1ZDRm NzBjZTU5MDdjNmIwNTE3OWQ4OWJlMmE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMy0xMi0xMyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjogc3VwcG9ydCBuZWdhdGl2ZSBudW1iZXJzIGlu IHNlY29uZHNUb1N0cmluZyBhbmQgYnl0ZXNUb1N0cmluZy4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1NzA4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1V0aWxpdGllcy5q czoKKyAgICAgICAgKE51bWJlci5zZWNvbmRzVG9TdHJpbmcpOiBVc2UgTWF0aC5hYnMgaW4gdGhl IHNpemUgY2hlY2tzLgorICAgICAgICAoTnVtYmVyLmJ5dGVzVG9TdHJpbmcpOiBEaXR0by4KKwog MjAxMy0xMi0wMiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAg ICAgU25hcCB0aW1lIGRpdmlkZXJzIHRvIG5lYXJlc3QgbnVtYmVycyBpbnN0ZWFkIG9mIGp1c3Qg ZGl2aWRpbmcgdGhlIHRpbWUgc3BhbiBpbnRvIG1heCBkZW5zaXR5IHNsaWNlcy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1V0aWxpdGllcy5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1V0aWxpdGllcy5qcwppbmRleCBkMWI2 NTAyMTkzMmRhZTRlZDAzN2ZjMWExOGY4OTE0ZDNmYjc5YTk2Li5hNThlZjEwODRiZDhlZTE1MjI1 ZmQ3NGZmNTMzMjVmMWRlMjcwNGFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9VdGlsaXRpZXMuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVXRpbGl0aWVzLmpzCkBAIC04OTksMjUgKzg5OSwyNSBAQCBPYmplY3QuZGVm aW5lUHJvcGVydHkoTnVtYmVyLCAic2Vjb25kc1RvU3RyaW5nIiwKICAgICB7CiAgICAgICAgIHZh ciBtcyA9IHNlY29uZHMgKiAxMDAwOwogCi0gICAgICAgIGlmIChoaWdoZXJSZXNvbHV0aW9uICYm IG1zIDwgMTAwKQorICAgICAgICBpZiAoaGlnaGVyUmVzb2x1dGlvbiAmJiBNYXRoLmFicyhtcykg PCAxMDApCiAgICAgICAgICAgICByZXR1cm4gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIlLjJmbXMi KS5mb3JtYXQobXMpOwotICAgICAgICBlbHNlIGlmIChtcyA8IDEwMCkKKyAgICAgICAgZWxzZSBp ZiAoTWF0aC5hYnMobXMpIDwgMTAwKQogICAgICAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5V SVN0cmluZygiJS4xZm1zIikuZm9ybWF0KG1zKTsKIAotICAgICAgICBpZiAoaGlnaGVyUmVzb2x1 dGlvbiAmJiBtcyA8IDEwMDApCisgICAgICAgIGlmIChoaWdoZXJSZXNvbHV0aW9uICYmIE1hdGgu YWJzKG1zKSA8IDEwMDApCiAgICAgICAgICAgICByZXR1cm4gV2ViSW5zcGVjdG9yLlVJU3RyaW5n KCIlLjFmbXMiKS5mb3JtYXQobXMpOwotICAgICAgICBlbHNlIGlmIChtcyA8IDEwMDApCisgICAg ICAgIGVsc2UgaWYgKE1hdGguYWJzKG1zKSA8IDEwMDApCiAgICAgICAgICAgICByZXR1cm4gV2Vi SW5zcGVjdG9yLlVJU3RyaW5nKCIlLjBmbXMiKS5mb3JtYXQobXMpOwogCi0gICAgICAgIGlmIChz ZWNvbmRzIDwgNjApCisgICAgICAgIGlmIChNYXRoLmFicyhzZWNvbmRzKSA8IDYwKQogICAgICAg ICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5VSVN0cmluZygiJS4yZnMiKS5mb3JtYXQoc2Vjb25k cyk7CiAKICAgICAgICAgdmFyIG1pbnV0ZXMgPSBzZWNvbmRzIC8gNjA7Ci0gICAgICAgIGlmICht aW51dGVzIDwgNjApCisgICAgICAgIGlmIChNYXRoLmFicyhtaW51dGVzKSA8IDYwKQogICAgICAg ICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5VSVN0cmluZygiJS4xZm1pbiIpLmZvcm1hdChtaW51 dGVzKTsKIAogICAgICAgICB2YXIgaG91cnMgPSBtaW51dGVzIC8gNjA7Ci0gICAgICAgIGlmICho b3VycyA8IDI0KQorICAgICAgICBpZiAoTWF0aC5hYnMoaG91cnMpIDwgMjQpCiAgICAgICAgICAg ICByZXR1cm4gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIlLjFmaHJzIikuZm9ybWF0KGhvdXJzKTsK IAogICAgICAgICB2YXIgZGF5cyA9IGhvdXJzIC8gMjQ7CkBAIC05MzIsMTMgKzkzMiwxMyBAQCBP YmplY3QuZGVmaW5lUHJvcGVydHkoTnVtYmVyLCAiYnl0ZXNUb1N0cmluZyIsCiAgICAgICAgIGlm IChoaWdoZXJSZXNvbHV0aW9uID09PSB1bmRlZmluZWQpCiAgICAgICAgICAgICBoaWdoZXJSZXNv bHV0aW9uID0gdHJ1ZTsKIAotICAgICAgICBpZiAoYnl0ZXMgPCAxMDI0KQorICAgICAgICBpZiAo TWF0aC5hYnMoYnl0ZXMpIDwgMTAyNCkKICAgICAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3Iu VUlTdHJpbmcoIiUuMGYgQiIpLmZvcm1hdChieXRlcyk7CiAKICAgICAgICAgdmFyIGtpbG9ieXRl cyA9IGJ5dGVzIC8gMTAyNDsKLSAgICAgICAgaWYgKGhpZ2hlclJlc29sdXRpb24gJiYga2lsb2J5 dGVzIDwgMTAyNCkKKyAgICAgICAgaWYgKGhpZ2hlclJlc29sdXRpb24gJiYgTWF0aC5hYnMoa2ls b2J5dGVzKSA8IDEwMjQpCiAgICAgICAgICAgICByZXR1cm4gV2ViSW5zcGVjdG9yLlVJU3RyaW5n KCIlLjJmIEtCIikuZm9ybWF0KGtpbG9ieXRlcyk7Ci0gICAgICAgIGVsc2UgaWYgKGtpbG9ieXRl cyA8IDEwMjQpCisgICAgICAgIGVsc2UgaWYgKE1hdGguYWJzKGtpbG9ieXRlcykgPCAxMDI0KQog ICAgICAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5VSVN0cmluZygiJS4wZiBLQiIpLmZvcm1h dChraWxvYnl0ZXMpOwogCiAgICAgICAgIHZhciBtZWdhYnl0ZXMgPSBraWxvYnl0ZXMgLyAxMDI0 Owo= 220895 2014-01-10 15:16:46 -0800 2014-01-10 15:50:08 -0800 Patch for landing bug-126676-20140110150142.patch text/plain 3397 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxNjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA3 YTI2ZWE3NTliNWMzM2U2OWY4Y2YxOGNlNmY1NjZkMTE5OTI5N2Q0Li41Njc1NmEyNjc5YzE5Zjk0 MDkwMDU5OTA3ZWI4OTNkNDhjYzliZmQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMy0xMi0xMyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjogc3VwcG9ydCBuZWdhdGl2ZSBudW1iZXJzIGlu IHNlY29uZHNUb1N0cmluZyBhbmQgYnl0ZXNUb1N0cmluZy4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1NzA4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgSm9zZXBoIFBlY29yYXJvLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9VdGlsaXRpZXMu anM6CisgICAgICAgIChOdW1iZXIuc2Vjb25kc1RvU3RyaW5nKTogVXNlIE1hdGguYWJzIGluIHRo ZSBzaXplIGNoZWNrcy4KKyAgICAgICAgKE51bWJlci5ieXRlc1RvU3RyaW5nKTogRGl0dG8uCisK IDIwMTMtMTItMDIgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAg ICAgIFNuYXAgdGltZSBkaXZpZGVycyB0byBuZWFyZXN0IG51bWJlcnMgaW5zdGVhZCBvZiBqdXN0 IGRpdmlkaW5nIHRoZSB0aW1lIHNwYW4gaW50byBtYXggZGVuc2l0eSBzbGljZXMuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9VdGlsaXRpZXMuanMgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9VdGlsaXRpZXMuanMKaW5kZXggMzc1 Mzk3MTU2MGQ0M2NiNDdmZmVlZjY3YjlkOGVkNGY4Njc5Mzc3MC4uMmE5ZjQ4Y2E2YjllN2EyMmYy ODQzOGZmOGZhMjBmNmIyYmU1ODE3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVXRpbGl0aWVzLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1V0aWxpdGllcy5qcwpAQCAtNzc1LDI1ICs3NzUsMjUgQEAgT2JqZWN0LmRl ZmluZVByb3BlcnR5KE51bWJlciwgInNlY29uZHNUb1N0cmluZyIsCiAgICAgewogICAgICAgICB2 YXIgbXMgPSBzZWNvbmRzICogMTAwMDsKIAotICAgICAgICBpZiAoaGlnaGVyUmVzb2x1dGlvbiAm JiBtcyA8IDEwMCkKKyAgICAgICAgaWYgKGhpZ2hlclJlc29sdXRpb24gJiYgTWF0aC5hYnMobXMp IDwgMTAwKQogICAgICAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5VSVN0cmluZygiJS4yZm1z IikuZm9ybWF0KG1zKTsKLSAgICAgICAgZWxzZSBpZiAobXMgPCAxMDApCisgICAgICAgIGVsc2Ug aWYgKE1hdGguYWJzKG1zKSA8IDEwMCkKICAgICAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3Iu VUlTdHJpbmcoIiUuMWZtcyIpLmZvcm1hdChtcyk7CiAKLSAgICAgICAgaWYgKGhpZ2hlclJlc29s dXRpb24gJiYgbXMgPCAxMDAwKQorICAgICAgICBpZiAoaGlnaGVyUmVzb2x1dGlvbiAmJiBNYXRo LmFicyhtcykgPCAxMDAwKQogICAgICAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5VSVN0cmlu ZygiJS4xZm1zIikuZm9ybWF0KG1zKTsKLSAgICAgICAgZWxzZSBpZiAobXMgPCAxMDAwKQorICAg ICAgICBlbHNlIGlmIChNYXRoLmFicyhtcykgPCAxMDAwKQogICAgICAgICAgICAgcmV0dXJuIFdl Ykluc3BlY3Rvci5VSVN0cmluZygiJS4wZm1zIikuZm9ybWF0KG1zKTsKIAotICAgICAgICBpZiAo c2Vjb25kcyA8IDYwKQorICAgICAgICBpZiAoTWF0aC5hYnMoc2Vjb25kcykgPCA2MCkKICAgICAg ICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIiUuMmZzIikuZm9ybWF0KHNlY29u ZHMpOwogCiAgICAgICAgIHZhciBtaW51dGVzID0gc2Vjb25kcyAvIDYwOwotICAgICAgICBpZiAo bWludXRlcyA8IDYwKQorICAgICAgICBpZiAoTWF0aC5hYnMobWludXRlcykgPCA2MCkKICAgICAg ICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIiUuMWZtaW4iKS5mb3JtYXQobWlu dXRlcyk7CiAKICAgICAgICAgdmFyIGhvdXJzID0gbWludXRlcyAvIDYwOwotICAgICAgICBpZiAo aG91cnMgPCAyNCkKKyAgICAgICAgaWYgKE1hdGguYWJzKGhvdXJzKSA8IDI0KQogICAgICAgICAg ICAgcmV0dXJuIFdlYkluc3BlY3Rvci5VSVN0cmluZygiJS4xZmhycyIpLmZvcm1hdChob3Vycyk7 CiAKICAgICAgICAgdmFyIGRheXMgPSBob3VycyAvIDI0OwpAQCAtODA4LDE3ICs4MDgsMTcgQEAg T2JqZWN0LmRlZmluZVByb3BlcnR5KE51bWJlciwgImJ5dGVzVG9TdHJpbmciLAogICAgICAgICBp ZiAoaGlnaGVyUmVzb2x1dGlvbiA9PT0gdW5kZWZpbmVkKQogICAgICAgICAgICAgaGlnaGVyUmVz b2x1dGlvbiA9IHRydWU7CiAKLSAgICAgICAgaWYgKGJ5dGVzIDwgMTAyNCkKKyAgICAgICAgaWYg KE1hdGguYWJzKGJ5dGVzKSA8IDEwMjQpCiAgICAgICAgICAgICByZXR1cm4gV2ViSW5zcGVjdG9y LlVJU3RyaW5nKCIlLjBmIEIiKS5mb3JtYXQoYnl0ZXMpOwogCiAgICAgICAgIHZhciBraWxvYnl0 ZXMgPSBieXRlcyAvIDEwMjQ7Ci0gICAgICAgIGlmIChraWxvYnl0ZXMgPCAxMCB8fCAoaGlnaGVy UmVzb2x1dGlvbiAmJiBraWxvYnl0ZXMgPCAxMDI0KSkKKyAgICAgICAgaWYgKE1hdGguYWJzKGtp bG9ieXRlcykgPCAxMCB8fCAoaGlnaGVyUmVzb2x1dGlvbiAmJiBNYXRoLmFicyhraWxvYnl0ZXMp IDwgMTAyNCkpCiAgICAgICAgICAgICByZXR1cm4gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIlLjJm IEtCIikuZm9ybWF0KGtpbG9ieXRlcyk7Ci0gICAgICAgIGVsc2UgaWYgKGtpbG9ieXRlcyA8IDEw MjQpCisgICAgICAgIGVsc2UgaWYgKE1hdGguYWJzKGtpbG9ieXRlcykgPCAxMDI0KQogICAgICAg ICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5VSVN0cmluZygiJS4xZiBLQiIpLmZvcm1hdChraWxv Ynl0ZXMpOwogCiAgICAgICAgIHZhciBtZWdhYnl0ZXMgPSBraWxvYnl0ZXMgLyAxMDI0OwotICAg ICAgICBpZiAoaGlnaGVyUmVzb2x1dGlvbiB8fCBtZWdhYnl0ZXMgPCAxMCkKKyAgICAgICAgaWYg KGhpZ2hlclJlc29sdXRpb24gfHwgTWF0aC5hYnMobWVnYWJ5dGVzKSA8IDEwKQogICAgICAgICAg ICAgcmV0dXJuIFdlYkluc3BlY3Rvci5VSVN0cmluZygiJS4yZiBNQiIpLmZvcm1hdChtZWdhYnl0 ZXMpOwogICAgICAgICBlbHNlCiAgICAgICAgICAgICByZXR1cm4gV2ViSW5zcGVjdG9yLlVJU3Ry aW5nKCIlLjFmIE1CIikuZm9ybWF0KG1lZ2FieXRlcyk7Cg==