125703 2013-12-13 12:54:33 -0800 [MSE] Update duration after appending samples, per spec. 2013-12-17 16:54:31 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble commit-queue eric.carlson glenn oldest_to_newest 959638 0 jer.noble 2013-12-13 12:54:33 -0800 [MSE] Update duration after appending samples, per spec. 959644 1 219187 jer.noble 2013-12-13 13:04:46 -0800 Created attachment 219187 Patch 959682 2 219187 eric.carlson 2013-12-13 14:53:40 -0800 Comment on attachment 219187 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219187&action=review > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1010 > + if (highestPresentationEndTimestamp().toDouble() > m_source->duration()) > + m_source->setDuration(highestPresentationEndTimestamp().toDouble(), IgnorableExceptionCode()); Nit: it will be more efficient to put the timestamp in a variable instead of calculating it twice. > LayoutTests/media/media-source/media-source-duration-after-append.html:16 > + function runTest() { Nit: wrong place for the opening brace. 960743 3 219187 commit-queue 2013-12-17 16:54:29 -0800 Comment on attachment 219187 Patch Clearing flags on attachment: 219187 Committed r160739: <http://trac.webkit.org/changeset/160739> 960744 4 commit-queue 2013-12-17 16:54:31 -0800 All reviewed patches have been landed. Closing bug. 219187 2013-12-13 13:04:46 -0800 2013-12-17 16:54:29 -0800 Patch bug-125703-20131213130445.patch text/plain 7230 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmU1YzY0ZDAyZGU4ZmQ1 MGRhNzIwMzk1Y2IzMGNlZGUyZmExZWZhYi4uNmNjMDljZjM3M2QwNWRmOTlhZGVjNThkOThlNjE5 YjdhOWVjMzJiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEzLTEyLTEzICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIFtNU0VdIFVwZGF0ZSBkdXJh dGlvbiBhZnRlciBhcHBlbmRpbmcgc2FtcGxlcywgcGVyIHNwZWMuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU3MDMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBtZWRpYS9tZWRpYS1zb3VyY2Uv bWVkaWEtc291cmNlLWR1cmF0aW9uLWFmdGVyLWFwcGVuZC5odG1sCisKKyAgICAgICAgQWZ0ZXIg YXBwZW5kaW5nIGEgc2FtcGxlLCB1cGRhdGUgdGhlIE1lZGlhU291cmNlIGR1cmF0aW9uIGlmIHRo ZSBzYW1wbGUncworICAgICAgICBwcmVzZW50YXRpb24gZW5kIHRpbWUgaXMgZ3JlYXRlciB0aGFu IHRoZSBleGlzdGluZyBkdXJhdGlvbi4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzb3VyY2Uv U291cmNlQnVmZmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNvdXJjZUJ1ZmZlcjo6c291cmNl QnVmZmVyUHJpdmF0ZURpZFJlY2VpdmVTYW1wbGUpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2Jq Qy5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlh U291cmNlUHJpdmF0ZUFWRk9iakMubW06CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNvdXJjZVBy aXZhdGVBVkZPYmpDOjpzZXREdXJhdGlvbik6IE5vdGlmeSB0aGUgTWVkaWFQbGF5ZXIuCisKKzIw MTMtMTItMTMgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKICAgICAgICAgW01T RV1bTWFjXSBOdWxsLWRlcmVmIGluIENNU2FtcGxlQnVmZmVySXNSYW5kb21BY2Nlc3MoKS4KICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTY5OAogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNlL1NvdXJjZUJ1ZmZl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNlL1NvdXJjZUJ1ZmZlci5j cHAKaW5kZXggM2VhNzhkNmQwYmUzYzAxMTc0MDkyMzU5MjgxZTUxZWNmZmIwYTkxZS4uNTMyZTli MGQzMjAyMzU0MGIwNWRlZGZhZTFiMmU4MzhhNWU3N2NlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvU291cmNlQnVmZmVyLmNwcApAQCAtMTAwMSw2ICsx MDAxLDEzIEBAIHZvaWQgU291cmNlQnVmZmVyOjpzb3VyY2VCdWZmZXJQcml2YXRlRGlkUmVjZWl2 ZVNhbXBsZShTb3VyY2VCdWZmZXJQcml2YXRlKiwgUGFzCiAKICAgICAgICAgYnJlYWs7CiAgICAg fSB3aGlsZSAoMSk7CisKKyAgICAvLyBTdGVwcyAyLTQgd2lsbCBiZSBoYW5kbGVkIGJ5IE1lZGlh U291cmNlOjptb25pdG9yU291cmNlQnVmZmVycygpCisKKyAgICAvLyA1LiBJZiB0aGUgbWVkaWEg c2VnbWVudCBjb250YWlucyBkYXRhIGJleW9uZCB0aGUgY3VycmVudCBkdXJhdGlvbiwgdGhlbiBy dW4gdGhlIGR1cmF0aW9uIGNoYW5nZSBhbGdvcml0aG0gd2l0aCBuZXcKKyAgICAvLyBkdXJhdGlv biBzZXQgdG8gdGhlIG1heGltdW0gb2YgdGhlIGN1cnJlbnQgZHVyYXRpb24gYW5kIHRoZSBoaWdo ZXN0IGVuZCB0aW1lc3RhbXAgcmVwb3J0ZWQgYnkgSFRNTE1lZGlhRWxlbWVudC5idWZmZXJlZC4K KyAgICBpZiAoaGlnaGVzdFByZXNlbnRhdGlvbkVuZFRpbWVzdGFtcCgpLnRvRG91YmxlKCkgPiBt X3NvdXJjZS0+ZHVyYXRpb24oKSkKKyAgICAgICAgbV9zb3VyY2UtPnNldER1cmF0aW9uKGhpZ2hl c3RQcmVzZW50YXRpb25FbmRUaW1lc3RhbXAoKS50b0RvdWJsZSgpLCBJZ25vcmFibGVFeGNlcHRp b25Db2RlKCkpOwogfQogCiBib29sIFNvdXJjZUJ1ZmZlcjo6c291cmNlQnVmZmVyUHJpdmF0ZUhh c0F1ZGlvKGNvbnN0IFNvdXJjZUJ1ZmZlclByaXZhdGUqKSBjb25zdApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5 ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFW Rk9iakMuaAppbmRleCBkNmNmYzEyNDVkZTMyMGRjNzY1NzFmZWU0NzdkY2FjM2Y5ODIxYTVkLi5j NDg0ZjM5ZGYzNWYzMDljNjQ1MDk5ZjE1NjgxYjMwYzNiYTMwYTlhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXll clByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJj ZUFWRk9iakMuaApAQCAtNjAsNiArNjAsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZWVrSW50ZXJu YWwoZG91YmxlLCBkb3VibGUsIGRvdWJsZSk7CiAgICAgdm9pZCBzZXRMb2FkaW5nUHJvZ3Jlc3Nz ZWQoYm9vbCBmbGFnKSB7IG1fbG9hZGluZ1Byb2dyZXNzZWQgPSBmbGFnOyB9CiAgICAgdm9pZCBz ZXRIYXNBdmFpbGFibGVWaWRlb0ZyYW1lKGJvb2wgZmxhZykgeyBtX2hhc0F2YWlsYWJsZVZpZGVv RnJhbWUgPSBmbGFnOyB9CisgICAgdm9pZCBkdXJhdGlvbkNoYW5nZWQoKTsKIAogcHJpdmF0ZToK ICAgICAvLyBNZWRpYVBsYXllclByaXZhdGVJbnRlcmZhY2UKQEAgLTEzNiw3ICsxMzcsNiBAQCBw cml2YXRlOgogCiAgICAgdm9pZCBlbnN1cmVMYXllcigpOwogICAgIHZvaWQgZGVzdHJveUxheWVy KCk7Ci0gICAgdm9pZCBkdXJhdGlvbkNoYW5nZWQoKTsKIAogICAgIC8vIE1lZGlhUGxheWVyIEZh Y3RvcnkgTWV0aG9kcwogICAgIHN0YXRpYyBQYXNzT3duUHRyPE1lZGlhUGxheWVyUHJpdmF0ZUlu dGVyZmFjZT4gY3JlYXRlKE1lZGlhUGxheWVyKik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVNvdXJjZVByaXZhdGVB VkZPYmpDLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9u L29iamMvTWVkaWFTb3VyY2VQcml2YXRlQVZGT2JqQy5tbQppbmRleCAyMTA5ZWFhOTkxZmQ1MjA0 MjcyNWRmZDc1NzRjMzVjZDQ0MDlhZTg5Li5iODNiZTcyMzkxZTRhNDg5Y2RkNmY4N2IyOWIzM2Q2 YjRlODEyMGQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9h dmZvdW5kYXRpb24vb2JqYy9NZWRpYVNvdXJjZVByaXZhdGVBVkZPYmpDLm1tCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhU291cmNl UHJpdmF0ZUFWRk9iakMubW0KQEAgLTk5LDYgKzk5LDcgQEAgdm9pZCBNZWRpYVNvdXJjZVByaXZh dGVBVkZPYmpDOjpzZXREdXJhdGlvbihkb3VibGUgZHVyYXRpb24pCiAgICAgICAgIHJldHVybjsK IAogICAgIG1fZHVyYXRpb24gPSBkdXJhdGlvbjsKKyAgICBtX3BsYXllci0+ZHVyYXRpb25DaGFu Z2VkKCk7CiB9CiAKIHZvaWQgTWVkaWFTb3VyY2VQcml2YXRlQVZGT2JqQzo6bWFya0VuZE9mU3Ry ZWFtKEVuZE9mU3RyZWFtU3RhdHVzIHN0YXR1cykKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjNDMwMmU0NDQ4ODBiODQ1Mjdm YTM3ZDUzNjFmYmZkMGJiZjM5NDQ2Li5lMDdhZjRiNDY1OTRkNjE5NjEwM2QxZGRkZjk2Y2EyMjI0 YjNhOTFkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMTItMTMgIEplciBOb2JsZSAgPGpl ci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgW01TRV0gVXBkYXRlIGR1cmF0aW9uIGFmdGVy IGFwcGVuZGluZyBzYW1wbGVzLCBwZXIgc3BlYy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTcwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogbWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXNvdXJjZS1k dXJhdGlvbi1hZnRlci1hcHBlbmQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBtZWRp YS9tZWRpYS1zb3VyY2UvbWVkaWEtc291cmNlLWR1cmF0aW9uLWFmdGVyLWFwcGVuZC5odG1sOiBB ZGRlZC4KKwogMjAxMy0xMi0wOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSRUdSRVNTSU9OKHIxMzYyODApOiBpbnB1dFt0eXBlPWltYWdlXSBzaG91bGQgYXNz dW1lIGNvb3JkcyBvZiAwLDAgd2hlbiBhY3RpdmF0ZWQgd2l0aG91dCBwaHlzaWNhbGx5IGNsaWNr aW5nCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1zb3VyY2UvbWVkaWEtc291 cmNlLWR1cmF0aW9uLWFmdGVyLWFwcGVuZC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRp YS9tZWRpYS1zb3VyY2UvbWVkaWEtc291cmNlLWR1cmF0aW9uLWFmdGVyLWFwcGVuZC1leHBlY3Rl ZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uYTRiNjYzNjc4ZGI4NDA2YzdjOWNmYTAwMmQ1MTU5M2E2ZGQ4NGMz ZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlhL21lZGlhLXNvdXJjZS9tZWRp YS1zb3VyY2UtZHVyYXRpb24tYWZ0ZXItYXBwZW5kLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEx IEBACisKK0VWRU5UKHNvdXJjZW9wZW4pCitSVU4oc291cmNlQnVmZmVyID0gc291cmNlLmFkZFNv dXJjZUJ1ZmZlcigidmlkZW8vbW9jazsgY29kZWNzPW1vY2siKSkKK1JVTihzb3VyY2VCdWZmZXIu YXBwZW5kQnVmZmVyKGluaXRTZWdtZW50KSkKK0VWRU5UKHVwZGF0ZWVuZCkKK0VYUEVDVEVEICh2 aWRlby5kdXJhdGlvbiA9PSAnMCcpIE9LCitSVU4oc291cmNlQnVmZmVyLmFwcGVuZEJ1ZmZlcihz YW1wbGUpKQorRVZFTlQodXBkYXRlZW5kKQorRVhQRUNURUQgKHZpZGVvLmR1cmF0aW9uID09ICcx MCcpIE9LCitFTkQgT0YgVEVTVAorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9tZWRp YS1zb3VyY2UvbWVkaWEtc291cmNlLWR1cmF0aW9uLWFmdGVyLWFwcGVuZC5odG1sIGIvTGF5b3V0 VGVzdHMvbWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXNvdXJjZS1kdXJhdGlvbi1hZnRlci1hcHBl bmQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi4zMGYyMzUxNmY4YWUwNzkyNGFjZTg0ZGZhN2RhYjcyOTdiOTU4 OTJjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtc291cmNlL21l ZGlhLXNvdXJjZS1kdXJhdGlvbi1hZnRlci1hcHBlbmQuaHRtbApAQCAtMCwwICsxLDQ4IEBACis8 IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+CisgICAgPHRpdGxlPm1vY2stbWVkaWEtc291 cmNlPC90aXRsZT4KKyAgICA8c2NyaXB0IHNyYz0ibW9jay1tZWRpYS1zb3VyY2UuanMiPjwvc2Ny aXB0PgorICAgIDxzY3JpcHQgc3JjPSIuLi92aWRlby10ZXN0LmpzIj48L3NjcmlwdD4KKyAgICA8 c2NyaXB0PgorICAgIHZhciBzb3VyY2U7CisgICAgdmFyIHNvdXJjZUJ1ZmZlcjsKKyAgICB2YXIg aW5pdFNlZ21lbnQ7CisgICAgdmFyIHNhbXBsZTsKKworICAgIGlmICh3aW5kb3cuaW50ZXJuYWxz KQorICAgICAgICBpbnRlcm5hbHMuaW5pdGlhbGl6ZU1vY2tNZWRpYVNvdXJjZSgpOworCisgICAg ZnVuY3Rpb24gcnVuVGVzdCgpIHsKKyAgICAgICAgZmluZE1lZGlhRWxlbWVudCgpOworCisgICAg ICAgIHNvdXJjZSA9IG5ldyBNZWRpYVNvdXJjZSgpOworICAgICAgICB3YWl0Rm9yRXZlbnRPbihz b3VyY2UsICdzb3VyY2VvcGVuJywgc291cmNlT3Blbik7CisgICAgICAgIHZpZGVvLnNyYyA9IFVS TC5jcmVhdGVPYmplY3RVUkwoc291cmNlKTsKKyAgICB9CisKKyAgICBmdW5jdGlvbiBzb3VyY2VP cGVuKCkgeworICAgICAgICBydW4oJ3NvdXJjZUJ1ZmZlciA9IHNvdXJjZS5hZGRTb3VyY2VCdWZm ZXIoInZpZGVvL21vY2s7IGNvZGVjcz1tb2NrIiknKTsKKyAgICAgICAgd2FpdEZvckV2ZW50T24o c291cmNlQnVmZmVyLCAndXBkYXRlZW5kJywgbG9hZFNhbXBsZXMsIGZhbHNlLCB0cnVlKTsKKyAg ICAgICAgaW5pdFNlZ21lbnQgPSBtYWtlQUluaXQoMCwgW21ha2VBVHJhY2soMSwgJ21vY2snLCBU UkFDS19LSU5ELlZJREVPKV0pOworICAgICAgICBydW4oJ3NvdXJjZUJ1ZmZlci5hcHBlbmRCdWZm ZXIoaW5pdFNlZ21lbnQpJyk7CisgICAgfQorCisgICAgZnVuY3Rpb24gbG9hZFNhbXBsZXMoKSB7 CisgICAgICAgIHRlc3RFeHBlY3RlZCgndmlkZW8uZHVyYXRpb24nLCAwKTsKKyAgICAgICAgc2Ft cGxlID0gbWFrZUFTYW1wbGUoMCwgMCwgMTAsIDEsIFNBTVBMRV9GTEFHLlNZTkMpOworICAgICAg ICB3YWl0Rm9yRXZlbnRPbihzb3VyY2VCdWZmZXIsICd1cGRhdGVlbmQnLCBjaGVja0R1cmF0aW9u LCBmYWxzZSwgdHJ1ZSk7CisgICAgICAgIHJ1bignc291cmNlQnVmZmVyLmFwcGVuZEJ1ZmZlcihz YW1wbGUpJyk7CisgICAgfQorCisgICAgZnVuY3Rpb24gY2hlY2tEdXJhdGlvbigpIHsKKyAgICAg ICAgdGVzdEV4cGVjdGVkKCd2aWRlby5kdXJhdGlvbicsIDEwKTsKKyAgICAgICAgZW5kVGVzdCgp OworICAgIH0KKyAgICAKKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0icnVu VGVzdCgpIj4KKyAgICA8dmlkZW8+PC92aWRlbz4KKzwvYm9keT4KKzwvaHRtbD4K