125692 2013-12-13 07:21:23 -0800 REGRESSION(r155784): [GTK] Some methods incorrectly removed in r155784 and deprecated in r158662 2013-12-13 07:38:12 -0800 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned cdumez commit-queue gustavo jasuarez oldest_to_newest 959547 0 cgarcia 2013-12-13 07:21:23 -0800 In r155784 the build was fixed by skipping Console::profile() and Console::profileEnd(), but the patch also skipped other methods containing the profile method name. Those were incorrectly deprecated in r158662 thinking that the property had been removed in the idl. 959548 1 219169 cgarcia 2013-12-13 07:23:34 -0800 Created attachment 219169 Patch 959550 2 cgarcia 2013-12-13 07:38:12 -0800 Committed r160545: <http://trac.webkit.org/changeset/160545> 219169 2013-12-13 07:23:34 -0800 2013-12-13 07:34:17 -0800 Patch wkdom-deprecations.diff text/plain 5530 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzY2IzOGI0Li40NmEwZDZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjcg QEAKIDIwMTMtMTItMTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFJFR1JFU1NJT04ocjE1NTc4NCk6IFtHVEtdIFNvbWUgbWV0aG9kcyBpbmNv cnJlY3RseSByZW1vdmVkIGluIHIxNTU3ODQgYW5kIGRlcHJlY2F0ZWQgaW4gcjE1ODY2MgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1NjkyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gcjE1NTc4NCB0 aGUgYnVpbGQgd2FzIGZpeGVkIGJ5IHNraXBwaW5nIENvbnNvbGU6OnByb2ZpbGUoKSBhbmQKKyAg ICAgICAgQ29uc29sZTo6cHJvZmlsZUVuZCgpLCBidXQgdGhlIHBhdGNoIGFsc28gc2tpcHBlZCBv dGhlciBtZXRob2RzCisgICAgICAgIGNvbnRhaW5pbmcgdGhlIHByb2ZpbGUgbWV0aG9kIG5hbWUu IFRob3NlIHdlcmUgaW5jb3JyZWN0bHkKKyAgICAgICAgZGVwcmVjYXRlZCBpbiByMTU4NjYyIHRo aW5raW5nIHRoYXQgdGhlIHByb3BlcnR5IGhhZCBiZWVuIHJlbW92ZWQKKyAgICAgICAgaW4gdGhl IGlkbC4KKworICAgICAgICAqIGJpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NRGVwcmVjYXRlZC5j cHA6IFVuZGVwcmVjYXRlCisgICAgICAgIHdlYmtpdF9kb21faHRtbF9oZWFkX2VsZW1lbnRfZ2V0 X3Byb2ZpbGUgYW5kCisgICAgICAgIHdlYmtpdF9kb21faHRtbF9oZWFkX2VsZW1lbnRfc2V0X3By b2ZpbGUuCisgICAgICAgICogYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01EZXByZWNhdGVkLmg6 IERpdHRvLgorICAgICAgICAqIGJpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NRGVwcmVjYXRlZC5z eW1ib2xzOiBEaXR0by4KKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JH T2JqZWN0LnBtOgorICAgICAgICAoU2tpcEZ1bmN0aW9uKTogU2tpcCB3ZWJraXRfZG9tX2NvbnNv bGVfcHJvZmlsZSBhbmQKKyAgICAgICAgd2Via2l0X2RvbV9jb25zb2xlX3Byb2ZpbGVfZW5kLgor CisyMDEzLTEyLTEzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K KwogICAgICAgICBbR1RLXSBFeHBvc2UgYWxzbyB3ZWJraXRfZG9tX2RvY3VtZW50X2dldF91cmwK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTY5MQog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTURl cHJlY2F0ZWQuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01E ZXByZWNhdGVkLmNwcAppbmRleCBlZjE1ZTg1Li5kNDAzY2ZjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTURlcHJlY2F0ZWQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NRGVwcmVjYXRlZC5jcHAKQEAg LTU0NywxOSArNTQ3LDYgQEAgZ2RvdWJsZSB3ZWJraXRfZG9tX2h0bWxfbWVkaWFfZWxlbWVudF9n ZXRfaW5pdGlhbF90aW1lKFdlYktpdERPTUhUTUxNZWRpYUVsZW1lbnQKICAgICByZXR1cm4gMDsK IH0KIAotLy8gV2ViS2l0RE9NSFRNTEhlYWRFbGVtZW50Ci0KLWdjaGFyKiB3ZWJraXRfZG9tX2h0 bWxfaGVhZF9lbGVtZW50X2dldF9wcm9maWxlKFdlYktpdERPTUhUTUxIZWFkRWxlbWVudCogc2Vs ZikKLXsKLSAgICBnX3dhcm5pbmcoIiVzOiB0aGUgSGVhZEVsZW1lbnQgb2JqZWN0IGhhcyBiZWVu IHJlbW92ZWQgZnJvbSBXZWJLaXQsIHRoaXMgZnVuY3Rpb24gZG9lcyBub3RoaW5nLiIsIF9fZnVu Y19fKTsKLSAgICByZXR1cm4gZ19zdHJkdXAoIiIpOwotfQotCi12b2lkIHdlYmtpdF9kb21faHRt bF9oZWFkX2VsZW1lbnRfc2V0X3Byb2ZpbGUoV2ViS2l0RE9NSFRNTEhlYWRFbGVtZW50KiBzZWxm LCBjb25zdCBnY2hhciogdmFsdWUpCi17Ci0gICAgZ193YXJuaW5nKCIlczogdGhlIEhlYWRFbGVt ZW50IG9iamVjdCBoYXMgYmVlbiByZW1vdmVkIGZyb20gV2ViS2l0LCB0aGlzIGZ1bmN0aW9uIGRv ZXMgbm90aGluZy4iLCBfX2Z1bmNfXyk7Ci19Ci0KIC8vIFdlYktpdERPTVByb2Nlc3NpbmdJbnN0 cnVjdGlvbgogCiBnY2hhciogd2Via2l0X2RvbV9wcm9jZXNzaW5nX2luc3RydWN0aW9uX2dldF9k YXRhKFdlYktpdERPTVByb2Nlc3NpbmdJbnN0cnVjdGlvbiogc2VsZikKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NRGVwcmVjYXRlZC5oIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01EZXByZWNhdGVkLmgKaW5kZXgg YWQxOGM4Yy4uYzAzYTljNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29i amVjdC9XZWJLaXRET01EZXByZWNhdGVkLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv Z29iamVjdC9XZWJLaXRET01EZXByZWNhdGVkLmgKQEAgLTU1MiwzMSArNTUyLDYgQEAgV0VCS0lU X0RFUFJFQ0FURUQgZ2RvdWJsZQogd2Via2l0X2RvbV9odG1sX21lZGlhX2VsZW1lbnRfZ2V0X2lu aXRpYWxfdGltZShXZWJLaXRET01IVE1MTWVkaWFFbGVtZW50KiBzZWxmKTsKIAogLyoqCi0gKiB3 ZWJraXRfZG9tX2h0bWxfaGVhZF9lbGVtZW50X2dldF9wcm9maWxlOgotICogQHNlbGY6IEEgI1dl YktpdERPTUhUTUxIZWFkRWxlbWVudAotICoKLSAqIFRoaXMgZnVuY3Rpb25hbGl0eSBoYXMgYmVl biByZW1vdmVkIGZyb20gV2ViS2l0LCB0aGlzIGZ1bmN0aW9uIGRvZXMgbm90aGluZy4KLSAqCi0g KiBSZXR1cm5zOiBhICNnY2hhcgotICoKLSAqIERlcHJlY2F0ZWQ6IDIuNAotICovCi1XRUJLSVRf REVQUkVDQVRFRCBnY2hhcioKLXdlYmtpdF9kb21faHRtbF9oZWFkX2VsZW1lbnRfZ2V0X3Byb2Zp bGUoV2ViS2l0RE9NSFRNTEhlYWRFbGVtZW50KiBzZWxmKTsKLQotLyoqCi0gKiB3ZWJraXRfZG9t X2h0bWxfaGVhZF9lbGVtZW50X3NldF9wcm9maWxlOgotICogQHNlbGY6IEEgI1dlYktpdERPTUhU TUxIZWFkRWxlbWVudAotICogQHZhbHVlOiBBICNnY2hhcgotICoKLSAqIFRoaXMgZnVuY3Rpb25h bGl0eSBoYXMgYmVlbiByZW1vdmVkIGZyb20gV2ViS2l0LCB0aGlzIGZ1bmN0aW9uIGRvZXMgbm90 aGluZy4KLSAqCi0gKiBEZXByZWNhdGVkOiAyLjQKLSAqLwotV0VCS0lUX0RFUFJFQ0FURUQgdm9p ZAotd2Via2l0X2RvbV9odG1sX2hlYWRfZWxlbWVudF9zZXRfcHJvZmlsZShXZWJLaXRET01IVE1M SGVhZEVsZW1lbnQqIHNlbGYsIGNvbnN0IGdjaGFyKiB2YWx1ZSk7Ci0KLS8qKgogICogd2Via2l0 X2RvbV9wcm9jZXNzaW5nX2luc3RydWN0aW9uX2dldF9kYXRhOgogICogQHNlbGY6IEEgI1dlYktp dERPTVByb2Nlc3NpbmdJbnN0cnVjdGlvbgogICoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NRGVwcmVjYXRlZC5zeW1ib2xzIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01EZXByZWNhdGVkLnN5bWJvbHMKaW5kZXgg Zjk3MjA2ZC4uN2EwNWZmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29i amVjdC9XZWJLaXRET01EZXByZWNhdGVkLnN5bWJvbHMKKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvZ29iamVjdC9XZWJLaXRET01EZXByZWNhdGVkLnN5bWJvbHMKQEAgLTQ0LDcgKzQ0LDUg QEAgV2ViS2l0RE9NTm9kZSogd2Via2l0X2RvbV9wcm9wZXJ0eV9ub2RlX2xpc3RfaXRlbSh2b2lk KiwgZ3Vsb25nKQogZ3Vsb25nIHdlYmtpdF9kb21fcHJvcGVydHlfbm9kZV9saXN0X2dldF9sZW5n dGgodm9pZCopCiBnZG91YmxlIHdlYmtpdF9kb21faHRtbF9tZWRpYV9lbGVtZW50X2dldF9zdGFy dF90aW1lKFdlYktpdERPTUhUTUxNZWRpYUVsZW1lbnQqKQogZ2RvdWJsZSB3ZWJraXRfZG9tX2h0 bWxfbWVkaWFfZWxlbWVudF9nZXRfaW5pdGlhbF90aW1lKFdlYktpdERPTUhUTUxNZWRpYUVsZW1l bnQqKQotZ2NoYXIqIHdlYmtpdF9kb21faHRtbF9oZWFkX2VsZW1lbnRfZ2V0X3Byb2ZpbGUoV2Vi S2l0RE9NSFRNTEhlYWRFbGVtZW50KikKLXZvaWQgd2Via2l0X2RvbV9odG1sX2hlYWRfZWxlbWVu dF9zZXRfcHJvZmlsZShXZWJLaXRET01IVE1MSGVhZEVsZW1lbnQqLCBjb25zdCBnY2hhciopCiBn Y2hhciogd2Via2l0X2RvbV9wcm9jZXNzaW5nX2luc3RydWN0aW9uX2dldF9kYXRhKFdlYktpdERP TVByb2Nlc3NpbmdJbnN0cnVjdGlvbiopCiB2b2lkIHdlYmtpdF9kb21fcHJvY2Vzc2luZ19pbnN0 cnVjdGlvbl9zZXRfZGF0YShXZWJLaXRET01Qcm9jZXNzaW5nSW5zdHJ1Y3Rpb24qLCBjb25zdCBn Y2hhciosIEdFcnJvcioqKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KaW5kZXggMTE1ZmU5NC4uOTBlM2EwZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09i amVjdC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0 b3JHT2JqZWN0LnBtCkBAIC0zMDQsNiArMzA0LDExIEBAIHN1YiBTa2lwRnVuY3Rpb24gewogICAg ICAgICByZXR1cm4gMTsKICAgICB9CiAKKyAgICAjIFNraXAgQ29uc29sZTo6cHJvZmlsZSgpIGFu ZCBDb25zb2xlOjpwcm9maWxlRW5kKCkgYXMgdGhleSdyZSBub3QgY29ycmVjdGx5IGdlbmVyYXRl ZCBmb3IgdGhlIG1vbWVudC4KKyAgICBpZiAoJGZ1bmN0aW9uTmFtZSBlcSAid2Via2l0X2RvbV9j b25zb2xlX3Byb2ZpbGUiIHx8ICRmdW5jdGlvbk5hbWUgZXEgIndlYmtpdF9kb21fY29uc29sZV9w cm9maWxlX2VuZCIpIHsKKyAgICAgICAgcmV0dXJuIDE7CisgICAgfQorCiAgICAgaWYgKCRmdW5j dGlvbi0+c2lnbmF0dXJlLT5uYW1lIGVxICJzZXQiIGFuZCAkcGFyZW50Tm9kZS0+ZXh0ZW5kZWRB dHRyaWJ1dGVzLT57IlR5cGVkQXJyYXkifSkgewogICAgICAgICByZXR1cm4gMTsKICAgICB9CkBA IC0zMjQsNyArMzI5LDcgQEAgc3ViIFNraXBGdW5jdGlvbiB7CiAgICAgICAgIHJldHVybiAxOwog ICAgIH0KIAotICAgIGlmICgkZnVuY3Rpb24tPnNpZ25hdHVyZS0+bmFtZSBlcSAidGltZUVuZCIg fHwgJGZ1bmN0aW9uLT5zaWduYXR1cmUtPm5hbWUgZXEgInByb2ZpbGUiIHx8ICRmdW5jdGlvbi0+ c2lnbmF0dXJlLT5uYW1lIGVxICJwcm9maWxlRW5kIikgeworICAgIGlmICgkZnVuY3Rpb24tPnNp Z25hdHVyZS0+bmFtZSBlcSAidGltZUVuZCIpIHsKICAgICAgICAgcmV0dXJuIDE7CiAgICAgfQog Cg==