125691 2013-12-13 04:19:17 -0800 [GTK] Expose also webkit_dom_document_get_url 2013-12-13 04:37:09 -0800 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned cdumez commit-queue gustavo jasuarez oldest_to_newest 959537 0 cgarcia 2013-12-13 04:19:17 -0800 For some reason we expose the URL property, so it can be accessed with g_object_get(), but we have a special case to not provide a public getter. 959538 1 219166 cgarcia 2013-12-13 04:21:03 -0800 Created attachment 219166 Patch 959539 2 219166 mrobinson 2013-12-13 04:24:41 -0800 Comment on attachment 219166 Patch Were you able to figure out why the getter wasn't exposed? 959540 3 cgarcia 2013-12-13 04:31:08 -0800 (In reply to comment #2) > (From update of attachment 219166 [details]) > Were you able to figure out why the getter wasn't exposed? Nope, looked at git blame and that exception is there since the very beginning. My guess is that the property was added and the check for the public method was forgotten. 959542 4 cgarcia 2013-12-13 04:37:09 -0800 Committed r160543: <http://trac.webkit.org/changeset/160543> 219166 2013-12-13 04:21:03 -0800 2013-12-13 04:24:41 -0800 Patch wkdom-url-property.diff text/plain 2465 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMTJjZDZmLi45MWUzNTQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMTItMTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEV4cG9zZSBhbHNvIHdlYmtpdF9kb21fZG9jdW1lbnRfZ2V0X3Vy bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1Njkx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIHNv bWUgcmVhc29uIHdlIGV4cG9zZSB0aGUgVVJMIHByb3BlcnR5LCBzbyBpdCBjYW4gYmUgYWNjZXNz ZWQKKyAgICAgICAgd2l0aCBnX29iamVjdF9nZXQoKSwgYnV0IHdlIGhhdmUgYSBzcGVjaWFsIGNh c2UgdG8gbm90IHByb3ZpZGUgYQorICAgICAgICBwdWJsaWMgZ2V0dGVyLgorCisgICAgICAgICog YmluZGluZ3MvZ29iamVjdC93ZWJraXRkb20uc3ltYm9sczogQWRkIG5ldyBzeW1ib2wuCisgICAg ICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbToKKyAgICAgICAg KEdlbmVyYXRlRnVuY3Rpb25zKTogUmVtb3ZlIHRoZSBzcGVjaWFsIGNhc2Ugb2YgVVJMIHByb3Bl cnR5LgorCiAyMDEzLTEyLTEzICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAog ICAgICAgICBDU1NGaWx0ZXJJbWFnZVZhbHVlIGNvbnN0cnVjdG9yIHNob3VsZCByZXF1aXJlIGJv dGggaW1hZ2UgYW5kIGZpbHRlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2dvYmplY3Qvd2Via2l0ZG9tLnN5bWJvbHMgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2Jq ZWN0L3dlYmtpdGRvbS5zeW1ib2xzCmluZGV4IDZkZGY2OTcuLjk3MWI2NDkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3Qvd2Via2l0ZG9tLnN5bWJvbHMKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC93ZWJraXRkb20uc3ltYm9scwpAQCAtMTM2 LDYgKzEzNiw3IEBAIHZvaWQgd2Via2l0X2RvbV9kb2N1bWVudF9zZXRfZG9jdW1lbnRfdXJpKFdl YktpdERPTURvY3VtZW50KiwgY29uc3QgZ2NoYXIqKQogV2ViS2l0RE9NRE9NV2luZG93KiB3ZWJr aXRfZG9tX2RvY3VtZW50X2dldF9kZWZhdWx0X3ZpZXcoV2ViS2l0RE9NRG9jdW1lbnQqKQogV2Vi S2l0RE9NU3R5bGVTaGVldExpc3QqIHdlYmtpdF9kb21fZG9jdW1lbnRfZ2V0X3N0eWxlX3NoZWV0 cyhXZWJLaXRET01Eb2N1bWVudCopCiBnY2hhciogd2Via2l0X2RvbV9kb2N1bWVudF9nZXRfdGl0 bGUoV2ViS2l0RE9NRG9jdW1lbnQqKQorZ2NoYXIqIHdlYmtpdF9kb21fZG9jdW1lbnRfZ2V0X3Vy bChXZWJLaXRET01Eb2N1bWVudCopCiB2b2lkIHdlYmtpdF9kb21fZG9jdW1lbnRfc2V0X3RpdGxl KFdlYktpdERPTURvY3VtZW50KiwgY29uc3QgZ2NoYXIqKQogZ2NoYXIqIHdlYmtpdF9kb21fZG9j dW1lbnRfZ2V0X3JlZmVycmVyKFdlYktpdERPTURvY3VtZW50KikKIGdjaGFyKiB3ZWJraXRfZG9t X2RvY3VtZW50X2dldF9kb21haW4oV2ViS2l0RE9NRG9jdW1lbnQqKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbSBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KaW5k ZXggZDNhYTQ4Ni4uMTE1ZmU5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCkBAIC0xMjcyLDExICsxMjcyLDkg QEAgc3ViIEdlbmVyYXRlRnVuY3Rpb25zIHsKICAgICAgICAgICAgIG5leHQgVE9QOwogICAgICAg ICB9CiAKLSAgICAgICAgaWYgKCRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+bmFtZSBlcSAidHlwZSIK KyAgICAgICAgaWYgKCRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+bmFtZSBlcSAidHlwZSIpIHsKICAg ICAgICAgICAgICMgVGhpcyB3aWxsIGNvbmZsaWN0IHdpdGggdGhlIGdldF90eXBlKCkgZnVuY3Rp b24gd2UgZGVmaW5lIHRvIHJldHVybiBhIEdUeXBlCiAgICAgICAgICAgICAjIGFjY29yZGluZyB0 byBHT2JqZWN0IGNvbnZlbnRpb25zLiAgU2tpcCB0aGlzIGZvciBub3cuCi0gICAgICAgICAgICB8 fCAkYXR0cmlidXRlLT5zaWduYXR1cmUtPm5hbWUgZXEgIlVSTCIgICAgICMgVE9ETzogaGFuZGxl IHRoaXMKLSAgICAgICAgICAgICkgewogICAgICAgICAgICAgbmV4dCBUT1A7CiAgICAgICAgIH0K ICAgICAgICAgICAgIAo=