125686 2013-12-13 01:53:48 -0800 [GTK] Add a unit tests to WebKit2 to test node names 2013-12-13 02:21:42 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned commit-queue gustavo mrobinson oldest_to_newest 959521 0 cgarcia 2013-12-13 01:53:48 -0800 This was reported as a problem in the mailing list, so I added a new test case to check if I could reproduce the problem, that I can't, but I think we can add the test in any case. 959522 1 219163 cgarcia 2013-12-13 01:56:38 -0800 Created attachment 219163 Patch 959523 2 commit-queue 2013-12-13 01:57:35 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 959525 3 219163 gustavo 2013-12-13 02:12:44 -0800 Comment on attachment 219163 Patch Yeah, I couldn't reproduce it either. 959527 4 cgarcia 2013-12-13 02:21:42 -0800 Committed r160540: <http://trac.webkit.org/changeset/160540> 219163 2013-12-13 01:56:38 -0800 2013-12-13 02:12:43 -0800 Patch wk2-test-tag-names.diff text/plain 5020 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwMjdhZDMxLi44NTUwYWU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMTItMTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEFkZCBhIHVuaXQgdGVzdHMgdG8gV2ViS2l0MiB0byB0ZXN0IG5v ZGUgbmFtZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNTY4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvRE9NTm9kZVRlc3QuY3BwOgorICAgICAgICAoV2Vi S2l0RE9NTm9kZVRlc3Q6OnRlc3RUYWdOYW1lcyk6CisgICAgICAgIChXZWJLaXRET01Ob2RlVGVz dDo6cnVuVGVzdCk6CisgICAgICAgIChyZWdpc3RlclRlc3RzKToKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL2d0ay90ZXN0cy9UZXN0RE9NTm9kZS5jcHA6CisgICAgICAgICh0ZXN0V2ViS2l0RE9N Tm9kZVRhZ05hbWVzKToKKyAgICAgICAgKGJlZm9yZUFsbCk6CisKIDIwMTMtMTItMTIgIFphbiBE b2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFVzZSBvZiBhciBUIG9w dGlvbiBub3Qgc3VwcG9ydGVkIGJ5IG9sZGVyIGJpbnV0aWxzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9ET01Ob2RlVGVzdC5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9ET01Ob2RlVGVzdC5jcHAKaW5kZXggYmY3 ODQ1Ny4uZTE3NTRjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvdGVzdHMvRE9NTm9kZVRlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL3Rlc3RzL0RPTU5vZGVUZXN0LmNwcApAQCAtMjIsNiArMjIsNyBAQAogI2luY2x1ZGUg IldlYlByb2Nlc3NUZXN0LmgiCiAjaW5jbHVkZSA8Z2lvL2dpby5oPgogI2luY2x1ZGUgPHdlYmtp dDIvd2Via2l0LXdlYi1leHRlbnNpb24uaD4KKyNpbmNsdWRlIDx3dGYvZ29iamVjdC9HT3duUHRy Lmg+CiAKIGNsYXNzIFdlYktpdERPTU5vZGVUZXN0IDogcHVibGljIFdlYlByb2Nlc3NUZXN0IHsK IHB1YmxpYzoKQEAgLTE2OSwxMiArMTcwLDM2IEBAIHByaXZhdGU6CiAgICAgICAgIHJldHVybiB0 cnVlOwogICAgIH0KIAorICAgIGJvb2wgdGVzdFRhZ05hbWVzKFdlYktpdFdlYkV4dGVuc2lvbiog ZXh0ZW5zaW9uLCBHVmFyaWFudCogYXJncykKKyAgICB7CisgICAgICAgIHN0YXRpYyBjb25zdCBj aGFyKiBleHBlY3RlZFRhZ05hbWVzW10gPSB7ICJIVE1MIiwgIkhFQUQiLCAiQk9EWSIsICJWSURF TyIsICJTT1VSQ0UiLCAiVklERU8iLCAiU09VUkNFIiwgIklOUFVUIiB9OworCisgICAgICAgIFdl YktpdFdlYlBhZ2UqIHBhZ2UgPSB3ZWJraXRfd2ViX2V4dGVuc2lvbl9nZXRfcGFnZShleHRlbnNp b24sIHdlYlBhZ2VGcm9tQXJncyhhcmdzKSk7CisgICAgICAgIGdfYXNzZXJ0KFdFQktJVF9JU19X RUJfUEFHRShwYWdlKSk7CisgICAgICAgIFdlYktpdERPTURvY3VtZW50KiBkb2N1bWVudCA9IHdl YmtpdF93ZWJfcGFnZV9nZXRfZG9tX2RvY3VtZW50KHBhZ2UpOworICAgICAgICBnX2Fzc2VydChX RUJLSVRfRE9NX0lTX0RPQ1VNRU5UKGRvY3VtZW50KSk7CisKKyAgICAgICAgV2ViS2l0RE9NTm9k ZUxpc3QqIGxpc3QgPSB3ZWJraXRfZG9tX2RvY3VtZW50X2dldF9lbGVtZW50c19ieV90YWdfbmFt ZShkb2N1bWVudCwgIioiKTsKKyAgICAgICAgZ3Vsb25nIG5vZGVDb3VudCA9IHdlYmtpdF9kb21f bm9kZV9saXN0X2dldF9sZW5ndGgobGlzdCk7CisgICAgICAgIGdfYXNzZXJ0X2NtcHVpbnQobm9k ZUNvdW50LCA9PSwgR19OX0VMRU1FTlRTKGV4cGVjdGVkVGFnTmFtZXMpKTsKKyAgICAgICAgZm9y ICh1bnNpZ25lZCBpID0gMDsgaSA8IG5vZGVDb3VudDsgaSsrKSB7CisgICAgICAgICAgICBXZWJL aXRET01Ob2RlKiBub2RlID0gd2Via2l0X2RvbV9ub2RlX2xpc3RfaXRlbShsaXN0LCBpKTsKKyAg ICAgICAgICAgIGdfYXNzZXJ0KFdFQktJVF9ET01fSVNfTk9ERShub2RlKSk7CisgICAgICAgICAg ICBHT3duUHRyPGNoYXI+IHRhZ05hbWUod2Via2l0X2RvbV9ub2RlX2dldF9ub2RlX25hbWUobm9k ZSkpOworICAgICAgICAgICAgZ19hc3NlcnRfY21wc3RyKHRhZ05hbWUuZ2V0KCksID09LCBleHBl Y3RlZFRhZ05hbWVzW2ldKTsKKyAgICAgICAgfQorCisgICAgICAgIHJldHVybiB0cnVlOworICAg IH0KKwogICAgIHZpcnR1YWwgYm9vbCBydW5UZXN0KGNvbnN0IGNoYXIqIHRlc3ROYW1lLCBXZWJL aXRXZWJFeHRlbnNpb24qIGV4dGVuc2lvbiwgR1ZhcmlhbnQqIGFyZ3MpCiAgICAgewogICAgICAg ICBpZiAoIXN0cmNtcCh0ZXN0TmFtZSwgImhpZXJhcmNoeS1uYXZpZ2F0aW9uIikpCiAgICAgICAg ICAgICByZXR1cm4gdGVzdEhpZXJhcmNoeU5hdmlnYXRpb24oZXh0ZW5zaW9uLCBhcmdzKTsKICAg ICAgICAgaWYgKCFzdHJjbXAodGVzdE5hbWUsICJpbnNlcnRpb24iKSkKICAgICAgICAgICAgIHJl dHVybiB0ZXN0SW5zZXJ0aW9uKGV4dGVuc2lvbiwgYXJncyk7CisgICAgICAgIGlmICghc3RyY21w KHRlc3ROYW1lLCAidGFnLW5hbWVzIikpCisgICAgICAgICAgICByZXR1cm4gdGVzdFRhZ05hbWVz KGV4dGVuc2lvbiwgYXJncyk7CiAKICAgICAgICAgZ19hc3NlcnRfbm90X3JlYWNoZWQoKTsKICAg ICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtMTg1LDYgKzIxMCw3IEBAIHN0YXRpYyB2b2lkIF9fYXR0 cmlidXRlX18oKGNvbnN0cnVjdG9yKSkgcmVnaXN0ZXJUZXN0cygpCiB7CiAgICAgUkVHSVNURVJf VEVTVChXZWJLaXRET01Ob2RlVGVzdCwgIldlYktpdERPTU5vZGUvaGllcmFyY2h5LW5hdmlnYXRp b24iKTsKICAgICBSRUdJU1RFUl9URVNUKFdlYktpdERPTU5vZGVUZXN0LCAiV2ViS2l0RE9NTm9k ZS9pbnNlcnRpb24iKTsKKyAgICBSRUdJU1RFUl9URVNUKFdlYktpdERPTU5vZGVUZXN0LCAiV2Vi S2l0RE9NTm9kZS90YWctbmFtZXMiKTsKIH0KIAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0RE9NTm9kZS5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0RE9NTm9kZS5jcHAKaW5kZXggZjc5OWMxOS4u YmQzMjA3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVz dHMvVGVzdERPTU5vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L3Rlc3RzL1Rlc3RET01Ob2RlLmNwcApAQCAtNTAsNiArNTAsMjcgQEAgc3RhdGljIHZvaWQgdGVz dFdlYktpdERPTU5vZGVJbnNlcnRpb24oV2ViVmlld1Rlc3QqIHRlc3QsIGdjb25zdHBvaW50ZXIp CiAgICAgZ19hc3NlcnQodGVzdFJ1bm5lci0+cnVuVGVzdCgiV2ViS2l0RE9NTm9kZSIsICJpbnNl cnRpb24iLCBnX3ZhcmlhbnRfYnVpbGRlcl9lbmQoJmJ1aWxkZXIpKSk7CiB9CiAKK3N0YXRpYyB2 b2lkIHRlc3RXZWJLaXRET01Ob2RlVGFnTmFtZXMoV2ViVmlld1Rlc3QqIHRlc3QsIGdjb25zdHBv aW50ZXIpCit7CisgICAgc3RhdGljIGNvbnN0IGNoYXIqIHRlc3RIVE1MID0gIjxodG1sPjxoZWFk PjwvaGVhZD48Ym9keT4iCisgICAgICAgICI8dmlkZW8gaWQ9J3ZpZGVvJyBwcmVsb2FkPSdub25l Jz4iCisgICAgICAgICIgICAgPHNvdXJjZSBzcmM9J21vdmllLm9nZycgdHlwZT0ndmlkZW8vb2dn Jz4iCisgICAgICAgICIgICAgICAgIFlvdXIgYnJvd3NlciBkb2VzIG5vdCBzdXBwb3J0IHRoZSB2 aWRlbyB0YWcuIgorICAgICAgICAiPC92aWRlbz4iCisgICAgICAgICI8dmlkZW8gaWQ9J3ZpZGVv MicgcHJlbG9hZD0nbm9uZSc+IgorICAgICAgICAiICAgICA8c291cmNlIHNyYz0nbW92aWUub2dn JyB0eXBlPSd2aWRlby9vZ2cnPiIKKyAgICAgICAgIiAgICAgICAgWW91ciBicm93c2VyIGRvZXMg bm90IHN1cHBvcnQgdGhlIHZpZGVvIHRhZy4iCisgICAgICAgICI8L3ZpZGVvPiIKKyAgICAgICAg IjxpbnB1dCB0eXBlPSdoaWRkZW4nIGlkPSd0ZXN0JyBuYW1lPSdmaW5pc2gnIHZhbHVlPSdmYWxz ZSc+PC9ib2R5PjwvaHRtbD4iOworICAgIHRlc3QtPmxvYWRIdG1sKHRlc3RIVE1MLCAwKTsKKyAg ICB0ZXN0LT53YWl0VW50aWxMb2FkRmluaXNoZWQoKTsKKworICAgIEdWYXJpYW50QnVpbGRlciBi dWlsZGVyOworICAgIGdfdmFyaWFudF9idWlsZGVyX2luaXQoJmJ1aWxkZXIsIEdfVkFSSUFOVF9U WVBFX1ZBUkRJQ1QpOworICAgIGdfdmFyaWFudF9idWlsZGVyX2FkZCgmYnVpbGRlciwgIntzdn0i LCAicGFnZUlEIiwgZ192YXJpYW50X25ld191aW50NjQod2Via2l0X3dlYl92aWV3X2dldF9wYWdl X2lkKHRlc3QtPm1fd2ViVmlldykpKTsKKyAgICBnX2Fzc2VydCh0ZXN0UnVubmVyLT5ydW5UZXN0 KCJXZWJLaXRET01Ob2RlIiwgInRhZy1uYW1lcyIsIGdfdmFyaWFudF9idWlsZGVyX2VuZCgmYnVp bGRlcikpKTsKK30KKwogdm9pZCBiZWZvcmVBbGwoKQogewogICAgIHRlc3RSdW5uZXIgPSBuZXcg V2ViUHJvY2Vzc1Rlc3RSdW5uZXIoKTsKQEAgLTU3LDYgKzc4LDcgQEAgdm9pZCBiZWZvcmVBbGwo KQogCiAgICAgV2ViVmlld1Rlc3Q6OmFkZCgiV2ViS2l0RE9NTm9kZSIsICJoaWVyYXJjaHktbmF2 aWdhdGlvbiIsIHRlc3RXZWJLaXRET01Ob2RlSGllcmFyY2h5TmF2aWdhdGlvbik7CiAgICAgV2Vi Vmlld1Rlc3Q6OmFkZCgiV2ViS2l0RE9NTm9kZSIsICJpbnNlcnRpb24iLCB0ZXN0V2ViS2l0RE9N Tm9kZUluc2VydGlvbik7CisgICAgV2ViVmlld1Rlc3Q6OmFkZCgiV2ViS2l0RE9NTm9kZSIsICJ0 YWctbmFtZXMiLCB0ZXN0V2ViS2l0RE9NTm9kZVRhZ05hbWVzKTsKIH0KIAogdm9pZCBhZnRlckFs bCgpCg==