125677 2013-12-12 21:22:12 -0800 CStack Branch: Use proper values for stack checks 2013-12-12 21:48:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 959465 0 msaboff 2013-12-12 21:22:12 -0800 Each of the JavaScript engines needs to check for available stack on entry to a function. This is done by subtracting a value from the callFrameRegister and then making sure it is greater than VM::m_jsStackLimit. Each engine gets the value a slightly different way. The LLInt should use CodeBlock::m_numCalleeRegisters * register size + maxFrameExtentForSlowPathCall The baseline JIT should use frameRegisterCountFor() The DFG should use Graph::requiredRegisterCountForExecutionAndExit() 959471 1 219152 msaboff 2013-12-12 21:32:10 -0800 Created attachment 219152 Patch 959475 2 msaboff 2013-12-12 21:48:34 -0800 Committed r160527: <http://trac.webkit.org/changeset/160527> 219152 2013-12-12 21:32:10 -0800 2013-12-12 21:47:19 -0800 Patch 125677.patch text/plain 3905 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwNTI2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDEzLTEyLTEyICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENTdGFjayBCcmFuY2g6IFVzZSBwcm9wZXIgdmFsdWVzIGZvciBzdGFjayBjaGVja3MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTY3NworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvciB0aGUgTExJ bnQgdXNpbmcgQ29kZUJsb2NrOjptX251bUNhbGxlZVJlZ2lzdGVycyArIG1heEZyYW1lRXh0ZW50 Rm9yU2xvd1BhdGhDYWxsLgorICAgICAgICBGb3IgdGhlIGJhc2VsaW5lIEpJVCB1c2luZyBmcmFt ZVJlZ2lzdGVyQ291bnRGb3IoKS4KKyAgICAgICAgRm9yIHRoZSBERkcgdXNpbmcgR3JhcGg6OnJl cXVpcmVkUmVnaXN0ZXJDb3VudEZvckV4ZWN1dGlvbkFuZEV4aXQoKS4KKworICAgICAgICBVc2lu ZyB2aXJ0dWFsUmVnaXN0ZXJGb3JMb2NhbCgpLm9mZnNldCgpIHRvIGdldCB0aGUgcmVnaXN0ZXIg b2Zmc2V0IGdpdmVuIGEgY291bnQuCisgICAgICAgIE5vdGUgdGhhdCBmb3IgTiByZWdpc3RlcnMs IHRoZSB2YWx1ZSBwYXNzZWQgaW50byB2aXJ0dWFsUmVnaXN0ZXJGb3JMb2NhbCgpIG5lZWRzCisg ICAgICAgIHRvIGJlIE4tMSwgc2luY2Ugd2UgYXJlIHRyeWluZyB0byBjaGVjayB0byBzZWUgaWYg dGhlcmUgaXMgc3BhY2UgZm9yIHJlZ2lzdGVycyAwLi5OLTEuCisKKyAgICAgICAgKiBkZmcvREZH SklUQ29tcGlsZXIuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkpJVENvbXBpbGVyOjpjb21waWxl RnVuY3Rpb24pOgorICAgICAgICAqIGppdC9KSVQuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OnBy aXZhdGVDb21waWxlKToKKyAgICAgICAgKiBsbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbToK KwogMjAxMy0xMi0xMiAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAg ICAgICBDU3RhY2sgQnJhbmNoOiBBZGQgZXF1aXZhbGVudCB2YWx1ZXMgZnJvbSBNYXhGcmFtZUV4 dGVudEZvclNsb3dQYXRoQ2FsbC5oIHRvIGxpbnQgZmlsZXMKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCShyZXZpc2lvbiAxNjA1MjIpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBpbGVyLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMzI2LDcgKzMyNiw3IEBAIHZvaWQgSklUQ29tcGlsZXI6OmNvbXBpbGVGdW5jdGlvbigp CiAgICAgLy8gc28gZW50ZXIgYWZ0ZXIgdGhpcy4KICAgICBMYWJlbCBmcm9tQXJpdHlDaGVjayh0 aGlzKTsKICAgICAvLyBQbGFudCBhIGNoZWNrIHRoYXQgc3VmZmljaWVudCBzcGFjZSBpcyBhdmFp bGFibGUgaW4gdGhlIEpTU3RhY2suCi0gICAgYWRkUHRyKFRydXN0ZWRJbW0zMih2aXJ0dWFsUmVn aXN0ZXJGb3JMb2NhbChtX2dyYXBoLnJlcXVpcmVkUmVnaXN0ZXJDb3VudEZvckV4ZWN1dGlvbkFu ZEV4aXQoKSkub2Zmc2V0KCkgKiBzaXplb2YoUmVnaXN0ZXIpKSwgR1BSSW5mbzo6Y2FsbEZyYW1l UmVnaXN0ZXIsIEdQUkluZm86OnJlZ1QxKTsKKyAgICBhZGRQdHIoVHJ1c3RlZEltbTMyKHZpcnR1 YWxSZWdpc3RlckZvckxvY2FsKG1fZ3JhcGgucmVxdWlyZWRSZWdpc3RlckNvdW50Rm9yRXhlY3V0 aW9uQW5kRXhpdCgpIC0gMSkub2Zmc2V0KCkgKiBzaXplb2YoUmVnaXN0ZXIpKSwgR1BSSW5mbzo6 Y2FsbEZyYW1lUmVnaXN0ZXIsIEdQUkluZm86OnJlZ1QxKTsKICAgICBKdW1wIHN0YWNrQ2hlY2sg PSBicmFuY2hQdHIoQWJvdmUsIEFic29sdXRlQWRkcmVzcyhtX3ZtLT5hZGRyZXNzT2ZKU1N0YWNr TGltaXQoKSksIEdQUkluZm86OnJlZ1QxKTsKICAgICAvLyBSZXR1cm4gaGVyZSBhZnRlciBzdGFj ayBjaGVjay4KICAgICBMYWJlbCBmcm9tU3RhY2tDaGVjayA9IGxhYmVsKCk7CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2ppdC9KSVQuY3BwCShyZXZpc2lvbiAxNjA1MjIpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvaml0L0pJVC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQyLDYgKzQyLDcgQEAgSlND OjpNYWNyb0Fzc2VtYmxlclg4NkNvbW1vbjo6U1NFMkNoZWNrUwogI2luY2x1ZGUgIkpTQXJyYXku aCIKICNpbmNsdWRlICJKU0Z1bmN0aW9uLmgiCiAjaW5jbHVkZSAiTGlua0J1ZmZlci5oIgorI2lu Y2x1ZGUgIk1heEZyYW1lRXh0ZW50Rm9yU2xvd1BhdGhDYWxsLmgiCiAjaW5jbHVkZSAiT3BlcmF0 aW9ucy5oIgogI2luY2x1ZGUgIlJlcGF0Y2hCdWZmZXIuaCIKICNpbmNsdWRlICJSZXN1bHRUeXBl LmgiCkBAIC01MzgsNyArNTM5LDcgQEAgQ29tcGlsYXRpb25SZXN1bHQgSklUOjpwcml2YXRlQ29t cGlsZShKSQogICAgICAgICB9CiAjZW5kaWYKIAotICAgICAgICBhZGRQdHIoVHJ1c3RlZEltbTMy KHZpcnR1YWxSZWdpc3RlckZvckxvY2FsKGZyYW1lUmVnaXN0ZXJDb3VudEZvcihtX2NvZGVCbG9j aykpLm9mZnNldCgpICogc2l6ZW9mKFJlZ2lzdGVyKSksIGNhbGxGcmFtZVJlZ2lzdGVyLCByZWdU MSk7CisgICAgICAgIGFkZFB0cihUcnVzdGVkSW1tMzIodmlydHVhbFJlZ2lzdGVyRm9yTG9jYWwo ZnJhbWVSZWdpc3RlckNvdW50Rm9yKG1fY29kZUJsb2NrKSAtIDEpLm9mZnNldCgpICogc2l6ZW9m KFJlZ2lzdGVyKSAtIG1heEZyYW1lRXh0ZW50Rm9yU2xvd1BhdGhDYWxsKSwgY2FsbEZyYW1lUmVn aXN0ZXIsIHJlZ1QxKTsKICAgICAgICAgc3RhY2tDaGVjayA9IGJyYW5jaFB0cihBYm92ZSwgQWJz b2x1dGVBZGRyZXNzKG1fdm0tPmFkZHJlc3NPZkpTU3RhY2tMaW1pdCgpKSwgcmVnVDEpOwogICAg IH0KIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0 ZXIuYXNtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZl bEludGVycHJldGVyLmFzbQkocmV2aXNpb24gMTYwNTIyKQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC00MjMs OSArNDIzLDkgQEAgbWFjcm8gZnVuY3Rpb25Jbml0aWFsaXphdGlvbihwcm9maWxlQXJnUwogICAg ICAgICAKICAgICAjIENoZWNrIHN0YWNrIGhlaWdodC4KICAgICBsb2FkaSBDb2RlQmxvY2s6Om1f bnVtQ2FsbGVlUmVnaXN0ZXJzW3QxXSwgdDAKLSAgICBhZGRpIDEsIHQwICMgQWNjb3VudCB0aGF0 IGxvY2FsMCBnb2VzIGF0IHNsb3QgLTEKICAgICBsb2FkcCBDb2RlQmxvY2s6Om1fdm1bdDFdLCB0 MgogICAgIGxzaGlmdHAgMywgdDAKKyAgICBhZGRpIG1heEZyYW1lRXh0ZW50Rm9yU2xvd1BhdGhD YWxsLCB0MAogICAgIHN1YnAgY2ZyLCB0MCwgdDAKICAgICBicGJlcSBWTTo6bV9qc1N0YWNrTGlt aXRbdDJdLCB0MCwgLnN0YWNrSGVpZ2h0T0sKIAo=