125669 2013-12-12 17:47:01 -0800 CStack Branch: Add equivalent values from MaxFrameExtentForSlowPathCall.h to lint files 2013-12-12 18:03:30 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff commit-queue eflews.bot gtk-ews gyuyoung.kim xan.lopez oldest_to_newest 959416 0 msaboff 2013-12-12 17:47:01 -0800 The port specific values of maxFrameExtentForSlowPathCall in assembler/MaxFrameExtentForSlowPathCall.h also need to be added to LowLevelInterpreter.asm. 959417 1 219137 msaboff 2013-12-12 17:48:57 -0800 Created attachment 219137 Patch 959419 2 commit-queue 2013-12-12 17:51:12 -0800 Attachment 219137 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/llint/LLIntData.cpp', u'Source/JavaScriptCore/llint/LowLevelInterpreter.asm', '--commit-queue']" exit_code: 1 ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:128: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 959420 3 219137 mark.lam 2013-12-12 17:54:15 -0800 Comment on attachment 219137 Patch r=me 959421 4 219137 eflews.bot 2013-12-12 17:58:23 -0800 Comment on attachment 219137 Patch Attachment 219137 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/48648018 959422 5 219137 eflews.bot 2013-12-12 17:58:27 -0800 Comment on attachment 219137 Patch Attachment 219137 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/48658025 959424 6 219137 gtk-ews 2013-12-12 17:58:59 -0800 Comment on attachment 219137 Patch Attachment 219137 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/48618026 959425 7 219137 mark.lam 2013-12-12 18:00:04 -0800 Comment on attachment 219137 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219137&action=review > Source/JavaScriptCore/llint/LLIntData.cpp:131 > +#elif CPU(ARM) || CPU(SH4) > + ASSERT(maxFrameExtentForSlowPathCall == 16); Since CPU(ARM) covers both the CPU(ARM_TRADITIONAL) and CPU(ARM_THUMB2) cases, can you change the #if in MaxFrameExtentForSlowPathCall.h to reflect this (so that this list looks consistent with the one there)? 959428 8 msaboff 2013-12-12 18:03:30 -0800 Committed r160522: <http://trac.webkit.org/changeset/160522> 219137 2013-12-12 17:48:57 -0800 2013-12-12 18:00:04 -0800 Patch 125669.patch text/plain 2547 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwNTIxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEzLTEyLTEyICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENTdGFjayBCcmFuY2g6IEFkZCBlcXVpdmFsZW50IHZhbHVlcyBmcm9tIE1heEZyYW1lRXh0 ZW50Rm9yU2xvd1BhdGhDYWxsLmggdG8gbGludCBmaWxlcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1NjY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgcGxhdGZvcm0gc3BlY2lmaWMgdmFsdWUg b2YgbWF4RnJhbWVFeHRlbnRGb3JTbG93UGF0aENhbGwgdG8gbGxpbnQgY29kZS4KKyAgICAgICAg QWxzbyBhZGRlZCBBU1NFUlRzIHRvIGNoZWNrIHRoYXQgd2UgYXJlIHVzaW5nIHRoZSBzYXZlIHZh bHVlIGluIGJvdGggcGxhY2VzLgorCisgICAgICAgICogbGxpbnQvTExJbnREYXRhLmNwcDoKKyAg ICAgICAgKEpTQzo6TExJbnQ6OkRhdGE6OnBlcmZvcm1Bc3NlcnRpb25zKToKKyAgICAgICAgKiBs bGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbToKKwogMjAxMy0xMi0xMiAgTWljaGFlbCBTYWJv ZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBDU3RhY2sgQnJhbmNoOiBBZGQgdGhl IG5ldyBhc3NlbWJsZXIvTWF4RnJhbWVFeHRlbnRGb3JTbG93UGF0aENhbGwuaCB0byBidWlsZCBm aWxlcwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50RGF0YS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50RGF0YS5jcHAJKHJl dmlzaW9uIDE2MDUxNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludERhdGEu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMyw3IEBACiAjaW5jbHVkZSAiSW5zdHJ1Y3Rp b24uaCIKICNpbmNsdWRlICJKU1Njb3BlLmgiCiAjaW5jbHVkZSAiTExJbnRDTG9vcC5oIgorI2lu Y2x1ZGUgIk1heEZyYW1lRXh0ZW50Rm9yU2xvd1BhdGhDYWxsLmgiCiAjaW5jbHVkZSAiT3Bjb2Rl LmgiCiAjaW5jbHVkZSAiUHJvcGVydHlPZmZzZXQuaCIKIApAQCAtMTI0LDYgKzEyNSwxMyBAQCB2 b2lkIERhdGE6OnBlcmZvcm1Bc3NlcnRpb25zKFZNJiB2bSkKICAgICBBU1NFUlQoVmFsdWVVbmRl ZmluZWQgPT0gKFRhZ0JpdFR5cGVPdGhlciB8IFRhZ0JpdFVuZGVmaW5lZCkpOwogICAgIEFTU0VS VChWYWx1ZU51bGwgPT0gVGFnQml0VHlwZU90aGVyKTsKICNlbmRpZgorI2lmIENQVShYODZfNjQp IHx8IENQVShBUk02NCkgfHwgRU5BQkxFKExMSU5UX0NfTE9PUCkKKyAgICBBU1NFUlQobWF4RnJh bWVFeHRlbnRGb3JTbG93UGF0aENhbGwgPT0gMCk7CisjZWxpZiBDUFUoQVJNKSB8fCBDUFUoU0g0 KQorICAgIEFTU0VSVChtYXhGcmFtZUV4dGVudEZvclNsb3dQYXRoQ2FsbCA9PSAxNik7CisjZWxp ZiBDUFUoWDg2KSB8fCBDUFUoTUlQUykKKyAgICBBU1NFUlQobWF4RnJhbWVFeHRlbnRGb3JTbG93 UGF0aENhbGwgPT0gMzIpOworI2VuZGlmCiAgICAgQVNTRVJUKFN0cmluZ1R5cGUgPT0gNSk7CiAg ICAgQVNTRVJUKE9iamVjdFR5cGUgPT0gMTcpOwogICAgIEFTU0VSVChGaW5hbE9iamVjdFR5cGUg PT0gMTgpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJw cmV0ZXIuYXNtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dM ZXZlbEludGVycHJldGVyLmFzbQkocmV2aXNpb24gMTYwNTE2KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC03 Myw2ICs3MywxNCBAQCBjb25zdCBEZWxldGVkVmFsdWVUYWcgPSAtNwogY29uc3QgTG93ZXN0VGFn ID0gRGVsZXRlZFZhbHVlVGFnCiBlbmQKIAoraWYgWDg2XzY0IG9yIEFSTTY0IG9yIENfTE9PUAor Y29uc3QgbWF4RnJhbWVFeHRlbnRGb3JTbG93UGF0aENhbGwgPSAwCitlbHNpZiBBUk0gb3IgQVJN djdfVFJBRElUSU9OQUwgb3IgQVJNdjcgb3IgU0g0Citjb25zdCBtYXhGcmFtZUV4dGVudEZvclNs b3dQYXRoQ2FsbCA9IDE2CitlbHNpZiBYODYgb3IgTUlQUworY29uc3QgbWF4RnJhbWVFeHRlbnRG b3JTbG93UGF0aENhbGwgPSAzMgorZW5kCisKICMgV2F0Y2hwb2ludCBzdGF0ZXMKIGNvbnN0IENs ZWFyV2F0Y2hwb2ludCA9IDAKIGNvbnN0IElzV2F0Y2hlZCA9IDEK