125666 2013-12-12 16:21:50 -0800 CStack Branch: Put all stack saving and restoring callToJavaScript in {push/pop}CalleeSaves 2014-01-13 18:44:48 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff mark.lam oldest_to_newest 959394 0 msaboff 2013-12-12 16:21:50 -0800 The LLInt stub callToJavaScript uses the peudo-ops pushCalleeSaves and popCalleeSaves to save and restore C calling convention calle saves. It also uses a separate value to leave extra stack space. This was needed for aligning the stack and space for outgoing calls to C helper function. The aligning should be done in {push,pop}CalleeSaves and the extra space is now at the top of the stack and will be handled separately. 959397 1 219134 msaboff 2013-12-12 16:27:27 -0800 Created attachment 219134 Patch 959398 2 msaboff 2013-12-12 16:27:52 -0800 Landed in r160516 on the jsCStack branch: <http://trac.webkit.org/160516 > 959400 3 219134 ggaren 2013-12-12 16:30:00 -0800 Comment on attachment 219134 Patch r=me 967608 4 mark.lam 2014-01-13 18:44:48 -0800 Review status updated in r161938: <http://trac.webkit.org/r161938>. 219134 2013-12-12 16:27:27 -0800 2013-12-12 16:30:00 -0800 Patch 125666.patch text/plain 3818 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwNTE1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTEyLTEyICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENTdGFjayBCcmFuY2g6IFB1dCBhbGwgc3RhY2sgc2F2aW5nIGFuZCByZXN0b3JpbmcgY2Fs bFRvSmF2YVNjcmlwdCBpbiB7cHVzaC9wb3B9Q2FsbGVlU2F2ZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTY2NgorCisgICAgICAgIE5vdCB5ZXQg cmV2aWV3ZWQuCisKKyAgICAgICAgRWxpbWluYXRlZCAiZXh0cmFTdGFjayIgYXJndW1lbnRzIGFu ZCByZWxhdGVkIHN0YWNrIHBvaW50ZXIgbWFuaXB1bGF0aW9uIGZvciA2NCBiaXQgcGxhdGZvcm1z LgorICAgICAgICBCb3RoIEFSTTY0IGFuZCBYODZfNjQgYWxyZWFkeSBoYXZlIGFsaWduZWQgc3Rh Y2tzLiAgRWxpbWluYXRlZCBzb21lIHJlbGF0ZWQgY29tbWVudGVkIG91dAorICAgICAgICBjb2Rl LgorCisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbToKKwogMjAxMy0x Mi0xMiAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBDU3Rh Y2sgQnJhbmNoOiBFbGltaW5hdGUgdW5uZWNlc3NhcnkgYWRkL3N1YiAxNiB0byBzdGFjayBwb2lu dGVyCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRl cjY0LmFzbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2 ZWxJbnRlcnByZXRlcjY0LmFzbQkocmV2aXNpb24gMTYwNTE1KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5hc20JKHdvcmtpbmcgY29weSkKQEAg LTk5LDE4ICs5OSwxNiBAQCBtYWNybyBjaGVja1N0YWNrUG9pbnRlckFsaWdubWVudCh0ZW1wUmVn CiBlbmQKIAogCi1tYWNybyBmdW5jdGlvblByb2xvZ3VlKGV4dHJhU3RhY2tTcGFjZSkKK21hY3Jv IGZ1bmN0aW9uUHJvbG9ndWUoKQogICAgIGlmIFg4Nl82NAogICAgICAgICBwdXNoIGNmcgogICAg ICAgICBtb3ZlIHNwLCBjZnIKICAgICBlbHNpZiBBUk02NAogICAgICAgICBwdXNoTFJBbmRGUAog ICAgIGVuZAotICAgIHN1YnAgZXh0cmFTdGFja1NwYWNlLCBzcAogZW5kCiAKLW1hY3JvIGZ1bmN0 aW9uRXBpbG9ndWUoZXh0cmFTdGFja1NwYWNlKQotICAgIGFkZHAgZXh0cmFTdGFja1NwYWNlLCBz cAorbWFjcm8gZnVuY3Rpb25FcGlsb2d1ZSgpCiAgICAgaWYgWDg2XzY0CiAgICAgICAgIHBvcCBj ZnIKICAgICBlbHNpZiBBUk02NApAQCAtMTE4LDI5ICsxMTYsMjAgQEAgbWFjcm8gZnVuY3Rpb25F cGlsb2d1ZShleHRyYVN0YWNrU3BhY2UpCiAgICAgZW5kCiBlbmQKIAotbWFjcm8gY2FsbFRvSmF2 YVNjcmlwdFByb2xvZ3VlKGV4dHJhU3RhY2tTcGFjZSkKK21hY3JvIGNhbGxUb0phdmFTY3JpcHRQ cm9sb2d1ZSgpCiAgICAgaWYgWDg2XzY0Ci0jICAgICAgICBwdXNoIGNmcgotIyAgICAgICAgbW92 ZSBzcCwgY2ZyCiAgICAgZWxzaWYgQVJNNjQKICAgICAgICAgcHVzaExSQW5kRlAKICAgICBlbmQK ICAgICBwdXNoQ2FsbGVlU2F2ZXMKLSAgICBpZiBYODZfNjQKLSAgICAgICAgc3VicCBleHRyYVN0 YWNrU3BhY2UsIHNwCi0gICAgZW5kCiBlbmQKIAotbWFjcm8gY2FsbFRvSmF2YVNjcmlwdEVwaWxv Z3VlKGV4dHJhU3RhY2tTcGFjZSkKK21hY3JvIGNhbGxUb0phdmFTY3JpcHRFcGlsb2d1ZSgpCiAg ICAgYWRkcCAoQ2FsbEZyYW1lSGVhZGVyU2xvdHMtMSkqOCwgY2ZyLCBzcAogICAgIGxvYWRwIENh bGxlckZyYW1lW2Nmcl0sIGNmcgogCi0gICAgaWYgWDg2XzY0Ci0gICAgICAgIGFkZHAgZXh0cmFT dGFja1NwYWNlLCBzcAotICAgIGVuZAogICAgIHBvcENhbGxlZVNhdmVzCiAgICAgaWYgWDg2XzY0 Ci0jICAgICAgICBwb3AgY2ZyCiAgICAgZWxzaWYgQVJNNjQKICAgICAgICAgcG9wTFJBbmRGUAog ICAgIGVuZApAQCAtMTY2LDcgKzE1NSw2IEBAIG1hY3JvIGRvQ2FsbFRvSmF2YVNjcmlwdChtYWtl Q2FsbCkKICAgICAgICAgY29uc3QgcHJvdG9DYWxsRnJhbWUgPSB0MQogICAgICAgICBjb25zdCB0 b3BPZlN0YWNrID0gdDIKIAotICAgICAgICBjb25zdCBleHRyYVN0YWNrU3BhY2UgPSAxNgogICAg ICAgICBjb25zdCBwcmV2aW91c0NGUiA9IHQwCiAgICAgICAgIGNvbnN0IHByZXZpb3VzUEMgPSB0 NgogICAgICAgICBjb25zdCB0ZW1wMSA9IHQwCkBAIC0xNzgsNyArMTY2LDYgQEAgbWFjcm8gZG9D YWxsVG9KYXZhU2NyaXB0KG1ha2VDYWxsKQogICAgICAgICBjb25zdCBwcm90b0NhbGxGcmFtZSA9 IGEyCiAgICAgICAgIGNvbnN0IHRvcE9mU3RhY2sgPSBhMwogCi0gICAgICAgIGNvbnN0IGV4dHJh U3RhY2tTcGFjZSA9IDAKICAgICAgICAgY29uc3QgcHJldmlvdXNDRlIgPSB0NAogICAgICAgICBj b25zdCBwcmV2aW91c1BDID0gbHIKICAgICAgICAgY29uc3QgdGVtcDEgPSB0MwpAQCAtMTkwLDcg KzE3Nyw3IEBAIG1hY3JvIGRvQ2FsbFRvSmF2YVNjcmlwdChtYWtlQ2FsbCkKICAgICAgICAgbG9h ZHAgW3NwXSwgcHJldmlvdXNQQwogICAgIGVuZAogICAgIG1vdmUgY2ZyLCBwcmV2aW91c0NGUgot ICAgIGNhbGxUb0phdmFTY3JpcHRQcm9sb2d1ZShleHRyYVN0YWNrU3BhY2UpCisgICAgY2FsbFRv SmF2YVNjcmlwdFByb2xvZ3VlKCkKIAogICAgIGNoZWNrU3RhY2tQb2ludGVyQWxpZ25tZW50KHRl bXAyLCAweGJhZDBkYzAxKQogCkBAIC0yNjIsNyArMjQ5LDcgQEAgbWFjcm8gZG9DYWxsVG9KYXZh U2NyaXB0KG1ha2VDYWxsKQogCiAgICAgY2hlY2tTdGFja1BvaW50ZXJBbGlnbm1lbnQodGVtcDMs IDB4YmFkMGRjMDQpCiAKLSAgICBjYWxsVG9KYXZhU2NyaXB0RXBpbG9ndWUoZXh0cmFTdGFja1Nw YWNlKQorICAgIGNhbGxUb0phdmFTY3JpcHRFcGlsb2d1ZSgpCiAgICAgcmV0CiBlbmQKIApAQCAt MzAxLDcgKzI4OCw3IEBAIF9oYW5kbGVVbmNhdWdodEV4Y2VwdGlvbjoKICAgICBsb2FkcCBTY29w ZUNoYWluW2Nmcl0sIHQ2CiAgICAgc3RvcmVwIHQ2LCBbdDNdCiAKLSAgICBjYWxsVG9KYXZhU2Ny aXB0RXBpbG9ndWUoMTYpCisgICAgY2FsbFRvSmF2YVNjcmlwdEVwaWxvZ3VlKCkKICAgICByZXQK IAogCkBAIC0xOTA1LDcgKzE4OTIsNyBAQCBfbGxpbnRfdGhyb3dfZHVyaW5nX2NhbGxfdHJhbXBv bGluZToKIAogbWFjcm8gbmF0aXZlQ2FsbFRyYW1wb2xpbmUoZXhlY3V0YWJsZU9mZnNldFRvRnVu Y3Rpb24pCiAKLSAgICBmdW5jdGlvblByb2xvZ3VlKDApCisgICAgZnVuY3Rpb25Qcm9sb2d1ZSgp CiAgICAgc3RvcmVwIDAsIENvZGVCbG9ja1tjZnJdCiAgICAgaWYgWDg2XzY0CiAgICAgICAgIGxv YWRwIFNjb3BlQ2hhaW5bY2ZyXSwgdDAKQEAgLTE5NzAsNyArMTk1Nyw3IEBAIG1hY3JvIG5hdGl2 ZUNhbGxUcmFtcG9saW5lKGV4ZWN1dGFibGVPZmYKICAgICBlbmQKIAogICAgIGJ0cW56IFZNOjpt X2V4Y2VwdGlvblt0M10sIC5leGNlcHRpb24KLSAgICBmdW5jdGlvbkVwaWxvZ3VlKDApCisgICAg ZnVuY3Rpb25FcGlsb2d1ZSgpCiAgICAgcmV0CiAuZXhjZXB0aW9uOgogICAgIGlmIFg4Nl82NAo=