125664 2013-12-12 15:48:14 -0800 Web Inspector: Fix Type Dependency Issues 2014-10-29 19:29:42 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck buildbot burg commit-queue joepeck rniwa timothy webkit-bug-importer oldest_to_newest 959381 0 joepeck 2013-12-12 15:48:14 -0800 There are some type dependency issues where Domains in JavaScriptCore depended on types in WebCore. We should come up with proper fixes for these issues, so that we can safely share the types between all places. At the moment, my intended workaround has been to duplicate the type with different names in JSC and WebCore. 959386 1 joepeck 2013-12-12 15:54:24 -0800 • Runtime.RuntimeFrameId duplicates Network.FrameId • Debugger.DebuggerSearchMatch duplicates Page.SearchMatch One approach would be to just reverse the dependency, and define it in the lower domain. However I think this may need to addressed on a case by case basis: • FrameId doesn't belong in Runtime. Maybe a more generic type name should used. • SearchMatch doesn't need to be in a specific domain. Maybe we should have a place of shared types everywhere. E.g. a Type domain which has no commands, just very generic types. 1044925 2 webkit-bug-importer 2014-10-29 17:42:56 -0700 <rdar://problem/18819515> 1044926 3 240643 joepeck 2014-10-29 17:43:02 -0700 Created attachment 240643 [PATCH] Proposed Fix 1044927 4 joepeck 2014-10-29 17:44:07 -0700 (In reply to comment #1) > • Debugger.DebuggerSearchMatch duplicates Page.SearchMatch This was worked around by GenericTypes.json. I'll keep that for now, I think its a worthwhile concept. 1044949 5 240643 burg 2014-10-29 18:50:32 -0700 Comment on attachment 240643 [PATCH] Proposed Fix Thanks for the cleanup! 1044957 6 240643 commit-queue 2014-10-29 19:29:39 -0700 Comment on attachment 240643 [PATCH] Proposed Fix Clearing flags on attachment: 240643 Committed r175362: <http://trac.webkit.org/changeset/175362> 1044958 7 commit-queue 2014-10-29 19:29:42 -0700 All reviewed patches have been landed. Closing bug. 240643 2014-10-29 17:43:02 -0700 2014-10-29 19:29:39 -0700 [PATCH] Proposed Fix fix-dependency.patch text/plain 5347 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDA4NWM3MTEuLjQ5OGI3YzcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTEwLTI5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IFR5 cGUgRGVwZW5kZW5jeSBJc3N1ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyNTY2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5vdyB0aGF0IGFsbCBKU09OIHByb3RvY29sIGZpbGVzIGFyZSBwcm9jZXNz ZWQgdG9nZXRoZXIgYWdhaW4KKyAgICAgICAgaW4gcjE3NDg5Miwgd2UgY2FuIHJlbW92ZSB0aGUg ZHVwbGljYXRlZCB0eXBlcyB3aGljaCB3ZXJlIG9ubHkKKyAgICAgICAgbmVlZGVkIHdoZW4gdGhl IGRvbWFpbnMgd2VyZSBzcGxpdC4KKworICAgICAgICAqIGluc3BlY3Rvci9wcm90b2NvbC9Db25z b2xlLmpzb246CisgICAgICAgICogaW5zcGVjdG9yL3Byb3RvY29sL1J1bnRpbWUuanNvbjoKKwor MjAxNC0xMC0yOSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IFNob3cgU2VsZWN0b3IncyBTcGVjaWZpY2l0eQogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM4MTg5CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcHJvdG9jb2wvQ29uc29sZS5qc29u IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9wcm90b2NvbC9Db25zb2xlLmpzb24K aW5kZXggMjNhZDk0Ny4uMTg0ZTRjZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2luc3BlY3Rvci9wcm90b2NvbC9Db25zb2xlLmpzb24KKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2luc3BlY3Rvci9wcm90b2NvbC9Db25zb2xlLmpzb24KQEAgLTMsMTYgKzMsNiBAQAogICAg ICJkZXNjcmlwdGlvbiI6ICJDb25zb2xlIGRvbWFpbiBkZWZpbmVzIG1ldGhvZHMgYW5kIGV2ZW50 cyBmb3IgaW50ZXJhY3Rpb24gd2l0aCB0aGUgSmF2YVNjcmlwdCBjb25zb2xlLiBDb25zb2xlIGNv bGxlY3RzIG1lc3NhZ2VzIGNyZWF0ZWQgYnkgbWVhbnMgb2YgdGhlIDxhIGhyZWY9J2h0dHA6Ly9n ZXRmaXJlYnVnLmNvbS93aWtpL2luZGV4LnBocC9Db25zb2xlX0FQSSc+SmF2YVNjcmlwdCBDb25z b2xlIEFQSTwvYT4uIE9uZSBuZWVkcyB0byBlbmFibGUgdGhpcyBkb21haW4gdXNpbmcgPGNvZGU+ ZW5hYmxlPC9jb2RlPiBjb21tYW5kIGluIG9yZGVyIHRvIHN0YXJ0IHJlY2VpdmluZyB0aGUgY29u c29sZSBtZXNzYWdlcy4gQnJvd3NlciBjb2xsZWN0cyBtZXNzYWdlcyBpc3N1ZWQgd2hpbGUgY29u c29sZSBkb21haW4gaXMgbm90IGVuYWJsZWQgYXMgd2VsbCBhbmQgcmVwb3J0cyB0aGVtIHVzaW5n IDxjb2RlPm1lc3NhZ2VBZGRlZDwvY29kZT4gbm90aWZpY2F0aW9uIHVwb24gZW5hYmxpbmcuIiwK ICAgICAidHlwZXMiOiBbCiAgICAgICAgIHsKLSAgICAgICAgICAgICJpZCI6ICJDb25zb2xlTmV0 d29ya1JlcXVlc3RJZCIsCi0gICAgICAgICAgICAidHlwZSI6ICJzdHJpbmciLAotICAgICAgICAg ICAgImRlc2NyaXB0aW9uIjogIlVuaXF1ZSByZXF1ZXN0IGlkZW50aWZpZXIuIEZJWE1FOiBEdXBs aWNhdGUgb2YgTmV0d29yay5SZXF1ZXN0SWQgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyNTY2ND4g V2ViIEluc3BlY3RvcjogRklYIFR5cGUgRGVwZW5kZW5jeSBJc3N1ZXMiCi0gICAgICAgIH0sCi0g ICAgICAgIHsKLSAgICAgICAgICAgICJpZCI6ICJDb25zb2xlRE9NTm9kZUlkIiwKLSAgICAgICAg ICAgICJ0eXBlIjogImludGVnZXIiLAotICAgICAgICAgICAgImRlc2NyaXB0aW9uIjogIlVuaXF1 ZSBET00gbm9kZSBpZGVudGlmaWVyLiBGSVhNRTogRHVwbGljYXRlIG9mIERPTS5Ob2RlSWQgPGh0 dHBzOi8vd2Via2l0Lm9yZy9iLzEyNTY2ND4gV2ViIEluc3BlY3RvcjogRklYIFR5cGUgRGVwZW5k ZW5jeSBJc3N1ZXMiCi0gICAgICAgIH0sCi0gICAgICAgIHsKICAgICAgICAgICAgICJpZCI6ICJD b25zb2xlTWVzc2FnZSIsCiAgICAgICAgICAgICAidHlwZSI6ICJvYmplY3QiLAogICAgICAgICAg ICAgImRlc2NyaXB0aW9uIjogIkNvbnNvbGUgbWVzc2FnZS4iLApAQCAtMjcsNyArMTcsNyBAQAog ICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAicmVwZWF0Q291bnQiLCAidHlwZSI6ICJpbnRlZ2Vy IiwgIm9wdGlvbmFsIjogdHJ1ZSwgImRlc2NyaXB0aW9uIjogIlJlcGVhdCBjb3VudCBmb3IgcmVw ZWF0ZWQgbWVzc2FnZXMuIiB9LAogICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAicGFyYW1ldGVy cyIsICJ0eXBlIjogImFycmF5IiwgIml0ZW1zIjogeyAiJHJlZiI6ICJSdW50aW1lLlJlbW90ZU9i amVjdCIgfSwgIm9wdGlvbmFsIjogdHJ1ZSwgImRlc2NyaXB0aW9uIjogIk1lc3NhZ2UgcGFyYW1l dGVycyBpbiBjYXNlIG9mIHRoZSBmb3JtYXR0ZWQgbWVzc2FnZS4iIH0sCiAgICAgICAgICAgICAg ICAgeyAibmFtZSI6ICJzdGFja1RyYWNlIiwgIiRyZWYiOiAiU3RhY2tUcmFjZSIsICJvcHRpb25h bCI6IHRydWUsICJkZXNjcmlwdGlvbiI6ICJKYXZhU2NyaXB0IHN0YWNrIHRyYWNlIGZvciBhc3Nl cnRpb25zIGFuZCBlcnJvciBtZXNzYWdlcy4iIH0sCi0gICAgICAgICAgICAgICAgeyAibmFtZSI6 ICJuZXR3b3JrUmVxdWVzdElkIiwgIiRyZWYiOiAiQ29uc29sZU5ldHdvcmtSZXF1ZXN0SWQiLCAi b3B0aW9uYWwiOiB0cnVlLCAiZGVzY3JpcHRpb24iOiAiSWRlbnRpZmllciBvZiB0aGUgbmV0d29y ayByZXF1ZXN0IGFzc29jaWF0ZWQgd2l0aCB0aGlzIG1lc3NhZ2UuIiB9CisgICAgICAgICAgICAg ICAgeyAibmFtZSI6ICJuZXR3b3JrUmVxdWVzdElkIiwgIiRyZWYiOiAiTmV0d29yay5SZXF1ZXN0 SWQiLCAib3B0aW9uYWwiOiB0cnVlLCAiZGVzY3JpcHRpb24iOiAiSWRlbnRpZmllciBvZiB0aGUg bmV0d29yayByZXF1ZXN0IGFzc29jaWF0ZWQgd2l0aCB0aGlzIG1lc3NhZ2UuIiB9CiAgICAgICAg ICAgICBdCiAgICAgICAgIH0sCiAgICAgICAgIHsKQEAgLTcxLDcgKzYxLDcgQEAKICAgICAgICAg ewogICAgICAgICAgICAgIm5hbWUiOiAiYWRkSW5zcGVjdGVkTm9kZSIsCiAgICAgICAgICAgICAi cGFyYW1ldGVycyI6IFsKLSAgICAgICAgICAgICAgICB7ICJuYW1lIjogIm5vZGVJZCIsICIkcmVm IjogIkNvbnNvbGVET01Ob2RlSWQiLCAiZGVzY3JpcHRpb24iOiAiRE9NIG5vZGUgaWQgdG8gYmUg YWNjZXNzaWJsZSBieSBtZWFucyBvZiAkeCBjb21tYW5kIGxpbmUgQVBJLiIgfQorICAgICAgICAg ICAgICAgIHsgIm5hbWUiOiAibm9kZUlkIiwgIiRyZWYiOiAiRE9NLk5vZGVJZCIsICJkZXNjcmlw dGlvbiI6ICJET00gbm9kZSBpZCB0byBiZSBhY2Nlc3NpYmxlIGJ5IG1lYW5zIG9mICR4IGNvbW1h bmQgbGluZSBBUEkuIiB9CiAgICAgICAgICAgICBdLAogICAgICAgICAgICAgImRlc2NyaXB0aW9u IjogIkVuYWJsZXMgY29uc29sZSB0byByZWZlciB0byB0aGUgbm9kZSB3aXRoIGdpdmVuIGlkIHZp YSAkeCAoc2VlIENvbW1hbmQgTGluZSBBUEkgZm9yIG1vcmUgZGV0YWlscyAkeCBmdW5jdGlvbnMp LiIKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rv ci9wcm90b2NvbC9SdW50aW1lLmpzb24gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9y L3Byb3RvY29sL1J1bnRpbWUuanNvbgppbmRleCAxNTczNTNhLi5hZjYzNDk1IDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL1J1bnRpbWUuanNvbgor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL1J1bnRpbWUuanNv bgpAQCAtODIsMTEgKzgyLDYgQEAKICAgICAgICAgICAgICJkZXNjcmlwdGlvbiI6ICJJZCBvZiBh biBleGVjdXRpb24gY29udGV4dC4iCiAgICAgICAgIH0sCiAgICAgICAgIHsKLSAgICAgICAgICAg ICJpZCI6ICJSdW50aW1lRnJhbWVJZCIsCi0gICAgICAgICAgICAidHlwZSI6ICJzdHJpbmciLAot ICAgICAgICAgICAgImRlc2NyaXB0aW9uIjogIlVuaXF1ZSBmcmFtZSBpZGVudGlmaWVyLiBGSVhN RTogRHVwbGljYXRlIG9mIE5ldHdvcmsuRnJhbWVJZCA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTI1 NjY0PiBXZWIgSW5zcGVjdG9yOiBGSVggVHlwZSBEZXBlbmRlbmN5IElzc3VlcyIKLSAgICAgICAg fSwKLSAgICAgICAgewogICAgICAgICAgICAgImlkIjogIkV4ZWN1dGlvbkNvbnRleHREZXNjcmlw dGlvbiIsCiAgICAgICAgICAgICAidHlwZSI6ICJvYmplY3QiLAogICAgICAgICAgICAgImRlc2Ny aXB0aW9uIjogIkRlc2NyaXB0aW9uIG9mIGFuIGlzb2xhdGVkIHdvcmxkLiIsCkBAIC05NCw3ICs4 OSw3IEBACiAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJpZCIsICIkcmVmIjogIkV4ZWN1dGlv bkNvbnRleHRJZCIsICJkZXNjcmlwdGlvbiI6ICJVbmlxdWUgaWQgb2YgdGhlIGV4ZWN1dGlvbiBj b250ZXh0LiBJdCBjYW4gYmUgdXNlZCB0byBzcGVjaWZ5IGluIHdoaWNoIGV4ZWN1dGlvbiBjb250 ZXh0IHNjcmlwdCBldmFsdWF0aW9uIHNob3VsZCBiZSBwZXJmb3JtZWQuIiB9LAogICAgICAgICAg ICAgICAgIHsgIm5hbWUiOiAiaXNQYWdlQ29udGV4dCIsICJ0eXBlIjogImJvb2xlYW4iLCAiZGVz Y3JpcHRpb24iOiAiVHJ1ZSBpZiB0aGlzIGlzIGEgY29udGV4dCB3aGVyZSBpbnBzcGVjdGVkIHdl YiBwYWdlIHNjcmlwdHMgcnVuLiBGYWxzZSBpZiBpdCBpcyBhIGNvbnRlbnQgc2NyaXB0IGlzb2xh dGVkIGNvbnRleHQuIiB9LAogICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAibmFtZSIsICJ0eXBl IjogInN0cmluZyIsICJkZXNjcmlwdGlvbiI6ICJIdW1hbiByZWFkYWJsZSBuYW1lIGRlc2NyaWJp bmcgZ2l2ZW4gY29udGV4dC4ifSwKLSAgICAgICAgICAgICAgICB7ICJuYW1lIjogImZyYW1lSWQi LCAiJHJlZiI6ICJSdW50aW1lRnJhbWVJZCIsICJkZXNjcmlwdGlvbiI6ICJJZCBvZiB0aGUgb3du aW5nIGZyYW1lLiIgfQorICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAiZnJhbWVJZCIsICIkcmVm IjogIk5ldHdvcmsuRnJhbWVJZCIsICJkZXNjcmlwdGlvbiI6ICJJZCBvZiB0aGUgb3duaW5nIGZy YW1lLiIgfQogICAgICAgICAgICAgXQogICAgICAgICB9LAogICAgICAgICB7Cg==