125662 2013-12-12 15:14:45 -0800 Add a few more ASCIILiterals 2013-12-12 18:16:24 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue joepeck timothy oldest_to_newest 959369 0 joepeck 2013-12-12 15:14:45 -0800 Some string constants are turning into WTF::Strings, so they can use ASCIILiteral. They eventually get put into an InspectorObject. 959370 1 219127 joepeck 2013-12-12 15:15:57 -0800 Created attachment 219127 [PATCH] Proposed Fix 959418 2 219127 darin 2013-12-12 17:49:00 -0800 Comment on attachment 219127 [PATCH] Proposed Fix OK. But even better might be to make the argument be const char* instead of WTF::String; might yield smaller code size. 959423 3 joepeck 2013-12-12 17:58:49 -0800 (In reply to comment #2) > (From update of attachment 219127 [details]) > OK. But even better might be to make the argument be const char* instead of WTF::String; might yield smaller code size. Note shown in the context of the patch, there is another case that returns a concatenation of strings, which would be harder to do if the arguments was a const char*. 959430 4 joepeck 2013-12-12 18:05:40 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 219127 [details] [details]) > > OK. But even better might be to make the argument be const char* instead of WTF::String; might yield smaller code size. > > Note shown in the context of the patch, there is another case that returns a concatenation of strings, which would be harder to do if the arguments was a const char*. Wow, horrible English. Not* shown ... if the argument* was ... 959432 5 219127 commit-queue 2013-12-12 18:16:22 -0800 Comment on attachment 219127 [PATCH] Proposed Fix Clearing flags on attachment: 219127 Committed r160523: <http://trac.webkit.org/changeset/160523> 959433 6 commit-queue 2013-12-12 18:16:24 -0800 All reviewed patches have been landed. Closing bug. 219127 2013-12-12 15:15:57 -0800 2013-12-12 18:16:22 -0800 [PATCH] Proposed Fix literal.patch text/plain 3312 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDBkYzdjMWQuLjhhYTAwNzIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEyLTEyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgZmV3IG1vcmUgQVNDSUlM aXRlcmFscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTI1NjYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvSW5zcGVjdG9yQmFja2VuZERpc3BhdGNoZXIuY3BwOgorICAgICAgICAoSW5z cGVjdG9yOjpJbnNwZWN0b3JCYWNrZW5kRGlzcGF0Y2hlcjo6ZGlzcGF0Y2gpOgorCiAyMDEzLTEy LTExICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogQWRkIEluc3BlY3RvciBDb2RlIEdlbmVyYXRpb24gdG8gSmF2YVNjcmlwdENv cmUgZm9yIFJ1bnRpbWUgRG9tYWluCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aW5zcGVjdG9yL0luc3BlY3RvckJhY2tlbmREaXNwYXRjaGVyLmNwcCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQmFja2VuZERpc3BhdGNoZXIuY3BwCmluZGV4IGMy NjY4NTEuLjMwYTY2ZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yQmFja2VuZERpc3BhdGNoZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQmFja2VuZERpc3BhdGNoZXIuY3BwCkBAIC04MCw0MyAr ODAsNDMgQEAgdm9pZCBJbnNwZWN0b3JCYWNrZW5kRGlzcGF0Y2hlcjo6ZGlzcGF0Y2goY29uc3Qg U3RyaW5nJiBtZXNzYWdlKQogCiAgICAgUmVmUHRyPEluc3BlY3RvclZhbHVlPiBwYXJzZWRNZXNz YWdlID0gSW5zcGVjdG9yVmFsdWU6OnBhcnNlSlNPTihtZXNzYWdlKTsKICAgICBpZiAoIXBhcnNl ZE1lc3NhZ2UpIHsKLSAgICAgICAgcmVwb3J0UHJvdG9jb2xFcnJvcihudWxscHRyLCBQYXJzZUVy cm9yLCAiTWVzc2FnZSBtdXN0IGJlIGluIEpTT04gZm9ybWF0Iik7CisgICAgICAgIHJlcG9ydFBy b3RvY29sRXJyb3IobnVsbHB0ciwgUGFyc2VFcnJvciwgQVNDSUlMaXRlcmFsKCJNZXNzYWdlIG11 c3QgYmUgaW4gSlNPTiBmb3JtYXQiKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKICAgICBS ZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiBtZXNzYWdlT2JqZWN0ID0gcGFyc2VkTWVzc2FnZS0+YXNP YmplY3QoKTsKICAgICBpZiAoIW1lc3NhZ2VPYmplY3QpIHsKLSAgICAgICAgcmVwb3J0UHJvdG9j b2xFcnJvcihudWxscHRyLCBJbnZhbGlkUmVxdWVzdCwgIk1lc3NhZ2UgbXVzdCBiZSBhIEpTT05p ZmllZCBvYmplY3QiKTsKKyAgICAgICAgcmVwb3J0UHJvdG9jb2xFcnJvcihudWxscHRyLCBJbnZh bGlkUmVxdWVzdCwgQVNDSUlMaXRlcmFsKCJNZXNzYWdlIG11c3QgYmUgYSBKU09OaWZpZWQgb2Jq ZWN0IikpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCiAgICAgUmVmUHRyPEluc3BlY3RvclZh bHVlPiBjYWxsSWRWYWx1ZSA9IG1lc3NhZ2VPYmplY3QtPmdldCgiaWQiKTsKICAgICBpZiAoIWNh bGxJZFZhbHVlKSB7Ci0gICAgICAgIHJlcG9ydFByb3RvY29sRXJyb3IobnVsbHB0ciwgSW52YWxp ZFJlcXVlc3QsICInaWQnIHByb3BlcnR5IHdhcyBub3QgZm91bmQiKTsKKyAgICAgICAgcmVwb3J0 UHJvdG9jb2xFcnJvcihudWxscHRyLCBJbnZhbGlkUmVxdWVzdCwgQVNDSUlMaXRlcmFsKCInaWQn IHByb3BlcnR5IHdhcyBub3QgZm91bmQiKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKICAg ICBsb25nIGNhbGxJZCA9IDA7CiAgICAgaWYgKCFjYWxsSWRWYWx1ZS0+YXNOdW1iZXIoJmNhbGxJ ZCkpIHsKLSAgICAgICAgcmVwb3J0UHJvdG9jb2xFcnJvcihudWxscHRyLCBJbnZhbGlkUmVxdWVz dCwgIlRoZSB0eXBlIG9mICdpZCcgcHJvcGVydHkgbXVzdCBiZSBudW1iZXIiKTsKKyAgICAgICAg cmVwb3J0UHJvdG9jb2xFcnJvcihudWxscHRyLCBJbnZhbGlkUmVxdWVzdCwgQVNDSUlMaXRlcmFs KCJUaGUgdHlwZSBvZiAnaWQnIHByb3BlcnR5IG11c3QgYmUgbnVtYmVyIikpOwogICAgICAgICBy ZXR1cm47CiAgICAgfQogCiAgICAgUmVmUHRyPEluc3BlY3RvclZhbHVlPiBtZXRob2RWYWx1ZSA9 IG1lc3NhZ2VPYmplY3QtPmdldCgibWV0aG9kIik7CiAgICAgaWYgKCFtZXRob2RWYWx1ZSkgewot ICAgICAgICByZXBvcnRQcm90b2NvbEVycm9yKCZjYWxsSWQsIEludmFsaWRSZXF1ZXN0LCAiJ21l dGhvZCcgcHJvcGVydHkgd2Fzbid0IGZvdW5kIik7CisgICAgICAgIHJlcG9ydFByb3RvY29sRXJy b3IoJmNhbGxJZCwgSW52YWxpZFJlcXVlc3QsIEFTQ0lJTGl0ZXJhbCgiJ21ldGhvZCcgcHJvcGVy dHkgd2Fzbid0IGZvdW5kIikpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCiAgICAgU3RyaW5n IG1ldGhvZDsKICAgICBpZiAoIW1ldGhvZFZhbHVlLT5hc1N0cmluZygmbWV0aG9kKSkgewotICAg ICAgICByZXBvcnRQcm90b2NvbEVycm9yKCZjYWxsSWQsIEludmFsaWRSZXF1ZXN0LCAiVGhlIHR5 cGUgb2YgJ21ldGhvZCcgcHJvcGVydHkgbXVzdCBiZSBzdHJpbmciKTsKKyAgICAgICAgcmVwb3J0 UHJvdG9jb2xFcnJvcigmY2FsbElkLCBJbnZhbGlkUmVxdWVzdCwgQVNDSUlMaXRlcmFsKCJUaGUg dHlwZSBvZiAnbWV0aG9kJyBwcm9wZXJ0eSBtdXN0IGJlIHN0cmluZyIpKTsKICAgICAgICAgcmV0 dXJuOwogICAgIH0KIAogICAgIHNpemVfdCBwb3NpdGlvbiA9IG1ldGhvZC5maW5kKCcuJyk7CiAg ICAgaWYgKHBvc2l0aW9uID09IFdURjo6bm90Rm91bmQpIHsKLSAgICAgICAgcmVwb3J0UHJvdG9j b2xFcnJvcigmY2FsbElkLCBJbnZhbGlkUmVxdWVzdCwgIlRoZSAnbWV0aG9kJyBwcm9wZXJ0eSB3 YXMgZm9ybWF0dGVkIGluY29ycmVjdGx5LiBJdCBzaG91bGQgYmUgJ0RvbWFpbi5tZXRob2QnIik7 CisgICAgICAgIHJlcG9ydFByb3RvY29sRXJyb3IoJmNhbGxJZCwgSW52YWxpZFJlcXVlc3QsIEFT Q0lJTGl0ZXJhbCgiVGhlICdtZXRob2QnIHByb3BlcnR5IHdhcyBmb3JtYXR0ZWQgaW5jb3JyZWN0 bHkuIEl0IHNob3VsZCBiZSAnRG9tYWluLm1ldGhvZCciKSk7CiAgICAgICAgIHJldHVybjsKICAg ICB9CiAK