125616 2013-12-11 22:14:06 -0800 check-webkit-style is wrong about style for C++11 lambdas 2016-08-26 09:13:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED DUPLICATE 160910 https://bugs.webkit.org/show_bug.cgi?id=160910 P2 Normal --- 1 beidson webkit-unassigned cgarcia darin jbedard zan oldest_to_newest 959054 0 beidson 2013-12-11 22:14:06 -0800 check-webkit-style is wrong about style for c++11 lambdas It complains: Place brace on its own line for function definitions. [whitespace/braces] [4] An example patch with the correct style is attached to bug https://bugs.webkit.org/show_bug.cgi?id=125258 960244 1 219357 beidson 2013-12-16 14:52:01 -0800 Created attachment 219357 The fix, without a unit test or a patch to the website to add this exception to the coding style guidelines. Don't have time to add the exception to the coding style guidelines or write a unit test for this, but this is the fix. 1160757 2 darin 2016-01-31 20:36:05 -0800 *** Bug 137309 has been marked as a duplicate of this bug. *** 1160759 3 darin 2016-01-31 20:36:32 -0800 Bug 153732 shows one of the many, many cases where the style checker gives false positives about this. 1223527 4 jbedard 2016-08-26 09:13:03 -0700 *** This bug has been marked as a duplicate of bug 160910 *** 219357 2013-12-16 14:52:01 -0800 2013-12-16 14:52:01 -0800 The fix, without a unit test or a patch to the website to add this exception to the coding style guidelines. pypatch text/plain 758 beidson ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggYjA5 ZGZhZi4uNGY1NmJjYiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHAucHkKQEAgLTIzNzEsNiArMjM3MSw3IEBAIGRlZiBjaGVja19icmFjZXMoY2xlYW5fbGlu ZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAgICAgZWxpZiAoc2VhcmNoKHInXClccyooKChjb25z dHxPVkVSUklERSlccyopKlxzKik/e1xzKiQnLCBsaW5lKQogICAgICAgICAgIGFuZCBsaW5lLmNv dW50KCcoJykgPT0gbGluZS5jb3VudCgnKScpCiAgICAgICAgICAgYW5kIG5vdCBzZWFyY2gocidc YihpZnxmb3J8Zm9yZWFjaHx3aGlsZXxzd2l0Y2h8TlNfRU5VTXxFTlVNX0NMQVNTKVxiJywgbGlu ZSkKKyAgICAgICAgICBhbmQgbm90IHNlYXJjaChyJyhcW1teXF1dKlxdXChbXlwpXSpcKSknLCBs aW5lKQogICAgICAgICAgIGFuZCBub3QgbWF0Y2gocidccytbQS1aX11bQS1aXzAtOV0rXGInLCBs aW5lKSk6CiAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAnd2hpdGVzcGFjZS9icmFjZXMnLCA0 LAogICAgICAgICAgICAgICAnUGxhY2UgYnJhY2Ugb24gaXRzIG93biBsaW5lIGZvciBmdW5jdGlv biBkZWZpbml0aW9ucy4nKQo=