125609 2013-12-11 18:07:48 -0800 jsCStack: Introducing MaxFrameExtentForSlowPathCall.h 2013-12-11 18:21:02 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 958996 0 mark.lam 2013-12-11 18:07:48 -0800 Depending on the target CPU architecture / ABI, we need to allocate some amount of stack space for holding outgoing args for slow path calls from JS to C functions. MaxFrameExtentForSlowPathCall.h will define this constant. 958999 1 219025 mark.lam 2013-12-11 18:11:10 -0800 Created attachment 219025 the patch. 959005 2 219025 mhahnenberg 2013-12-11 18:18:06 -0800 Comment on attachment 219025 the patch. r=me. We might want to create file for all globals eventually, but this will work for now. 959006 3 mhahnenberg 2013-12-11 18:18:20 -0800 (In reply to comment #2) > (From update of attachment 219025 [details]) > r=me. We might want to create file for all globals eventually, but this will work for now. And by globals I mean global constants. 959008 4 mark.lam 2013-12-11 18:21:02 -0800 Landed in r160470 on the jsCStack branch: <http://trac.webkit.org/r160470> 219025 2013-12-11 18:11:10 -0800 2013-12-11 18:18:06 -0800 the patch. bug-125609.patch text/plain 4021 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwNDY5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTEyLTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBJ bnRyb2R1Y2luZyBNYXhGcmFtZUV4dGVudEZvclNsb3dQYXRoQ2FsbC5oLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1NjA5LgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL01heEZyYW1l RXh0ZW50Rm9yU2xvd1BhdGguaDogQWRkZWQuCisgICAgICAgIC0gZGVmaW5lcyBhIGNvbnN0YW50 IGZvciB0aGUgbWF4IGFtb3VudCBvZiBzdGFjayBzcGFjZSB0aGF0IHdlIG5lZWQgdG8KKyAgICAg ICAgICBhbGxvY2F0ZSAocGVyIEpTIGZyYW1lKSBmb3IgaG9sZGluZyB0aGUgb3V0Z29pbmcgYXJn cyBmb3Igc2xvdyBwYXRoCisgICAgICAgICAgY2FsbHMgZnJvbSBKUyB0byBDIGZ1bmN0aW9ucy4K KwogMjAxMy0xMi0xMSAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAg ICAgICBDU3RhY2sgQnJhbmNoOiBlbmFibGUgdXNlIG9mIERGRyBmb3Igc2ltcGxlIEphdmFTY3Jp cHQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWF4RnJhbWVFeHRlbnRG b3JTbG93UGF0aENhbGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL01heEZyYW1lRXh0ZW50Rm9yU2xvd1BhdGhDYWxsLmgJKHJldmlzaW9uIDApCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01heEZyYW1lRXh0ZW50Rm9yU2xvd1BhdGhD YWxsLmgJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw3NCBAQAorLyoKKyAqIENvcHlyaWdodCAo QykgMjAxMyBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKgorICogUmVkaXN0cmli dXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0 CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93 aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291 cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0 aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICog Mi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92 ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRo ZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29y IG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICog VEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIGBgQVMgSVMnJyBBTkQgQU5Z CisgKiBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJ TUlURUQgVE8sIFRIRQorICogSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBB TkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSCisgKiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiAg SU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUgorICogQ09OVFJJQlVUT1JTIEJFIExJQUJM RSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsCisgKiBFWEVN UExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlU RUQgVE8sCisgKiBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBM T1NTIE9GIFVTRSwgREFUQSwgT1IKKyAqIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElP TikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkKKyAqIE9GIExJQUJJTElUWSwgV0hF VEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorICogKElOQ0xVRElO RyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUg VVNFCisgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklM SVRZIE9GIFNVQ0ggREFNQUdFLiAKKyAqLworCisjaWZuZGVmIE1heEZyYW1lRXh0ZW50Rm9yU2xv d1BhdGhDYWxsX2gKKyNkZWZpbmUgTWF4RnJhbWVFeHRlbnRGb3JTbG93UGF0aENhbGxfaAorCitu YW1lc3BhY2UgSlNDIHsKKworLy8gVGhlIG1heEZyYW1lRXh0ZW50Rm9yU2xvd1BhdGhDYWxsIGlz IHRoZSBtYXggYW1vdW50IG9mIHN0YWNrIHNwYWNlIChpbiBieXRlcykKKy8vIHRoYXQgY2FuIGJl IHVzZWQgZm9yIG91dGdvaW5nIGFyZ3Mgd2hlbiBjYWxsaW5nIGEgc2xvdyBwYXRoIEMgZnVuY3Rp b24KKy8vIGZyb20gSlMgY29kZS4KKworI2lmIEVOQUJMRShMTElOVF9DX0xPT1ApIHx8IFVTRShT RVBBUkFURV9DX0FORF9KU19TVEFDSykKK3N0YXRpYyBjb25zdCBzaXplX3QgbWF4RnJhbWVFeHRl bnRGb3JTbG93UGF0aENhbGwgPSAwOworCisjZWxpZiBDUFUoWDg2XzY0KSAmJiBPUyhXSU5ET1dT KQorLy8gNCBhcmdzIGluIHJlZ2lzdGVycywgYnV0IHN0YWNrIHNwYWNlIG5lZWRzIHRvIGJlIGFs bG9jYXRlZCBmb3IgYWxsIGFyZ3MuCitzdGF0aWMgY29uc3Qgc2l6ZV90IG1heEZyYW1lRXh0ZW50 Rm9yU2xvd1BhdGhDYWxsID0gNDg7CisKKyNlbGlmIENQVShYODZfNjQpCisvLyBBbGwgYXJncyBp biByZWdpc3RlcnMuCitzdGF0aWMgY29uc3Qgc2l6ZV90IG1heEZyYW1lRXh0ZW50Rm9yU2xvd1Bh dGhDYWxsID0gMDsKKworI2VsaWYgQ1BVKFg4NikKKy8vIDYgYXJncyBvbiBzdGFjayAoMjQgYnl0 ZXMpICsgOCBieXRlcyB0byBhbGlnbiB0aGUgc3RhY2suCitzdGF0aWMgY29uc3Qgc2l6ZV90IG1h eEZyYW1lRXh0ZW50Rm9yU2xvd1BhdGhDYWxsID0gMzI7CisKKyNlbGlmIENQVShBUk02NCkKKy8v IEFsbCBhcmdzIGluIHJlZ2lzdGVycy4KK3N0YXRpYyBjb25zdCBzaXplX3QgbWF4RnJhbWVFeHRl bnRGb3JTbG93UGF0aENhbGwgPSAwOworCisjZWxpZiBDUFUoQVJNKSB8fCBDUFUoQVJNX1RSQURJ VElPTkFMKSB8fCBDUFUoQVJNX1RIVU1CMikKKy8vIEZpcnN0IGZvdXIgYXJncyBpbiByZWdpc3Rl cnMsIHJlbWFpbmluZyA0IGFyZ3Mgb24gc3RhY2suCitzdGF0aWMgY29uc3Qgc2l6ZV90IG1heEZy YW1lRXh0ZW50Rm9yU2xvd1BhdGhDYWxsID0gMTY7CisKKyNlbGlmIENQVShTSDQpCisvLyBGaXJz dCBmb3VyIGFyZ3MgaW4gcmVnaXN0ZXJzLCByZW1haW5pbmcgNCBhcmdzIG9uIHN0YWNrLgorc3Rh dGljIGNvbnN0IHNpemVfdCBtYXhGcmFtZUV4dGVudEZvclNsb3dQYXRoQ2FsbCA9IDE2OworCisj ZWxpZiBDUFUoTUlQUykKKy8vIFRob3VnaCBhcmdzIGFyZSBpbiByZWdpc3RlcnMsIHRoZXJlIG5l ZWQgdG8gYmUgc3BhY2Ugb24gdGhlIHN0YWNrIGZvciBhbGwgYXJncy4KK3N0YXRpYyBjb25zdCBz aXplX3QgbWF4RnJhbWVFeHRlbnRGb3JTbG93UGF0aENhbGwgPSAzMjsKKworI2Vsc2UKKyNlcnJv ciAiVW5zdXBwb3J0ZWQgQ1BVOiBuZWVkIHZhbHVlIGZvciBtYXhGcmFtZUV4dGVudEZvclNsb3dQ YXRoQ2FsbCIKKworI2VuZGlmCisKK30gLy8gbmFtZXNwYWNlIEpTQworCisjZW5kaWYgLy8gTWF4 RnJhbWVFeHRlbnRGb3JTbG93UGF0aENhbGxfaAorCg==