125598 2013-12-11 13:44:32 -0800 Give Unique StringImpls a meaningful data pointer 2013-12-11 14:04:08 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver benjamin cmarcelo commit-queue oldest_to_newest 958882 0 oliver 2013-12-11 13:44:32 -0800 Give Unique StringImpls a meaningful data pointer 958884 1 219000 oliver 2013-12-11 13:48:13 -0800 Created attachment 219000 Patch 958885 2 219000 msaboff 2013-12-11 13:52:44 -0800 Comment on attachment 219000 Patch r=me, but add a comment in the code that we expect m_buffer to be null. If we change StringImpl in the future it will be easier to see why you're doing this without tracking down the change set / bug. 958891 3 oliver 2013-12-11 14:04:08 -0800 Committed r160453: <http://trac.webkit.org/changeset/160453> 219000 2013-12-11 13:48:13 -0800 2013-12-11 13:52:44 -0800 Patch bug-125598-20131211134812.patch text/plain 1823 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwNDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGM2NzgzOTEzNDczNzNiOWYwMTA3YTU2 YTZiZDUwMTk0NTE1ZTNkM2MuLmMwMDYyNTY0ZmU4MDI4MmQ2ODliNDVmOTNhOGVmNTMyNWJiYjQ0 NjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTMtMTItMTEgIE9saXZlciBIdW50ICA8b2xpdmVy QGFwcGxlLmNvbT4KKworICAgICAgICBHaXZlIFVuaXF1ZSBTdHJpbmdJbXBscyBhIG1lYW5pbmdm dWwgZGF0YSBwb2ludGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjU1OTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGb3VuZCBieSBjb2RlIGluc3BlY3Rpb24uICBJZiB0aGVyZSBpcyBhIGNvbGxpc2lv biBpbiBhbiBJZGVudGlmaWVyCisgICAgICAgIHRhYmxlIHdoZW4gY29tcGFyaW5nIHRvIGEgc3Ry aW5nIGxpdGVyYWwgd2UgYXR0ZW1wdCB0byB1c2UgdGhlIGRhdGEKKyAgICAgICAgcG9pbnRlciAo ZXNzZW50aWFsbHkgdGhpcyBlbmRzIHVwIGJlaW5nIGEgbnVsbCB0ZXJtaW5hdGlvbiBjaGVjayku CisKKyAgICAgICAgUHJldmlvdXNseSB1bmlxdWUgcG9pbnRlcnMganVzdCB1c2VkIHRoZSBsaXRl cmFsIDEgYXMgdGhlIGRhdGEgYWRkcmVzcworICAgICAgICBidXQgdGhpcyBvYnZpb3VzbHkgZmFp bHMgd2hlbiBkZXJlZmVyZW5jZWQuICBJbnN0ZWFkIHdlIG5vdyBtYWtlIHRoZQorICAgICAgICBk YXRhIHBvaW50ZXIgcG9pbnQgdG8gdGhlIGxvY2F0aW9uIG9mIHRoZSBidWZmZXIgcG9pbnRlciBp dHNlbGYuICBBcworICAgICAgICB0aGUgYnVmZmVyIHBvaW50ZXIgaXMgaW5pdGlhbGlzZWQgdG8g MCwgdGhpcyBzYXRpc2ZpZXMgdGhlIHJlcXVpcmVtZW50CisgICAgICAgIHRoYXQgdGhlIDAtbGVu Z3RoIHVuaXF1ZSBzdHJpbmcgaXMgbnVsbCB0ZXJtaW5hdGVkLgorCisgICAgICAgICogd3RmL3Rl eHQvU3RyaW5nSW1wbC5oOgorICAgICAgICAoV1RGOjpTdHJpbmdJbXBsOjpTdHJpbmdJbXBsKToK KwogMjAxMy0xMi0xMCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAg ICAgICAgIEFkZCBhIEhhc2hNYXAgY29uc3RydWN0b3IgdGhhdCB0YWtlcyBhbiBpbml0aWFsaXpl ciBsaXN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaCBiL1Nv dXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCmluZGV4IDYwMzUyOTUwNGRjYTFlYmQ1ZWE1 ZTEzYmI3ODc4ZWQ1NTI0ZTQ1ZjkuLjg3ZGNjODFmZGQ2ZjZiMDFkYWQ4ZmEyMzc4MDNlYjBkNmQ1 M2JjMDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCisrKyBi L1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5oCkBAIC0zMTUsNyArMzE1LDcgQEAgcHJp dmF0ZToKICAgICBTdHJpbmdJbXBsKENyZWF0ZUVtcHR5VW5pcXVlX1QpCiAgICAgICAgIDogbV9y ZWZDb3VudChzX3JlZkNvdW50SW5jcmVtZW50KQogICAgICAgICAsIG1fbGVuZ3RoKDApCi0gICAg ICAgICwgbV9kYXRhMTYocmVpbnRlcnByZXRfY2FzdDxjb25zdCBVQ2hhcio+KDEpKQorICAgICAg ICAsIG1fZGF0YTE2KHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgVUNoYXIqPigmbV9idWZmZXIpKQog ICAgICAgICAsIG1fYnVmZmVyKDApCiAgICAgewogICAgICAgICBBU1NFUlQobV9kYXRhMTYpOwo=