125594 2013-12-11 11:36:50 -0800 [ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM 2013-12-16 07:55:32 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 125493 1 mario webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 958827 0 mario 2013-12-11 11:36:50 -0800 This would fix elements with role "menuitemcheckbox" 958836 1 218988 mario 2013-12-11 11:42:35 -0800 Created attachment 218988 Patch proposal 959560 2 mario 2013-12-13 08:50:41 -0800 Thanks for the review Chris. Would you mind taking a look to to bug 125587, so I can submit both patches in the same order I created them? 960063 3 mario 2013-12-16 07:55:32 -0800 Committed r160638: <http://trac.webkit.org/changeset/160638> 218988 2013-12-11 11:42:35 -0800 2013-12-13 08:45:00 -0800 Patch proposal 0001-ATK-Expose-accessibility-objects-with-ATK_ROLE_CHECK.patch text/plain 7548 mario RnJvbSAxYTY1MjMyOGQ2ODI3M2M5YjEyNjBiMWU0ZTE2N2VkNGM4YTdjMjRjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KRGF0ZTogVHVlLCAxMCBEZWMgMjAxMyAxOTo0Njo0OCArMDEwMApTdWJqZWN0OiBb UEFUQ0hdICAgICAgICAgW0FUS10gRXhwb3NlIGFjY2Vzc2liaWxpdHkgb2JqZWN0cyB3aXRoCiBB VEtfUk9MRV9DSEVDS19NRU5VX0lURU0gICAgICAgIAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNTU5NAoKLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDEyICsrKysrKysrKysrKwogLi4uL3Bs YXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3JvbGVzLWV4cG9zZWQtZXhwZWN0ZWQudHh0ICAgfCAg NiArKysrKysKIExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3JvbGVzLWV4 cG9zZWQuaHRtbCAgIHwgIDQgKystLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxMyArKysrKysrKysrKysrCiAuLi4vYWNjZXNz aWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwICAgICAgICB8ICAyICsr CiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB8IDEyICsrKysrKysrKysrKwogVG9vbHMvRHVtcFJlbmRlclRyZWUvYXRrL0FjY2Vzc2li aWxpdHlVSUVsZW1lbnRBdGsuY3BwICAgICAgfCAgMiArKwogLi4uL0luamVjdGVkQnVuZGxlL2F0 ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcCAgICAgICAgfCAgMiArKwogOCBmaWxlcyBj aGFuZ2VkLCA1MSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2MWI0ZDYz Li43YWFiYmZmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTMtMTItMTEgIE1hcmlvIFNhbmNo ZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1zdW5nLmNvbT4KIAorICAgICAgICBbQVRLXSBFeHBv c2UgYWNjZXNzaWJpbGl0eSBvYmplY3RzIHdpdGggQVRLX1JPTEVfQ0hFQ0tfTUVOVV9JVEVNCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU1OTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGVz dCB0byB1cGRhdGUgZXhwZWN0YXRpb25zLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL2FjY2Vz c2liaWxpdHkvcm9sZXMtZXhwb3NlZC1leHBlY3RlZC50eHQ6CisgICAgICAgICogcGxhdGZvcm0v Z3RrL2FjY2Vzc2liaWxpdHkvcm9sZXMtZXhwb3NlZC5odG1sOgorCisyMDEzLTEyLTExICBNYXJp byBTYW5jaGV6IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CisKICAgICAgICAgW0FU S10gRXhwb3NlIGFjY2Vzc2liaWxpdHkgb2JqZWN0cyB3aXRoIEFUS19ST0xFX0FSVElDTEUKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTU4NwogCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9yb2xlcy1l eHBvc2VkLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmls aXR5L3JvbGVzLWV4cG9zZWQtZXhwZWN0ZWQudHh0CmluZGV4IDU0M2M3MzcuLmRjNmFkZTcgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3JvbGVzLWV4 cG9zZWQtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3Np YmlsaXR5L3JvbGVzLWV4cG9zZWQtZXhwZWN0ZWQudHh0CkBAIC0zMDUsNiArMzA1LDkgQEAgUEFT UzogZGl2W3JvbGU9bWVudV0KIFBBU1M6IGRpdltyb2xlPW1lbnVpdGVtXQogICAgICAgQVhSb2xl OiBBWE1lbnVJdGVtCiAgICAgICAKK1BBU1M6IGRpdltyb2xlPW1lbnVpdGVtY2hlY2tib3hdCisg ICAgICBBWFJvbGU6IEFYQ2hlY2tNZW51SXRlbQorICAgICAgCiBQQVNTOiBkaXZbcm9sZT1tZW51 aXRlbXJhZGlvXQogICAgICAgQVhSb2xlOiBBWFJhZGlvTWVudUl0ZW0KICAgICAgIApAQCAtMzE0 LDYgKzMxNyw5IEBAIFBBU1M6IGRpdltyb2xlPW1lbnViYXJdCiBQQVNTOiBkaXZbcm9sZT1tZW51 aXRlbV0KICAgICAgIEFYUm9sZTogQVhNZW51SXRlbQogICAgICAgCitQQVNTOiBkaXZbcm9sZT1t ZW51aXRlbWNoZWNrYm94XQorICAgICAgQVhSb2xlOiBBWENoZWNrTWVudUl0ZW0KKyAgICAgIAog UEFTUzogZGl2W3JvbGU9bWVudWl0ZW1yYWRpb10KICAgICAgIEFYUm9sZTogQVhSYWRpb01lbnVJ dGVtCiAgICAgICAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3Np YmlsaXR5L3JvbGVzLWV4cG9zZWQuaHRtbCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nl c3NpYmlsaXR5L3JvbGVzLWV4cG9zZWQuaHRtbAppbmRleCAxZmRiNjk0Li41MTdmYTdjIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9yb2xlcy1leHBv c2VkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvcm9s ZXMtZXhwb3NlZC5odG1sCkBAIC0yMjgsMTMgKzIyOCwxMyBAQAogPGRpdiByb2xlPSJtZW51IiAg ICAgICAgICAgICAgICAgICAgIGRhdGEtcm9sZT0iQVhNZW51IiBjbGFzcz0iZXgiPgogICAgIDwh LS0gTm90ZTogZGlmZiBiZXR3ZWVuIG1lbnVpdGVtIHR5cGVzIGlzIGFuIGF0dHJpYnV0ZTsgbmVl ZCBhZGRpdGlvbmFsIG5vbi1yb2xlIHZlcmlmaWNhdGlvbiBpbiBhbm90aGVyIHRlc3QuIC0tPgog ICAgIDxkaXYgcm9sZT0ibWVudWl0ZW0iICAgICAgICAgICAgIGRhdGEtcm9sZT0iQVhNZW51SXRl bSIgY2xhc3M9ImV4Ij5YPC9kaXY+Ci0gICAgPCEtLSBodHRwOi8vd2Via2l0Lm9yZy9iLzEyNTQ5 MyA8ZGl2IHJvbGU9Im1lbnVpdGVtY2hlY2tib3giICAgICBkYXRhLXJvbGU9IkFYQ2hlY2tNZW51 SXRlbSIgY2xhc3M9ImV4Ij5YPC9kaXY+LS0+CisgICAgPGRpdiByb2xlPSJtZW51aXRlbWNoZWNr Ym94IiAgICAgZGF0YS1yb2xlPSJBWENoZWNrTWVudUl0ZW0iIGNsYXNzPSJleCI+WDwvZGl2Pgog ICAgIDxkaXYgcm9sZT0ibWVudWl0ZW1yYWRpbyIgICAgICAgIGRhdGEtcm9sZT0iQVhSYWRpb01l bnVJdGVtIiBjbGFzcz0iZXgiPlg8L2Rpdj4KIDwvZGl2PgogPGRpdiByb2xlPSJtZW51YmFyIiAg ICAgICAgICAgICAgICAgIGRhdGEtcm9sZT0iQVhNZW51QmFyIiBjbGFzcz0iZXgiPgogICAgIDwh LS0gTm90ZTogZGlmZiBiZXR3ZWVuIG1lbnVpdGVtIHR5cGVzIGlzIGFuIGF0dHJpYnV0ZTsgbmVl ZCBhZGRpdGlvbmFsIG5vbi1yb2xlIHZlcmlmaWNhdGlvbiBpbiBhbm90aGVyIHRlc3QuIC0tPgog ICAgIDxkaXYgcm9sZT0ibWVudWl0ZW0iICAgICAgICAgICAgIGRhdGEtcm9sZT0iQVhNZW51SXRl bSIgY2xhc3M9ImV4Ij5YPC9kaXY+Ci0gICAgPCEtLSBodHRwOi8vd2Via2l0Lm9yZy9iLzEyNTQ5 MyA8ZGl2IHJvbGU9Im1lbnVpdGVtY2hlY2tib3giICAgICBkYXRhLXJvbGU9IkFYQ2hlY2tNZW51 SXRlbSIgY2xhc3M9ImV4Ij5YPC9kaXY+LS0+CisgICAgPGRpdiByb2xlPSJtZW51aXRlbWNoZWNr Ym94IiAgICAgZGF0YS1yb2xlPSJBWENoZWNrTWVudUl0ZW0iIGNsYXNzPSJleCI+WDwvZGl2Pgog ICAgIDxkaXYgcm9sZT0ibWVudWl0ZW1yYWRpbyIgICAgICAgIGRhdGEtcm9sZT0iQVhSYWRpb01l bnVJdGVtIiBjbGFzcz0iZXgiPlg8L2Rpdj4KIDwvZGl2PgogPGRpdiByb2xlPSJuYXZpZ2F0aW9u IiAgICAgICAgICAgICAgIGRhdGEtcm9sZT0iQVhMYW5kbWFya05hdmlnYXRpb24iIGNsYXNzPSJl eCI+WDwvZGl2PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDI5NjFhNjUuLmQ3M2RjNzMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsNSArMSwxOCBAQAogMjAxMy0xMi0xMSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvLnBy YWRhQHNhbXN1bmcuY29tPgogCisgICAgICAgIFtBVEtdIEV4cG9zZSBhY2Nlc3NpYmlsaXR5IG9i amVjdHMgd2l0aCBBVEtfUk9MRV9DSEVDS19NRU5VX0lURU0KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTU5NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cG9zZWQgYWNjZXNzaWJpbGl0eSBvYmplY3Rz IHdpdGggY2hlY2ttZW51aXRlbSByb2xlIHdpdGggdGhlCisgICAgICAgIHByb3BlciBBdGtSb2xl LCB0byBiZSBwcm92aWRlZCBieSB0aGUgbmV4dCBzdGFibGUgcmVsZWFzZSBvZiBBVEsuCisKKyAg ICAgICAgKiBhY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5jcHA6 CisgICAgICAgIChhdGtSb2xlKToKKworMjAxMy0xMi0xMSAgTWFyaW8gU2FuY2hleiBQcmFkYSAg PG1hcmlvLnByYWRhQHNhbXN1bmcuY29tPgorCiAgICAgICAgIFtBVEtdIEV4cG9zZSBhY2Nlc3Np YmlsaXR5IG9iamVjdHMgd2l0aCBBVEtfUk9MRV9BUlRJQ0xFCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU1ODcKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3Bw IGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBw ZXJBdGsuY3BwCmluZGV4IDA4MThmMjkuLjgxY2IzNjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBl ckF0ay5jcHAKQEAgLTYwMyw2ICs2MDMsOCBAQCBzdGF0aWMgQXRrUm9sZSBhdGtSb2xlKEFjY2Vz c2liaWxpdHlSb2xlIHJvbGUpCiAgICAgY2FzZSBNZW51TGlzdE9wdGlvblJvbGU6CiAgICAgY2Fz ZSBNZW51SXRlbVJvbGU6CiAgICAgICAgIHJldHVybiBBVEtfUk9MRV9NRU5VX0lURU07CisgICAg Y2FzZSBNZW51SXRlbUNoZWNrYm94Um9sZToKKyAgICAgICAgcmV0dXJuIEFUS19ST0xFX0NIRUNL X01FTlVfSVRFTTsKICAgICBjYXNlIE1lbnVJdGVtUmFkaW9Sb2xlOgogICAgICAgICByZXR1cm4g QVRLX1JPTEVfUkFESU9fTUVOVV9JVEVNOwogICAgIGNhc2UgQ29sdW1uUm9sZToKZGlmZiAtLWdp dCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkNjllMzFhLi5hNjJj Nzk4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMTcgQEAKIDIwMTMtMTItMTEgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5w cmFkYUBzYW1zdW5nLmNvbT4KIAorICAgICAgICBbQVRLXSBFeHBvc2UgYWNjZXNzaWJpbGl0eSBv YmplY3RzIHdpdGggQVRLX1JPTEVfQ0hFQ0tfTUVOVV9JVEVNCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU1OTQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbWFwcGluZ3MgdG8gRFJUICYgV0tUUiBm b3IgY2hlY2ttZW51aXRlbSByb2xlLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvYXRrL0Fj Y2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIv SW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwOgorCisyMDEz LTEyLTExICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CisK ICAgICAgICAgW0FUS10gRXhwb3NlIGFjY2Vzc2liaWxpdHkgb2JqZWN0cyB3aXRoIEFUS19ST0xF X0FSVElDTEUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNTU4NwogCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9hdGsvQWNjZXNzaWJp bGl0eVVJRWxlbWVudEF0ay5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9hdGsvQWNjZXNzaWJp bGl0eVVJRWxlbWVudEF0ay5jcHAKaW5kZXggZTZjMTJkNC4uNDZmZjUxMyAxMDA2NDQKLS0tIGEv VG9vbHMvRHVtcFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwCisr KyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNw cApAQCAtMjgwLDYgKzI4MCw4IEBAIGNvbnN0IGNoYXIqIHJvbGVUb1N0cmluZyhBdGtPYmplY3Qq IG9iamVjdCkKICAgICAgICAgcmV0dXJuICJBWFJhZGlvTWVudUl0ZW0iOwogICAgIGNhc2UgQVRL X1JPTEVfUk9XX0hFQURFUjoKICAgICAgICAgcmV0dXJuICJBWFJvd0hlYWRlciI7CisgICAgY2Fz ZSBBVEtfUk9MRV9DSEVDS19NRU5VX0lURU06CisgICAgICAgIHJldHVybiAiQVhDaGVja01lbnVJ dGVtIjsKICAgICBjYXNlIEFUS19ST0xFX1JVTEVSOgogICAgICAgICByZXR1cm4gIkFYUnVsZXIi OwogICAgIGNhc2UgQVRLX1JPTEVfU0NST0xMX0JBUjoKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsu Y3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJp bGl0eVVJRWxlbWVudEF0ay5jcHAKaW5kZXggZWUwNGZkNi4uNDI5ODE4YSAxMDA2NDQKLS0tIGEv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0eVVJ RWxlbWVudEF0ay5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRs ZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHAKQEAgLTM2OSw2ICszNjksOCBAQCBj b25zdCBnY2hhciogcm9sZVRvU3RyaW5nKEF0a09iamVjdCogb2JqZWN0KQogICAgICAgICByZXR1 cm4gIkFYUmFkaW9NZW51SXRlbSI7CiAgICAgY2FzZSBBVEtfUk9MRV9ST1dfSEVBREVSOgogICAg ICAgICByZXR1cm4gIkFYUm93SGVhZGVyIjsKKyAgICBjYXNlIEFUS19ST0xFX0NIRUNLX01FTlVf SVRFTToKKyAgICAgICAgcmV0dXJuICJBWENoZWNrTWVudUl0ZW0iOwogICAgIGNhc2UgQVRLX1JP TEVfUlVMRVI6CiAgICAgICAgIHJldHVybiAiQVhSdWxlciI7CiAgICAgY2FzZSBBVEtfUk9MRV9T Q1JPTExfQkFSOgotLSAKMS44LjMuMgoK