125579 2013-12-11 07:43:35 -0800 [Mac] Observe the activeURL property to keep the MiniBrowser URL field up to date 2013-12-11 08:13:27 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz oldest_to_newest 958724 0 mitz 2013-12-11 07:43:35 -0800 [Mac] Observer the activeURL property to keep the MiniBrowser URL field up to date 958725 1 218966 mitz 2013-12-11 07:46:37 -0800 Created attachment 218966 Observe activeURL 958735 2 218966 andersca 2013-12-11 08:09:22 -0800 Comment on attachment 218966 Observe activeURL View in context: https://bugs.webkit.org/attachment.cgi?id=218966&action=review > Tools/MiniBrowser/mac/WK2BrowserWindowController.m:40 > +static void* keyValueObservingContext = &keyValueObservingContext; Nice. 958737 3 mitz 2013-12-11 08:13:27 -0800 Committed <http://trac.webkit.org/r160433>. 218966 2013-12-11 07:46:37 -0800 2013-12-11 08:09:21 -0800 Observe activeURL bug-125579-20131211074637.patch text/plain 6241 mitz SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MDQzMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIzIEBACisyMDEzLTEyLTExICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisK KyAgICAgICAgW01hY10gT2JzZXJ2ZSB0aGUgYWN0aXZlVVJMIHByb3BlcnR5IHRvIGtlZXAgdGhl IE1pbmlCcm93c2VyIFVSTCBmaWVsZCB1cCB0byBkYXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU1NzkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1pbmlCcm93c2VyL21hYy9XSzJCcm93c2VyV2lu ZG93Q29udHJvbGxlci5tOgorICAgICAgICAoLVtXSzJCcm93c2VyV2luZG93Q29udHJvbGxlciBk ZWFsbG9jXSk6IFN0b3Agb2JzZXJ2aW5nIHRoZSBhY3RpdmVVUkwgcHJvcGVydHkuCisgICAgICAg ICgtW1dLMkJyb3dzZXJXaW5kb3dDb250cm9sbGVyIG9ic2VydmVWYWx1ZUZvcktleVBhdGg6b2ZP YmplY3Q6Y2hhbmdlOmNvbnRleHQ6XSk6IFdoZW4gdGhlCisgICAgICAgIGFjdGl2ZVVSTCBwcm9w ZXJ0eSBjaGFuZ2VzLCB1cGRhdGUgdGhlIFVSTCBmaWVsZCB3aXRoIGl0cyB2YWx1ZS4KKyAgICAg ICAgKC1bV0syQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIgYXdha2VGcm9tTmliXSk6IFN0YXJ0IG9i c2VydmluZyB0aGUgYWN0aXZlVVJMIHByb3BlcnR5LgorICAgICAgICAoLVtXSzJCcm93c2VyV2lu ZG93Q29udHJvbGxlciBicm93c2luZ0NvbnRleHRDb250cm9sbGVyRGlkU3RhcnRQcm92aXNpb25h bExvYWQ6XSk6IEp1c3QgbG9nLgorICAgICAgICAoLVtXSzJCcm93c2VyV2luZG93Q29udHJvbGxl ciBicm93c2luZ0NvbnRleHRDb250cm9sbGVyRGlkUmVjZWl2ZVNlcnZlclJlZGlyZWN0Rm9yUHJv dmlzaW9uYWxMb2FkOl0pOgorICAgICAgICBEaXR0by4KKyAgICAgICAgKC1bV0syQnJvd3Nlcldp bmRvd0NvbnRyb2xsZXIgYnJvd3NpbmdDb250ZXh0Q29udHJvbGxlcjpkaWRGYWlsUHJvdmlzaW9u YWxMb2FkV2l0aEVycm9yOl0pOgorICAgICAgICBEaXR0by4KKyAgICAgICAgKC1bV0syQnJvd3Nl cldpbmRvd0NvbnRyb2xsZXIgYnJvd3NpbmdDb250ZXh0Q29udHJvbGxlckRpZENvbW1pdExvYWQ6 XSk6IERpdHRvLgorICAgICAgICAoLVtXSzJCcm93c2VyV2luZG93Q29udHJvbGxlciBicm93c2lu Z0NvbnRleHRDb250cm9sbGVyOmRpZEZhaWxMb2FkV2l0aEVycm9yOl0pOiBEaXR0by4KKwogMjAx My0xMi0xMSAgRMOhbmllbCBCw6F0eWFpICA8QmF0eWFpLkRhbmllbEBzdHVkLnUtc3plZ2VkLmh1 PgogCiAgICAgICAgIEZpeGVkIHRlc3Qtd2Vwa2l0cHkgbG9nZ2luZyBmb3IgYnVpbGRzbGF2ZXMK SW5kZXg6IFRvb2xzL01pbmlCcm93c2VyL21hYy9XSzJCcm93c2VyV2luZG93Q29udHJvbGxlci5t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL01pbmlCcm93c2VyL21hYy9XSzJCcm93c2VyV2luZG93Q29u dHJvbGxlci5tCShyZXZpc2lvbiAxNjA0MDcpCisrKyBUb29scy9NaW5pQnJvd3Nlci9tYWMvV0sy QnJvd3NlcldpbmRvd0NvbnRyb2xsZXIubQkod29ya2luZyBjb3B5KQpAQCAtMzcsNiArMzcsOCBA QAogI2ltcG9ydCA8V2ViS2l0Mi9XS1VSTENGLmg+CiAjaW1wb3J0IDxXZWJLaXQyL1dLVmlld1By aXZhdGUuaD4KIAorc3RhdGljIHZvaWQqIGtleVZhbHVlT2JzZXJ2aW5nQ29udGV4dCA9ICZrZXlW YWx1ZU9ic2VydmluZ0NvbnRleHQ7CisKIEBpbnRlcmZhY2UgV0syQnJvd3NlcldpbmRvd0NvbnRy b2xsZXIgKCkgPFdLQnJvd3NpbmdDb250ZXh0TG9hZERlbGVnYXRlUHJpdmF0ZSwgV0tCcm93c2lu Z0NvbnRleHRQb2xpY3lEZWxlZ2F0ZSwgV0tCcm93c2luZ0NvbnRleHRIaXN0b3J5RGVsZWdhdGU+ CiBAZW5kCiAKQEAgLTYzLDcgKzY1LDggQEAgLSAodm9pZClkZWFsbG9jCiAgICAgW3Byb2dyZXNz SW5kaWNhdG9yIHVuYmluZDpOU0hpZGRlbkJpbmRpbmddOwogICAgIFtwcm9ncmVzc0luZGljYXRv ciB1bmJpbmQ6TlNWYWx1ZUJpbmRpbmddOwogCi0gICAgW193ZWJWaWV3LmJyb3dzaW5nQ29udGV4 dENvbnRyb2xsZXIgcmVtb3ZlT2JzZXJ2ZXI6c2VsZiBmb3JLZXlQYXRoOkAidGl0bGUiIGNvbnRl eHQ6W1dLMkJyb3dzZXJXaW5kb3dDb250cm9sbGVyIHNlbGZdXTsKKyAgICBbX3dlYlZpZXcuYnJv d3NpbmdDb250ZXh0Q29udHJvbGxlciByZW1vdmVPYnNlcnZlcjpzZWxmIGZvcktleVBhdGg6QCJ0 aXRsZSIgY29udGV4dDprZXlWYWx1ZU9ic2VydmluZ0NvbnRleHRdOworICAgIFtfd2ViVmlldy5i cm93c2luZ0NvbnRleHRDb250cm9sbGVyIHJlbW92ZU9ic2VydmVyOnNlbGYgZm9yS2V5UGF0aDpA ImFjdGl2ZVVSTCIgY29udGV4dDprZXlWYWx1ZU9ic2VydmluZ0NvbnRleHRdOwogICAgIF93ZWJW aWV3LmJyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIubG9hZERlbGVnYXRlID0gbmlsOwogICAgIF93 ZWJWaWV3LmJyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIucG9saWN5RGVsZWdhdGUgPSBuaWw7CiAg ICAgW193ZWJWaWV3IHJlbGVhc2VdOwpAQCAtMjk5LDExICszMDIsMTMgQEAgLSAoSUJBY3Rpb24p ZHVtcFNvdXJjZVRvQ29uc29sZTooaWQpc2VuZAogCiAtICh2b2lkKW9ic2VydmVWYWx1ZUZvcktl eVBhdGg6KE5TU3RyaW5nICopa2V5UGF0aCBvZk9iamVjdDooaWQpb2JqZWN0IGNoYW5nZTooTlNE aWN0aW9uYXJ5ICopY2hhbmdlIGNvbnRleHQ6KHZvaWQgKiljb250ZXh0CiB7Ci0gICAgaWYgKGNv bnRleHQgIT0gW1dLMkJyb3dzZXJXaW5kb3dDb250cm9sbGVyIHNlbGZdIHx8IG9iamVjdCAhPSBf d2ViVmlldy5icm93c2luZ0NvbnRleHRDb250cm9sbGVyKQorICAgIGlmIChjb250ZXh0ICE9IGtl eVZhbHVlT2JzZXJ2aW5nQ29udGV4dCB8fCBvYmplY3QgIT0gX3dlYlZpZXcuYnJvd3NpbmdDb250 ZXh0Q29udHJvbGxlcikKICAgICAgICAgcmV0dXJuOwogCiAgICAgaWYgKFtrZXlQYXRoIGlzRXF1 YWxUb1N0cmluZzpAInRpdGxlIl0pCiAgICAgICAgIHNlbGYud2luZG93LnRpdGxlID0gW193ZWJW aWV3LmJyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIudGl0bGUgc3RyaW5nQnlBcHBlbmRpbmdTdHJp bmc6QCIgW1dLMl0iXTsKKyAgICBlbHNlIGlmIChba2V5UGF0aCBpc0VxdWFsVG9TdHJpbmc6QCJh Y3RpdmVVUkwiXSkKKyAgICAgICAgW3NlbGYgdXBkYXRlVGV4dEZpZWxkRnJvbVVSTDpfd2ViVmll dy5icm93c2luZ0NvbnRleHRDb250cm9sbGVyLmFjdGl2ZVVSTF07CiB9CiAKIC8vIE1BUks6IFVJ IENsaWVudCBDYWxsYmFja3MKQEAgLTUwNCw3ICs1MDksOCBAQCAtICh2b2lkKWF3YWtlRnJvbU5p YgogICAgIFtwcm9ncmVzc0luZGljYXRvciBiaW5kOk5TSGlkZGVuQmluZGluZyB0b09iamVjdDpf d2ViVmlldy5icm93c2luZ0NvbnRleHRDb250cm9sbGVyIHdpdGhLZXlQYXRoOkAibG9hZGluZyIg b3B0aW9uczpAeyBOU1ZhbHVlVHJhbnNmb3JtZXJOYW1lQmluZGluZ09wdGlvbiA6IE5TTmVnYXRl Qm9vbGVhblRyYW5zZm9ybWVyTmFtZSB9XTsKICAgICBbcHJvZ3Jlc3NJbmRpY2F0b3IgYmluZDpO U1ZhbHVlQmluZGluZyB0b09iamVjdDpfd2ViVmlldy5icm93c2luZ0NvbnRleHRDb250cm9sbGVy IHdpdGhLZXlQYXRoOkAiZXN0aW1hdGVkUHJvZ3Jlc3MiIG9wdGlvbnM6bmlsXTsKIAotICAgIFtf d2ViVmlldy5icm93c2luZ0NvbnRleHRDb250cm9sbGVyIGFkZE9ic2VydmVyOnNlbGYgZm9yS2V5 UGF0aDpAInRpdGxlIiBvcHRpb25zOjAgY29udGV4dDpbV0syQnJvd3NlcldpbmRvd0NvbnRyb2xs ZXIgc2VsZl1dOworICAgIFtfd2ViVmlldy5icm93c2luZ0NvbnRleHRDb250cm9sbGVyIGFkZE9i c2VydmVyOnNlbGYgZm9yS2V5UGF0aDpAInRpdGxlIiBvcHRpb25zOjAgY29udGV4dDprZXlWYWx1 ZU9ic2VydmluZ0NvbnRleHRdOworICAgIFtfd2ViVmlldy5icm93c2luZ0NvbnRleHRDb250cm9s bGVyIGFkZE9ic2VydmVyOnNlbGYgZm9yS2V5UGF0aDpAImFjdGl2ZVVSTCIgb3B0aW9uczowIGNv bnRleHQ6a2V5VmFsdWVPYnNlcnZpbmdDb250ZXh0XTsKIAogICAgIF93ZWJWaWV3LmJyb3dzaW5n Q29udGV4dENvbnRyb2xsZXIubG9hZERlbGVnYXRlID0gc2VsZjsKICAgICBfd2ViVmlldy5icm93 c2luZ0NvbnRleHRDb250cm9sbGVyLnBvbGljeURlbGVnYXRlID0gc2VsZjsKQEAgLTU3MywyMiAr NTc5LDYgQEAgLSAodm9pZCl1cGRhdGVUZXh0RmllbGRGcm9tVVJMOihOU1VSTCAqKQogICAgIHVy bFRleHQuc3RyaW5nVmFsdWUgPSBbVVJMIGFic29sdXRlU3RyaW5nXTsKIH0KIAotLSAodm9pZCl1 cGRhdGVQcm92aXNpb25hbFVSTAotewotICAgIE5TVVJMICp1cmwgPSBfd2ViVmlldy5icm93c2lu Z0NvbnRleHRDb250cm9sbGVyLnByb3Zpc2lvbmFsVVJMOwotICAgIGlmICghdXJsKQotICAgICAg ICByZXR1cm47Ci0gICAgW3NlbGYgdXBkYXRlVGV4dEZpZWxkRnJvbVVSTDp1cmxdOwotfQotCi0t ICh2b2lkKXVwZGF0ZUNvbW1pdHRlZFVSTAotewotICAgIE5TVVJMICp1cmwgPSBfd2ViVmlldy5i cm93c2luZ0NvbnRleHRDb250cm9sbGVyLmNvbW1pdHRlZFVSTDsKLSAgICBpZiAoIXVybCkKLSAg ICAgICAgcmV0dXJuOwotICAgIFtzZWxmIHVwZGF0ZVRleHRGaWVsZEZyb21VUkw6dXJsXTsKLX0K LQogLSAodm9pZClsb2FkVVJMU3RyaW5nOihOU1N0cmluZyAqKXVybFN0cmluZwogewogICAgIC8v IEZJWE1FOiBXZSBzaG91bGRuJ3QgaGF2ZSB0byBzZXQgdGhlIHVybCB0ZXh0IGhlcmUuCkBAIC02 MTIsMjIgKzYwMiwyMiBAQCAtIChJQkFjdGlvbilmaW5kOihpZClzZW5kZXIKIAogLSAodm9pZCli cm93c2luZ0NvbnRleHRDb250cm9sbGVyRGlkU3RhcnRQcm92aXNpb25hbExvYWQ6KFdLQnJvd3Np bmdDb250ZXh0Q29udHJvbGxlciAqKXNlbmRlcgogewotICAgIFtzZWxmIHVwZGF0ZVByb3Zpc2lv bmFsVVJMXTsKKyAgICBMT0coQCJkaWRTdGFydFByb3Zpc2lvbmFsTG9hZCIpOwogfQogCiAtICh2 b2lkKWJyb3dzaW5nQ29udGV4dENvbnRyb2xsZXJEaWRSZWNlaXZlU2VydmVyUmVkaXJlY3RGb3JQ cm92aXNpb25hbExvYWQ6KFdLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxlciAqKXNlbmRlcgogewot ICAgIFtzZWxmIHVwZGF0ZVByb3Zpc2lvbmFsVVJMXTsKKyAgICBMT0coQCJkaWRSZWNlaXZlU2Vy dmVyUmVkaXJlY3RGb3JQcm92aXNpb25hbExvYWQiKTsKIH0KIAogLSAodm9pZClicm93c2luZ0Nv bnRleHRDb250cm9sbGVyOihXS0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIgKilzZW5kZXIgZGlk RmFpbFByb3Zpc2lvbmFsTG9hZFdpdGhFcnJvcjooTlNFcnJvciAqKWVycm9yCiB7Ci0gICAgW3Nl bGYgdXBkYXRlUHJvdmlzaW9uYWxVUkxdOworICAgIExPRyhAImRpZEZhaWxQcm92aXNpb25hbExv YWRXaXRoRXJyb3I6ICVAIiwgZXJyb3IpOwogfQogCiAtICh2b2lkKWJyb3dzaW5nQ29udGV4dENv bnRyb2xsZXJEaWRDb21taXRMb2FkOihXS0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIgKilzZW5k ZXIKIHsKLSAgICBbc2VsZiB1cGRhdGVDb21taXR0ZWRVUkxdOworICAgIExPRyhAImRpZENvbW1p dExvYWQiKTsKIH0KIAogLSAodm9pZClicm93c2luZ0NvbnRleHRDb250cm9sbGVyRGlkRmluaXNo TG9hZDooV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVyICopc2VuZGVyCkBAIC02MzcsNyArNjI3 LDcgQEAgLSAodm9pZClicm93c2luZ0NvbnRleHRDb250cm9sbGVyRGlkRmluaQogCiAtICh2b2lk KWJyb3dzaW5nQ29udGV4dENvbnRyb2xsZXI6KFdLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxlciAq KXNlbmRlciBkaWRGYWlsTG9hZFdpdGhFcnJvcjooTlNFcnJvciAqKWVycm9yCiB7Ci0gICAgW3Nl bGYgdXBkYXRlUHJvdmlzaW9uYWxVUkxdOworICAgIExPRyhAImRpZEZhaWxMb2FkV2l0aEVycm9y OiAlQCIsIGVycm9yKTsKIH0KIAogLSAodm9pZClicm93c2luZ0NvbnRleHRDb250cm9sbGVyRGlk Q2hhbmdlQmFja0ZvcndhcmRMaXN0OihXS0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIgKilzZW5k ZXIgYWRkZWRJdGVtOihXS0JhY2tGb3J3YXJkTGlzdEl0ZW0gKilhZGRlZEl0ZW0gcmVtb3ZlZEl0 ZW1zOihOU0FycmF5ICopcmVtb3ZlZEl0ZW1zCg==